From nobody Sun Feb 8 02:20:44 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F672DF13E for ; Fri, 19 Dec 2025 17:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766164489; cv=none; b=fYFw8SLvhnuf6/9IbRxrFVkeTx2kewN8F68GED1WYLB4ygIOhWV4MzyQlQHzYLKIwF4CAaukunveXC9GMw1lcmvu0ruzOHAHa+JmSxJJOlyCwsa+6S1leplJu83N+sra+NWMYM1iGExiQUmAqNHrWzkhhRpYODOfB+2afNdaucw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766164489; c=relaxed/simple; bh=dOfzmdQ6XtteHHqpWuXYEoXSYwJ5ISZ1weqIeOWwefQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lEW8XW2n4B+XDbKQK7RyERIh75mCeV59hhX+/QZxnXtZjQAI3hlB4I6mbbPXk8MaRcZhlMdLGC8DKBJCum4Z9g4+fQFwhotLZqv9Fs2s6EO3ubzfLuTfjDOxPGIzEg4E+oiqmf2gThT9QEUSmRQ2zWhx38jrZpEH9pSe81wmMQ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FB2BQVew; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FB2BQVew" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7b8bbf16b71so2049479b3a.2 for ; Fri, 19 Dec 2025 09:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766164487; x=1766769287; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FI43llsANdqGe6jTH+zTysLdat4X1xckyHWuski/dgo=; b=FB2BQVew76rhabnSRjX0NWFbmefiYUGYy65lQiArx1QoaU4GqDENq895Ty9LvFMosS m7hwLADIga5Xa6w78XywvniLTntt7S8B/qao/WJqYRunwHGgdhTkYqCEWxvK71qU8J/Z MXazKNJ3WUvsz9GGkbQVrbKdNl5clqOBTiU06LPc73/NkGeD+fX4oPVXgKAOOWVg78iB +qCGMKiVYbK3BC7KKh9iuU7Gx2o363n/9aHbfNyGn3tqSm2CNfZAu8wfip54bpJAt+ir 6UaU7v/HY/Quukj1KgpXssBHoEHJfvum45Qb2ONhzV2WcqtKL2UIbvTkBgyh5mUYSmBh BY1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766164487; x=1766769287; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FI43llsANdqGe6jTH+zTysLdat4X1xckyHWuski/dgo=; b=xJSi/v9mfCSU9fKCSh/uZ30vqHK7ojP+B9L2mB7678YxDKH5UPlaQxPNckmfi1s6xj ycETiePybVyS5xmK1c2T/sQvozH6r6RKj/vzQT/LyveREpTx4XGUi9hVG0/BE45I6wbv OeK/iPjEW7v15Hhe4GgLNclxtOZfBQWoj2zVubAEE4RYAckcjuJJL+U8ErkqvkCjjMGS bGmrut8za99F2WxcGFJ04XEZOTbbG72KpmLuQ42F1TSiJyPqGzSgwlwtwj6JBXDVX/0w XyDC+pHkEGsSGtlwdcXnXi14Q9tqo3bfTqMeggziJSYj84iu+rRg2ivjyjptchlrqfta Oghg== X-Gm-Message-State: AOJu0Yx3JG2qsyFnytggpxYTpLjdVQZCd6w6/KNXurL2CJSq+f01IQtl PJ0ggoStP3Yfi+XEk9xCEoODYPOGNYtGu0P0ZYE1j6xrHEQOA51kpkJh X-Gm-Gg: AY/fxX63wfNipAKV1Xt1FcnknK2OucbNVOUOErMjZqBEDbTl8dg7sOZlzb4c+QairrL 1GbtZpke6ooIX0MyVqXkhXeQpP+J4nYZAtinqXpSONxKqru4Z/yg5RWp7BFUPpCv3n3aptHiyk+ 4Zkekut9V8XUbb+ypvUKOweAdehwn0OlMCkVsR/n2Xb0jhjmTzCjqYxgOh8d16TILhEW/vnkcyX qzX84vK5Ne0Wv7f8g6rlgS4KRuN7FAUfQUFlC2EPGrjNUttDjnC2bMeWHNUSzaSgwa5e4pNQrp5 yln6aQMCKqKLNXfKRKsv/jkZtOOCN5kXa1m3RjXirPuRihk8ABTRAtoHU7aaQuyhkrGix0a178M CKMWCc+CtWl3sQJUXYAIbZneIDU8bqJLzSqrSr56JLjxqouHK1VBb4pBRekH5122nktPC3Ka20V FWDDbkfwANJwWM5rzK529d X-Google-Smtp-Source: AGHT+IEi32XXAS6VGNRuRqya6xBow9Yt0eEjyaeRRuCEQInqjEE+xMj/FCOW8zT0x16srCdXUcDczg== X-Received: by 2002:a05:6a20:244f:b0:36a:d3c9:efa5 with SMTP id adf61e73a8af0-376aa2f47demr3429123637.52.1766164487023; Fri, 19 Dec 2025 09:14:47 -0800 (PST) Received: from archlinux ([205.254.163.105]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e772ac1basm2219024a91.10.2025.12.19.09.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 09:14:46 -0800 (PST) From: Suchit Karunakaran To: clm@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Suchit Karunakaran Subject: [PATCH] btrfs: fix NULL pointer dereference in do_abort_log_replay Date: Fri, 19 Dec 2025 22:44:34 +0530 Message-ID: <20251219171434.46411-1-suchitkarunakaran@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coverity reported a NULL pointer dereference issue (CID 1666756) in do_abort_log_replay(). When btrfs_alloc_path() fails in replay_one_buffer(), wc->subvol_path is NULL, but btrfs_abort_log_replay() calls do_abort_log_replay() which unconditionally dereferences wc->subvol_path when attempting to print debug information. Fix this by adding a NULL check before dereferencing wc->subvol_path in do_abort_log_replay(). Signed-off-by: Suchit Karunakaran Reviewed-by: Filipe Manana --- fs/btrfs/tree-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 5831754bb01c..2d9d38b82daa 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -190,7 +190,7 @@ static void do_abort_log_replay(struct walk_control *wc= , const char *function, =20 btrfs_abort_transaction(wc->trans, error); =20 - if (wc->subvol_path->nodes[0]) { + if (wc->subvol_path && wc->subvol_path->nodes[0]) { btrfs_crit(fs_info, "subvolume (root %llu) leaf currently being processed:", btrfs_root_id(wc->root)); --=20 2.52.0