From nobody Sun Feb 8 08:48:19 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 622B31F03DE for ; Fri, 19 Dec 2025 16:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766160564; cv=none; b=XUF/g/0rPcYV0sz7bfb8xb6MWyq646uFQKHebUhH9zlwGddfN056NGgbYv76eFEdFfVBg2PvS+XdPvdtFTLm9PjYs65bNxzEmk7A6j0rCWfI05tDXsXp3sADZcgzTULvNneVC9G95qw1kAPrqelcD6Y3Cp+/gPTcTzYRv54WGqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766160564; c=relaxed/simple; bh=xCLPTytmwpg8U/KsII8GA6Xom6y/pOk3rStbgO9OET0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KGvoZ9pEnrSdwbTbir0YAYMahRsFiNZkhvfdgH4Pj+36pjK0im1DeXn2K3pOp/pWSjPiCDhnctbU79XimQIulJLoNJHLua2OTP1TxG23BJal5kXIAY63pg2G9kCHWOA48OgDpLbL+hxPX63f1nYkpaQ8Wl2gDsagK/6EK7LrvMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=leH7+rCh; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="leH7+rCh" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-477a2ab455fso18916665e9.3 for ; Fri, 19 Dec 2025 08:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766160560; x=1766765360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ehay3M186LcXUFYG3p9/ITKJQ7Me9IhwqSblYo6+TlQ=; b=leH7+rChK44R2n7Gw2kCnPMK5YTaVJ3yjuM2a/v1Koqg/oCGTTK8T60CGQlfi4IDEW B/ietTnJ04Hz+em3P3hx4zSx+ZKwTIL+n0SyXMnA2Wds9c3Gle9ZxMBl5zFk+xjfBDWe YlM/pHfQBz9ralsw5zTsA4V6OwpC3n5btYxsx0pNh5/zMUvVSZl97GJZGrP5bB6TGypT 2ZhxrbRJuMqGEJFlnkSXAUjXu+UQGQoas7BL6nvdFAhr61M41Xlk8GhrDUOlCGD7qLq2 16p4dNGipFeAim+zs4pZuevaMyF601efj0VoI8Wy75+uiCrEcBn5ZsH8xhQbLYHJrTsl Khdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766160560; x=1766765360; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ehay3M186LcXUFYG3p9/ITKJQ7Me9IhwqSblYo6+TlQ=; b=YppzwXkEaiQF6BTOdKs5nRXTJw7CIm2lgwldtSiWNHBIMbYmCe403ahUmuyfWncLfE yJhiAtoU/6WYZOXNLucgsGpWyJ2cLPGZfkw9+NwX7R8ZkuXKQ9oOnJ2++gq9szsMjduT Wf9hVrXXWGE5v5vNtkLkyxmxE3T1rMln5WdcDkpSoGi6+0nmCv5rdFDBcK8ntpuzsEw7 tzt4b9rJn9one4awk3ag4lnyG7njKVgRRh7NMkO4BJ1XWO3z7vfh2/f4B15npo5ufwq8 2KjZUazzkCgEFiFb1dmFG5JJU1/6csbr4xG4hl7pJ2ZSe6hut0FfUeCo/n76g3xHqx4O UzLw== X-Forwarded-Encrypted: i=1; AJvYcCU0GmONNYGqUinn5N/x9PjehxAqu5BDyR+nYyD1HyAqwy4rOEmuSrtBOUhQzZSdPGEAKijnzpVJjJ1fJLU=@vger.kernel.org X-Gm-Message-State: AOJu0YzsUK/+9mYbRoCXRR/xuIAqDhRvBSBuR8f6dk/6VFDfr9AUIxqt boWkUMw2dTexqrr8Bw4pMJkYpru8WvV0BqI/WnUlSLbEiVapRjVOD6Oh X-Gm-Gg: AY/fxX4qdMWzYLehiahKlipxS3nswO5Seqw1yalqqrBDF1H0GjAYWRzASxLe1QZcOpd ey2RLy07NBrP2p8zFTGGw7Ihmj+UDQqdT7BC08kOhahJRzrQZlAo/n79rcxolV2JxxWIdC2sWXu 5QyVUdprTCHcp/3qqmUv7SLQgjhC8ahRGcQu/gXcpsVzJYF5Xlbw10OZ7gSVLbUgSPYqHRii7Nx e5yPyBQynNYkh4Kj7hiMG/qiGm1n+uD1YfLr+uE0s5VjPYKdNV3IVjSec7PvPoIbqNxmbRuRsod SlRJ/VMEWRhsJEhBGDlM3mGs4jrKeSj0UdmYxgZGHQsb548+5KXY46l5g3ao6OrZB29ShioRZCj Kc+6AXwpdfjcrzbf6ex2KL1g7MTkB6byOdmXnxqirk5MSZkRFFr+RuKx6TlAJcdJ23nssQdw56N ZCA58o9xAvhExAC3vBve6RgJlROIFvG63X683bPIntVGzSkBZFz9z/TVJBfEqw2MrdAdub5d7BA 13uP/QQHXZV8Ps= X-Google-Smtp-Source: AGHT+IFZw56LBO5z3Wi45JPES3t//vnNXh9tW3SPvp6EG4Jj1i7soALK54FoiiJGWBVoLxuqYK7Ueg== X-Received: by 2002:a05:600c:c08a:b0:46e:1abc:1811 with SMTP id 5b1f17b1804b1-47d197f67edmr23573275e9.27.1766160559997; Fri, 19 Dec 2025 08:09:19 -0800 (PST) Received: from Lord-Beerus.station (net-5-94-28-5.cust.vodafonedsl.it. [5.94.28.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193cbe58sm49840975e9.9.2025.12.19.08.09.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 08:09:19 -0800 (PST) From: Stefano Radaelli X-Google-Original-From: Stefano Radaelli To: vkoul@kernel.org, neil.armstrong@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, j.zink@pengutronix.de, linux-kernel@vger.kernel.org Cc: xu.yang_2@nxp.com, jun.li@nxp.com, Frank.Li@nxp.com, haibo.chen@nxp.com, linux-phy@lists.infradead.org, imx@lists.linux.dev, Stefano Radaelli , Leonid Segal , Pierluigi Passaro Subject: [PATCH v3] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it Date: Fri, 19 Dec 2025 17:09:12 +0100 Message-ID: <20251219160912.561431-1-stefano.r@variscite.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clear the PCS_TX_SWING_FULL field mask before setting the new value in PHY_CTRL5 register. Without clearing the mask first, the OR operation could leave previously set bits, resulting in incorrect register configuration. Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning") Suggested-by: Leonid Segal Acked-by: Pierluigi Passaro Signed-off-by: Stefano Radaelli Reviewed-by: Xu Yang Reviewed-by: Frank Li Reviewed-by: Ahmad Fatoum Reviewed-by: Fabio Estevam --- v3: - Fixed commit message line wrapping (75 chars) v2: - Improved commit subject as suggested by Fabio Estevam drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index ad8a55012e42..9458b6e5fcf4 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -504,6 +504,7 @@ static void imx8m_phy_tune(struct imx8mq_usb_phy *imx_p= hy) =20 if (imx_phy->pcs_tx_swing_full !=3D PHY_TUNE_DEFAULT) { value =3D readl(imx_phy->base + PHY_CTRL5); + value &=3D ~PHY_CTRL5_PCS_TX_SWING_FULL_MASK; value |=3D FIELD_PREP(PHY_CTRL5_PCS_TX_SWING_FULL_MASK, imx_phy->pcs_tx_swing_full); writel(value, imx_phy->base + PHY_CTRL5); base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 --=20 2.47.3