From nobody Sun Feb 8 00:38:51 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D63233134 for ; Fri, 19 Dec 2025 15:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766157651; cv=none; b=Qhh6LiE8QVnBLVq9w2dINRkD5qGYn6CdoysqlDgUkZwnd/WtkIFRikqSSLI1IPRdkdRxfpWd93TlDxtX8RtXxJ3Xh4AHj0yYCTr9YkWK0eNzSbyzcqJvfZJMEaWK1bTLxRCec+GYWS2rSBZe11qdFyiCTN1RWOeDbBM8VYnQx08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766157651; c=relaxed/simple; bh=yHNdgzqc/4lAM8dbFsHeaviI2nF5q/YpEVMw74Bnsuk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GZfk/GC8g4haXM0f8F233R8bzpxS6eDe4WYuL8X8Su6aMTHMXXWnRNsvw+8+ApG6qmqEw5F58dDNs0yAvaT4MlgXgmQum5WgC1AVHH9hn+Fg+YbNNqdh6M7N9fVnu9fsCxR7WAolWoAt3MwvWWjjQ81pyI9FBlnSvcucwMjwmZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cKmWG048; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cKmWG048" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7b9c17dd591so1687183b3a.3 for ; Fri, 19 Dec 2025 07:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766157649; x=1766762449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FRLyHIcaTYgGGdTbN+5lMzudMmbrt4aktasmpYS38uM=; b=cKmWG048BaPXQBBqK3wUWEs6NmAoyhpC9TxTNyvxJzavY/jMCksKSqBwLMd3KuD78d 81zn/rUco3vAWp/s+7sTPo6WO6mn58ziVOIf8OS6qruJ6Ejk2ymUbRUdNj+naGzpYrpa SUANyjH9LcOcbhFFRUuLWs1KH4C3c+zJ02NW6WV1yqRuqSoCy+sfnIMHsp4+1yRaGVmG tPlQ3GQWfZFjuUs0Z04ma/NXJEt4uVE17VqobZ/NEXW4aF3ajNe6aRiz93G7gMTZO98X RD/U5juM6VdEwREKuPWotiVNCevj2cV/HBMu0iReoFA2iakq0FDFW7FQZgS4UmpruttA 2MIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766157649; x=1766762449; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FRLyHIcaTYgGGdTbN+5lMzudMmbrt4aktasmpYS38uM=; b=I2c6UXsGqA4tFo9NvYFkEvUIyhz5eiIuFjJ2vjcEuJkMM8A0XopnWXe1yRA9f2m/95 VIcr3YLxZdPpinscJwlQLmczXgwV3cBBHvAUISVerDqPuuKQpsHrZJeK92OKMLpEOHOA kR9HVMEMK/RkCJi8YAyW5phxgjITgod+ew04HXID+rz0sM3WUp0/EBE7692ovRfEzzDQ qimcwsgBIz5Hu99wzY908VSS8EQ7J4FjMP+Fs9g6q9gGqIRK4Azv+zNzG+FjosbioqJr ufRRj+x6k5zwvfxmVJOC5vF4KOZUlSMCOzkNgUv5FqrnZIVRY4nWOsLFTUuAx9A0DnQY 0XEw== X-Forwarded-Encrypted: i=1; AJvYcCW+FkXZZZWvZHVH2npqjRPBYFpJ6NJKxjOrEDh5WADA2HaRukb5c1rsnw2njqktYFs7cmUFuOt16dSKQyY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/A1hF2YyuNveIV4GwLAhFHM7V9hEgWb5B0dDrSsz9WkC6iE3W j9E7NrcSA2PTc7qh2kxTNmPntoEzpDjgb8/qkdpZUtc6t+JxUbDaeT2I X-Gm-Gg: AY/fxX4hB6rLKCP+7Mq4n62lxOxqK5ZHpmnDWIe09BnYz6ccncVDMsGYswKdyCBqzSg hHPMF6JnwSbiJ9a5V3GJ/eqLNONd+jEU8I0FBmnVDmKY+/EAjh/cnE6Zn9KFpOKCaIMweFxkn6n Oz62PLPmcIrJxBPra2m1JUJBqAEwJi9L3O/4acNZAwINY2P1es4QILlPXfyk3IyYgrMvX0xiuGW Y+o/oakNC+AIyEtMaaiKKYzDKz1sNVI8sAcI8scb5SCO3Z0puXHyMWCWAa/oZt+tmKLV9jqGICD g/tbZcj6YT83cQdu3Fa3mIYnlO0McaddkKW+WLru/UEVLLFCqLZM7uvVgQeZaOskBqBHCVi+XYI PZXk6FjOM8KwnM/Xp3i3KmBDxVRTNKRc9MaRzQb5dv9XMOKmTbNLhWeateMaDyAcVU8MlCZjr6q n0jT2f/22ISded X-Google-Smtp-Source: AGHT+IHZF6dThhbGJCz/FfsvtZUXhVynNTqCbs4rVadVbBB844qGhg3Y+x98uNRKysilHK4dqgzXuw== X-Received: by 2002:a05:6a20:7d9f:b0:366:14b2:31a with SMTP id adf61e73a8af0-376aa6eadcbmr3041159637.77.1766157648759; Fri, 19 Dec 2025 07:20:48 -0800 (PST) Received: from c45b92c47440.. ([202.120.234.58]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c1e7bd61b40sm2459612a12.23.2025.12.19.07.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 07:20:48 -0800 (PST) From: Miaoqian Lin To: Stefan Agner , Alison Wang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] drm/fsl-dcu: fix clock reference leak in fsl_tcon_init error path Date: Fri, 19 Dec 2025 19:20:35 +0400 Message-Id: <20251219152036.2958051-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In fsl_tcon_init(), when of_clk_get_by_name() succeeds but clk_prepare_enable() fails, the function jumps to err_node_put label without releasing the clock reference obtained. This causes a clock reference leak. Fix by calling clk_put() that properly releases the clock reference. Found via static analysis and code review. Fixes: fb127b7943c9 ("drm/fsl-dcu: add TCON driver") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c b/drivers/gpu/drm/fsl-dcu/f= sl_tcon.c index 49bbd00c77ae..b7ba90814b0e 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c @@ -86,7 +86,7 @@ struct fsl_tcon *fsl_tcon_init(struct device *dev) ret =3D clk_prepare_enable(tcon->ipg_clk); if (ret) { dev_err(dev, "Couldn't enable the TCON clock\n"); - goto err_node_put; + goto err_clk_put; } =20 of_node_put(np); @@ -94,6 +94,8 @@ struct fsl_tcon *fsl_tcon_init(struct device *dev) =20 return tcon; =20 +err_clk_put: + clk_put(tcon->ipg_clk); err_node_put: of_node_put(np); return NULL; --=20 2.25.1