From nobody Sun Feb 8 13:45:14 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1318832AACE for ; Fri, 19 Dec 2025 14:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766153535; cv=none; b=kWy7Gq1FWmJwq7SYBsNJHImeodFGzz3xmNSbuHoP0r7qCoF4unAmsCxxt9PRKYs2obDlCYsYWqLA3u3oEJNLJc8zgFANVLAlZqfnVNN6XF5OuD2brANI3EBpktelK1XhnoLK5N9gZGQ/DvL/K7pc4RriGqycIWhyFMVs6RwnMmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766153535; c=relaxed/simple; bh=+xw4qquMEDbOQ0hHhHQ1WQmmUVl9QW13/nMJlxdvFYk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gubSOMk6yTARJ+0wz11JGbz+lEHgySHs4yWwSpxYS5ga1FigDGdqO67sZfMdoxAl4hbECK1EgU6eboOx5S5qRKyjRyjmTpPtS/8O/V6VjSSq/27hmil0WFe/d1NeM9asbwLIprKoPBazQhrc88VWAHPyfPDP/Y7NNHEzELyylwg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dPdN/Lgn; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dPdN/Lgn" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0fe77d141so19376795ad.1 for ; Fri, 19 Dec 2025 06:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766153533; x=1766758333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yuVMIXJCkydm5uVU2HdEfL3gM/1O7B3pxM4tR+qCZ7c=; b=dPdN/LgnjJZmW5I6rnC+wXQBGwf1nnmsWDkRHS1sUtKzpb0AmMIreNvj77gWCCUzUj ihzfAAwSwRG+TfCWYK9jwvr9dELoE5psQxTqzD0emWx/gAlJ5OXW5qTqWTr2zsAVKnno LNNrqLrHddMZv1ySa4GU6pm8GGnFqvsoreIk62Tiz65mp1eyBRO0lcMES9Y1jIPTgGUy G5hoCdK0nRUh+EAEElh7lkW02Ypv0gCqHNR4B6gbyil6JuFtBeIdjd4zfyp0ZlZfU3OT ZtdrKJ0tCMBg7OI/SOtYDFgSj4diBxzN82a1BsKDJ4IAC+Ju6AdWE11e7r2kiJlWO4zK k/gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766153533; x=1766758333; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yuVMIXJCkydm5uVU2HdEfL3gM/1O7B3pxM4tR+qCZ7c=; b=w4VNBzVrSjiZN1f/ATtggL70GI17jIEv39XO7WFFNjEFSPkD6dCL5+z3jd4GkQs4b0 Ymyku70v+z4bAX7WPV19GOJqvWm7nTmSR3nuWodwUWACV24GNcg+PgEdhvcB40TvbXCH xmPKAMySPSokvJABgPsgOKHMym18IxyjVg+ovc26vSFbrajV3tsEcXrm4JrXeTjUjXFJ hOWeGoIQAHYXJeIYymOcU4rPgJyNx0BfRVgENFlIrN2YKah5zJJQI19wEcvqnLPFYQ1R Ti3alKz79c8NfDtq82fjowzM01/21DMj2e4jmddMkhPDut4e4L/3Z8hjTJkwmK/7c1AU VWzg== X-Forwarded-Encrypted: i=1; AJvYcCV5Hs7BUSSUjsJafJUfHcS5fuHUcMO9+zTaT0WZrNLceZmUG3HxSck88B/1ZjJlyEtcZYeh+r8oy7DTZQU=@vger.kernel.org X-Gm-Message-State: AOJu0YwaVFYTwAsI4zxQ5Girr27DSRCK2fclYWNgPus/h3zICZEm2Nmu Q2say2QVGV1NXWCT7K/ijt2HyZmDmJQnpBPxj50r9ZyM26gAJFPV+yty X-Gm-Gg: AY/fxX6XfX9Tivz37K6WaTo9vXjRRHpWjKkVuRd8XsU47EBYH2v4IG7we1Yxk5tEfaU D9/hCz503znQblBJ/xjGwOJucl9faPMcnHgeeHP0dc6d21jA4/QJ2VyPltLSssX+JxFH/hL1YYW K2yasWgJKlwJetUOpb79nyVPsGEtGl5IYzi2NfYvSlGPmcfITIdk6tmaCZxweIZDZGF0JCqDIcS flY8eMCXY4wMnMuoIKTrmzKTNONmKU9nrS6CSBdk3K4X5ImfNduemgjWeNRotYShkFKZE//3vY1 sDSTZjTjIxz665URXwuplbweqwoTalRi+jUTVSO4QCJtp9oI2Bu7vl1HF3gpsK+RG2T3oJIET3a +D50O0+q2+oIeJ8TjH3gQcDst0PUboUzT8W7o0zAq6h4HkU2If4t0RFJ2yrbC01dvdOh3swGK7H PoAQ== X-Google-Smtp-Source: AGHT+IGcjUWbmQcnlK1lPDMoiPsmtQhZgZ2i/cO1uiw7CWc51irQv/t47qGon7vqj0W5GmseeOcU1A== X-Received: by 2002:a17:903:fad:b0:271:479d:3dcb with SMTP id d9443c01a7336-2a2f2212bc9mr31352275ad.6.1766153533039; Fri, 19 Dec 2025 06:12:13 -0800 (PST) Received: from lgs.. ([103.86.77.131]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c820b8sm24081435ad.23.2025.12.19.06.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:12:12 -0800 (PST) From: Guangshuo Li To: Scott Branden , Arnd Bergmann , Greg Kroah-Hartman , Olof Johansson , Desmond Yan , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] misc: bcm-vk: validate entry_size before memcpy_fromio() Date: Fri, 19 Dec 2025 22:11:57 +0800 Message-ID: <20251219141157.59826-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver trusts the 'num' and 'entry_size' fields read from BAR2 and uses them directly to compute the length for memcpy_fromio() without any bounds checking. If these fields get corrupted or otherwise contain invalid values, num * entry_size can exceed the size of proc_mon_info.entries and lead to a potential out-of-bounds write. Add validation for 'entry_size' by ensuring it is non-zero and that num * entry_size does not exceed the size of proc_mon_info.entries. Fixes: ff428d052b3b ("misc: bcm-vk: add get_card_info, peerlog_info, and pr= oc_mon_info") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Acked-by: Scott Branden --- drivers/misc/bcm-vk/bcm_vk_dev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_= dev.c index a16b99bdaa13..a4a74c10f02b 100644 --- a/drivers/misc/bcm-vk/bcm_vk_dev.c +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c @@ -439,6 +439,7 @@ static void bcm_vk_get_proc_mon_info(struct bcm_vk *vk) struct device *dev =3D &vk->pdev->dev; struct bcm_vk_proc_mon_info *mon =3D &vk->proc_mon_info; u32 num, entry_size, offset, buf_size; + size_t max_bytes; u8 *dst; =20 /* calculate offset which is based on peerlog offset */ @@ -458,6 +459,9 @@ static void bcm_vk_get_proc_mon_info(struct bcm_vk *vk) num, BCM_VK_PROC_MON_MAX); return; } + if (!entry_size || (size_t)num > max_bytes / entry_size) { + return; + } mon->num =3D num; mon->entry_size =3D entry_size; =20 --=20 2.43.0