From nobody Mon Feb 9 19:55:37 2026 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 912CB329C4A for ; Fri, 19 Dec 2025 14:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766153455; cv=none; b=XyQKo4/3+sa2tdS0TlIjDE7M93pu+wMgPzFuLntE8+p1VJ2o1OnxGOU+uqTDO8XlZLNDFyeoZg5nmQEvEoeyV/4vvES5/10IKTmXCjQsxuYUpZoo+rEJY4wVpm276ydQmOl6OC7hlwluMb9xVXJtNaCWs3GmzVsvBTqE95s4rrg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766153455; c=relaxed/simple; bh=FbeAI6rEDdpipbM8oOakSTTpESlf7saB390Ei9bnbYk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kLQZfl8KdwJ/veVNtKt00RPRCK1QufMxNWJ2TlqrychwK+ddE52h+p6Dy2aoY51Jw6a1yh1iY7kE8e60QgPfVoFlHGK17yXaOGIC42Wd4NLNyDGa7oTqMYQmL3Va/HXCANfnfRfjuQ/6lwKPCgbzG6Fr+IY+PnhTM1Ld5v7kPsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.209]) by APP-05 (Coremail) with SMTP id zQCowACnOQ3dXEVpn+ovAQ--.16674S2; Fri, 19 Dec 2025 22:10:37 +0800 (CST) From: Haoxiang Li To: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, mporter@kernel.crashing.org, alex.bou9@gmail.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Haoxiang Li Subject: [PATCH] powerpc/fsl_rio: fix a improper release in fsl_rio_setup() Date: Fri, 19 Dec 2025 22:10:33 +0800 Message-Id: <20251219141033.632153-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACnOQ3dXEVpn+ovAQ--.16674S2 X-Coremail-Antispam: 1UD129KBjvJXoW7AF4kZF45Aw1UtrWDuF1rJFb_yoW8CF1rpa 1DKFyFkry0gr4IgFyjvFy0qF1vqa92y3yFkry8C3sakrs8Zry0vr1xAF97XFyUXFykAFyY qr9xJrWUWa18JF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkG14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWUuVWrJwAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r1j 6r4UM28EF7xvwVC2z280aVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r 4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU tVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUd-B_UUU UU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiCQ4BE2lFN99AuwACso Content-Type: text/plain; charset="utf-8" If rio_register_mport() fails, put_device() is the correct way to drop the device reference. To prevent a double free, remove put_device() in rio_register_mport() Also, add a put_device() in tsi721_setup_mport() to prevent reference leak. Found by code review. Signed-off-by: Haoxiang Li --- arch/powerpc/sysdev/fsl_rio.c | 2 +- drivers/rapidio/devices/tsi721.c | 1 + drivers/rapidio/rio.c | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c index f9b214b299e7..f6226b2619ed 100644 --- a/arch/powerpc/sysdev/fsl_rio.c +++ b/arch/powerpc/sysdev/fsl_rio.c @@ -697,7 +697,7 @@ static int fsl_rio_setup(struct platform_device *dev) if (rio_register_mport(port)) { release_resource(&port->iores); kfree(priv); - kfree(port); + put_device(&port->dev); continue; } active_ports++; diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi= 721.c index 4b84270a8906..17c2bcf29c5c 100644 --- a/drivers/rapidio/devices/tsi721.c +++ b/drivers/rapidio/devices/tsi721.c @@ -2758,6 +2758,7 @@ static int tsi721_setup_mport(struct tsi721_device *p= riv) err =3D rio_register_mport(mport); if (err) { tsi721_unregister_dma(priv); + put_device(&mport->dev); goto err_exit; } =20 diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c index 46daf32ea13b..026b2328afd7 100644 --- a/drivers/rapidio/rio.c +++ b/drivers/rapidio/rio.c @@ -2089,7 +2089,6 @@ int rio_register_mport(struct rio_mport *port) mutex_lock(&rio_mport_list_lock); list_del(&port->node); mutex_unlock(&rio_mport_list_lock); - put_device(&port->dev); } else { dev_dbg(&port->dev, "RIO: registered mport%d\n", port->id); } --=20 2.25.1