From nobody Tue Feb 10 02:01:22 2026 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4DEC33A6F7; Fri, 19 Dec 2025 13:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766150384; cv=none; b=ksBXqe7LQwkbwIt3q4EOUJpeRptde+48+juD+BZrJsCyT2zAHwj63Na6eHPhagL+Wmk9IBXPHsr9dwelgq7y4cBgmdFjXQ7yGw1c5PePxB9bWXmis9YSVQBSvnv9qP4psp9n3kyIrNNVmNBrA9CIfgBbutPa6bsoTtZ4pNmN3Kc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766150384; c=relaxed/simple; bh=CVtZSn4MAupFJnHEYt+sFGGQSY2JLbvXK2xlKCMK2ag=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=n4xCLQtVKQUOiKokuPOiUzTRoVJEp1AVbBcBuxCdOOegIUxSnX42+lB+iVbd01yqT3/+d9Me8jEjjKgr4vU2BX9TGP/YSGM8OSAhxsd/vMd788hc/nHI1A5PH91J/ldQnqtfxeQc/R8o02r7rD6altF2iCcVcT3LPXMCV3F0HuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.209]) by APP-05 (Coremail) with SMTP id zQCowABH2g3fUEVpPbYuAQ--.16196S2; Fri, 19 Dec 2025 21:19:27 +0800 (CST) From: Haoxiang Li To: James.Bottomley@HansenPartnership.com, deller@gmx.de, willy@infradead.org Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH] parisc: kernel: replace kfree() with put_device() in create_tree_node() Date: Fri, 19 Dec 2025 21:19:26 +0800 Message-Id: <20251219131926.623330-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABH2g3fUEVpPbYuAQ--.16196S2 X-Coremail-Antispam: 1UD129KBjvdXoWruFW7CF4UXFWUKFyxWr4kZwb_yoWfGFb_Ka 18Z3s5uF4kur4Ikr13GFyavryF93WqgrWrZr1jqr93try5Zr4UZrWFqrn5JrnrXw4DCr9r K34kGr90kw1FkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUYCJmUUUUU X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBg0BE2lFNrJEYwAAsW Content-Type: text/plain; charset="utf-8" If device_register() fails, put_device() is the correct way to drop the device reference. Found by code review. Fixes: 1070c9655b90 ("[PA-RISC] Fix must_check warnings in drivers.c") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- arch/parisc/kernel/drivers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/kernel/drivers.c b/arch/parisc/kernel/drivers.c index 8d23fe42b0ce..809e3c171ad5 100644 --- a/arch/parisc/kernel/drivers.c +++ b/arch/parisc/kernel/drivers.c @@ -435,7 +435,7 @@ static struct parisc_device * __init create_tree_node(c= har id, dev->dev.dma_mask =3D &dev->dma_mask; dev->dev.coherent_dma_mask =3D dev->dma_mask; if (device_register(&dev->dev)) { - kfree(dev); + put_device(&dev->dev); return NULL; } =20 --=20 2.25.1