From nobody Sun Feb 8 10:44:02 2026 Received: from mail-oa1-f68.google.com (mail-oa1-f68.google.com [209.85.160.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F82932D7F4 for ; Fri, 19 Dec 2025 14:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766155658; cv=none; b=qsymwOHykDj+RGzKqmNysUmmTrML3JfQc988fqrsSEO+slt9mmhxGyO/JnnLPsb/6e6C7rwC2m4ojDxZvWOUlHvfM36wIKL7u/RGFjKJ+7jp+FBQ7hudiLNGZSdu97A9+MAFh2AKfsZdmK8OwcjzdW/Prjl84XoFqp6t8ms5KL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766155658; c=relaxed/simple; bh=hGjYfTPZVpLjfYpJDfuQ8wmqEFOpDaT5M488rWNUYoM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LH2FrpTYbnWkpH109AnLhfQC03Lf6rim5MBlxTU7P/0x4Cx3fP3LudToWPmQwEtJX/+oaQS5yqm22L6kE1iTW3OwmMlLZqzIBe+e4aCTGF/SR0rHURMrSeS+76Gjvv9zVNSIB64X5jQzOO8W+52/T1pTvgFUwZAGenD7KFcqVXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hd4UW3o9; arc=none smtp.client-ip=209.85.160.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hd4UW3o9" Received: by mail-oa1-f68.google.com with SMTP id 586e51a60fabf-3fa11ba9ed5so1245126fac.0 for ; Fri, 19 Dec 2025 06:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766155655; x=1766760455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d8S9arpnQbQKRrRPutZ5MVC6WeUVyaLDfqwrd6H6Lag=; b=hd4UW3o9f3aOAJsjskJ0s+If2Y5sW60DRloCGQLLNKshKyJAf6RMfisqcMlXqCzXNj Rdws4RcVFhjb8N5BUK2jP9XP1gTaPFF8BTrq+ier0ysuaQmKwDoktTOyWNsnhjyqoNd7 uPOEZChghrIFExRacmZh78qTIkEm8FXs9qwfp3K+WYX+d4Wuel5134UrkfcczhhYc4+Q WSgs4/jRvsW10cgZd+EcEF1/YjcJKIqo6YygMhyOuZL3UgrNp1uzO20OUBee+jz8lzND p7LozapGu8DBxXhSCUpsVPVp8rg02g6spPKntsyW1JGDK3Tzc6RoYctLbKdjFKAqt3ER HDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766155655; x=1766760455; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d8S9arpnQbQKRrRPutZ5MVC6WeUVyaLDfqwrd6H6Lag=; b=LHSYaws+fPbDxAEn8CFpahEhmHWcTvwzkXZBp0Gm6BGRt8Oun2mGBxuiJinvC1LAb6 jLYcrYWDTSuGV3VCUy47nlb/STFc9UaFpVdJ0HD4/L2Ghpc2Fyf/bNqMO6VGtEXpX4Cy Unem2nx2vP9XvDCNOsRc3Y9irZAYr7LwHJjEXpEk++LhmFsmkw+44c79qUAZmmo3LSdd Idsxjtl9F4ZSqRM0mxo1EZvi49cfGmb3xAUvm2DdoeVZic1Ksfj2H+Ug1kiJpKNHwwX8 YbPmS8jCioR90SluiMMYd21WRjnbSSsxQdllVZsnknWs81Zl0jDqyhkC6WApXCgD88sH vQig== X-Forwarded-Encrypted: i=1; AJvYcCU/EPsb8z5++wqtzh4hgzZbFCkhvF7R1KL5rS/ExRIZz0agCgFsidQIP8AsXaFT7IlCjQA7P82In2bqKCY=@vger.kernel.org X-Gm-Message-State: AOJu0YzqP25pjy0H1YwpbCvYZCQn7pvSD0ga2NEC/taHPu1AeEOrwasd zJxC7iEYFPhtiwONsaiktoQT9+bn/e1bUkM6qPSXnUEP/PShBw6rpoFUcUAoyFyv/uU= X-Gm-Gg: AY/fxX5UUm44oLGfmFmNU/WYI3fw2H1N3f5Gt3OSEWUiG1Y8wSvoFh53HSlFfgVgVDd o6o+oAZUQ+ak5dBiIBplDgT0dPlzdWzj1FLJ6xO3tQ+6mmiaKIy4fvIy5OToxUgSzEm25KcwLiC uf6IkRER8H7yVOzr9nbVqbOn/dRjbicE0aU48BozStWImHRZCxlEdfADpG1SY46NCdwomiiuboO KzK/5CxKHzskcysGXqjdCWuvDOGyhpsKw+pOKQNsKD6ZbBy0hsXlEoB8J98BX9HgBx3LrbTWiBO dDmsImxDU0rMNd72gS2kQqOv3b0e5CEXybp8I3piQvCgrlTI3OK8qfI5j6LkbwCDIYzl4f4aKfO toEMMaj2mDT5I6Y7WiAvNjjzyc+4dL5zvLtyyooEkYIOPME4sqUMC/tUwkSXa2IjQHkYqinKkrz VxwHXfs/6Y9EM= X-Google-Smtp-Source: AGHT+IE+veN2yrrZeFF1UwlrVEnWYNBAeihhpAYdak+7pFIePoIXcnPL+veHjarmZ99tXTrQ3zfZ4g== X-Received: by 2002:a05:6a20:e293:b0:341:d5f3:f1ac with SMTP id adf61e73a8af0-376a9de5b1fmr2872897637.41.1766148481835; Fri, 19 Dec 2025 04:48:01 -0800 (PST) Received: from 7950hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7961fbb9sm2110688a12.2.2025.12.19.04.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 04:48:01 -0800 (PST) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, bjorn@kernel.org, pulehui@huawei.com, puranjay@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, menglong8.dong@gmail.com, jiang.biao@linux.dev, bpf@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf] riscv, bpf: fix incorrect usage of BPF_TRAMP_F_ORIG_STACK Date: Fri, 19 Dec 2025 20:47:48 +0800 Message-ID: <20251219124748.81133-1-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The usage of BPF_TRAMP_F_ORIG_STACK in __arch_prepare_bpf_trampoline() is wrong, and it should be BPF_TRAMP_F_CALL_ORIG, which caused crash as Andreas reported: Insufficient stack space to handle exception! Task stack: [0xff20000000010000..0xff20000000014000] Overflow stack: [0xff600000ffdad070..0xff600000ffdae070] CPU: 1 UID: 0 PID: 1 Comm: systemd Not tainted 6.18.0-rc5+ #15 PREEMPT(vo= luntary) Hardware name: riscv-virtio qemu/qemu, BIOS 2025.10 10/01/2025 epc : copy_from_kernel_nofault+0xa/0x198 ra : bpf_probe_read_kernel+0x20/0x60 epc : ffffffff802b732a ra : ffffffff801e6070 sp : ff2000000000ffe0 gp : ffffffff82262ed0 tp : 0000000000000000 t0 : ffffffff80022320 t1 : ffffffff801e6056 t2 : 0000000000000000 s0 : ff20000000010040 s1 : 0000000000000008 a0 : ff20000000010050 a1 : ff60000083b3d320 a2 : 0000000000000008 a3 : 0000000000000097 a4 : 0000000000000000 a5 : 0000000000000000 a6 : 0000000000000021 a7 : 0000000000000003 s2 : ff20000000010050 s3 : ff6000008459fc18 s4 : ff60000083b3d340 s5 : ff20000000010060 s6 : 0000000000000000 s7 : ff20000000013aa8 s8 : 0000000000000000 s9 : 0000000000008000 s10: 000000000058dcb0 s11: 000000000058dca7 t3 : 000000006925116d t4 : ff6000008090f026 t5 : 00007fff9b0cbaa8 t6 : 0000000000000016 status: 0000000200000120 badaddr: 0000000000000000 cause: 8000000000000005 Kernel panic - not syncing: Kernel stack overflow CPU: 1 UID: 0 PID: 1 Comm: systemd Not tainted 6.18.0-rc5+ #15 PREEMPT(vo= luntary) Hardware name: riscv-virtio qemu/qemu, BIOS 2025.10 10/01/2025 Call Trace: [] dump_backtrace+0x28/0x38 [] show_stack+0x3a/0x50 [] dump_stack_lvl+0x56/0x80 [] dump_stack+0x18/0x22 [] vpanic+0xf6/0x328 [] panic+0x3e/0x40 [] handle_bad_stack+0x98/0xa0 [] bpf_probe_read_kernel+0x20/0x60 Just fix it. Fixes: 47c9214dcbea ("bpf: fix the usage of BPF_TRAMP_F_SKIP_FRAME") Reported-by: Andreas Schwab Closes: https://lore.kernel.org/bpf/874ipnkfvt.fsf@igel.home/ Signed-off-by: Menglong Dong --- arch/riscv/net/bpf_jit_comp64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_comp6= 4.c index 5f9457e910e8..09b70bf362d3 100644 --- a/arch/riscv/net/bpf_jit_comp64.c +++ b/arch/riscv/net/bpf_jit_comp64.c @@ -1134,7 +1134,7 @@ static int __arch_prepare_bpf_trampoline(struct bpf_t= ramp_image *im, store_args(nr_arg_slots, args_off, ctx); =20 /* skip to actual body of traced function */ - if (flags & BPF_TRAMP_F_ORIG_STACK) + if (flags & BPF_TRAMP_F_CALL_ORIG) orig_call +=3D RV_FENTRY_NINSNS * 4; =20 if (flags & BPF_TRAMP_F_CALL_ORIG) { --=20 2.52.0