From nobody Mon Feb 9 00:42:11 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34EDF1E5207 for ; Fri, 19 Dec 2025 09:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766136550; cv=none; b=CiVuQHcuKovcoonCfPs2vdSbLhNsOFzZ4Z/OdQh2fsRnfGrmpYtQ1ksndX7i0Q7wB1iZAAYbz51U5uvPwzd9frjxZqh9e9hoty+dKJZZzrPAN6V5BrcsIYyZ+49D7x5GCnehpDS6+W95PeW/vHGcWLvfUYAAAQoxlPa76V8G9Vc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766136550; c=relaxed/simple; bh=D+1J0yuHajiY2KATxVRmx18d+yBHNB47fW5HJu4gFCs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ye395GNjJEJvGpsh3Yll58/Y6e5Yq+nsAmuooddwpeCxuQUmEATuv6G9HkqHIHUemNNyPqpV8Rr1y/G/qo+cdHOYRCjE7B33VdcbVqXvSiv9aXLQ4gsNu2RI9HfCPdspKfHdX4+XCzcdn4O99od9sBFB63Dr6yIIUAUZXDhb2R8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BpYlZilr; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BpYlZilr" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-7b8eff36e3bso2470892b3a.2 for ; Fri, 19 Dec 2025 01:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766136548; x=1766741348; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XExngbdMA66KSceeqvzAS6qK2XVljuJZWsz/+HS63Gs=; b=BpYlZilroS9vz2+EYAW7SWU/urD16r3dr81E6hacy3hq00kHz+PJF2++DBtICufh8e Xl+yc+pd45VBIjKkTyTtQv3QztoUy0bFaGL54/DVgaeSfiDfxPtuH0O1oWzuw2QCzsFr PnGW0OSDjOwEZXxtgdT8Bkk06TyXsP+qeNYKtls1S4f1CEJnv1DPBOMnxJtQwGcsht/1 MpCpk88IhKBgmBhplULMiIDPyEgKVCGypDR4ozDK762bpMeHsuPu39uk1dPi0jIxeLjm DKxurQhSeokLQUbhwZdjAOMnOIuGTvrQCRgSTz8SdphTmwjxr3Cb06CAFVUZyg+ixdiM yvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766136548; x=1766741348; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XExngbdMA66KSceeqvzAS6qK2XVljuJZWsz/+HS63Gs=; b=h9ReuVDGXj89zubPbP8Z1BizDX5d0GPt5Oxj98wESoARZQdm+Mj6kxQf7yg/qZgnkM TlHdZpCwnXB9Qh3Xbv8eguo63FQaY739MAxy6iGwfO1r4069Oj0H+TJt54PZC5NEU0hw 7rV83CgdpF9ORI1CMprj4tMcA2Vx4UeIymy64RCcD5s0M1p+oAeUa2Bs7rGMnX1AzxZE W/bblGHyM70i4PM43KfNQOncCOu2GaqXXBBiIsFj+TKjIy4wFunakiTFjuav1xbT/gQV aIBWoEZyIWnyBQ9sOWaLkM8YSLiYt+ASAcCk0atiBhtD50sAbz+RZbrPIZtQPyJMo6V2 Iv8Q== X-Forwarded-Encrypted: i=1; AJvYcCWU+X1Iul5GEHgIU4T9TRVG/gK5SonStEQiLqSyhX8egcYXDh4ezzdeNgZSlqfVWTlpdwmKNFNl6elTNv8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz51oN7MHAeoxK/UjYGsQDPjW2b0O610S0I7MTrJDf9S/JpBtkJ OplxERqtbruVA+dniZBHGBDJX+7i+vrS/AyhDlNn2MC4PkNIr+Oga/tt X-Gm-Gg: AY/fxX4KbNIRBFIMLH/bbAnwHkg/gUcUbdPhLfCMbjae99abKx5ZyZpK/F1pgidI3pI Z5y/9MGyfZcEK3U52LH4h0xvyzkt1jkFGRGxaO65DyuxKQMi3BnnWQZIebchLeSJVByQ9cKc2Cj xuJSdvY3UDA6TIE7dKOKEOHFQpjaysF9uPteuvVDTjbitKHIweH5v210hCBMniUqqszAao5VXdq wAgAZEzfVYGZODsEr6SHil3xj1ZxFDcDhQaoHmQrgZ9wNOsQoaqEXWCSOIHFOPCNcw59VqUoTSk uKeMEOZs3ljFBbfcjIhnPyJtXpWSpK+jr2ENIkzT8DsPmKPhyqaHkMapHKp8AFRAu6HrttWrbMl b4um9m/bTWsIP41CyFiZA/WTwU8QqTCEetBAVUxTIKknR630Bi/M1jVWkAY6k1qcpBvIVV8aLyM pg5YVfJ+q/EN9amCFE3kzO X-Google-Smtp-Source: AGHT+IE5JWw+7lSFXVYhNQmKqcHjdbswmfo+aR7gfYK9vA7mwuV3TlNvu2ksUtf6W2RFNTmkAeswTQ== X-Received: by 2002:a05:6a00:4ac1:b0:7f6:4a1f:68b8 with SMTP id d2e1a72fcca58-7ff66a6c35fmr1898834b3a.46.1766136548055; Fri, 19 Dec 2025 01:29:08 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e0a19d8sm1811179b3a.42.2025.12.19.01.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 01:29:07 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Peter Zijlstra Cc: Ingo Molnar , linux-sched@vger.kernel.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] sched/core: avoid assignment in conditional expression Date: Fri, 19 Dec 2025 17:29:02 +0800 Message-ID: <20251219092902.51495-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Split the assignment from the conditional expression when matching task state. This improves readability and avoids the use of assignment within an if condition, which is discouraged by the kernel coding style. No functional change intended. Signed-off-by: Zhan Xusheng --- kernel/sched/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 41ba0be16911..c7fb7cbec2e1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -2275,7 +2275,8 @@ unsigned long wait_task_inactive(struct task_struct *= p, unsigned int match_state running =3D task_on_cpu(rq, p); queued =3D task_on_rq_queued(p); ncsw =3D 0; - if ((match =3D __task_state_match(p, match_state))) { + match =3D __task_state_match(p, match_state); + if (match) { /* * When matching on p->saved_state, consider this task * still queued so it will wait. --=20 2.43.0