From nobody Sun Feb 8 14:10:47 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC471E1DF0 for ; Fri, 19 Dec 2025 05:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123027; cv=none; b=HC/rMXk0qd/CfOFdzarIUM5lujLEFF0k+6OHtk3A84tMGXvI8043qwqevPJEZzQPmOYFo7L1QY5PK431NUPK8nhreCpKf9M2hX2sO1boT73Vb2I9HvdORh6XCyTBgbjObx5ESZFpwPdtLs66AGjb3cPpzr98VB1YT+/OReqkYB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123027; c=relaxed/simple; bh=/h0B2MrEIB8vw1/0qkLk8pblOQDpqw3e0E/7EdgwDz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eNxBxg+ok+eqRuc3iWZp6nkhTgOUQSXGxd8oYFPmSjy6FHvv70j5QddnIOzM1zEwqRVE1fJQd6OSOk0/NIlG9pwyLJAQ2TNDxgwTax4VdPUogCPaxIRZeVE3S4HfQh481uzjswpcgETYaOpJAJHQx+WpKjuZuzgr+lOGU7qyKtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MEMGQLF7; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MEMGQLF7" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a0bae9aca3so19430885ad.3 for ; Thu, 18 Dec 2025 21:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766123024; x=1766727824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wLowgtUxpf7Ylc32b4gcev+kc2iAvzLFrJvCpgPdl8s=; b=MEMGQLF7wLCH7OpEDUVaeJDgrsjKFUWkDuTpFnx68L9JLQGVqnOKVr3h5P2gLMuyOW exuw/wisARzusZqbKf8LBe6QvrY/8BXg/hvpQodRQts4DHIY5VaCMkMfKHxLAA8Ns4P6 /Ny/SY61iHs4hHSwAuURv7PQXQZR9w6VAqgq9BzlnqlbM4F6+FiDC72mVVXAf0muTirB +6mW1Bqqtw8vtQm7o07NdHyU3ccWcMjCVdbokwywQYw8S/sBn46uQQyT0sxHOznYPQ/M xunbDVL7QbCo7owcg9G/pa1yu0yyfSYmN2GaaAefjDBqQm3x9N0FjZ22vtIKazBYuZyu SwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766123024; x=1766727824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wLowgtUxpf7Ylc32b4gcev+kc2iAvzLFrJvCpgPdl8s=; b=opNvs6GMbsifHtldLwCJHfUr/8dsurP8uVOowgN2r2LRsHSs4ieVuFsVB+AAVtUr9f fiMPwZx/fgEqvm7THHuvCW3Bp5Kb7hIiRdD4mK/GSmWtcM9xvxTJpRF+BiW5RNMqUo8X SKkl4wM/4+hzRJa3AD8NFjr+tfU8r+G5PPLH7GONWdYHpq5mhwrgKuVBOxZB9cc7q4uP G1chplDBf3znXATZFmDxGvCbsZTPmMq0RKpXKAVg4y6se/sdoajrbKAX1cORG1C3OQvJ C2p4T5bM00qOxDeAiadIKFvi/k8tHCfVyOl4PZNBkzESqDqSJla9XyGTMMQ36RaZg/Me bPLw== X-Gm-Message-State: AOJu0YyZ2ZpDYdETikSTV0VmmbZKX6PUFCGWGkD1P5ca21DxdNIBTkXq 9vGfSvYwwW0en/DjAF644J8yuIZMKGMxlKU48zR8lLRPf8wRhypsphGF X-Gm-Gg: AY/fxX7V6o+fdzzz4QzV+VjZQeO66E7zfBNohYtG0EDnhb5hIGMAIA3vBibWA0GLUfQ WLwexuEONuEeBcMCzVX9EjBOiFw4cNhObz9MeG0b4AA4WYxKCom7VXmNRThdYxwD39QiKIwvTQx 9ovCY8A+5z2E3h2f0USp5UAhYP1P9z9BWdsou6WnrA2AwWItTbU/K9dIC8qwqI3ETsZ1rinVQd/ D5ToTfyZKIKQ5CfjAHFvaJnM6W3YSaCs7FraY9m/wfu5d+rgBEqOJFOvD0TkKHCNYdeuQZEG7F1 FXuzqMg0scDyYfowNcU/29F9EUE95UiPH0GtN+izxGyMlp7lm/QVNW5bAc88HVyNJJ2AXp7ZEmd KYE99s7xsbk0HIe8FUhCbzqbOAszghtjef904tKyfFpc/Iit4wGWZyhI96hlatFZDXO4tgJhtOc ydoVnMGGMNDRs/Ru0oR8cGBH+10HwdR9tD2qm1AYcV+YM= X-Google-Smtp-Source: AGHT+IHapH6OsO1AHtO1AIXlBe8ewsFWc/T53IxGs44x5WRWKW2jyFjQP7saYVlxU5+BW4fZO8YydA== X-Received: by 2002:a17:902:e809:b0:297:cf96:45bd with SMTP id d9443c01a7336-2a2f2231b01mr17507025ad.19.1766123024262; Thu, 18 Dec 2025 21:43:44 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:5160:2cad:cf88:afa5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3da7dabsm9878955ad.25.2025.12.18.21.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 21:43:44 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v2 2/4] staging: fbtft: Make FB_DEVICE dependency optional Date: Thu, 18 Dec 2025 21:43:17 -0800 Message-ID: <20251219054320.447281-3-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251219054320.447281-1-chintanlike@gmail.com> References: <20251219054320.447281-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fbtft provides sysfs interfaces for debugging and gamma configuration, but these are not required for the core driver. Drop the hard dependency on CONFIG_FB_DEVICE and make sysfs support optional by using dev_of_fbinfo() at runtime. When FB_DEVICE is disabled, sysfs operations are skipped while the code remains buildable and type-checked. v2: - Replace CONFIG_FB_DEVICE ifdefs with runtime checks - Use dev_of_fbinfo() to guard sysfs creation and removal Suggested-by: Thomas Zimmermann Suggested-by: Helge Deller Signed-off-by: Chintan Patel --- drivers/staging/fbtft/Kconfig | 5 ++++- drivers/staging/fbtft/fbtft-sysfs.c | 18 ++++++++++++++---- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index c2655768209a..578412a2f379 100644 --- a/drivers/staging/fbtft/Kconfig +++ b/drivers/staging/fbtft/Kconfig @@ -2,11 +2,14 @@ menuconfig FB_TFT tristate "Support for small TFT LCD display modules" depends on FB && SPI - depends on FB_DEVICE depends on BACKLIGHT_CLASS_DEVICE depends on GPIOLIB || COMPILE_TEST select FB_BACKLIGHT select FB_SYSMEM_HELPERS_DEFERRED + help + Support for small TFT LCD display modules over SPI bus. FB_DEVICE + is not required, but if enabled, provides sysfs interface for debugging + and gamma curve configuration. =20 if FB_TFT =20 diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fb= tft-sysfs.c index e45c90a03a90..848702fc871a 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -203,14 +203,24 @@ static struct device_attribute debug_device_attr =3D =20 void fbtft_sysfs_init(struct fbtft_par *par) { - device_create_file(par->info->dev, &debug_device_attr); + struct device *dev =3D dev_of_fbinfo(par->info); + + if (!dev) + return; + + device_create_file(dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) - device_create_file(par->info->dev, &gamma_device_attrs[0]); + device_create_file(dev, &gamma_device_attrs[0]); } =20 void fbtft_sysfs_exit(struct fbtft_par *par) { - device_remove_file(par->info->dev, &debug_device_attr); + struct device *dev =3D dev_of_fbinfo(par->info); + + if (!dev) + return; + + device_remove_file(dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) - device_remove_file(par->info->dev, &gamma_device_attrs[0]); + device_remove_file(dev, &gamma_device_attrs[0]); } --=20 2.43.0