From nobody Sat Feb 7 15:35:11 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F032D130B for ; Fri, 19 Dec 2025 05:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123024; cv=none; b=Ed1UwNlWPo5lwqmK2re8iAdSuFg81JfriP8Ij0ZO5qemLpxiT1swoOmwuxAvO8Vu8khIx5NUqvVFr9pN0dnCsFjjNh7c0D80Gyf1ORUnxDYhsOY1mhCUcgNHddM5zBK6WTXq3zgNo5Lv+kAtLPiHLK2Fk71nn7Eh31/pZOrCu9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123024; c=relaxed/simple; bh=86Kzw/hKU0nrIm8xZ8jpwyS+2DiCcDwmWTX+qvqHhFE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dryFr1agq39+mkv9Jm4ChdTYMrKjINYS1G717jHGw6+FtOekpLo556wrlO3IDYBA9a7kSgyskd5jDV5R/pK/7WyO9VQLxsgcVGlr1Wz7Ye2zgM0HMtWfKuCgDmw1Gw/+VmNUOrKefo6s0WM+eEAkZc75FzO3GvvUD4+elvwmVyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UVNZt8B0; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UVNZt8B0" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a09a3bd9c5so12199525ad.3 for ; Thu, 18 Dec 2025 21:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766123022; x=1766727822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fKkdwzvSXz/T9pEqrvQ0VdQLUSbrQRl3ctUuH0zUyRA=; b=UVNZt8B0eRLdEbUBBnh2zpWq40lqCA+elXS7xzOsTlxlq64QBnZcxPvl6QfxP/kPDT tuXIMj94oId9VJbpPx+G/bm80iRYbpaCAu8RODiJajR18I4ieuRN99MjU8TsGQPoGFNX 5CKj5ktHIgjWDVv/0QFpcpnuqGLBmDPFxCtHOf06uI4Xy3P/SlO46/+d5p+VSEjSK9D+ ydRm1K58ClGnvON/LdC8qscoEp+kN74teNXzFC0Rm5O+bS2vXp1JzBewGttJ4BSJgdr0 QLl/irSolSQlNtO1DLuj70gqlfog37mLwDcMVgUru9SmLfsZbKxc6nMQj53KgubYLbPG nfIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766123022; x=1766727822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fKkdwzvSXz/T9pEqrvQ0VdQLUSbrQRl3ctUuH0zUyRA=; b=NEBgtpZR3ifLJ2yQ7tzLUhP1n9HYBR1kV0zJQGWIqUNy5UzIGDPe0bpjm9nA/ZqayB XGCPFUq4yO4bKFP1+Kcb77+TXjpeykWTQjudZ93Qbp+rikvnfC20H0ux2MTjq3Sy80OR T7nR2iHFIpafPUsxIZQ3cZawonq0nTjn3oujqnZ8ghV9I1M9v5O7TBfA2Pl02gQ2uM9f 6/uyx+cubLtX5OOo8GOVe9PP+QszirS/VCZhvF0abyR7TvmUyypfwHbviuCNPZzqJgiQ BBrEKyigDhE3/LOxB6oXo+uTwSbyfBG8z5wuVj57cTRa4mzz51E613wk9zzyNYeDaNId qZ3Q== X-Gm-Message-State: AOJu0YxChAypvOX05WcCRkUQ39A+5Oe/kXqgPLdC/YblNiKeBOYhMSS+ 7LxXcs2hYSaxyBwuc2KsjpWYMekVJYflZ+GqSTJ9ysLu9MGR2CNwp/xR X-Gm-Gg: AY/fxX64RSvzwp+cUenQr44y9b0A+j43B7iUw1VmmyUVsNZUWrqKg+/OcllP5Oxv7m0 21r+qtU7J7OUEhTVuAveuQsDuPL9yrxzeNpceZTydDTJvLPGZpb0NmLRBkulgUaOHvvXxxTKBT+ Y7IRukAzarUwIvgDGnc+xScnvdhp5fgepvRvo5n7jepof5EMvv/4mUg6/+qdMQiMltgXLgtb2J/ SjM3hf/O9jTtC/MaxeoI2Zz7V/oTCus3SI+gBHTHZCjGQ0RthSgInLTSkAJqWV5JVwWMxktUYtG C1H64ayJ9FGhP5t0yhu5Lfzzn3hRDsrSmkQt6s27eaNdbQgoQpscVgBlzhucPaYmTlF4HzJDPcy ZU6szTw4wP2X3thVfFjphm578m/ohrC1SaYNXqKgGs+fHIAByo6GBwcdU1g6tpHrtW7ZTHDeWBc oBkjp2IsdEsWUO4s97L2/Gxw6VwYKtTpuOtpU20wdKB9A= X-Google-Smtp-Source: AGHT+IGRBz3LEiHHY3N36Lf2Jbdyl+OtCRRLAqx/kmUDLPH9d4n3KvJgE1piBAVSSdqL472NtK6Xtg== X-Received: by 2002:a17:902:f78d:b0:2a0:c35c:572e with SMTP id d9443c01a7336-2a2f2836480mr16751125ad.30.1766123021882; Thu, 18 Dec 2025 21:43:41 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:5160:2cad:cf88:afa5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3da7dabsm9878955ad.25.2025.12.18.21.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 21:43:41 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v2 1/4] fb: Add dev_of_fbinfo() helper for optional sysfs support Date: Thu, 18 Dec 2025 21:43:16 -0800 Message-ID: <20251219054320.447281-2-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251219054320.447281-1-chintanlike@gmail.com> References: <20251219054320.447281-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add dev_of_fbinfo() to return the framebuffer struct device when CONFIG_FB_DEVICE is enabled, or NULL otherwise. This allows fbdev drivers to use sysfs interfaces via runtime checks instead of CONFIG_FB_DEVICE ifdefs, keeping the code clean while remaining fully buildable. Suggested-by: Helge Deller Signed-off-by: Chintan Patel Reviewed-by: Andy Shevchenko --- include/linux/fb.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/linux/fb.h b/include/linux/fb.h index 05cc251035da..dad3fb61a06a 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -628,6 +628,15 @@ static inline void unlock_fb_info(struct fb_info *info) mutex_unlock(&info->lock); } =20 +static inline struct device *dev_of_fbinfo(const struct fb_info *info) +{ +#ifdef CONFIG_FB_DEVICE + return info->dev; +#else + return NULL; +#endif +} + static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pitch, u32 height) { --=20 2.43.0 From nobody Sat Feb 7 15:35:11 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC471E1DF0 for ; Fri, 19 Dec 2025 05:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123027; cv=none; b=HC/rMXk0qd/CfOFdzarIUM5lujLEFF0k+6OHtk3A84tMGXvI8043qwqevPJEZzQPmOYFo7L1QY5PK431NUPK8nhreCpKf9M2hX2sO1boT73Vb2I9HvdORh6XCyTBgbjObx5ESZFpwPdtLs66AGjb3cPpzr98VB1YT+/OReqkYB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123027; c=relaxed/simple; bh=/h0B2MrEIB8vw1/0qkLk8pblOQDpqw3e0E/7EdgwDz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eNxBxg+ok+eqRuc3iWZp6nkhTgOUQSXGxd8oYFPmSjy6FHvv70j5QddnIOzM1zEwqRVE1fJQd6OSOk0/NIlG9pwyLJAQ2TNDxgwTax4VdPUogCPaxIRZeVE3S4HfQh481uzjswpcgETYaOpJAJHQx+WpKjuZuzgr+lOGU7qyKtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MEMGQLF7; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MEMGQLF7" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a0bae9aca3so19430885ad.3 for ; Thu, 18 Dec 2025 21:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766123024; x=1766727824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wLowgtUxpf7Ylc32b4gcev+kc2iAvzLFrJvCpgPdl8s=; b=MEMGQLF7wLCH7OpEDUVaeJDgrsjKFUWkDuTpFnx68L9JLQGVqnOKVr3h5P2gLMuyOW exuw/wisARzusZqbKf8LBe6QvrY/8BXg/hvpQodRQts4DHIY5VaCMkMfKHxLAA8Ns4P6 /Ny/SY61iHs4hHSwAuURv7PQXQZR9w6VAqgq9BzlnqlbM4F6+FiDC72mVVXAf0muTirB +6mW1Bqqtw8vtQm7o07NdHyU3ccWcMjCVdbokwywQYw8S/sBn46uQQyT0sxHOznYPQ/M xunbDVL7QbCo7owcg9G/pa1yu0yyfSYmN2GaaAefjDBqQm3x9N0FjZ22vtIKazBYuZyu SwCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766123024; x=1766727824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wLowgtUxpf7Ylc32b4gcev+kc2iAvzLFrJvCpgPdl8s=; b=opNvs6GMbsifHtldLwCJHfUr/8dsurP8uVOowgN2r2LRsHSs4ieVuFsVB+AAVtUr9f fiMPwZx/fgEqvm7THHuvCW3Bp5Kb7hIiRdD4mK/GSmWtcM9xvxTJpRF+BiW5RNMqUo8X SKkl4wM/4+hzRJa3AD8NFjr+tfU8r+G5PPLH7GONWdYHpq5mhwrgKuVBOxZB9cc7q4uP G1chplDBf3znXATZFmDxGvCbsZTPmMq0RKpXKAVg4y6se/sdoajrbKAX1cORG1C3OQvJ C2p4T5bM00qOxDeAiadIKFvi/k8tHCfVyOl4PZNBkzESqDqSJla9XyGTMMQ36RaZg/Me bPLw== X-Gm-Message-State: AOJu0YyZ2ZpDYdETikSTV0VmmbZKX6PUFCGWGkD1P5ca21DxdNIBTkXq 9vGfSvYwwW0en/DjAF644J8yuIZMKGMxlKU48zR8lLRPf8wRhypsphGF X-Gm-Gg: AY/fxX7V6o+fdzzz4QzV+VjZQeO66E7zfBNohYtG0EDnhb5hIGMAIA3vBibWA0GLUfQ WLwexuEONuEeBcMCzVX9EjBOiFw4cNhObz9MeG0b4AA4WYxKCom7VXmNRThdYxwD39QiKIwvTQx 9ovCY8A+5z2E3h2f0USp5UAhYP1P9z9BWdsou6WnrA2AwWItTbU/K9dIC8qwqI3ETsZ1rinVQd/ D5ToTfyZKIKQ5CfjAHFvaJnM6W3YSaCs7FraY9m/wfu5d+rgBEqOJFOvD0TkKHCNYdeuQZEG7F1 FXuzqMg0scDyYfowNcU/29F9EUE95UiPH0GtN+izxGyMlp7lm/QVNW5bAc88HVyNJJ2AXp7ZEmd KYE99s7xsbk0HIe8FUhCbzqbOAszghtjef904tKyfFpc/Iit4wGWZyhI96hlatFZDXO4tgJhtOc ydoVnMGGMNDRs/Ru0oR8cGBH+10HwdR9tD2qm1AYcV+YM= X-Google-Smtp-Source: AGHT+IHapH6OsO1AHtO1AIXlBe8ewsFWc/T53IxGs44x5WRWKW2jyFjQP7saYVlxU5+BW4fZO8YydA== X-Received: by 2002:a17:902:e809:b0:297:cf96:45bd with SMTP id d9443c01a7336-2a2f2231b01mr17507025ad.19.1766123024262; Thu, 18 Dec 2025 21:43:44 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:5160:2cad:cf88:afa5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3da7dabsm9878955ad.25.2025.12.18.21.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 21:43:44 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v2 2/4] staging: fbtft: Make FB_DEVICE dependency optional Date: Thu, 18 Dec 2025 21:43:17 -0800 Message-ID: <20251219054320.447281-3-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251219054320.447281-1-chintanlike@gmail.com> References: <20251219054320.447281-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fbtft provides sysfs interfaces for debugging and gamma configuration, but these are not required for the core driver. Drop the hard dependency on CONFIG_FB_DEVICE and make sysfs support optional by using dev_of_fbinfo() at runtime. When FB_DEVICE is disabled, sysfs operations are skipped while the code remains buildable and type-checked. v2: - Replace CONFIG_FB_DEVICE ifdefs with runtime checks - Use dev_of_fbinfo() to guard sysfs creation and removal Suggested-by: Thomas Zimmermann Suggested-by: Helge Deller Signed-off-by: Chintan Patel --- drivers/staging/fbtft/Kconfig | 5 ++++- drivers/staging/fbtft/fbtft-sysfs.c | 18 ++++++++++++++---- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index c2655768209a..578412a2f379 100644 --- a/drivers/staging/fbtft/Kconfig +++ b/drivers/staging/fbtft/Kconfig @@ -2,11 +2,14 @@ menuconfig FB_TFT tristate "Support for small TFT LCD display modules" depends on FB && SPI - depends on FB_DEVICE depends on BACKLIGHT_CLASS_DEVICE depends on GPIOLIB || COMPILE_TEST select FB_BACKLIGHT select FB_SYSMEM_HELPERS_DEFERRED + help + Support for small TFT LCD display modules over SPI bus. FB_DEVICE + is not required, but if enabled, provides sysfs interface for debugging + and gamma curve configuration. =20 if FB_TFT =20 diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fb= tft-sysfs.c index e45c90a03a90..848702fc871a 100644 --- a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -203,14 +203,24 @@ static struct device_attribute debug_device_attr =3D =20 void fbtft_sysfs_init(struct fbtft_par *par) { - device_create_file(par->info->dev, &debug_device_attr); + struct device *dev =3D dev_of_fbinfo(par->info); + + if (!dev) + return; + + device_create_file(dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) - device_create_file(par->info->dev, &gamma_device_attrs[0]); + device_create_file(dev, &gamma_device_attrs[0]); } =20 void fbtft_sysfs_exit(struct fbtft_par *par) { - device_remove_file(par->info->dev, &debug_device_attr); + struct device *dev =3D dev_of_fbinfo(par->info); + + if (!dev) + return; + + device_remove_file(dev, &debug_device_attr); if (par->gamma.curves && par->fbtftops.set_gamma) - device_remove_file(par->info->dev, &gamma_device_attrs[0]); + device_remove_file(dev, &gamma_device_attrs[0]); } --=20 2.43.0 From nobody Sat Feb 7 15:35:11 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE112D0C92 for ; Fri, 19 Dec 2025 05:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123029; cv=none; b=Syc9ERBXdMGmKhykkK/ajhUVLiPooY/wTinvEyt1ghAfPT0wtZfA//I9vdPZjKNhbrcWzJ4W879GhUZVRN3lCdWVrzs2V5lceK8NiKa6oaQlSZbXV5WOS4qF3BT9C8VtGyOYHJcCwYImloQ55ALVwDtIyXDTOp9rPE3UmhoSeCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123029; c=relaxed/simple; bh=UkrCfcHpZ1i8AvHQA/75nfwWAOIjYXg29xVkb1liZX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E9olZh8TE/F71IZKMvmq38Oyc5S8PYTdvUtmUMwHqihhNoj6vGiNVLpeirfxqe3/fcxV9rCcdTGU3PeIoDW7aOxrqA7jt3yW4AL7P2iyHRvgi1FSblHN1rRbiIMCdduTrEE5oejK9pkfQqfj2JdMcjyFSw8UIpVSaDnd05m/rSA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m2V9tFrw; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m2V9tFrw" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a0eaf55d58so14997605ad.1 for ; Thu, 18 Dec 2025 21:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766123027; x=1766727827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7OguNjtskMuqb5lnf7iu+ciDjHTh+c3vKrdbcOWFfIs=; b=m2V9tFrwPsthnDwSsO1gfcgtW2II7tx4ucMLGwjFF+cFNFTtVrq2GH8epS+99WbX98 pPGvAsAlXvL6BsNXODoPDAPzLya/F5kSHMZ2C/PgRYWYmNWXWlmoKccIA/l4XKfECmaW a6+SLG9nGKZSobhp/xoGfCpx3SJeog55yuUr88gT70TMso4EHKUQZiUsZxmzEBlcs9Le Ps9GpvxHqpqVeuLURr9gSIdoDZ1r3oktEk4gu3DRqPO9Swoj9DqGdY6lSYJ9lSD2Novp XxOv2YsTY2/NuFxtT0/dvSOFLUYy8lylfFUlBJocPJDSa/OEjIIAMP9K0ix7CuUsrRtQ EBUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766123027; x=1766727827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7OguNjtskMuqb5lnf7iu+ciDjHTh+c3vKrdbcOWFfIs=; b=nTQMGKwdsgCB3HK8uEhloyShgemTO9fCmueeLhiY8/SEv192IYYtS8znvrlNvB6jq/ +z8i54WQvm1ZRNOhqhnvuMRHO3t+6C6R7IAgIpjZsu4dkoat62SDLEeMXASxlzLG8rAw mTZ2z5E7UJuNKT0/zQpwMfcSL9ps9w9iERS4IyiQJC4XfUKJyKDMgDR5C2vEPaS0nlTB tzRYjPV/0yXnWwiu7/P+m161PJ0+k0Vaz0q62/D6A9RkZ9457GTfCe0ZgU/qg06g1RS/ 0JKuwdNcWsH0rlLcXFqgGbG58o6mG52nmyJpfGvIggHEFiU1QrPtC7GTZeFnvU3IcfTZ Xp/g== X-Gm-Message-State: AOJu0YyXwR/56BSECDvV5ztu7YKAlFGaIOf6ARqiQ3xlm/4NKsNTl0m4 /k6KckfOQRZ+ZnBe1h8hqTwNMVM7A/uGkYaItgdlbxN5VhvSoLgfcPwh X-Gm-Gg: AY/fxX7DNSCyg59yBUNiI9MgvR6+qxgWGi3oUf6kWdH+0725ZLxefU0D/kLvVQ4WMlj QISvfUHQekpT0l/KM5qbazp6qygMH9Oq3LG2xjYHj+oHo5OcjOR2JpVYOxRSHjGjH26NQ77901i 0tW73tByAl4RVeVuiKGExjmJVBTvvau3fvxFRiS3hZ6oceOtalEpzX/X6TCoTOrvkdVb+sasF/z bwjKY5irLpJYPqfWMp86huv9zGFmPKcA8wjcqOoSlrW3ryQDv0t8zC4fTBnvBRxVXJMMEZzjkB5 OjUSnXgTOUEBq1BRofFNmUkEvQ8DT5Qc65Dee2oC+qcaDGfI1OzhSAe9yAy9224VDFAAv6YnFzg +Y+n9TthCMhyVrQTtK78EUOboZIU2G5GBbzPFcuH3ojaQggm9uzv+o8xwH6hcXJ6UkU9pug8l1w YOlAOw+tkhX85aXCJHs9Rk+zbdCzR2+7oZRbnQw6U4j6I= X-Google-Smtp-Source: AGHT+IFIN9O1bSTaoX7Y9Xly+yqtX/VSEkwqhmoGFiL1kW7k2Mixeaj5EcJ8LC8LuF4Nk/249G3y9g== X-Received: by 2002:a17:902:cec7:b0:295:134:9ae5 with SMTP id d9443c01a7336-2a2f0d41127mr17823485ad.24.1766123027055; Thu, 18 Dec 2025 21:43:47 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:5160:2cad:cf88:afa5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3da7dabsm9878955ad.25.2025.12.18.21.43.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 21:43:46 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v2 3/4] fbdev: omapfb: Make FB_DEVICE dependency optional Date: Thu, 18 Dec 2025 21:43:18 -0800 Message-ID: <20251219054320.447281-4-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251219054320.447281-1-chintanlike@gmail.com> References: <20251219054320.447281-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" omapfb provides several sysfs interfaces for framebuffer configuration and debugging, but these are not required for the core driver. Remove the hard dependency on CONFIG_FB_DEVICE and make sysfs support optional by using dev_of_fbinfo() to obtain the backing device at runtime. When FB_DEVICE is disabled, sysfs operations are skipped while the code still builds and is type-checked. v2: - Replace CONFIG_FB_DEVICE ifdefs and stubs with runtime checks - Use dev_of_fbinfo() to skip sysfs when unavailable Suggested-by: Helge Deller Signed-off-by: Chintan Patel --- drivers/video/fbdev/omap2/omapfb/Kconfig | 3 ++- drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c | 16 ++++++++++++---- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev= /omap2/omapfb/Kconfig index f4cdf999a080..2d20e79adefc 100644 --- a/drivers/video/fbdev/omap2/omapfb/Kconfig +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig @@ -5,7 +5,6 @@ config OMAP2_VRFB menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB - depends on FB_DEVICE depends on DRM_OMAP =3D n depends on GPIOLIB select FB_OMAP2_DSS @@ -13,6 +12,8 @@ menuconfig FB_OMAP2 select FB_IOMEM_HELPERS help Frame buffer driver for OMAP2+ based boards. + FB_DEVICE is not required, but if enabled, provides sysfs interface + for framebuffer configuration and debugging. =20 if FB_OMAP2 =20 diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c b/drivers/vide= o/fbdev/omap2/omapfb/omapfb-sysfs.c index 831b2c2fbdf9..ef555dd598aa 100644 --- a/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-sysfs.c @@ -558,10 +558,14 @@ int omapfb_create_sysfs(struct omapfb2_device *fbdev) =20 DBG("create sysfs for fbs\n"); for (i =3D 0; i < fbdev->num_fbs; i++) { + struct device *dev =3D dev_of_fbinfo(fbdev->fbs[i]); int t; + + if (!dev) + continue; + for (t =3D 0; t < ARRAY_SIZE(omapfb_attrs); t++) { - r =3D device_create_file(fbdev->fbs[i]->dev, - &omapfb_attrs[t]); + r =3D device_create_file(dev, &omapfb_attrs[t]); =20 if (r) { dev_err(fbdev->dev, "failed to create sysfs " @@ -580,9 +584,13 @@ void omapfb_remove_sysfs(struct omapfb2_device *fbdev) =20 DBG("remove sysfs for fbs\n"); for (i =3D 0; i < fbdev->num_fbs; i++) { + struct device *dev =3D dev_of_fbinfo(fbdev->fbs[i]); + + if (!dev) + continue; + for (t =3D 0; t < ARRAY_SIZE(omapfb_attrs); t++) - device_remove_file(fbdev->fbs[i]->dev, - &omapfb_attrs[t]); + device_remove_file(dev, &omapfb_attrs[t]); } } =20 --=20 2.43.0 From nobody Sat Feb 7 15:35:11 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE5842D130B for ; Fri, 19 Dec 2025 05:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123031; cv=none; b=C99Dz9V3LQ1escas7avK+ZWv81h8vkOgmbwHshF1llJYyPOXspu50qUOP/w9bifJMtSuRX4my9LW+LfORTcMC978/nGkz7X9d/ZzpJ1YEHqsr2JsKym3zUNnPLceEg01vToJ/Qtu5I8MDIvWoLyv5qQfvBV4yY4KLQNyH9CoQic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766123031; c=relaxed/simple; bh=wTBNcJt2rI9S3EuSYIzTN+CG+sDnu9ds+FK4O8Ikt9Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GCxGUEXii9DG5BvlzWUMBESIFD1HyyonrHtmLlaAq40TxesapStNht8e+k8lHAIYusID+JZgEvN4JEmUtnTDVpcrsD0I+yoc1TYZ3+kjut6ZMSIHmcTiTgroKy8XDzveAfok27MxdRYduarTHpkVbQNFICczOxKa302mYNqbizw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BqUXsznZ; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BqUXsznZ" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2a099233e8dso13003225ad.3 for ; Thu, 18 Dec 2025 21:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766123029; x=1766727829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GyhsaHMpowAoVL5AwJvNjQeVURBtbaVBE0KV9gHYSKY=; b=BqUXsznZ8P4OyXHuXngaPVscRGGIN/svI91ndgycwFbrr3iCcwu5Wn2+sFPD7AOqlk kXcxIW8kg1HeXADbKto+/VAnpIErudnnYXfZh7TopzCAI5uMtMeuVGs63CsH5aW7X3eb koehOKM4CqKu/7rRtLf4ezvx1k9ZZ6ovrvkKZI1mi1TA9/X7Vi6hFSn7Ttbcnlvtdrvq lIC7ugaXETfdBVwpsloxNv7ijcTtBBODJ34LxSmk2bGuUiO6KQa82Q5/ulYCx15DeqNv HyodnIMuUS5nHuaVni4opLEi8xaHtL5oc7ZJFMs5w20s0VtXyd+r2eGzucpOSXneXhEH /K9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766123029; x=1766727829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GyhsaHMpowAoVL5AwJvNjQeVURBtbaVBE0KV9gHYSKY=; b=njGF61Tmop9Z1G/l4dXIl6wn5/hL4FwlCuVm+cVZ6/AMlp8nrOEUmzTmwCsUJ/oJmB VO+I9rZuPdYy1IVWVeUOZVgw+tVbteqsf2jjZjT0CbfVTewpox/tWIIZWjS6jlE1Jg5i g3wfQ5IT2eAIO9d7R/fcBh1NzRZ0/oJtQalhcVHMhoEF48dbRstSNVbHGsVHpnwnMM7u UZ9dMCwXTd3h3sWe40bJhBO7UR5OcQSMGDfjLWUWNj4uosjw82y6RpvzkzMQ/yGw0Bn0 k/rM71o+SgWMXkr7+NpztGmuVvEXQvLgO2duwn4PTyvSfszsMIglrCXMh3x7zsEMQPpH muTQ== X-Gm-Message-State: AOJu0Yw9aSQx32G0egposzoXk5L1LcNGMHxpCTwBbf0uzIYrNRJ2QNOI 7lrcWC76rtbxmaeUgTeb0O9jqox4qDKn84WY4Zd8IDLdMocOdq6krrwO X-Gm-Gg: AY/fxX6dOUvkOF54u/eISSM9QCxUGLkUey/RAxeokX4BILC9heeswrkFmgxd7Y42+Hw cM1Rnk24fN7MQImp2Lb537vDnCifFNXvj1Lj6OXez6G85EeSCrP7hYAkAnW/2zYDafTxw7vHUar /KJv9+eSA3Dn4v5oGqeZYmDvwzCIVoWju2mtqvic3xjgftKbCR8AnZJ4QII8lHxXw5MR+N5j1eb Gt576NXegc9W+/CtJ/cR1UzkkXZVTFhry7rntCuZQoLmFumueqsx7ulICFP1BdGHnkwPfvECk0c FBxAVRNBg3EYvdcY+4SB4EZJ5vYLJqGXuX+Y8olADxjum6inv5ZOKotvXGxMCjixenC9IYBs7kf MYIP1JTNwhb/UjXpqSx7ZLa1vKOPGQGwXnxilTko/xwVGtwwVKZUs/l6ll1mgeOo65fH3bnCNqt 8sjzVQYuDtcNSnB5B8gPCy+q2ef6jXFhpOhAMtYKhyY6o= X-Google-Smtp-Source: AGHT+IHXEchSi8iM+Y5+MS3Ww91XngpXuQu21mxZ8hWmVfsLgeWot8cDnyt6+QWma8zqSPX6kmHH4g== X-Received: by 2002:a17:902:f68f:b0:29f:1fad:8e56 with SMTP id d9443c01a7336-2a2f22049acmr15569505ad.6.1766123029021; Thu, 18 Dec 2025 21:43:49 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:5160:2cad:cf88:afa5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3da7dabsm9878955ad.25.2025.12.18.21.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 21:43:48 -0800 (PST) From: Chintan Patel To: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, andy@kernel.org, deller@gmx.de, gregkh@linuxfoundation.org, Chintan Patel Subject: [PATCH v2 4/4] fbdev: sh_mobile_lcdc: Make FB_DEVICE dependency optional Date: Thu, 18 Dec 2025 21:43:19 -0800 Message-ID: <20251219054320.447281-5-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251219054320.447281-1-chintanlike@gmail.com> References: <20251219054320.447281-1-chintanlike@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sh_mobile_lcdc driver exposes overlay configuration via sysfs, but the core driver does not require CONFIG_FB_DEVICE. Make sysfs support optional by defining overlay_sysfs_groups as NULL when FB_DEVICE is disabled. The driver always sets .dev_groups, and the kernel naturally skips NULL attribute groups while the code remains buildable and type-checked. v2: - Replace CONFIG_FB_DEVICE ifdefs with NULL overlay_sysfs_groups - Always populate .dev_groups Suggested-by: Helge Deller Signed-off-by: Chintan Patel --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/s= h_mobile_lcdcfb.c index dd950e4ab5ce..704c17ad241e 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1350,7 +1350,16 @@ static struct attribute *overlay_sysfs_attrs[] =3D { &dev_attr_overlay_rop3.attr, NULL, }; + +#ifdef CONFIG_FB_DEVICE ATTRIBUTE_GROUPS(overlay_sysfs); +#else +/* + * When CONFIG_FB_DEVICE is disabled, define overlay_sysfs_groups as NULL. + * The compiler will optimize out the sysfs code paths when dev_groups is = NULL. + */ +static const struct attribute_group *overlay_sysfs_groups[] =3D { NULL }; +#endif =20 static const struct fb_fix_screeninfo sh_mobile_lcdc_overlay_fix =3D { .id =3D "SH Mobile LCDC", --=20 2.43.0