From nobody Mon Feb 9 17:57:37 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1EA238D22 for ; Fri, 19 Dec 2025 21:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766180854; cv=none; b=mZWS9z1GMqDZqe2xgS3K5YLqrTHAwKHXNjvB8B7GwufAA7zoxwVsjLVe239+/KAbt2dyuGkjYbX3CwsPmcirbJw+RpCZYICEmqnDePm7SwGeE31mJh/jSp99e3cNHi+qa5rRAolM7ljVhdEb0WxqLqmJ7xiruM6crFrk4pGRjXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766180854; c=relaxed/simple; bh=ELPlvd/HHteO5jAPXsFgQeDK91aLwt10AAxIyPMcifU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IX/Hp34C39td1OBx9IPVR2e8kBqiPH0wciUoRkOXKm9IugGenueWtgkDJFBXMdfHAAw+acO+9tRI1mtMMwzaQXzFBZBYgmM6W98y9GPseiOSm24KwA88q+xOSmr75OenaVmNa10E/ehoXWJkYmp+PxnAKnIqGgeLmIgtoGzb5G4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=TX/yByPi; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="TX/yByPi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1766180850; bh=ELPlvd/HHteO5jAPXsFgQeDK91aLwt10AAxIyPMcifU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TX/yByPi/0JqZAjMlvupgrOqNNr67Ed/ug+dJwoHp0EqrX3aemI9d5q5qbpSWjq1P RUu+WnB0A/KqsIDSkbxCXWTgvlX/3CpTqawCnsuBfG3OrOOwERIyv6THWSvDJweyfq 4T9LUTyC0o3sJ0GhoXp+Efa1yBpyI4QSujE2rwSV7Gs0B9lCVYBDdRHbny0WEO5Klu 4P6ta+L9m1BwxG0/I3RpPCgT97O9XLDked75oqQESZ0+UhIdPmirteQ7rpzomdNvoN SmVmC+QzX5PEeW2idbV9/shLs7WoRBljiL3P8F/9xjXlgk56+yY4x5R/JSRN1m4A3j DqIXTuNWINEkQ== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 8233C17E1404; Fri, 19 Dec 2025 22:47:30 +0100 (CET) From: Cristian Ciocaltea Date: Fri, 19 Dec 2025 23:47:00 +0200 Subject: [PATCH v4 3/4] drm/vkms: Support setting custom background color Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-rk3588-bgcolor-v4-3-2ff1127ea757@collabora.com> References: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> In-Reply-To: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-Mailer: b4 0.14.3 Make use of the BACKGROUND_COLOR CRTC property when filling the background during blending. It already defaults to solid black. Since the internal representation of the pixel color in VKMS relies on 16 bits of precision, use the newly introduced DRM_ARGB64_GET{R|G|B}() helpers to access the individual components of the background color property, which is compliant with DRM_FORMAT_ARGB16161616. It's worth noting the alpha component is ignored, hence non-opaque background colors are not supported. Signed-off-by: Cristian Ciocaltea Reviewed-by: N=C3=ADcolas F. R. A. Prado --- drivers/gpu/drm/vkms/vkms_composer.c | 10 ++++++++-- drivers/gpu/drm/vkms/vkms_crtc.c | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vk= ms_composer.c index 3cf3f26e0d8e..03dd1815dab8 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.c +++ b/drivers/gpu/drm/vkms/vkms_composer.c @@ -474,8 +474,14 @@ static void blend(struct vkms_writeback_job *wb, { struct vkms_plane_state **plane =3D crtc_state->active_planes; u32 n_active_planes =3D crtc_state->num_active_planes; - - const struct pixel_argb_u16 background_color =3D { .a =3D 0xffff }; + u64 bgcolor =3D crtc_state->base.background_color; + + const struct pixel_argb_u16 background_color =3D { + .a =3D 0xffff, + .r =3D DRM_ARGB64_GETR(bgcolor), + .g =3D DRM_ARGB64_GETG(bgcolor), + .b =3D DRM_ARGB64_GETB(bgcolor), + }; =20 int crtc_y_limit =3D crtc_state->base.mode.vdisplay; int crtc_x_limit =3D crtc_state->base.mode.hdisplay; diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_c= rtc.c index 9a7db1d51022..2514c367f710 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -4,6 +4,7 @@ =20 #include #include +#include #include #include #include @@ -228,6 +229,8 @@ struct vkms_output *vkms_crtc_init(struct drm_device *d= ev, struct drm_plane *pri =20 drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE); =20 + drm_crtc_attach_background_color_property(crtc); + spin_lock_init(&vkms_out->lock); spin_lock_init(&vkms_out->composer_lock); =20 --=20 2.51.2