From nobody Fri Dec 19 17:16:04 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAAF9301477 for ; Fri, 19 Dec 2025 10:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766138916; cv=none; b=dkpUqqCv2FsP6k3pgvH4zvWA2jt/PcHYF42oIb1X3kdW0mf0klQSMAeEIUBoCU+jGxeTiiSlwxOqUygPi6qwOu9ZU6JMPtYZ2N84EWe8W1scl1ysoV6ccMWlmqLzVy1jYJnybV9FNtcSDdDIBWu1t4SwZJLE0BZiAXxy6JJQTFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766138916; c=relaxed/simple; bh=7PMKbHeEm/om41ZfOgXSUioL9D/Bfv6TCCK90Aa4rTw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=slVgAW1JZ/bWL1pfnyWUQoXj8qPD2h4OyYsr4pKPiTl3IgC3fs8CGIVhzAyE4Z+LRR9pzjhJ4V9ZuSlDnBUaCx3IcN0peGNzgwLO82W8LOws702ov/FMq34qOBbNf2zQa0UH0EIYZfPbAEm33aHw1NFOH7n4J5Utj4z79iDs1wU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ndl0vkEM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IwFBeaeh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ndl0vkEM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IwFBeaeh" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJ4cDAn3991646 for ; Fri, 19 Dec 2025 10:08:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OKtSBSYuKktai9lNFrMLMD4oW6B4SqV4qHfmpcs+L+4=; b=Ndl0vkEMEUdkCxV8 N3ed9BiryJrCvZMjeKx1MFoIncdkjYyRZCT7C/1ZPxYsnYJqzcr4qeFxgPrV9AOI WcPDq6CJKJCQbzVPFlzQ7Hl+4b2IdLLD5eqhtZaMFUdZWJ61piZw5vvIWcQnfauq 1ZVeW4ivGuxy4oRT4wLCpDTiObHhwyg8bHNJlCB8+ekjvl+N2d4PtNyUsk5F8ENM 0um8PGcSFRCulClJxdy4VGo7+oImJq7dptycKgASPHxW7DT0JL00MNtzdo9wl3c9 nachHeRsG6Z5Pqbe/eMQfpX4r/5ogG5cz43oqrwuH8GbME5FuzNiWzWTPL7CRsIR jScseA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2da6mw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 10:08:32 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee04f4c632so28716121cf.3 for ; Fri, 19 Dec 2025 02:08:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766138912; x=1766743712; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OKtSBSYuKktai9lNFrMLMD4oW6B4SqV4qHfmpcs+L+4=; b=IwFBeaehHsEpIzb5mbV285dqQw9Q9lcEjeEHAzCfSVNCtBwrReQLMCa6/2u3VI/i8h nef5XQ5wfiVcZAyUX52M9het4nVDbw0FxB4cjp3xCqHDMgoLbMj1M4bMiI3mA0B6Dg1K xZl+cndDVVzuPzAa1m5ubL8Am5dsBGKvpyeuTNPjoUzt67oiTi1ddlFawDQVYoWilYrV jkb5oyQ+lvBOIzG1ehm7nNhs0NK0TI39ogSHxkxASMICoYUKAZmPwdY4JzBDqdr4o0Uf 1R/YgORTdivw5TK8xDt6taO9ryVCtUJT/3MsF+DVapM8+Hb7EQ3WU2Hp4TDnt40O82ov cTvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766138912; x=1766743712; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OKtSBSYuKktai9lNFrMLMD4oW6B4SqV4qHfmpcs+L+4=; b=QHMxY1yQ7fhsuCkONDU4eQvWOE0L9DYdKk3TQETe4AxV9QHFAggvsyQrRi+rPj8c9o QdvY9G2062wNlc2FpfkoplcgcjzEFNMMLsi5j7p8XCoEcnY3gypNdkTumPhl61tJVYVl apd4gd7IPiJic5zCrwMsCtUYOKrdkX7dN1dzR8QkSH0EIKL1/FrwFKK4NRPfF89EZvAj 0ztcrUUSmGrAaO0YOsYZxfMHeD3hIU8+25jdPTlM27b/UuwjFdZ3hJo0PwCrKqVbjHOm pPGbtWv6/8GXLKsLE20nA2aJJ3oHpqpaygyaB2yg94hCH0KNN95WZd8EL7jfvzTmnMgf jcrg== X-Forwarded-Encrypted: i=1; AJvYcCV5Qf9KEuEOaXBH+piTxKqmJKE9nLv8HUf23X2GHF7d3FeF8GG8Dic+6gM3e50vMVNDNqVLlmG9wlH0hBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzHuRCLaELx8fy9aM23e8m7ahtMgFpLyPSiJv6uPAWVNRsCAqM9 eUreayQJTuzoxOuBmSKT0MFiZTGt8x+55dT5f1/QNmytsbkoon17tnoBJt+WTv2HF6BLdkNzWMz zGQe2bgALZi+6KhxEKxH37975oc+ysfnX3mBdQr3pQ4R83nT8btg54YYYOuYkkTjPnDY= X-Gm-Gg: AY/fxX55/hEZQpMahkFgumHmSJ9Fn+OEBhVe8XVe3ysL/9GoPjEqJmcfJ/fTDCY6v7Q ZqZYdbHmLoqeuzkwS258vi9rIaufFz2oAlPdqGlykZsd1Wh2gkzB3HAXuZpDQqxXsInP2RrSK7j mVv1SNH4m+E86bFMVB7OxtfvftS9p3Ogl145P0yEG6LJCACBD9NWameUtfRSElzExZ1x2h6Ou1D doZRiN8THIb5+zN0Tn5j0C9GAK1VRBiFrLkJdjRfLud8rxJBP4okupbRQOY8hluj8WP1Inx1Mgm qL+JkzfkMwTieW0QejU/h/TwHz/Vyi8gUEAVZsH8VX+Mhh6dATc2SU8O1x7tcFKSOAfgh+V5OQu 9ORveVG3sr/xxblMVxoG1wdfPWPJ8DNnw4/UMiQ== X-Received: by 2002:a05:622a:1b89:b0:4b7:a680:2111 with SMTP id d75a77b69052e-4f4abcd07c2mr28894911cf.8.1766138911782; Fri, 19 Dec 2025 02:08:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFx4aU9c/3drBxdTal9gjRRzpkhIFGuTGGDieFoT8rX+8Th5TCaz2tgCfcXi74dOJfJo/j0UA== X-Received: by 2002:a05:622a:1b89:b0:4b7:a680:2111 with SMTP id d75a77b69052e-4f4abcd07c2mr28894711cf.8.1766138911240; Fri, 19 Dec 2025 02:08:31 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:a48:678b:dad2:b2eb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82f6asm4209571f8f.27.2025.12.19.02.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 02:08:30 -0800 (PST) From: Bartosz Golaszewski Date: Fri, 19 Dec 2025 11:07:43 +0100 Subject: [PATCH v10 04/12] dmaengine: qcom: bam_dma: implement support for BAM locking Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-qcom-qce-cmd-descr-v10-4-ff7e4bf7dad4@oss.qualcomm.com> References: <20251219-qcom-qce-cmd-descr-v10-0-ff7e4bf7dad4@oss.qualcomm.com> In-Reply-To: <20251219-qcom-qce-cmd-descr-v10-0-ff7e4bf7dad4@oss.qualcomm.com> To: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Daniel Perez-Zoghbi , Md Sadre Alam , Dmitry Baryshkov , Peter Ujfalusi , Michal Simek Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski , Bartosz Golaszewski , Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5035; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=Ky8hwlPnsaQJGL7zF3W8NhhDThxLSiaPym+IqXC47N4=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpRSQQvsUmiLulYKcMt7Dn+ylHkzG53fkNhxgDh wsQHoEoaTeJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaUUkEAAKCRAFnS7L/zaE w8MtEACG6d1PBtOtnqSSYotH582RdbHlR0LL2ik5vDSIR+js62LAIsEzJoNSGDWvy8NnHWcOP8G Hhp3DWitWgvuwBJav0rMhIrnnM5I21v33l2BozxeaehaaDe0qrKLbXXjiNY9oyeNk+RL5nKlImx hO2q7/2Gi0RxG8clBEpwLIf7hz/Fj7fRuDHGOayKJEU7DrclDToToh2lLeIH0pRmgqGOEKrYhps 4Ob6kEhPgaYXhxZjSTgm0vd0nH18qcFtoHeqE/uHqsVOQZo9Ov6W54OU97ezQLev03fTOpoEISA CN63bP2hoXRb3jSa5mohRAaFwMOfoeyOf0gaDTqxAzBYVZL4DgGSMgy/p9CkgamWYd40fcvdTDC GU9ruIpkUtziXSF5ARJo6PY9pHZFuAUoimF6snHTxDY0og30re1TIUQM7zoxWKRTghcB9DvvPPJ KBzuu1B27Mhc69Ua+wR2Xq2efRxGxAqI1zbWngLUA32g+Ezdjbj7VnZayBxQflxDSncJFhye54k udwIt4afIkVdlnwrSacKjywmYp3mP1dxlI/ZkHSCnM0sWsKmzAQ0+WTxraBpJ8ZndtJL3TfmGo6 GTUrxEIxSpIsIoqNdOhO5o5iV29MjT5/nQ+jjcTCv9i+oyFaqMa838CIku+L5qedOjfPnb4Znno vAPKN4X1W+sA6QA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=AcG83nXG c=1 sm=1 tr=0 ts=69452420 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ff4Q2WZ4h2nLullQlX0A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA4MyBTYWx0ZWRfX+2mPRMoFdYQk jSniQd5uMEG4R8UmhPr+Jze3qA+7SV0+j4wFsj4dpHoet3xjHje1W7KmPp26Jl3jaJQsGC+wCX9 W71gr817fApJM/oKmf3kOPyj4U/ll+UxXjzJOktMqll9Fiss/pnFkdp5u8lYfN9Y8p0B5hfSKxw NuBRxIPPob3dcGErBSRqJXALvQjP4YwXYCNJPYSZL9VyQbNSbkf7StgB25pg2egfYogm0eouLX9 U2LFI6KnINjOGpHrlRYY9CRpCZG5poKCjQ0P6BStovWyMbTJTIrxIp8fFBCSGTJaVkate/17TCh BHu2eHx/e97CRgJu/SclTEYgu3vtloLXcRHbKayBBw75vXUsw/Rfd6ha4KceHZjytb8/PfCWTUh /31RW9fUuXhuqH0dEdMe9gfYg4UAcBB2uSAUdUTQ/h1NCJJAwVWhlgBE9mj5xQN/POWcNe9IXFq C+OYOMy8N+3j+G2qtVg== X-Proofpoint-GUID: IvgJkbO__GuvU30AzvidrUX5YGsE_ypO X-Proofpoint-ORIG-GUID: IvgJkbO__GuvU30AzvidrUX5YGsE_ypO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_03,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190083 From: Bartosz Golaszewski Use metadata operations in DMA descriptors to allow BAM users to pass additional information to the engine. To that end: define a new structure - struct bam_desc_metadata - as a medium and define two new commands: for locking and unlocking the BAM respectively. Handle the locking in the .attach() callback. Signed-off-by: Bartosz Golaszewski Reviewed-by: Dmitry Baryshkov Signed-off-by: Bartosz Golaszewski --- drivers/dma/qcom/bam_dma.c | 61 ++++++++++++++++++++++++++++++++++++= +++- include/linux/dma/qcom_bam_dma.h | 12 ++++++++ 2 files changed, 72 insertions(+), 1 deletion(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index 0ce9153da67032dc8ce910f68d1f80019d8b29f4..e35fc73a53aaa2a6b999b189add= 7d72df15ebf0b 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -59,6 +60,8 @@ struct bam_desc_hw { #define DESC_FLAG_EOB BIT(13) #define DESC_FLAG_NWD BIT(12) #define DESC_FLAG_CMD BIT(11) +#define DESC_FLAG_LOCK BIT(10) +#define DESC_FLAG_UNLOCK BIT(9) =20 struct bam_async_desc { struct virt_dma_desc vd; @@ -390,6 +393,8 @@ struct bam_chan { struct list_head desc_list; =20 struct list_head node; + + bool bam_locked; }; =20 static inline struct bam_chan *to_bam_chan(struct dma_chan *common) @@ -651,6 +656,53 @@ static int bam_slave_config(struct dma_chan *chan, return 0; } =20 +static int bam_metadata_attach(struct dma_async_tx_descriptor *desc, void = *data, size_t len) +{ + struct virt_dma_desc *vd =3D container_of(desc, struct virt_dma_desc, tx); + struct bam_async_desc *async_desc =3D container_of(vd, struct bam_async_d= esc, vd); + struct bam_desc_hw *hw_desc =3D async_desc->desc; + struct bam_desc_metadata *metadata =3D data; + struct bam_chan *bchan =3D to_bam_chan(metadata->chan); + struct bam_device *bdev =3D bchan->bdev; + + if (!data) + return -EINVAL; + + if (metadata->op =3D=3D BAM_META_CMD_LOCK || metadata->op =3D=3D BAM_META= _CMD_UNLOCK) { + if (!bdev->dev_data->bam_pipe_lock) + return -EOPNOTSUPP; + + /* Expecting a dummy write when locking, only one descriptor allowed. */ + if (async_desc->num_desc !=3D 1) + return -EINVAL; + } + + switch (metadata->op) { + case BAM_META_CMD_LOCK: + if (bchan->bam_locked) + return -EBUSY; + + hw_desc->flags |=3D DESC_FLAG_LOCK; + bchan->bam_locked =3D true; + break; + case BAM_META_CMD_UNLOCK: + if (!bchan->bam_locked) + return -EPERM; + + hw_desc->flags |=3D DESC_FLAG_UNLOCK; + bchan->bam_locked =3D false; + break; + default: + return -EOPNOTSUPP; + } + + return 0; +} + +static const struct dma_descriptor_metadata_ops bam_metadata_ops =3D { + .attach =3D bam_metadata_attach, +}; + /** * bam_prep_slave_sg - Prep slave sg transaction * @@ -667,6 +719,7 @@ static struct dma_async_tx_descriptor *bam_prep_slave_s= g(struct dma_chan *chan, void *context) { struct bam_chan *bchan =3D to_bam_chan(chan); + struct dma_async_tx_descriptor *tx_desc; struct bam_device *bdev =3D bchan->bdev; struct bam_async_desc *async_desc; struct scatterlist *sg; @@ -728,7 +781,12 @@ static struct dma_async_tx_descriptor *bam_prep_slave_= sg(struct dma_chan *chan, } while (remainder > 0); } =20 - return vchan_tx_prep(&bchan->vc, &async_desc->vd, flags); + tx_desc =3D vchan_tx_prep(&bchan->vc, &async_desc->vd, flags); + if (!tx_desc) + return NULL; + + tx_desc->metadata_ops =3D &bam_metadata_ops; + return tx_desc; } =20 /** @@ -1356,6 +1414,7 @@ static int bam_dma_probe(struct platform_device *pdev) bdev->common.device_terminate_all =3D bam_dma_terminate_all; bdev->common.device_issue_pending =3D bam_issue_pending; bdev->common.device_tx_status =3D bam_tx_status; + bdev->common.desc_metadata_modes =3D DESC_METADATA_CLIENT; bdev->common.dev =3D bdev->dev; =20 ret =3D dma_async_device_register(&bdev->common); diff --git a/include/linux/dma/qcom_bam_dma.h b/include/linux/dma/qcom_bam_= dma.h index 68fc0e643b1b97fe4520d5878daa322b81f4f559..dd30bb9c520fac7bd98c5a47e56= a5a286331461a 100644 --- a/include/linux/dma/qcom_bam_dma.h +++ b/include/linux/dma/qcom_bam_dma.h @@ -8,6 +8,8 @@ =20 #include =20 +struct dma_chan; + /* * This data type corresponds to the native Command Element * supported by BAM DMA Engine. @@ -34,6 +36,16 @@ enum bam_command_type { BAM_READ_COMMAND, }; =20 +enum bam_desc_metadata_op { + BAM_META_CMD_LOCK =3D 1, + BAM_META_CMD_UNLOCK, +}; + +struct bam_desc_metadata { + enum bam_desc_metadata_op op; + struct dma_chan *chan; +}; + /* * prep_bam_ce_le32 - Wrapper function to prepare a single BAM command * element with the data already in le32 format. --=20 2.47.3