From nobody Sun Feb 8 12:39:11 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB96E339B52 for ; Fri, 19 Dec 2025 14:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154967; cv=none; b=kqjU3AZ4pxakwH5TUenSs7N1OOSWML/s4rHoGxxpSO3o3GIoKEhdw/i8qmbVfNwrmbR1KjHIZqyoohsyPARFu+5jgOxha+alWgOYCb+eG2TpkvuMBBIPHdA4uQbdHhluboWIXBhlPXw4kqNknRnb5G1WJHZq5ULEFhwKLNF0hlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154967; c=relaxed/simple; bh=FwErtDRj45YR9+G3sGWpElTdT9H2524MS3PEIg8X+gs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=thkZQ6GBi6D+232Ur9WqzXlj/hiydAihnTBijTbvAavZblXY56NBlnl9mmEGz5tTsEWUkhZ0yRevjRy46DSge/ZlSzF8NUbeowShLwam/wEG22DfY3FBgS8JFRXI61XAtKnyDpoOcfsf/dhXwEmoWQKWdih/xxfFw9jABSKsEn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WAIpjOpQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lfhfrg04; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WAIpjOpQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lfhfrg04" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBk6BO3320433 for ; Fri, 19 Dec 2025 14:36:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QO7v3mInpyxqmqngfzK6cMArjVhYiK5JPVpSUzcyyGQ=; b=WAIpjOpQ+PoNwSKf y6JtoIF7TqlCyNrzHYGE+yWtSdWoOyxksM5aRSYFA8xjuacFCIiBdanU0xMirIwc HvvXytN5sQL9MThx09ocL96j496Kwdh1HT/ShkbLg+avvHcZOQyP0aQcLTJjdjNS plwyUlhPM5DGO7yfqsRg7kNjM3mghrWuzrUg4NZSiwgykJ0l3J1XJiVeohj5EvBg ZwM7Hk4vg/6y/A39PL5MEv/AFz7koX2K9SDHVI/Su1KtYGcY+uEGI6Nx5NjVhRjX TOpKAI0d9aANoZ5kav6OUUVD8dNycvwl6xva9HaolBGgAafQsUkpDV4jOb5etk2Q ME8/Dw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2etwhh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 14:36:04 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4eff973c491so41774481cf.1 for ; Fri, 19 Dec 2025 06:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766154964; x=1766759764; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QO7v3mInpyxqmqngfzK6cMArjVhYiK5JPVpSUzcyyGQ=; b=Lfhfrg04yTkKQWJUbLB5Lk8/hjlK40psqjW3P94WAx85x0mCXkSdB4QifIK5tXdGdv nvVZA3s3T+STjMetgUsTj55G8dWTZqzbOx3f+ZZu6Ez2AMnzckMMTjrPxpnAl2QJWP6Y LqfTepK0R6FRSjVHQhWKoM4DccCSIHWgLvHKE9OLBnmDFVFJupvxHivG49vxOWfmqjUA XU4KB+ePdITvukkMoyYK8WPp642WGXk8VmT4d3A6TIPJWOLfsJy4VQLhZeGjVWpLM8Eg vuxiLgprpKRsQ82L9lkQLnilR3eFT+xJZgSLHg0mbmNWVgSZ5jerWjI2UAgRuqPS6+jX 3yEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766154964; x=1766759764; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QO7v3mInpyxqmqngfzK6cMArjVhYiK5JPVpSUzcyyGQ=; b=HdMGrjzD5An8eOZuAqzRMgCBoQaLwjnlyEWG3cXb3G6MVpDbVdKP0PHH1m971zhTcd vgN070vlS1TJMqVUS5SrIueO7od5JdBoqlN9GkK/p4gpbS2JykCdKWiMpckM8yT4Crjw QIi0q2KKNC/99v/+apIyFqK0rfZ8X3+QqNCrOQ0p2cI7M4OhZ5YK0JS0A06YDZj7dTFm CEoz08mSjleCv6FBReGN22Q8l22ogw2BFq2XCUbH4uO+wYyACIiwmXjw0TJTq9Mlxbs+ 58UPvXZeNJzEWkDGCyukFnRhounQbnO6b2ASfhTf/xZvlVRjw4mG62OOZfnoCrXNQDZG n4kw== X-Forwarded-Encrypted: i=1; AJvYcCXTBS78yITbVAARcMAzvv0OW7AE6v2J3rD6crUQClbD5I238FB82+sRocD47EZriCYd+KVfi42Whzfv12Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxD9D4rMGwyVZ22SWCGH5ho30h8lutxBksXrOodZSVua5O2TLvG bbDHqtjYZi69Zfy7u4FqPYfwa6GChBHryUHA5q2HwMjhj9uZeQWcQil00VCbcgq60XNUnOycKHs n8DjR7Zec4mSlbphFglHtWk4GoCnooWX9eaIFgvsEQh/4Bqnk4ZxIGb88FqbVqf0yp/4= X-Gm-Gg: AY/fxX7xWquYeahj1HTSOPvabY2FlNVzeRtzW+QAjmU0fQHb/XvlA35GUtm/7CA2eC7 tI4ywTaAFnuOeFdlEHMl/36ZxPC3hb8Qx1sKxBg+BarakPVcnuStGBJLeanLUvv67mTYMqvV9PJ SFjYv83N80/cE8luYOG+spk1tcn6lpgq3V4OZMK0aRDnKv4zA9uv0P6LTJ1rAhuKarNWaj1hDfy vFJQwI1oGywbsS/X7q16M+5yh+PkI1HwNkrzV7w1ZPFKsv3aWQs8gbY6rD9RH59m8TjFvpoEEmP vrfg1IACNUFZc09yDYkULjsN1RlOIU/2rbL285mpof76CfxsuOVog/9ywcGLaiJiedC8Xusgme4 sywICea0w/3JdjY7HGXXcowSXsIIMyjHkZrdxwD4MrpYlSRGkMTAaUJhaGjnkiCQb0ZFL X-Received: by 2002:a05:622a:11cb:b0:4ed:a6b0:5c39 with SMTP id d75a77b69052e-4f4abdc6a4dmr43263581cf.63.1766154964149; Fri, 19 Dec 2025 06:36:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYupEl3gYLzDt53suprXOO0WmjuzlD6rknnropJD9KMCWfnffglHqPJoWvFjr/nYkg2I6ZFg== X-Received: by 2002:a05:622a:11cb:b0:4ed:a6b0:5c39 with SMTP id d75a77b69052e-4f4abdc6a4dmr43262891cf.63.1766154963604; Fri, 19 Dec 2025 06:36:03 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f86sm245145966b.17.2025.12.19.06.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:36:03 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 15:31:54 +0100 Subject: [PATCH 5/5] iio: adc: sc27xx: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-iio-dev-err-probe-v1-5-bd0fbc83c8a0@oss.qualcomm.com> References: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> In-Reply-To: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3222; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=FwErtDRj45YR9+G3sGWpElTdT9H2524MS3PEIg8X+gs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRWLIBxhyFmOssOsCYuSdWCS+KQ38MQOZRW/DR UUjiKlsTFiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUViyAAKCRDBN2bmhouD 14EwD/9O5g0sKxohmlPbWRb5GCF+Zyv/zhIM4UOKtjqVRmXpwhQlQ5PPhdnKhun24YiM5mVrrTJ jazVQ0q7AS3Pd2nhNF4aEli4cGK6v+5tsbY+W+Z0S4brTp60yR3kHRWKRCH1obXF5k//KG88vDI utRrA3kUsFGOuVY7/mGT6u70Y3vLUHvpOIePcaw7yO9ZGQDh1fhrk3V3xE726Y05GFCMAGboP75 e5VMg8CddWKpb7pPw6KRXj6vMp3stkIQKd2FwIKY+ZVmeuk/WbgJCkyb7JgtONVtYQ7HhS5kv5V quVBHJXrbe7XoEpzecJg2KoIlIGSd1hkMo3M3rO6eKwxyyDiwo+IbO+1tAiGJ6z94+0rB3TWS0z JCwZsFz7fcLYl/27TiOCXPxoBnkGkpvwMCilqcQ0wuG8Na42nRitMIu5+E2veKtiSHsZkYBaOyR qHojscW3lXvVSO1PfjMjpFwqaB3byNdUl96aEpaSezOibzXovGjyYtcrkVErlwWYnUUgSm7JDfd SuH2bGvlkFDQDgaR7/uudIXSCccjtRXp+GjB0rZJLAgTtoPW+LIukSddD2zmR6Pz+gV0UFqZSMK mAbcTZA4Xd+e1kCf+Aey0jp6AP4Fkt9KxCEvNYvSGtubZ60ve7d5mAoLFT1jAeudBulbCHSu47V dnwL6XXYday0k5w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: i_3K8ycrOrPOFpdLxxrjxzWWzr3xAof6 X-Proofpoint-ORIG-GUID: i_3K8ycrOrPOFpdLxxrjxzWWzr3xAof6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEyMiBTYWx0ZWRfX976ADMZCZvCj wgn1b8sBKxhIQPNJkqrI3b9eY32da1nV7dZWPjzLWxG5nyw+MtfEgqOSL1g3glaAoswc0gS6k4z x89+QdjlKgBKl5QNGoR5IErxEelPizXu142mXUws37xofcsQ38Z9+P3Y1yWUR8w5HjpBpHbS3Ck NEw9QoGR2Z49D03Td0bRbAVsvh66ho4Adzgx1tKYskKoD0GRcAPS52UgDkyGLWUYz23p6ThJh3c t7XUo5En0+eVYb6kDKEPiJq+vMP110AGMEdPy/mAoMzuj6HR0lKU8soVu7V2nzHtYu1l4SesxRC XSd0vaHMfALE+AUQuAyTgttNKwayoM2n5nyQfHSc3TaQClqI1dpmQ2KvtcDdHja3Tc8RQMy45Z1 FrJx/+g3KTlg4sib9l4+us7X+vLed2O+JS79yQslcZqwS2TYz0M3EhJNxK8lMsGIsGcC6qRNh6T QKuBSP9/2ELuZX/sXCQ== X-Authority-Analysis: v=2.4 cv=Tp7rRTXh c=1 sm=1 tr=0 ts=694562d4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=cWTT0jPcX04evTyD5nUA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_05,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190122 Use dev_err_probe() to make error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/sc27xx_adc.c | 49 +++++++++++++++-------------------------= ---- 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c index 2535c2c3e60b..6209499c5c37 100644 --- a/drivers/iio/adc/sc27xx_adc.c +++ b/drivers/iio/adc/sc27xx_adc.c @@ -867,10 +867,8 @@ static int sc27xx_adc_probe(struct platform_device *pd= ev) int ret; =20 pdata =3D of_device_get_match_data(dev); - if (!pdata) { - dev_err(dev, "No matching driver data found\n"); - return -EINVAL; - } + if (!pdata) + return dev_err_probe(dev, -EINVAL, "No matching driver data found\n"); =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*sc27xx_data)); if (!indio_dev) @@ -879,56 +877,43 @@ static int sc27xx_adc_probe(struct platform_device *p= dev) sc27xx_data =3D iio_priv(indio_dev); =20 sc27xx_data->regmap =3D dev_get_regmap(dev->parent, NULL); - if (!sc27xx_data->regmap) { - dev_err(dev, "failed to get ADC regmap\n"); - return -ENODEV; - } + if (!sc27xx_data->regmap) + return dev_err_probe(dev, -ENODEV, "failed to get ADC regmap\n"); =20 ret =3D of_property_read_u32(np, "reg", &sc27xx_data->base); - if (ret) { - dev_err(dev, "failed to get ADC base address\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to get ADC base address\n"); =20 sc27xx_data->irq =3D platform_get_irq(pdev, 0); if (sc27xx_data->irq < 0) return sc27xx_data->irq; =20 ret =3D of_hwspin_lock_get_id(np, 0); - if (ret < 0) { - dev_err(dev, "failed to get hwspinlock id\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "failed to get hwspinlock id\n"); =20 sc27xx_data->hwlock =3D devm_hwspin_lock_request_specific(dev, ret); - if (!sc27xx_data->hwlock) { - dev_err(dev, "failed to request hwspinlock\n"); - return -ENXIO; - } + if (!sc27xx_data->hwlock) + return dev_err_probe(dev, -ENXIO, "failed to request hwspinlock\n"); =20 sc27xx_data->dev =3D dev; if (pdata->set_volref) { sc27xx_data->volref =3D devm_regulator_get(dev, "vref"); - if (IS_ERR(sc27xx_data->volref)) { - ret =3D PTR_ERR(sc27xx_data->volref); - return dev_err_probe(dev, ret, "failed to get ADC volref\n"); - } + if (IS_ERR(sc27xx_data->volref)) + return dev_err_probe(dev, PTR_ERR(sc27xx_data->volref), + "failed to get ADC volref\n"); } =20 sc27xx_data->var_data =3D pdata; sc27xx_data->var_data->init_scale(sc27xx_data); =20 ret =3D sc27xx_adc_enable(sc27xx_data); - if (ret) { - dev_err(dev, "failed to enable ADC module\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to enable ADC module\n"); =20 ret =3D devm_add_action_or_reset(dev, sc27xx_adc_disable, sc27xx_data); - if (ret) { - dev_err(dev, "failed to add ADC disable action\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to add ADC disable action\n"); =20 indio_dev->name =3D dev_name(dev); indio_dev->modes =3D INDIO_DIRECT_MODE; --=20 2.51.0