From nobody Sun Feb 8 01:31:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 204DF339875 for ; Fri, 19 Dec 2025 14:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154961; cv=none; b=mbmcGL6vICG1wb8Lie57OXM0FpeRVaAolIbyTmonFC7MENccGoX+bdhZepmFd8ZSNisHZGbKoiL4xZmsL1/P0JqhsKARIuvD5ZLAHa/x0zgRKR0pE9f9722UQ/sYpwWDP32IYwE8fU4el4Orevi9ztVhP7Vu0SpMy5VdRQq1WEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154961; c=relaxed/simple; bh=z3gIGj1oIvvmH82pocqz/4k2PQOnpGa3jr5JHcWhyj8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qhZUROW3KFc/GECf1eunHD2uDjm25ikI9jQP1bD+5wghVdL4uDi9PH/hj6QZ6N29T6uLIn86CSCT8L+wEMeI8J7CJdA7ekj+k79bPNcNorl3ln2X+3g8NRZP8QauVpncUvu5MckMDL46/w8CppOL8rZ6hpKuiUavP1BNFx9YFQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aAO6xiK7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JaqxpZsf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aAO6xiK7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JaqxpZsf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBkcEF091626 for ; Fri, 19 Dec 2025 14:35:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xV7Sj1lP+ipO/vMdQQDAnXh1FyZ9JEzti6vulzMdahc=; b=aAO6xiK7B2Ahpu0Q tStX64yB/Oyj6iYNxsdek7WORUjXVMmB1EL6+Wo81vsth5sEsUNHmvEBxPaakkiT 3WXMe9musPUKGR66HMiUIVPfcEIYimPkz8v+nn5K5fZ/ot581KTdLa2XOFf9SC3G yKvrcxcYJxj5Zm2LKOXeDZS61VYFmeBQk4w+V48PN/LZSjl4Hvuyy9Rak2s+wL9V GRCZXgEVJ5hMXictveqt3ggt1808OhVYh55oeeXcA4/BqHqX8Qj8pBVlO07OmyJI tUd5Qv3CNWYPQZF0FaRzPBUdlbC7lgYYqyx6sA3bQ0YIuCRo22y6rQg+MYvAEJOf t2aX0A== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2eay3h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 14:35:57 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b17194d321so227980785a.0 for ; Fri, 19 Dec 2025 06:35:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766154957; x=1766759757; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xV7Sj1lP+ipO/vMdQQDAnXh1FyZ9JEzti6vulzMdahc=; b=JaqxpZsf9sw3FdzTGwsPCaYwypSmPdzFIuLChBu5daWVSpFEtrcBDNXLnZt45NbysL J+ETCxizcWlRUFQqF7rUhIb2jRfiK0ksET9xwKHjGPTWvjVLlTVjrrhI1O/giT+S4kOA pR4U3PSCv4VhDw1lgIaNFXtC/BqhODhXuhTgtKw+Pv4YLsOJcjNNGhrZ31oLNaPizoDn cmOaNjESgjj9Hn3HTpJCw9Su7trUQNpmvROEk4L33kHX2M0OZ5nIoX2XHY7nAW5mXmlt n+BZRLX+5dl0zovn4B5zokxW52RsRS1njMdEh3Ynq51i7Mfr/orol1Sv7ABYAiihZpaL aiaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766154957; x=1766759757; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xV7Sj1lP+ipO/vMdQQDAnXh1FyZ9JEzti6vulzMdahc=; b=MzuNbMRsEecOro1U6Ky3TZPoNqzlEL6p3MJdmU4t+aKx2pV02k2viipw8BrLfIVvxT CF4XP+r/IEL1DU5EQBIbp/my1dM6SV5PKT6+To7pt/Bxqv6/9GwRCQku5GTJ7XRkIPDa ZYikSicNzHlffs5o4/fhgCnuijREH78kRzM7LJ3AGfljpzHHOF/Tjjgf8eGpETCy7PH3 YS028DAephuAFQPWoZArKArd+cl9VQm/wQlPEuKm+CNVkSZEP/LBYKur2axCGcflWQAa 1qCtqfiLVvJR0U649WI5zPxHHEIFXA4ibCtr3zdPLsttUqw0SREHvd69tkVQXe8SDcl+ iMaA== X-Forwarded-Encrypted: i=1; AJvYcCVWGlcvhUukvEc+Eg8lb6jXjBYjeKoXPwdYkQHgvS4RahUqx6FeTDLkPRgHzrQCCd3u0BcxQCKHDLlAjqY=@vger.kernel.org X-Gm-Message-State: AOJu0YzX+JfrxGrcgr28btK5tWc1MgxRbynGe9eejHEl65iZc1bkrLXP +vTj/B84F8Uh4YvENASAdXF9n0kcDw3zGbIkSQTzHrwVl8AoNA93pltJNYxR3hHAC5SGaxJlJ9Q OZIqhe4XKDRSOXpQK2/Ldg+851gOZH0KVl4R4Xq4zbgJNNEXghP4ETW7fHkLmCbx0J9o= X-Gm-Gg: AY/fxX4QEI+eioju0g8OOHJZodlFH0OApI1d8SryeePLX1LZvNvahoyU8xFOkqpac0L tdN85j6jwp6Xt6ncvqkgljk92voHgdCo6Lt7pjCfH9nh10y6zjA1+kgAu31cwfnIKewebEuYjpP DS/oIJF3DVrGSdxiWofvqY0QXvyE97gjJ51v2+N19a3dHYOmbLSACXbVFshoGnOGeytCQNrxfjf IFD1chCvM458IcEJJvlg5qOKXOvQjcvcdkpHDJEJ05C6Oj7CB1sW76ryhJdM1bQ71Szyw10zZ68 NJ9oK0YLSrRaGepbnug3ogqrE9HJBP1M4KF/Y4K8b8PVCD+YI3P2nfRAPpZrz4NV7X4EqQg9d+b DaBCkh8Zz/IB7KpLbzWNfNLzTyu6S3Ju+wEWMYwDqL6Zm3ZD+Baz+rXdrktcTztq7rdAL X-Received: by 2002:a05:622a:4c15:b0:4ec:fdaa:b31e with SMTP id d75a77b69052e-4f4abce094cmr43174021cf.32.1766154957154; Fri, 19 Dec 2025 06:35:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpXU5pTYf8IAIDbE0Sqzc6Vk3SDvjFDfm4RPQu+aDyXRPlzu/xbQTB4M/gboaQR6K2hZYIIA== X-Received: by 2002:a05:622a:4c15:b0:4ec:fdaa:b31e with SMTP id d75a77b69052e-4f4abce094cmr43173611cf.32.1766154956699; Fri, 19 Dec 2025 06:35:56 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f86sm245145966b.17.2025.12.19.06.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:35:56 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 15:31:50 +0100 Subject: [PATCH 1/5] iio: adc: aspeed: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-iio-dev-err-probe-v1-1-bd0fbc83c8a0@oss.qualcomm.com> References: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> In-Reply-To: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1098; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=z3gIGj1oIvvmH82pocqz/4k2PQOnpGa3jr5JHcWhyj8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRWLEcsg/U41BoWF/u0CzNiG+xeoGWVjGVoXoT NfSmwwYEgaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUVixAAKCRDBN2bmhouD 17LSD/9ruRFSUuxVXUPfzteRn2rDyimSpK7gTLu+xZB/8ccc5jh3NFxaTc82kprKc9KeXopFpk7 sxqJAClDY/CkpObXefij8urEBNLvrMDnI2eShXdGAumF4Re2rxTN2eN4fpTrEsHeVCeRn/GUiTm aqd8AWv2WVpUQocZdUlWsHte9x4AyuaQiclWlO2P/+ESmUygqA526P77fL+zqusY8dl1Qx/mLZl 0Fj9c5zLge/Pdq6xHeypu8XYSNPOeFtFIu4bjKsusMTEzUmFcfEs4PcejG89bsqU21BGciXyuCj VDozY6YnIFEx8SvMmhcSZeXZ1hH9yn6PHBevAuaxu4jdUVVhe7WFjiKht6Q/J1KECutkpfaQ7Ut /CZjinA1SFtrdElPEAfnk5RXoXjxH8VdVzcEFz/hbgzOR0pDj81MJnNJYyX0wBCFZ6uqWFfQfxw foCaRbwDfrobfvdERQQb8brmubRaYWsJPduVobsoGGGm9GCqzCFf8QoqtaWV0vG55G6vnuLCktx jK8PiB2fsLJ6Tf8T938FxIEAkBGN799ClXQq6w07f+8xN1d6kqIGHE3RDvu8eVdfqEvu9PEeyKm oUutIFIRV+Ua5vv9o5gi4gWG3SfHKRQq+UEMXE1nm7Z8KS7cy4Kymsd/ds1yZD71QXN8clXwwKl b/wRwDEQRYvMMdA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEyMiBTYWx0ZWRfX75anvXvmuMuE 9e2yMtmZ+gzaQNAPKLSr39d03vEHMRMOg/1zzu7BYmYDjDTaYX+UuWYzsqwz2MayVWysMQ6LONr hE3v/+tKXiDCGObkhrlUhG4UBRYX1VcWk2i5xQWR5ft+/LF9Z6KGkAPRhiT4bBpGho5UH/QyFPk 5PCtxItVcwwkkBEIpTzRmysZ4utf2d1Lmrf8nB83CUmHqU5b5a2Bw1gX0X7fl+HRhYAdmBovPrM t4Mt7yDMYrneJ3HTyxC5UuL/bHR9ajO935LQFKutus9FTW31v9LfZqwe1tTsLcZt9polrQYpkfI n4IT5T+3EOE1YCBVZE/HKiGril66Zbw/7bbQYT7um6+C+HXxDzaOfQzJ98794bJN0fVIRHY5oo0 3romjzxMf5mdZh7ucoghmIPp07mKunxtZX8qbzTmsyEI8FAFcUyb1jQmI1m56QSjiJS+FS+Rop2 p2eyo77+1fCfS1fZkUQ== X-Authority-Analysis: v=2.4 cv=W+c1lBWk c=1 sm=1 tr=0 ts=694562cd cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=dK7io7gEiNwTpUlzFjcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: xqPYJblIsVA_5tlMSEkr8itkESWSf8kx X-Proofpoint-GUID: xqPYJblIsVA_5tlMSEkr8itkESWSf8kx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_05,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190122 Use dev_err_probe() to make error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/aspeed_adc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c index bf2bfd6bdc41..1ae45fe90e6c 100644 --- a/drivers/iio/adc/aspeed_adc.c +++ b/drivers/iio/adc/aspeed_adc.c @@ -535,11 +535,10 @@ static int aspeed_adc_probe(struct platform_device *p= dev) return PTR_ERR(data->clk_scaler); =20 data->rst =3D devm_reset_control_get_shared(&pdev->dev, NULL); - if (IS_ERR(data->rst)) { - dev_err(&pdev->dev, - "invalid or missing reset controller device tree entry"); - return PTR_ERR(data->rst); - } + if (IS_ERR(data->rst)) + return dev_err_probe(&pdev->dev, PTR_ERR(data->rst), + "invalid or missing reset controller device tree entry"); + reset_control_deassert(data->rst); =20 ret =3D devm_add_action_or_reset(data->dev, aspeed_adc_reset_assert, --=20 2.51.0 From nobody Sun Feb 8 01:31:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF3792D1916 for ; Fri, 19 Dec 2025 14:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154962; cv=none; b=qmcJUwYwVGjUwuWOOaTp+PbVctAiv60d5svKJNUD7ySAOXsc+EW19vpwzv1xE3AUIslV86DnNLABKYvlpdno/cRK/a0+hIJ1eRAWtzdLTN/G3KLKAR6q+iFGfZbqCH7hdX/7H2TiKE2/DYdWWmGD07+MXOpO7OMhkUPdAmO+28Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154962; c=relaxed/simple; bh=5iVrwaVGkX/lz9WN7/1Hu0jkjOFLzSRBWe82w60UkjU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ma+uj70C9WWBXW2I+R1Jso86U8PNi6Qeu0wx0V8cxctQHFdawoqy9iscaQ5aIKLKEyxuND2P3DBenICUfwBVsM1ykIwu+vW6hQISirBWaP8JZF5ZU+vLR4ql4DEwNTSIH5uGK+23YZ3vVUvG7g1U63OVYhiaJlX67EAZL3Oyx/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nWMnW2pp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LX+gLj94; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nWMnW2pp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LX+gLj94" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJCDmje091068 for ; Fri, 19 Dec 2025 14:35:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MyMmVElDZvwdRIAby/7iW7vi4WeJE4eibZZHiU0BOnA=; b=nWMnW2ppEGj8sQO1 72cd/O2SvycHwZ7mfK+mnsDlsERmYByJEzPltbj60Q+AIUnRJwaKAMUNtnd9sBgV mQnpWkAOzI5oDXDNOmhADGWtPkspwBO6OLbr3aRxqkQTbBc4KZRfKxXjRylK0JGg YusVtweDPoS/yOzIooZTZQELwNqQXAYnV05U1gYJyFp2jp7Nl+/57jhnjsZkqEQW WrCvAV6cCa5Elx5uZRFoNYwJTWu7B7dsEj9n6yKpMzeF+ZuAnI3v6VzKGsjGHBzo fPTjEEkH4SjwIYKQ1mGqONKLf5i3pXSk4T4mDpJsyWxGnp18xxYaDnMQ/2YqxLTx 29VZ/g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2eay3n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 14:35:59 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f4a5dba954so33067131cf.0 for ; Fri, 19 Dec 2025 06:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766154959; x=1766759759; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MyMmVElDZvwdRIAby/7iW7vi4WeJE4eibZZHiU0BOnA=; b=LX+gLj94Yhmovy/6Dqanpqt0lhF5XOLF4WZqn3DTgRI8IO+AjoDJbItEDr3AO/jg0s iq7WP8xP8hY49zfTpAlAH1coFSzHjyQHEG1UYbffMLK0SkoL/xm621wtyapoaw9Kj7A2 5IE7NGucP/csoenr8tNz1aEOBqZiz4TObek98CfYJg8z1Yx+xSnq878/B6DdqoSUSFzH TYviIo0EwWHCMTL5L2AOzEB4bxjp3HkxISAX576rDjZQKsG3FSgNYm4Adb6VAkJd61QR 4oiykZdBkq9rv2pnqWoLLpp/UVN3YSDPs5fdMygqK21qe7McU19pILtHlctBQlkxVqhB 8QdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766154959; x=1766759759; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MyMmVElDZvwdRIAby/7iW7vi4WeJE4eibZZHiU0BOnA=; b=jeGGTDaHqLSwb9N+Y4CJA34l1ibbb+VyKLDUsMzSe9dfFhM5R0TBQbrWyC1zCFNm9e 6T6nnsNrna0PQumvdxZjgfsGaODuTxK+TXaIC2GBnO9/jXNp6u066jMlWXUyzzzThNl5 EUrlu6+NT6DDa2vbqZnUb+A5PobmwQ0fGXgxGL8ugX/qPOlgC53yLGfx/83iuKahPZDn li7U+fOheUYmw69KWEan0+KYtnAjY4VfBU3mu7riK/Z2QTP4FGSfMHYuK/GgRdHexdHY YfyIJGhaplRa86JjjTUxxEVsDwy086Wt1ivEeJuN/d++dGYfkbHU5clvzyvOnJPnQoEV iQPQ== X-Forwarded-Encrypted: i=1; AJvYcCX5V6OqLyoTqrOSjiv+VwqgoB64+pgfhD8BtEODp142SRZK4Ay3MvyH2YVKCYXoeRMv8Jwx+b6wYowev0E=@vger.kernel.org X-Gm-Message-State: AOJu0YxLs3JHxJhQXb0BClU6N/N9OWXHoE/ABmMnc5H1kHNd0F8inPmU PAqymS3Qjma8TVgZ+Glz2g9dYbsbcW3r3f2ljfMMrYGa6FnBG5s6AXuZpzd2uE9/UlO/CtQ6x8I R7dSFqSLPiDhwIibs71hyrx4wzC1qWcd7wKAciEQuKoMQSmjGBsVo1cG/mPXAMArAf2k= X-Gm-Gg: AY/fxX5msIH9YBpzpguSY5N2jJ2xmHgJSrG6zRrVKPNY4adamZiOuGR9LOv3gAPzP0d 4e+Yo8brk3j5Ssc0s8p4ZFAalyg74+LEafqkyUsBb4An0TUo57fzmj1rI5hK+356om02TWZgMVS hq9SvdKIRK8tnSYFt1kCm7pD8OeJ4TztEsT7fiKNddfxRVOdasday6HiQ7KIrOSA4lg1XnOa155 XMKZViTGxsultlyQDC2vypeaOVsUb+AbNyUfOYp6eUdHgVBYGj9H7e/xkz1AQyRBNn7IdAIDbE0 7YdfJYQsVQPPXSryHi43cRh/cmwI8w8SG48I1dSjJQgBwH1iC55cFlYY4P6BGetoMb0v9bnmqk0 hcFmRBOw8e+fSAgbHh+7C8kve59fvQUz+2kayMq8QLGI0Ip3xkuKa1P/hyw4TggF+UL3I X-Received: by 2002:a05:622a:1e94:b0:4ee:209c:be59 with SMTP id d75a77b69052e-4f4abd9541bmr48095961cf.55.1766154958804; Fri, 19 Dec 2025 06:35:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFy3s+cedRD+jScDO/yti3WIT0fmJUy0yEz4L9LKCuvDsUwnGPrO9lv5lNcy508pzCE+1Jc6A== X-Received: by 2002:a05:622a:1e94:b0:4ee:209c:be59 with SMTP id d75a77b69052e-4f4abd9541bmr48095371cf.55.1766154958397; Fri, 19 Dec 2025 06:35:58 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f86sm245145966b.17.2025.12.19.06.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:35:57 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 15:31:51 +0100 Subject: [PATCH 2/5] iio: adc: exynos: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-iio-dev-err-probe-v1-2-bd0fbc83c8a0@oss.qualcomm.com> References: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> In-Reply-To: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2371; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=5iVrwaVGkX/lz9WN7/1Hu0jkjOFLzSRBWe82w60UkjU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRWLFkLm4i1w5ivMIJ1P76TTT6SODbzjV9Amfa 9AuVP27BKyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUVixQAKCRDBN2bmhouD 1355D/9zK05TIVLM90YKH+VJ22rkGMMZGxQjjUGFR0oKrTlLWycdW95453AT1vgoNi5JaUt7uhG EEm4uMIUCWH+8hMVEji27mf/TEh4IxaMOwaO679edjyhgWMLoV93nYZ3dIEHbA3pJU/dj2JBQ3C mRWJowsgDCUMxCHqy9iZAHAX5nTZYZlxArvoFGlaAMrya9ou9xnNapJXa+lRHk9/Zcyx6GudSge M71hRmDuvoU3UX3rdLU3Y2+2KjqIt/6cWBzm09etk280kbA4IU1Om9TgwNkN9ydPmDECDHPrftn FZYZ/9kAVjsqrPUkaMFBAhEXW4UowvR8EbZ4b8bXf1twI5WrtlGKwpsfXXkkiUJNdDg0RPBN1Zp bEXk5mcZg00qSFTFxZZdNuQSYV/USnXxwVpkNZ+uAvwRkGZWoAYSLBoS6uTz/sdoDQnJSUV4OQP UybAN7xllOhnQwQwxlyF7rXZNAVgo/aHHU/wiDGNrcDMix34ODC7ZIu5LqbaYe2bw+0nzCpy4wp GLj0CDDkP88fOOZ2vI/6mCHyZpXvBMcE12Jn6EFKBOQyxG9ju0A5khAGXp8vToVjZrdMhDi/f8U s9v0QkdA6kJF4TjZbVqsyIEr9GKmHiq/T9Hm7HB4od4NZSU3rm+SkVpm6RFCMeUBySXr9gQJ8Pd ONf3bUbf6HecpuA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEyMiBTYWx0ZWRfX+ExlwEafZThw E7IZlkMjb8bCA3+7ZQc9D7h4vCmdCO83vl1h82SZGZbREWWHrOLq+/k4SKPz3VFqys7O5eQV4OW C3+PPVvlp2WDgs2Lf2+oSZ39ZOEqh94y+F/69ugDQ6/+6nPArHnNnFuRBEv77cXgGudPiRcxmoG G9Kq/c2+6dtMZ2OzcgINB67tC+ArNREJU0glFUl3Bav0s2On5WdDiP78cPouC0fi8V3IVVn5s8a bUMoMAlp3PHM8caa6JQvREYz5M4gyrEDvQ8C5PvQ4tknlNxxEEF1Tv52JXjhmeKQfDHVkYMO+OF vipv/nGMekaF9ZBdS4QATOgd2k1WswxXfWXwiRV5oVvTTH5As4D4a8jeIDfvpKjglR9OtgVM/Kf Tj9vJuWQw6b/mSEZ7PA/O/nr/DQfJkpy/M9FJKWVc9spZVkCVs95ZiP3qFgORYjHT06jgnkTRrA ZS63YHLpgCJH69KqpQg== X-Authority-Analysis: v=2.4 cv=W+c1lBWk c=1 sm=1 tr=0 ts=694562cf cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Y7nMzdyCy53GPDWIMu8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: Zg-0ZKtjuUszpr4qT4ODs-bcw5CCYsZb X-Proofpoint-GUID: Zg-0ZKtjuUszpr4qT4ODs-bcw5CCYsZb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_05,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190122 Use dev_err_probe() to make error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/exynos_adc.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c index 1484adff00df..491e8dcfd91e 100644 --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -564,10 +564,8 @@ static int exynos_adc_probe(struct platform_device *pd= ev) info =3D iio_priv(indio_dev); =20 info->data =3D exynos_adc_get_data(pdev); - if (!info->data) { - dev_err(&pdev->dev, "failed getting exynos_adc_data\n"); - return -EINVAL; - } + if (!info->data) + return dev_err_probe(&pdev->dev, -EINVAL, "failed getting exynos_adc_dat= a\n"); =20 info->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(info->regs)) @@ -578,10 +576,9 @@ static int exynos_adc_probe(struct platform_device *pd= ev) info->pmu_map =3D syscon_regmap_lookup_by_phandle( pdev->dev.of_node, "samsung,syscon-phandle"); - if (IS_ERR(info->pmu_map)) { - dev_err(&pdev->dev, "syscon regmap lookup failed.\n"); - return PTR_ERR(info->pmu_map); - } + if (IS_ERR(info->pmu_map)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->pmu_map), + "syscon regmap lookup failed.\n"); } =20 irq =3D platform_get_irq(pdev, 0); @@ -593,20 +590,14 @@ static int exynos_adc_probe(struct platform_device *p= dev) init_completion(&info->completion); =20 info->clk =3D devm_clk_get(&pdev->dev, "adc"); - if (IS_ERR(info->clk)) { - dev_err(&pdev->dev, "failed getting clock, err =3D %ld\n", - PTR_ERR(info->clk)); - return PTR_ERR(info->clk); - } + if (IS_ERR(info->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->clk), "failed getting clo= ck\n"); =20 if (info->data->needs_sclk) { info->sclk =3D devm_clk_get(&pdev->dev, "sclk"); - if (IS_ERR(info->sclk)) { - dev_err(&pdev->dev, - "failed getting sclk clock, err =3D %ld\n", - PTR_ERR(info->sclk)); - return PTR_ERR(info->sclk); - } + if (IS_ERR(info->sclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->sclk), + "failed getting sclk clock\n"); } =20 info->vdd =3D devm_regulator_get(&pdev->dev, "vdd"); --=20 2.51.0 From nobody Sun Feb 8 01:31:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CB6F339B51 for ; Fri, 19 Dec 2025 14:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154964; cv=none; b=Yby9JWUPKtK39/1tD9k4n7zfZvIHMk0dUOVV/l7yIIn5oF5Dlx164s2Z3nhJE6alH1bFExJNdhRT4NsA6+RBwV/gZ2McIsQqkADRcfBw3G9NWV4wtiVbi0c6MEkjKI2nwFBb9mPKW6K1hQBkzE4zsJ7l/yne9hztVeUR/DitK14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154964; c=relaxed/simple; bh=Wr5/vHqfZ3Gkfva2+k6ouaLP7uADJ4+N3dLFOeSScgE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SnaT/E73kFcQ9bklUvbvSFQc1pun3klyLPFJNSES8MCzn0rfuyQd9fHy2iWPdYjR709LRkdb4Alvj9338U+gvvGloRUf+kdGJmGi19ikc1ot6AfStuKgcPPX35NJI1S93VucIrq1VIIdy1DX2y3gDa8JzE6PNMPONyzSpDDOw0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hnl+K3EY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VyjA+Cx5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hnl+K3EY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VyjA+Cx5" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBlTMG3318713 for ; Fri, 19 Dec 2025 14:36:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mJ7RnbCsbqZV6SdekFc9SD1k8esD4C11UGzA5IGxZCQ=; b=Hnl+K3EYmUsBTOLP WKUR+pd29tzWcTrxfDnWjJym0NAIJMvzCAZo1XoIju72SabnOeH+Si/DSk7wWt9D oZMehEmfq4xBDwNtTOglEuyRmwgPGYyHIZ7vthx9Cp3LxdC5KHis5lVk+IbGd1AG ElFm+04c/XROzRn2bGmyaScKWTM3gcIW8QQFbwXq0V33Q2hFtJKWFfT23mz07ZNN 1mJGKMxg3R6Rkdy8l9mIR42LL+sQ8vIvQIlYW7l0INl85Z3iYZgIVtFrNda77bWh ZjlQAfFoHLQPLMmUG5GeGzRg4E5HV7BLzPrqmLb5/JTr8N3JPKG6ipoSyi13Pn+m 3fN/xA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2etwh8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 14:36:01 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f4ab58098eso25377001cf.1 for ; Fri, 19 Dec 2025 06:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766154961; x=1766759761; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mJ7RnbCsbqZV6SdekFc9SD1k8esD4C11UGzA5IGxZCQ=; b=VyjA+Cx5aeTVGBqholnIL/fUc1GB9dGEqzo7Ux5tJ4+M0OPzxmcqlH1IPP2xGHiByB G2+oAwTsowGn1hZsx53NzN5urVM13tIvyh6/DscEp2fphyPKKvbISL/RS6wqpgv4DZKu ZoYehM2yYvUDhHZLYdpPtx/Ihww5Fpfdq5n5OgR4Dy0abj1Ac3gb+GmEExti/RJkoa5H EPKmHFNX4eCDGS7l/5CNJYel7xRlSc+PFCmQH2lipnsn140OInCAMYl32UbeiARE4g/M gdGFaGhm0WpgFudcg5SKW1w8csyTP1OP6sPGFstPTaI+iRCe45g5OX5jxRgYvrLCOwMT jWuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766154961; x=1766759761; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mJ7RnbCsbqZV6SdekFc9SD1k8esD4C11UGzA5IGxZCQ=; b=ABG67ajXObVuCIvcEfc6pPFiSswZ1UC74TMDZPuR9dwfMBqbcklaSCfardMbEQTdgS r8esXtUMWH1JZxxo2/xw83i/F7KOb+c2d1on8LDXwGQP7a06pFSwAGvlZPYa/I2o2JtS eDsSFqnKtBX+jxEWlQTDp4L+rHeR26pZLe6yQuimwqGhcBdOIwYAp3IZ2ELjzH84xM0E ToI2ABrMrny5lcE/Ff/Fj7xioTi6NykwIVxQJBLDAJuDXxyx7Tzj5gGDVibVtKgAdbnO bVSppbEOCpxuiCmzKKOSKU2jcg5WUJDmNbWqwVKcrDkYaZagCuwK89ooKBFE9VZcR6pG wBiQ== X-Forwarded-Encrypted: i=1; AJvYcCWpis+bU+ZsU//7p+D184RgvPUQKHS1HBmno4LKUN38eXaLcJj/WS1KdIhk1L6+k1kOnYNiBWXHboHTXNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwPwt4pftvvzwguObtmeErvrfAWy6/vwTBNKUU+q0+SkLLDRl0z WjBzlhXpsPU4sDZCOdfL6K+wWt1foUeH1GU4LnARQO99gGhWAYtgL+qDYEHMrsYlxx/7BBZkRnk Kwfwwmg6q7ao4cgvjMwj8mXVD+rtXvk9LmrIwYHalGa5RhocfTjE0AmH9Y5s+3cwYfqc= X-Gm-Gg: AY/fxX6d4wVaHlrhccFcUN3v6PTXwYM10dPmn9QDN7XvrFclhldN9pQU+7LbA/fNU2E qc1Ede9AoKACaqBrmBjqfQh11KxsuXJ5mP2XFOSwUI2DsWwAVs3cYfVpGWsDNU98FBT60sFvTur mhF7s2DJd283+9YC+u4g5ZsfjJNPAnjL/HOrVyYAGs1XUhhJtTC0DTV3xBaV/SufSE8b4RAZ/P+ Mg36DFlytOfqyYEzyWBR+8+tUagU6aykIc483GTvteX/4wB9QxRTp7VmCLwxLbZYyVuT/Gaipvf ebttN5zS3x0wF8weU+XGflr7Eb9e/SWoieiE3Hq09xGnBrdbjrv6ZoUAOganknJQNTRx6Kc+dPz ldUGzctweE3WYBuG6nuP3GlGoGArWMKFJaIir0YsiYTU1yMpCPVmEKtf2Kq2piw7K6VD+ X-Received: by 2002:a05:622a:64b:b0:4ee:4128:bec1 with SMTP id d75a77b69052e-4f4abcd0634mr42477731cf.1.1766154960546; Fri, 19 Dec 2025 06:36:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE14Hdyk6PYivkSsJrsYsK8HqoPfU/tUKnkUGbL/VoSc0mjAxe4s8KppQKyl06O0O0KHLdlBw== X-Received: by 2002:a05:622a:64b:b0:4ee:4128:bec1 with SMTP id d75a77b69052e-4f4abcd0634mr42477181cf.1.1766154960101; Fri, 19 Dec 2025 06:36:00 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f86sm245145966b.17.2025.12.19.06.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:35:59 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 15:31:52 +0100 Subject: [PATCH 3/5] iio: adc: qcom-spmi-rradc: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-iio-dev-err-probe-v1-3-bd0fbc83c8a0@oss.qualcomm.com> References: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> In-Reply-To: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1783; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Wr5/vHqfZ3Gkfva2+k6ouaLP7uADJ4+N3dLFOeSScgE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRWLGmaXpsHKPVC+KP0GNHBF5FoyjkihTiGxVO 0Wee7mEOLWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUVixgAKCRDBN2bmhouD 1+tgEACJ9D5sTugYsbqYRRJ6CCQ3oNlqtf0R6GLUE4ytsf+XShS+0sC96+5R0EPmCZpzonwX3st rWjZ69pIrqkt8vi4/NGrDPo+3Adjwd+2aLuHyS3q5Zw2Mc1d6E+ZTr5VZuBvmK2h0A/+cLZOPaO LGen8z3hLH9M++ar0raTYwYjDOcIXvy/glGwyDie9kEZ0JFaLnCnQHv90k5gUAKx3G3V0zNHs4t jVLznzV0/bHuDILNvP3IC7IJIWbHSuj9uucQ452vB0a62/l9JI1Q/1UwDWU4oqSH8b7Nl+J+/j0 ZmpCOAxvxAAttvndseS8PXRQcwhYfFublNu/KXHm8PcaDvkoPbtSP/9i/dOu1iUvznZfTwSdC9s 5Smcy3zfm3Bkh4XKngX0bmVZN+5u2QFQAR6x4FrvtIMUKsn39QYc5nz9Iu8GE5RSIHZdPyK8NuP yWhRFxNJ6oX2Q1dPpYJO8vcm5MGfYVZC7+N2rCgl5u9M1NPv/8qmnFo+3/rdI5V/h2f4wXQcqII kkH49dB7Alz57gNeRKF27a5Gf/kY0/Fev/xjxyf77JZ+p+OUIDtgPgXX7/Oo9vWSkmWez62IGUM DRPR+FwkGYwPEUhasoSN5DCf5E0a+8HWt2Gm+zAX0hsAOUYNptE4rAXqrrr5Xxe1umf1ksteQNc q+XIrxE906tgOgg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: CdJ5M4uTpEYp8DfUL2VVl1gIzd2Dcr7j X-Proofpoint-ORIG-GUID: CdJ5M4uTpEYp8DfUL2VVl1gIzd2Dcr7j X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEyMiBTYWx0ZWRfX/Jg1ng72OeLV AOEJK02PrKrbA/y7XiUlTZQMMgNguTYI5pCBH++I21NFVdugYXR/OQHeO0Ftb5fz2/Y4jMX/gNf ZukC6fZwpBi5MwAz60Faaitv/BjkTapL8cDXRG7wDdKVm7gorwJ2yzyxIQueRNT8XNL6G7J+mY9 eRqcAUWwJ9m146ZgJtYpWT9DPztnTWLrkWGqvo6bY0Dr4zE/ptHUE1L8U9MbiJPfL2DPOL3D2tU psFFr3Nb7p6LLxdSz/F8PklViEI5Z/2sRKBYJ/qRqvLDpZBTyH/1SJY+gPTzmbaekNW5uC6dCzJ yfQO/mrd+I36H0hkikZXTTx5VjJtw8jU57W4P0b33EQAa5BDw+7Bk8XzQlz8CSotpGofMTwuak0 lL7uHNsoujiyAtAudM77dDCljP+exBpRKMT6w20EBaf/FDp8QublZ3ZrIKrJj4fX1w1HLf50Beu pzPk4aAZlDjsTXagHvA== X-Authority-Analysis: v=2.4 cv=Tp7rRTXh c=1 sm=1 tr=0 ts=694562d1 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=AYNcBwFTG3nuAf8aWDwA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_05,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190122 Use dev_err_probe() to make error code handling simpler. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- drivers/iio/adc/qcom-spmi-rradc.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/qcom-spmi-rradc.c b/drivers/iio/adc/qcom-spmi-= rradc.c index b245416bae12..8e75665204d1 100644 --- a/drivers/iio/adc/qcom-spmi-rradc.c +++ b/drivers/iio/adc/qcom-spmi-rradc.c @@ -934,20 +934,15 @@ static int rradc_probe(struct platform_device *pdev) =20 chip =3D iio_priv(indio_dev); chip->regmap =3D dev_get_regmap(pdev->dev.parent, NULL); - if (!chip->regmap) { - dev_err(dev, "Couldn't get parent's regmap\n"); - return -EINVAL; - } + if (!chip->regmap) + return dev_err_probe(dev, -EINVAL, "Couldn't get parent's regmap\n"); =20 chip->dev =3D dev; mutex_init(&chip->conversion_lock); =20 ret =3D device_property_read_u32(dev, "reg", &chip->base); - if (ret < 0) { - dev_err(chip->dev, "Couldn't find reg address, ret =3D %d\n", - ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Couldn't find reg address\n"); =20 batt_id_delay =3D -1; ret =3D device_property_read_u32(dev, "qcom,batt-id-delay-ms", @@ -975,10 +970,9 @@ static int rradc_probe(struct platform_device *pdev) =20 /* Get the PMIC revision, we need it to handle some varying coefficients = */ chip->pmic =3D qcom_pmic_get(chip->dev); - if (IS_ERR(chip->pmic)) { - dev_err(chip->dev, "Unable to get reference to PMIC device\n"); - return PTR_ERR(chip->pmic); - } + if (IS_ERR(chip->pmic)) + return dev_err_probe(dev, PTR_ERR(chip->pmic), + "Unable to get reference to PMIC device\n"); =20 switch (chip->pmic->subtype) { case PMI8998_SUBTYPE: --=20 2.51.0 From nobody Sun Feb 8 01:31:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A33F33A70E for ; Fri, 19 Dec 2025 14:36:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154966; cv=none; b=MICMS7UTq16VAPIAHx2dmPQFt/0ziWJ1omYJTB/+KCjCO8RshVvU/nOXvWDZxwhmGJrNo8JSJ8mFcQm7yKKfrA9p7uJwk0YX7vRcaWA9WszDaJuGpOK0fXfJd1B2YaROevle0Z2NMZ4PMuInDAvQFDHPeQb5gYimgSTnafj8K80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154966; c=relaxed/simple; bh=Fmnj6mVvpbfLtwijoNhLAn9j7guM9pp4HVJeADMhGe0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l6XzSTTche4lqW3ZC8pJ8yja0zA6Tanh5RdJ+3/NIBLQm3wAt2nCjWuMcYAfXPR/H82c7473XDpwZ7fOfAegwBY5xgzyTxbaIVx7Q94MXbfc407t8Qcngh61PBlFn/14tCDDalF9uWNmzXLntconjQDuKnxdym05dAEM1jVhw9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dx6RAz2M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T8Vfu7Ii; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dx6RAz2M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T8Vfu7Ii" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBg0Ow4145265 for ; Fri, 19 Dec 2025 14:36:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6KPYVk+CR22m/g5FBCc99SLHEDjfYAU2ih06ixsTGRk=; b=Dx6RAz2MmQbVOKoW UDi0K93jkktF0Nszi/pD8lDSsAqYLALDNIz8FwmlIXxBTLlZzeHqx4R7pTt7UhIG DWmkliMOf4jN/ZqpamEBz3dOcSS7LwJdW7a23TY7OZqHT94/fYay94YEaGDt2bCg eNWxmLyJm3NJOorIOvXcle/4rrXsHtln0vtt5DzVBlYaxJhYfeQsTUSftPurIdlQ CziXMC4GXW1tnfR43T+5Uy0uXJn9CEF2E3ohrI8zJzQ4kFYweHWwvMbLzqxPDzC/ bJhfDsut1yCEbk0zbCdA4ouj3hRi0woR18qT0YgOSfXRgJG7elKeZhYay+WFtIgo uEmzCw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2dtyjk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 14:36:02 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee09693109so33641541cf.3 for ; Fri, 19 Dec 2025 06:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766154962; x=1766759762; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6KPYVk+CR22m/g5FBCc99SLHEDjfYAU2ih06ixsTGRk=; b=T8Vfu7IiUP3ibsW/qX6/9AGiC5ZfqvdWjAd/zR1hsc0RJ5fKxme0nfpD5PTL6sYMxH seCw4S7CnHz0KJvuO3DDLyeUh4s6WPFLB1nVguaTUnG+bPV/LnkrcTXVpi7n3Wk8pN7j +J5oK/Ps1VLFdl0QraoehzUbUvScxcwhi/dlIjYLpDG60rrzpu1rH3LECKm9k723tf4V jFcmhGZwBviFfex6SXxSZN6biAiNz4BjDFozDKiabnbattVQMlEUahDlWg30WCPmVrQ9 PpRfOlZkTlfFnypJbP3jnRdbiUzGPapGA8Vwb1kGhhkFFNeujPESiIIRcVhNUASjw1m1 kgFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766154962; x=1766759762; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6KPYVk+CR22m/g5FBCc99SLHEDjfYAU2ih06ixsTGRk=; b=t6dTwNmsbX5ZcavyMSMgTsV4OWnB3kuH8cLzeDpKkZwidoLixxAwP/EyNgnU8Exo+7 v3z4Y7lH0S9eqXNx2a/7GVEy/nUbxxUqHJ6z9zL0ROPTLDRvxVbogMeM09TQaLKORrxk ZvW+laUJeNPVe+KDlsQg9+r11dkcX/FE0fFMGl5D5KT3Nl9yoiNSKJ3xXNvmpB5c8QjM n56l44KDthmlK1ku5ySzg5MLoCCLe5LxHMQ3LbunxsTnGDAh2J4ix8zqRGwmragZyEMJ EHOCtvCtRFxfO60e4C4/F1PSvobtK9T+m/BtTAs9aSigHVEQ+bLroBB6dZvQZIhod8i3 clSA== X-Forwarded-Encrypted: i=1; AJvYcCW4GJ/P81uIUhxI+fe3foC45xoFLzZxovWSoG6GAodOIK+QuscmbrznoQ/Kl25AgPkcUabUIcEFAMsUSZw=@vger.kernel.org X-Gm-Message-State: AOJu0YzWOsyKzIcxuvkSBU1aAkviQM6I7VNq7IF0HR3iGYTYJT4dCUpc aembj/H4Y65bU7uK/rPElIrCV6eD2F7R4M+Ta07s4WMeX4Ax8nnop1x3j6XQ7PnjKFj7Hu76+Qa e/J3t11mHiL64QXk7+L/HxlsHELflzWeW1maJpl+Hk3Yiiw1djXWcbrw9JsfxfGwgXxo= X-Gm-Gg: AY/fxX4RJymf8C0OHaqw99f7UBdLJ35LobE4/kkG4K9XDUra3CQjWzbTrJCW0weWSfx J0AG4t+Isao1TcJ4FazwxFL2LJ2aXCAdGUcW3HJ0Koj64SOXBxyk9olVx4GqXHeaquY4Oe4f2zJ bplWsUloOYU61fPNqKHQYRY0R3mysXKTFT0b/Oj4CmDgHox66jB1blXjHBDbryS8GSdj8BFVe7A A5OMmQNOwLrsPPKFw18l6N8kw0vlqmPD+52DtjQUCtmEaljen78n3712bstnBWrmiliNFsSKCZN TjkSby5TTCmzvbM3xdrH/wCYAEFDaeCqoT1aZJDm9OCdBkRU5tI6xJ7bYEbKKk2YVmRb/HkRX2I 9ZFbV/g5UX3GTXv06hofHaULTsbOoauuR9ZzrK+NrXhtEz7/943PNnsGtCM64BwfOiB7U X-Received: by 2002:a05:622a:5909:b0:4ee:2c3c:6e with SMTP id d75a77b69052e-4f4abd0cafbmr40585901cf.30.1766154962195; Fri, 19 Dec 2025 06:36:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEf/8P/7gffTggqaLL7XA+UX+u7FNuz6BrjE8UubcGAq9Jn0DzHD2i139MD/SRvhbhO2DTJMw== X-Received: by 2002:a05:622a:5909:b0:4ee:2c3c:6e with SMTP id d75a77b69052e-4f4abd0cafbmr40585381cf.30.1766154961735; Fri, 19 Dec 2025 06:36:01 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f86sm245145966b.17.2025.12.19.06.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:36:01 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 15:31:53 +0100 Subject: [PATCH 4/5] iio: adc: rockchip: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-iio-dev-err-probe-v1-4-bd0fbc83c8a0@oss.qualcomm.com> References: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> In-Reply-To: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1502; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Fmnj6mVvpbfLtwijoNhLAn9j7guM9pp4HVJeADMhGe0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRWLH1EFl2sCBthzt79pkShZZiMmOVlFkKcQCW mlR1bgxXBeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUVixwAKCRDBN2bmhouD 1yneEACQf/jyEI6/m6DrHaosqP0fY91Xp3YLGPZnm/1USifaPKrakFkvixtn0eSGYllX4PXMDgd duf5nq+PPq67Mbt2J6GvQ80K55z+C99pMr/xL1KxwOqk7vbu18uyryGnjYDo/O3ra1OFDJUCBL1 xbEmsfWqd15AUJcY74qMPZW30zYCuLScdNNvhWpQvsURFVXzruPmXAUEA1LZDkD13KfhiF+4hd6 0+cey9A7YbrHXZuLIjkq+EKDRu5c1HY7nFEXeRjZG/VdRpNHnnrZOYLeoSg89UD3d9zHAoAIlC6 k2HwnIcyCIoM1VTZcC0v71LYPm9FtsIMbZ94VyqS7JIzAkn9JWACeavbmC8utEloLZ1sdxRA5fw j+nj7Ugdy0niu9678mY+/hCHp0pGpfxC4S5L2uAkyze9Be1VsT/nJ8+rY7+yrfcULh0awxpWvCY yq3qH+6xgGymoG7C/DWWg1p2Tc2UT5VXyB1wlUZ3Dy7rs1t6MPOoW0m6Y8GpIoqbxKl95Ot07Ql yxXnHOIsTgub0fbyrI3uwQNMn2b2HkGofj5xJHACHWk+TZRseG+oRZoNhk6gO/t5QSrT80IQCqV dapzjsOgJWWyp4u5wm7f/aXgCFoj+c/zRYy4LBpWkRFxP+7dqmmB8UObF1SIb2AyV0JQKEvlVEB VKH7vTQ/hvVYXJA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: ZKzieEJq-Dfc_t6F_NCwRZzxkvDYMeNA X-Authority-Analysis: v=2.4 cv=A7ph/qWG c=1 sm=1 tr=0 ts=694562d2 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=UodCGf9HWxkVo1034I8A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: ZKzieEJq-Dfc_t6F_NCwRZzxkvDYMeNA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEyMiBTYWx0ZWRfX09SUcXGISvBw qJKDuKT1WmA4ETGLCiPreCWzTGsxOGj1iMnjt74adZ0doFCJy2nqarzJfuOJeCmLbH0+IlO8NWc cZg/AYMZOAmfm8Kg9++ScW7xRMpusRIJ2mzj0O8O9Z+UMODrlttu3016O4ePK+1KAJnGy+1oAMR 33k0jauav3fw42IBdmABHgWYEagbUTXYsXydFbu1vEAJogh+HSi7IKi64flmihrR6PqjMHsAJsZ tRt81uLkoTCYBfYXRwvfj5mbmr5cH7VoLr2G+y98BcjRhq1JpxUYw8EXcdZ7z2uyJBmzSP2TIJ2 PaH2qw+W7HwWL1gwmg0NXz3SqGywLn7mQqouE5fl16T/5xRlsisR4ow7EtuiArIl7QrVSzeTs82 6ChLL93hRNbSLBWlw+jnVWO3RY70genFxyKdbvSbm5SKp0Ext6JKO3P7apwA5DtoLrSJVKilktC Kai1e0+GtN5jgjvm/SQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_05,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190122 Use dev_err_probe() to make error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Shawn Lin --- drivers/iio/adc/rockchip_saradc.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_s= aradc.c index 6721da0ed7bb..263d80c5fc50 100644 --- a/drivers/iio/adc/rockchip_saradc.c +++ b/drivers/iio/adc/rockchip_saradc.c @@ -492,10 +492,9 @@ static int rockchip_saradc_probe(struct platform_devic= e *pdev) */ info->reset =3D devm_reset_control_get_optional_exclusive(&pdev->dev, "saradc-apb"); - if (IS_ERR(info->reset)) { - ret =3D PTR_ERR(info->reset); - return dev_err_probe(&pdev->dev, ret, "failed to get saradc-apb\n"); - } + if (IS_ERR(info->reset)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->reset), + "failed to get saradc-apb\n"); =20 init_completion(&info->completion); =20 @@ -505,10 +504,8 @@ static int rockchip_saradc_probe(struct platform_devic= e *pdev) =20 ret =3D devm_request_irq(&pdev->dev, irq, rockchip_saradc_isr, 0, dev_name(&pdev->dev), info); - if (ret < 0) { - dev_err(&pdev->dev, "failed requesting irq %d\n", irq); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "failed requesting irq %d\n", irq); =20 info->vref =3D devm_regulator_get(&pdev->dev, "vref"); if (IS_ERR(info->vref)) --=20 2.51.0 From nobody Sun Feb 8 01:31:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB96E339B52 for ; Fri, 19 Dec 2025 14:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154967; cv=none; b=kqjU3AZ4pxakwH5TUenSs7N1OOSWML/s4rHoGxxpSO3o3GIoKEhdw/i8qmbVfNwrmbR1KjHIZqyoohsyPARFu+5jgOxha+alWgOYCb+eG2TpkvuMBBIPHdA4uQbdHhluboWIXBhlPXw4kqNknRnb5G1WJHZq5ULEFhwKLNF0hlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154967; c=relaxed/simple; bh=FwErtDRj45YR9+G3sGWpElTdT9H2524MS3PEIg8X+gs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=thkZQ6GBi6D+232Ur9WqzXlj/hiydAihnTBijTbvAavZblXY56NBlnl9mmEGz5tTsEWUkhZ0yRevjRy46DSge/ZlSzF8NUbeowShLwam/wEG22DfY3FBgS8JFRXI61XAtKnyDpoOcfsf/dhXwEmoWQKWdih/xxfFw9jABSKsEn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WAIpjOpQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lfhfrg04; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WAIpjOpQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lfhfrg04" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBk6BO3320433 for ; Fri, 19 Dec 2025 14:36:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QO7v3mInpyxqmqngfzK6cMArjVhYiK5JPVpSUzcyyGQ=; b=WAIpjOpQ+PoNwSKf y6JtoIF7TqlCyNrzHYGE+yWtSdWoOyxksM5aRSYFA8xjuacFCIiBdanU0xMirIwc HvvXytN5sQL9MThx09ocL96j496Kwdh1HT/ShkbLg+avvHcZOQyP0aQcLTJjdjNS plwyUlhPM5DGO7yfqsRg7kNjM3mghrWuzrUg4NZSiwgykJ0l3J1XJiVeohj5EvBg ZwM7Hk4vg/6y/A39PL5MEv/AFz7koX2K9SDHVI/Su1KtYGcY+uEGI6Nx5NjVhRjX TOpKAI0d9aANoZ5kav6OUUVD8dNycvwl6xva9HaolBGgAafQsUkpDV4jOb5etk2Q ME8/Dw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2etwhh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 14:36:04 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4eff973c491so41774481cf.1 for ; Fri, 19 Dec 2025 06:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766154964; x=1766759764; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QO7v3mInpyxqmqngfzK6cMArjVhYiK5JPVpSUzcyyGQ=; b=Lfhfrg04yTkKQWJUbLB5Lk8/hjlK40psqjW3P94WAx85x0mCXkSdB4QifIK5tXdGdv nvVZA3s3T+STjMetgUsTj55G8dWTZqzbOx3f+ZZu6Ez2AMnzckMMTjrPxpnAl2QJWP6Y LqfTepK0R6FRSjVHQhWKoM4DccCSIHWgLvHKE9OLBnmDFVFJupvxHivG49vxOWfmqjUA XU4KB+ePdITvukkMoyYK8WPp642WGXk8VmT4d3A6TIPJWOLfsJy4VQLhZeGjVWpLM8Eg vuxiLgprpKRsQ82L9lkQLnilR3eFT+xJZgSLHg0mbmNWVgSZ5jerWjI2UAgRuqPS6+jX 3yEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766154964; x=1766759764; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QO7v3mInpyxqmqngfzK6cMArjVhYiK5JPVpSUzcyyGQ=; b=HdMGrjzD5An8eOZuAqzRMgCBoQaLwjnlyEWG3cXb3G6MVpDbVdKP0PHH1m971zhTcd vgN070vlS1TJMqVUS5SrIueO7od5JdBoqlN9GkK/p4gpbS2JykCdKWiMpckM8yT4Crjw QIi0q2KKNC/99v/+apIyFqK0rfZ8X3+QqNCrOQ0p2cI7M4OhZ5YK0JS0A06YDZj7dTFm CEoz08mSjleCv6FBReGN22Q8l22ogw2BFq2XCUbH4uO+wYyACIiwmXjw0TJTq9Mlxbs+ 58UPvXZeNJzEWkDGCyukFnRhounQbnO6b2ASfhTf/xZvlVRjw4mG62OOZfnoCrXNQDZG n4kw== X-Forwarded-Encrypted: i=1; AJvYcCXTBS78yITbVAARcMAzvv0OW7AE6v2J3rD6crUQClbD5I238FB82+sRocD47EZriCYd+KVfi42Whzfv12Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxD9D4rMGwyVZ22SWCGH5ho30h8lutxBksXrOodZSVua5O2TLvG bbDHqtjYZi69Zfy7u4FqPYfwa6GChBHryUHA5q2HwMjhj9uZeQWcQil00VCbcgq60XNUnOycKHs n8DjR7Zec4mSlbphFglHtWk4GoCnooWX9eaIFgvsEQh/4Bqnk4ZxIGb88FqbVqf0yp/4= X-Gm-Gg: AY/fxX7xWquYeahj1HTSOPvabY2FlNVzeRtzW+QAjmU0fQHb/XvlA35GUtm/7CA2eC7 tI4ywTaAFnuOeFdlEHMl/36ZxPC3hb8Qx1sKxBg+BarakPVcnuStGBJLeanLUvv67mTYMqvV9PJ SFjYv83N80/cE8luYOG+spk1tcn6lpgq3V4OZMK0aRDnKv4zA9uv0P6LTJ1rAhuKarNWaj1hDfy vFJQwI1oGywbsS/X7q16M+5yh+PkI1HwNkrzV7w1ZPFKsv3aWQs8gbY6rD9RH59m8TjFvpoEEmP vrfg1IACNUFZc09yDYkULjsN1RlOIU/2rbL285mpof76CfxsuOVog/9ywcGLaiJiedC8Xusgme4 sywICea0w/3JdjY7HGXXcowSXsIIMyjHkZrdxwD4MrpYlSRGkMTAaUJhaGjnkiCQb0ZFL X-Received: by 2002:a05:622a:11cb:b0:4ed:a6b0:5c39 with SMTP id d75a77b69052e-4f4abdc6a4dmr43263581cf.63.1766154964149; Fri, 19 Dec 2025 06:36:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYupEl3gYLzDt53suprXOO0WmjuzlD6rknnropJD9KMCWfnffglHqPJoWvFjr/nYkg2I6ZFg== X-Received: by 2002:a05:622a:11cb:b0:4ed:a6b0:5c39 with SMTP id d75a77b69052e-4f4abdc6a4dmr43262891cf.63.1766154963604; Fri, 19 Dec 2025 06:36:03 -0800 (PST) Received: from [127.0.1.1] (83.31.98.88.ipv4.supernova.orange.pl. [83.31.98.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037ab7f86sm245145966b.17.2025.12.19.06.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 06:36:03 -0800 (PST) From: Krzysztof Kozlowski Date: Fri, 19 Dec 2025 15:31:54 +0100 Subject: [PATCH 5/5] iio: adc: sc27xx: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-iio-dev-err-probe-v1-5-bd0fbc83c8a0@oss.qualcomm.com> References: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> In-Reply-To: <20251219-iio-dev-err-probe-v1-0-bd0fbc83c8a0@oss.qualcomm.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Joel Stanley , Andrew Jeffery , Krzysztof Kozlowski , Alim Akhtar , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3222; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=FwErtDRj45YR9+G3sGWpElTdT9H2524MS3PEIg8X+gs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpRWLIBxhyFmOssOsCYuSdWCS+KQ38MQOZRW/DR UUjiKlsTFiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUViyAAKCRDBN2bmhouD 14EwD/9O5g0sKxohmlPbWRb5GCF+Zyv/zhIM4UOKtjqVRmXpwhQlQ5PPhdnKhun24YiM5mVrrTJ jazVQ0q7AS3Pd2nhNF4aEli4cGK6v+5tsbY+W+Z0S4brTp60yR3kHRWKRCH1obXF5k//KG88vDI utRrA3kUsFGOuVY7/mGT6u70Y3vLUHvpOIePcaw7yO9ZGQDh1fhrk3V3xE726Y05GFCMAGboP75 e5VMg8CddWKpb7pPw6KRXj6vMp3stkIQKd2FwIKY+ZVmeuk/WbgJCkyb7JgtONVtYQ7HhS5kv5V quVBHJXrbe7XoEpzecJg2KoIlIGSd1hkMo3M3rO6eKwxyyDiwo+IbO+1tAiGJ6z94+0rB3TWS0z JCwZsFz7fcLYl/27TiOCXPxoBnkGkpvwMCilqcQ0wuG8Na42nRitMIu5+E2veKtiSHsZkYBaOyR qHojscW3lXvVSO1PfjMjpFwqaB3byNdUl96aEpaSezOibzXovGjyYtcrkVErlwWYnUUgSm7JDfd SuH2bGvlkFDQDgaR7/uudIXSCccjtRXp+GjB0rZJLAgTtoPW+LIukSddD2zmR6Pz+gV0UFqZSMK mAbcTZA4Xd+e1kCf+Aey0jp6AP4Fkt9KxCEvNYvSGtubZ60ve7d5mAoLFT1jAeudBulbCHSu47V dnwL6XXYday0k5w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: i_3K8ycrOrPOFpdLxxrjxzWWzr3xAof6 X-Proofpoint-ORIG-GUID: i_3K8ycrOrPOFpdLxxrjxzWWzr3xAof6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDEyMiBTYWx0ZWRfX976ADMZCZvCj wgn1b8sBKxhIQPNJkqrI3b9eY32da1nV7dZWPjzLWxG5nyw+MtfEgqOSL1g3glaAoswc0gS6k4z x89+QdjlKgBKl5QNGoR5IErxEelPizXu142mXUws37xofcsQ38Z9+P3Y1yWUR8w5HjpBpHbS3Ck NEw9QoGR2Z49D03Td0bRbAVsvh66ho4Adzgx1tKYskKoD0GRcAPS52UgDkyGLWUYz23p6ThJh3c t7XUo5En0+eVYb6kDKEPiJq+vMP110AGMEdPy/mAoMzuj6HR0lKU8soVu7V2nzHtYu1l4SesxRC XSd0vaHMfALE+AUQuAyTgttNKwayoM2n5nyQfHSc3TaQClqI1dpmQ2KvtcDdHja3Tc8RQMy45Z1 FrJx/+g3KTlg4sib9l4+us7X+vLed2O+JS79yQslcZqwS2TYz0M3EhJNxK8lMsGIsGcC6qRNh6T QKuBSP9/2ELuZX/sXCQ== X-Authority-Analysis: v=2.4 cv=Tp7rRTXh c=1 sm=1 tr=0 ts=694562d4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=qe4J/qXhiWkb1JZGYKbLYA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=cWTT0jPcX04evTyD5nUA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_05,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190122 Use dev_err_probe() to make error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Krzysztof Kozlowski --- drivers/iio/adc/sc27xx_adc.c | 49 +++++++++++++++-------------------------= ---- 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c index 2535c2c3e60b..6209499c5c37 100644 --- a/drivers/iio/adc/sc27xx_adc.c +++ b/drivers/iio/adc/sc27xx_adc.c @@ -867,10 +867,8 @@ static int sc27xx_adc_probe(struct platform_device *pd= ev) int ret; =20 pdata =3D of_device_get_match_data(dev); - if (!pdata) { - dev_err(dev, "No matching driver data found\n"); - return -EINVAL; - } + if (!pdata) + return dev_err_probe(dev, -EINVAL, "No matching driver data found\n"); =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*sc27xx_data)); if (!indio_dev) @@ -879,56 +877,43 @@ static int sc27xx_adc_probe(struct platform_device *p= dev) sc27xx_data =3D iio_priv(indio_dev); =20 sc27xx_data->regmap =3D dev_get_regmap(dev->parent, NULL); - if (!sc27xx_data->regmap) { - dev_err(dev, "failed to get ADC regmap\n"); - return -ENODEV; - } + if (!sc27xx_data->regmap) + return dev_err_probe(dev, -ENODEV, "failed to get ADC regmap\n"); =20 ret =3D of_property_read_u32(np, "reg", &sc27xx_data->base); - if (ret) { - dev_err(dev, "failed to get ADC base address\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to get ADC base address\n"); =20 sc27xx_data->irq =3D platform_get_irq(pdev, 0); if (sc27xx_data->irq < 0) return sc27xx_data->irq; =20 ret =3D of_hwspin_lock_get_id(np, 0); - if (ret < 0) { - dev_err(dev, "failed to get hwspinlock id\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "failed to get hwspinlock id\n"); =20 sc27xx_data->hwlock =3D devm_hwspin_lock_request_specific(dev, ret); - if (!sc27xx_data->hwlock) { - dev_err(dev, "failed to request hwspinlock\n"); - return -ENXIO; - } + if (!sc27xx_data->hwlock) + return dev_err_probe(dev, -ENXIO, "failed to request hwspinlock\n"); =20 sc27xx_data->dev =3D dev; if (pdata->set_volref) { sc27xx_data->volref =3D devm_regulator_get(dev, "vref"); - if (IS_ERR(sc27xx_data->volref)) { - ret =3D PTR_ERR(sc27xx_data->volref); - return dev_err_probe(dev, ret, "failed to get ADC volref\n"); - } + if (IS_ERR(sc27xx_data->volref)) + return dev_err_probe(dev, PTR_ERR(sc27xx_data->volref), + "failed to get ADC volref\n"); } =20 sc27xx_data->var_data =3D pdata; sc27xx_data->var_data->init_scale(sc27xx_data); =20 ret =3D sc27xx_adc_enable(sc27xx_data); - if (ret) { - dev_err(dev, "failed to enable ADC module\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to enable ADC module\n"); =20 ret =3D devm_add_action_or_reset(dev, sc27xx_adc_disable, sc27xx_data); - if (ret) { - dev_err(dev, "failed to add ADC disable action\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to add ADC disable action\n"); =20 indio_dev->name =3D dev_name(dev); indio_dev->modes =3D INDIO_DIRECT_MODE; --=20 2.51.0