From nobody Sun Feb 8 02:26:43 2026 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EEAA3570AF for ; Fri, 19 Dec 2025 15:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159336; cv=none; b=RgDNsElW2j2gYXwv69M1KKx0tjpqfNtfjtMDGvF5uvQ+77pKNXJQSgjboS3SK8Gslg3UvWjH1tvXZArexBsbKqJAo7M2yeu7OSyDdhMutqbBLg8hgAeQbfR+VzP2gZVfbFiKr0G+SuNMjFThcgeRX+Y/TBMGodNeomx7jxa+u4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159336; c=relaxed/simple; bh=YdvmcO/xWrVGKvGLN3Sbu0MCh7VMaT4TyrfZK7GjnsY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eNw0gz3VDh0F/f5T0TRrs6NIx0ORH5bIhsQcv5TSDTAkRqVIW484dZTVf9LI7ESaobBBc0HcmA1tN0SrKYLYaFwoDPZqN3JgGb2V2H1Vh+S/pWypsXRW8nGnYODN0n/RtFiv4EJrNiBJhpsKkKj58DtXmIIDKifzP0NMmreikBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WUVcbWRj; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WUVcbWRj" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-37a3a4d3d53so15879291fa.3 for ; Fri, 19 Dec 2025 07:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766159333; x=1766764133; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=58EPOJ/ZliofUV0ndmhYUncAeMIjljEM//D48U8N39M=; b=WUVcbWRj1iz3pxLs5I8NK4Y42qU4qo0Fvfgw7P0hVVUS/YmbNzL5zmO7Bjuh8tgazD EaLiCb5mxoC5QJdJvbGp3GscZBczWPIENroa4Dx8w5B/9wWtJZMffO2kJJreVUtMs+Pw v6fAlhfIKu4uaUDkrbXK+nQWbvUBIR0ilv+4Nvk+97j9MvNAaH8483DPGtLh5rC3jsmp IuI9erRb8xvM2P/9yqpcBNRLKh7uteaOJz3J5RI1JmxUDiJsIC4McD0gUfpWXTX58K0b Nr3Q6ti8NkjtGI4g0E7AHxNF/F1xCMpdYAkbr45wi7CwUJ80wW8dNHCrAdk5thtZLIiB 4wxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766159333; x=1766764133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=58EPOJ/ZliofUV0ndmhYUncAeMIjljEM//D48U8N39M=; b=rM5gVSZ53fpcnaSb4q75fRy3dDKCJaAGB1x1blC2nsCs3CW2JY+7fFqN5s/OLQVqcB Ttz5oRFpotghewQjUt9xcgq2whI88JcaMDwkS3o52QSv2rnIcDLhM6jyqhfUDDvPBCFB s6+hQ+2LPGKQoKeOcYtQfkad/SYUgE7ccahOguvhwpofpoOwSPLHv+7Qy9Jid8BLklPH Q9ed2AqycsJAbkjjRJwsCqG2cYDNo4khcPWxleYwPJE3lncGl0kh4hVuED05/oWOU4jF A1o/5V3ZjaqqAyWRzWkFzxkOhGhvCk4JogzG7Np0HjVR59ChuCeU6yQ7Oyx9I7/DoNJZ r63g== X-Forwarded-Encrypted: i=1; AJvYcCXcZiQwrnjPRlRVKWoQG5yZDBvac/Tg+R8liFODgd9hKKzId8mGwNAwpxIWMfut42AO2n/nEMlDv6PII6E=@vger.kernel.org X-Gm-Message-State: AOJu0YxKL9JQTERKBqDysPN2XDJ85ZFgBF9oWZ+JSWXsOWLkqTpdlEB/ 5TLLCa7FL5ODrA+3whF5tAPJasjv4w0TuF2Va7yD2JwPf6rjLbSmBWSqMnqYfg== X-Gm-Gg: AY/fxX4WFYtyKJsvXQR24l060lj7pnWS2s+PbXw3kQqNc8HsrodbM26ZvvZARiojwRA D4sH/rWQB3JP5hnqxczNaXQ7kQayQn8rY5e41ehnOK4IUjQIPShP2DWxEQlgN+9cc+kr+oRv2md 2XASxC6wLzc/nWqe266vv0HDs1j3PSpaYjAXYF/i6Ax4v2KJtvIp+m2TqbCJX99XGn6RPVS6/UX CPyOn5mVnosglN0VhpLCkGKnyFKuogpe3gmNzFjGAs02eWj0a7CY+FK24qfhh6NASssq9hNWmEV I6tHydQfiTnqLw/EAj9IJnW3+6M8WMzMziCgq2MwEPfGYbUcZn2JRsvFJqMoQi4KAFuZyc2LsJP 369GCSMUiVSjJ9epePQKyVjnZZxoYupysn9Y+9+PpvPKJMTkVBymZQBSmqx6bKb3nS0pWwQ4eZU rMPcx/ctmKm5cgkvQKF77X47+ZD1DC27hkcOfc84TILoB1TvJ0u4nCqtF5M9FNQ8evQ0xwRVkn6 AusJw== X-Google-Smtp-Source: AGHT+IE7DsXldnsgfFUfZ0nWr1RvMsCKQcYmg5SxRFy8db1TNKQLxGI32gQJnwTCwqSt+BzRJBLk1Q== X-Received: by 2002:a2e:a905:0:b0:37e:566f:fc69 with SMTP id 38308e7fff4ca-38121637290mr10210591fa.30.1766159332971; Fri, 19 Dec 2025 07:48:52 -0800 (PST) Received: from LT-5CG5341NQ4.nordic.imtech.com (84-253-208-48.bb.dnainternet.fi. [84.253.208.48]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-381224de76csm6356391fa.10.2025.12.19.07.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 07:48:52 -0800 (PST) From: Kari Argillander Date: Fri, 19 Dec 2025 17:48:14 +0200 Subject: [PATCH 1/2] hwmon: Fix wrong return errno in *sanitize_name() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-hwmon-fixes-v1-1-21b29097ea3b@gmail.com> References: <20251219-hwmon-fixes-v1-0-21b29097ea3b@gmail.com> In-Reply-To: <20251219-hwmon-fixes-v1-0-21b29097ea3b@gmail.com> To: Kari Argillander , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766159330; l=998; i=kari.argillander@gmail.com; s=20251219; h=from:subject:message-id; bh=YdvmcO/xWrVGKvGLN3Sbu0MCh7VMaT4TyrfZK7GjnsY=; b=FIb+ROzvU8LN8nCjYfHOQ8eCkBKEvKpzL+Lgt1MruoF+g2RST6kKUhfvLazleWpH7go9oZZLl UXcjJ9QKj6ZDkAtjWi1r5ANmpWa4cjm3vZl9GHrbJqySsOAC7qGe5MO X-Developer-Key: i=kari.argillander@gmail.com; a=ed25519; pk=RwSxyhTpE3z4sywdDbIkC3q33ZQLNyhYWxT44iTY6r4= Currently if user of *sanitize_name() function gives nullptr for name they get's ENOMEM. Logically it should be EINVAL. Signed-off-by: Kari Argillander --- drivers/hwmon/hwmon.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c index 0b4bdcd33c7b..7a784d685d77 100644 --- a/drivers/hwmon/hwmon.c +++ b/drivers/hwmon/hwmon.c @@ -1260,6 +1260,9 @@ static char *__hwmon_sanitize_name(struct device *dev= , const char *old_name) */ char *hwmon_sanitize_name(const char *name) { + if (!name) + return ERR_PTR(-EINVAL); + return __hwmon_sanitize_name(NULL, name); } EXPORT_SYMBOL_GPL(hwmon_sanitize_name); @@ -1276,7 +1279,7 @@ EXPORT_SYMBOL_GPL(hwmon_sanitize_name); */ char *devm_hwmon_sanitize_name(struct device *dev, const char *name) { - if (!dev) + if (!dev || !name) return ERR_PTR(-EINVAL); =20 return __hwmon_sanitize_name(dev, name); --=20 2.43.0 From nobody Sun Feb 8 02:26:43 2026 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3375A3570B9 for ; Fri, 19 Dec 2025 15:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159337; cv=none; b=u83m8v5aMTYz1ta5CCV7qg/WsufDxwUQXnsrRr/HTNExSAN5ufjRZ9rhlAQIJOYzRudRMYelSbVp3jd8AkiUd4KwFgcKlrWGupFkzcf1qw7Bk2tXYPBK+Fx3MycUmdC7ftDOtnD5Jo8PaFJly8wp/5dhoKf7MZMmFgwoePZu/Os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766159337; c=relaxed/simple; bh=uHiA5FhcPLryQ8ugAxpypmlpj7SFCrfJ3SjCiilkFFg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SqU1mtka/59kRi8GIVvevMP8eTUfEgb5jy2DSSwWnVvpQ2HrNdK3NoB/gC+tnRCl1l2twSu7sA1hb/VAf9lSJXWjbjXE0jtbLLhOySwuxG5oJijGQHby+vYYTRQ5LWGH0KYapWXKN5Ms+zoUrJ4gLPffHXkDGZ797ZlZOKuzkRk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QS9QfCDv; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QS9QfCDv" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-37b9d8122fdso15043871fa.3 for ; Fri, 19 Dec 2025 07:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766159334; x=1766764134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=58qzkSPXKwLAUoCHlaJiWgl2e0ZZWj9EjRv5jxRxgI0=; b=QS9QfCDvr2nD21KHnV6IeUvgZvP0iPiOesUoA4PdteTIzoNe8td5xq3NdVopg634iQ rcHimwpN5it3bqhHI2Nr5l/MYYn0xaKcIRnFdzPuzAC8XQ8wQ9MqRtkTizt5SX5xkX2U DGuqJRbvCOehgHxE6uZV/QNT7uz8OepnqN2meMpppaimMlWtRedysSlnJjpK/UjCoU0j J4+orAOuV+u6x7G0ZCKfVQi9baKLNQelEmBae0G8yhujUPBu6F2spXb5p8MnPP9+AdxX Tv0Uqw3/FUbV6BKXKbn5QMrtDP2yDC40OdcEnqKsPqzL66I7cpUjLGzUe4zp7jYKfTWY nCIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766159334; x=1766764134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=58qzkSPXKwLAUoCHlaJiWgl2e0ZZWj9EjRv5jxRxgI0=; b=aA0rt4UV/F4XxOk35XmIlbCOdncMl+FCa9v2R+VNoMz8omHkOFv9Db70WYguCDBDMW 7PGnbUMHRFZH2jFTFapLAFqmmzoXonbAAaJHmHsMq36max5rZCQyunm3WYQS6n7wvOUL 5paL9Ihne1eB5GzlohrMTyVSd/q7icGWekobOvNo7Rl97YbAYBNn0NgyZZli+MUrjOAc KXlkHVQvrMETYpEYzwWdeIneDKcT0g+bz+faGL22r24nJgpSdKTUXxWYptkTksF9IsLn Mc3eHfe7+MOm7DEZu+Yr7RTANMD6dyZmCgMIxdc7rpx6ly2xHYMF4ByIYPOM5dgx3Wub Z3og== X-Forwarded-Encrypted: i=1; AJvYcCWzXPrZsyl9cOmMQUcUgiSYGOIw0pixKf+rnt1Q0nMKMYNWDC6vMesCgdRorzzVxZsmC13eCA0+pgk1zOc=@vger.kernel.org X-Gm-Message-State: AOJu0YwJyiwozCMrOIGV3/ixFFjoiFIuU9tmTQc5D8XOxbxV9tnq4hAn 0i9ND30/lNLh3RvCJH6YsbOogumShTmov1i+IswVf5BWquM54hPRk9XV X-Gm-Gg: AY/fxX7P15qXbWssIpqbWZfrKPYj+NvlTjWLCkEgfMRPRA1HsD1W77vw48PyHMqO03t hn+Fj/Xwod41FQX/lGy4KucjyYEKP7spq0pNuwVFMWpgG/ePN/ZS6dPEuOOlGq60nmzJvfK2+Ge KkCaptrdu8yuzdrVDnTYK+ng2E8+3Gjqiy+RK7dNY5yMW1FxuZQGHyBNKpZkcJu93L/0Ukut0IY rtlHdEurFnJq6YY7Tu6hlzzpzJ7hONs9Mqm2rhkqz9f7IaqoqaNeCGF+x17Qttvx62bCRXfo+4N azPkawMlmiwxYbJiOooUM6PDBf04D+qt0Xy56pBTCDFdxXkDcCHlWCqenCfQbv0MLN04N0EL3dZ c1BXtYQ+B2gVE9KnsOG8Uz3XR7JmlORLuM0SP4yZkuT8+Pzgp/sLSWHRJQ4nZ+4KMFSLEjLKEmM QQQrHExUkBX5B4zej0SzIHdZD1YwBJiHtgFg70MdNZDv2UgLZUgNeaCrw796XM8DoIZJV4ynADV Qyb386eYhDRHy7A X-Google-Smtp-Source: AGHT+IF95+Ws35JnyyvzCS5quO6tFnqnGPIRzFJiFpWaWJpei0LOPhjD+jVCG3zPqKkV3g7C4E9p3A== X-Received: by 2002:a05:651c:f01:b0:37a:9558:5bda with SMTP id 38308e7fff4ca-38121596988mr8904691fa.14.1766159334062; Fri, 19 Dec 2025 07:48:54 -0800 (PST) Received: from LT-5CG5341NQ4.nordic.imtech.com (84-253-208-48.bb.dnainternet.fi. [84.253.208.48]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-381224de76csm6356391fa.10.2025.12.19.07.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Dec 2025 07:48:53 -0800 (PST) From: Kari Argillander Date: Fri, 19 Dec 2025 17:48:15 +0200 Subject: [PATCH 2/2] hwmon: Use sysfs_emit in show function callsbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251219-hwmon-fixes-v1-2-21b29097ea3b@gmail.com> References: <20251219-hwmon-fixes-v1-0-21b29097ea3b@gmail.com> In-Reply-To: <20251219-hwmon-fixes-v1-0-21b29097ea3b@gmail.com> To: Kari Argillander , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766159330; l=1530; i=kari.argillander@gmail.com; s=20251219; h=from:subject:message-id; bh=uHiA5FhcPLryQ8ugAxpypmlpj7SFCrfJ3SjCiilkFFg=; b=A+nWb7oXCmtaGF0cVl0FtZi2O6GY5Lz17fZwLZyFJ7Y/kYUFz5hIBTb9dut+4bQyNmnX4FODf d4lQWwuYtH3Cp5RgcjoSk9pVhtE/waVT2lkXr16R5iWL2zxHJ7jRi7d X-Developer-Key: i=kari.argillander@gmail.com; a=ed25519; pk=RwSxyhTpE3z4sywdDbIkC3q33ZQLNyhYWxT44iTY6r4= Use sysfs_emit() over sprintf() to prevent potential overflows. In hwmon_attr_show() that is totally impossible but looking other places many still use sysfs_emit(). Also according Documentation/filesystems/sysfs.rst code should use sysfs_emit(). Signed-off-by: Kari Argillander --- drivers/hwmon/hwmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c index 7a784d685d77..714caa6a36a3 100644 --- a/drivers/hwmon/hwmon.c +++ b/drivers/hwmon/hwmon.c @@ -73,7 +73,7 @@ struct hwmon_thermal_data { static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "%s\n", to_hwmon_device(dev)->name); + return sysfs_emit(buf, "%s\n", to_hwmon_device(dev)->name); } static DEVICE_ATTR_RO(name); =20 @@ -446,7 +446,7 @@ static ssize_t hwmon_attr_show(struct device *dev, trace_hwmon_attr_show(hattr->index + hwmon_attr_base(hattr->type), hattr->name, val64); =20 - return sprintf(buf, "%lld\n", val64); + return sysfs_emit(buf, "%lld\n", val64); } =20 static ssize_t hwmon_attr_show_string(struct device *dev, @@ -469,7 +469,7 @@ static ssize_t hwmon_attr_show_string(struct device *de= v, trace_hwmon_attr_show_string(hattr->index + hwmon_attr_base(type), hattr->name, s); =20 - return sprintf(buf, "%s\n", s); + return sysfs_emit(buf, "%s\n", s); } =20 static ssize_t hwmon_attr_store(struct device *dev, --=20 2.43.0