From nobody Sun Feb 8 07:22:01 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F972221FBA for ; Thu, 18 Dec 2025 19:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766086885; cv=none; b=CJ8bvuGaWlKUywLWVyiOO5HkbsO3DcWfF6N9FkgkaHi7emsmhr4XB51YNkJcjDIpzwfFDLNOCIghlcwDxsaolXsnnTe69HE+zQOUTYB8eWKf2jp+nVXJifeWPBJuz5CUQZ+M79G/uUK6H5CSPJMQGGRqQUadANkKBOGNtTPCkEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766086885; c=relaxed/simple; bh=RDW64CupgaSddwFbfaf+AO/GxmMOa1s4D4VRDBTjiJQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LBwxm+kamfA0Fv3OTPVH1d80C8bHACPv+FOUl497/ln7q+WmF6N7N/gvAH0AOrvYt4vBWRLarybNJp9afXTHkta2hyK+S+sjrWIBC1Md/Jgnn33HQEwPf31COzluhI2TNJ4c/Q3K3xAOPWicJsoSGGauXMsfGoJkAM32r7S/luE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CrH5dYg+; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CrH5dYg+" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so724566f8f.3 for ; Thu, 18 Dec 2025 11:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766086882; x=1766691682; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BLxs0lQBx4sta6z6nnKDj4vKVTRti3i1pI2/aCW6qDU=; b=CrH5dYg+esH+0sqRhkMLHvVhRj7cssUXsvwNZ6TdqQ+SVKK9juRpSIFLl4SMh+xnzd CMftV99E6/nzcXXBtK/4rzqi0gnyExghmM9De6pO3Hid0Asq9Y9P6IaSTEUFBvIP/nm9 I61CPkN/p6T8k0/HJeVJVQ21yCJf3s/UcM45JkeIhl/UMZvKPwgdWwiXUweAxusLEMmX GhmsrtMJJbDnK8goL7YcR89hR6WT5q7wUwmcIgZ34aNUjj7Vv5f9p/k1n/Q9eqo0T/7e WW5QLoMFcVP6VIYaUOkzR7IhkHRwhXOl+tYyPDpK5RKQCtSMQv4AggbFj3x4Kmwg//5J KyTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766086882; x=1766691682; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BLxs0lQBx4sta6z6nnKDj4vKVTRti3i1pI2/aCW6qDU=; b=LiMW4FLt3UVCoNS3ko24apP6DwM0BJR/FbykAd0/5xODVW9ODBPL59SQFvxWLHtPRJ mbRE0YaLT30cxZjmM/0kyJURejN/oBScg7zxbxRKk3ksO8CfEFaH0I/Xn0+K0BYsYdLe UNXzPIXYrwYtjX6ylL1Nk1WOqEs87+eQaBNpfbYUmPUYxn9vNtNu+0Csba+Zqv4kZoPf UBAMxakttlZFVgdI9I/3EFEuz2jphWnKqXcfyWIzw/S0npUoh1zgehSACZO/zZbwlSas BcHpmSUgIVmS6zhRvqaIjpGDkE4Bp3ewU3txqks/vO5heyOfMKrIpLafjv8bct9J6D1G H8Lw== X-Forwarded-Encrypted: i=1; AJvYcCVxgtZu8Oh0219oOUtyq0weBncDkPMUSUo0qVbccl3hNuxQ8Gk111WXLN6/RPW/DfAn0O0daqR3pnSTfu8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4yMTOEZXuczEfxRkEnjomIuR+pmPp2UvxjxYaywl8BTJNaSIy 8VtBD/s9Gw/dfPboCU47IgN8nTm1TLolRFmehgbnFK/fn5j5rGCOuT5U X-Gm-Gg: AY/fxX4uIFqhx4grvN+HHzU5/L0oyH+KVCEXfU87oniGBRwnU2C+lzC2z8dpeh0FODU vizVWUO08KcZuB/Nb2havyZ1nsU2mM4YpBfFKlGQzEiXw7IEmgnBDdmb8gGaE6LZwuJ+7BjpX0y yPLNGEmuT+CvWrn57unMHo16mngu1ZNE7M44MtN9xeCeWh2d/WjoNKEsmhb4yB8BUGiUUb1VNzg pvYHhx/TFx5vSDYXprhW2CpW3Rr+CaYZK7+6eHXEnfYncZvji04CKvQ2QUPzTUV5tlvQz/YRjVZ MyabqY0B8S0KQG/UEIRaRVZA6aaA5Fsq5hW5sGdejcCQlhM2yWFllR98ENx1jb8YoLrxnUEkwOd rcWbhJhb4mxwigAg4690rWupUTAG0i72ayZ94vcIh2sPmGeFGOucVJGx2gpABA0/fpY42mkzh94 LdmMi5SZXCpL7oCVWIDqP3172/wMq593i3w1ct95Um0ctH/tVZxC75SRCZx2wNGhpeJU4bWJt8R kesg85eNrIccvM= X-Google-Smtp-Source: AGHT+IGQAnLgRUsVVnoRwQFGOEHR79qz4dsFP+YsgAFKs+KUs0BWTkYbN/tIazS3ji6D/iA5kpDA1g== X-Received: by 2002:a05:6000:186a:b0:430:f301:3e6c with SMTP id ffacd0b85a97d-4324e4fdcd8mr637543f8f.34.1766086882068; Thu, 18 Dec 2025 11:41:22 -0800 (PST) Received: from Lord-Beerus.station (net-5-94-28-5.cust.vodafonedsl.it. [5.94.28.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82c5csm556586f8f.21.2025.12.18.11.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 11:41:21 -0800 (PST) From: Stefano Radaelli X-Google-Original-From: Stefano Radaelli To: vkoul@kernel.org, neil.armstrong@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, j.zink@pengutronix.de, linux-kernel@vger.kernel.org Cc: xu.yang_2@nxp.com, jun.li@nxp.com, Frank.Li@nxp.com, haibo.chen@nxp.com, linux-phy@lists.infradead.org, imx@lists.linux.dev, Stefano Radaelli , Pierluigi Passaro Subject: [PATCH v2] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it Date: Thu, 18 Dec 2025 20:41:00 +0100 Message-ID: <20251218194100.365269-1-stefano.r@variscite.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clear the PCS_TX_SWING_FULL field mask before setting the new value in PHY_CTRL5 register. Without clearing the mask first, the OR operation could leave previously set bits, resulting in incorrect register configuration. Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning") Suggested-by: Pierluigi Passaro Signed-off-by: Stefano Radaelli Reviewed-by: Frank Li Reviewed-by: Xu Yang --- v2: - Improved commit subject as suggested by Fabio Estevam drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index ad8a55012e42..9458b6e5fcf4 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -504,6 +504,7 @@ static void imx8m_phy_tune(struct imx8mq_usb_phy *imx_p= hy) =20 if (imx_phy->pcs_tx_swing_full !=3D PHY_TUNE_DEFAULT) { value =3D readl(imx_phy->base + PHY_CTRL5); + value &=3D ~PHY_CTRL5_PCS_TX_SWING_FULL_MASK; value |=3D FIELD_PREP(PHY_CTRL5_PCS_TX_SWING_FULL_MASK, imx_phy->pcs_tx_swing_full); writel(value, imx_phy->base + PHY_CTRL5); base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 --=20 2.47.3