From nobody Sun Feb 8 05:42:15 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D652223BD1D for ; Thu, 18 Dec 2025 17:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766080211; cv=none; b=ZRyNn4s0iJNuM8swYk1DSeWJ3emacaiYKubtWzH3QencvXxzCum0GYHpguG08GHG/KI+xgqEV24PWfDxD1SjLllx4IUeG/Nztn8GgXZe/2IKDcIrPYISmlCWGfOLcaG25/Z3xp+/WfeUL/uRDsDocEbEAP2C8HAKO9bQS8cLAj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766080211; c=relaxed/simple; bh=rvJzjLErjW7vPxDrpXzXer4XNOLt+5Lu9/qPOviwYT4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UwZejnolB2Rs7wjhrsDXYMqPvc2PIB3MdCV53xUglOTrkHroJvOCGH5UE2atiXR1TNeyuoWqoB7bYwWAuD1v6jVInvAfraqnym3Tt74W1P57TKiiiSpdKsGuy8bNpeItxk9jq8yl+Rdjwp1DbSrh//ZuDiZ3BaixatIWMXztAD4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H0xlYffx; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H0xlYffx" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42fbbc3df8fso449969f8f.2 for ; Thu, 18 Dec 2025 09:50:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766080208; x=1766685008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AVw7T5bcH3lvfv3rJWK9YzPen8SSd5iHLxvK3gngGo0=; b=H0xlYffxyr4rhOParJT5n4tmxvCHCq0Y3JNv70fRdEuNwr1PIoBv7XIkO1zUShtb2m 3h6ZUOCkrZabZwa2NU1OtEEBWSr8G6IJn8etHATCKyMO5dkTgdLYRqs7E/AmBEYFAiL+ C90E7iyMgCVUxHlTll05UDx+Sa254j+s9JRTq0HQQNo0HgQHNpfrMr+6GsqAaoZInASx TUT7hzlNgkrVM/CPMAdWAt7XAIc7wjU2h5tsnw+nKYWf+dtnVof+sm9fNifa4zuQIsa9 kCy4GUX7u8zIiiIZl2BTbyJk+E8UGHVhmvZINcRDfMyMSA74q+Fc8Mi2Ar+PI34GdFsS LkxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766080208; x=1766685008; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AVw7T5bcH3lvfv3rJWK9YzPen8SSd5iHLxvK3gngGo0=; b=rwNvIYYplNjvo6I59WUPmnaWeSVENYbzGdRs9z+3Wx8DpJ83x9FMyinkbBHfbKYpH7 Y4xjqMQ8ENkfiedPwztgiiOtHb/UIlZEetR3FwJpvjOGUN2vLd6i8XNu4FMI7UMcE6H0 Z772fcfkXIAopll9CCRkjLiho26+OGOCk0GYECHw5H3HXqTe5KtrusQGg+VoFg74B3Lc /zajg611LNvxjY0AVYjgFfG38WR0s8xuc9nSEenVJmS/1S+12pfdm0o//Nd4E6eZrQH7 5hgjdz+pqi01L5Kjc8jGnpquzb6TpjtUnaZht43pcIted1XRIXXtaNPJcPPuROIp8ckt dRfg== X-Forwarded-Encrypted: i=1; AJvYcCVkLI2YClJ9qO8U0bLTj8Bu3FclpBk74ni3QrffuSqpYIG6TZcMHDhH1tPsogHCPUFfhnPOB17fM5AlKK0=@vger.kernel.org X-Gm-Message-State: AOJu0YwfA1KsiVrIPbDBgupHRj7rIFfatLdCvdGxZSYeNfnHw/E3RXF5 9RETDyiHiMiPwNX1VEzlC+Q5JNN/Y/h6IfNEEhK2DPAF+2B/417UTFIP X-Gm-Gg: AY/fxX6L9hJKCoJgSnxJSMYCTuA8wD4xKeYrAVU/mSiNnKG9UQZioiZa5ybOkzpsYgR VobSphMLtaycWgMPZ/B8hhqARQkxvNE2OQy+f3PbX2rhDyPD6zLjmmsdJBGRuKl69wGNleL8BCj dPZjuybK2tXEktp10Pe9gE2Afq876BFTJT7BG/3lItmpTGldpT13qIw847ptYA4KOsFHJlVRErK sAjqzUezvNLK/h/l1OyDqweEHKH5X/6+RtdWSlT/k7Kmksm+c39ERrCZIbZ80pw4A3bLHSnh19L Q1vFh3/W3ZJXzTdlBfePz9vnIlCh5e+U/sb1l+1uRwxXH3EZDyB2BjryWOF7LrMk5rbcyxBaSNr edSb4lBNvmN1gvvDggkNYgWFuelWDN0pKAEY+jHpk1HJoqTTXstylZtfN6kNucbo02XC/s57Rtc Q7lIO/NTSxKyZqleS3VocSDNVuP/aKxk5RRwn91PbVuNnNNSWnTeu+VJqLXK2jZHhxjmFFteyYq ZNhUUlAl+gPf0SPknhT0xsmpg== X-Google-Smtp-Source: AGHT+IHkrVsVPpnhIf2cWnEa+19MOkN09a76xidWg9x92oZBtd32naBG20DJoni8nBJ/zdrSoqP2Dg== X-Received: by 2002:a05:6000:2886:b0:42b:4247:b077 with SMTP id ffacd0b85a97d-4324e501629mr374640f8f.41.1766080207883; Thu, 18 Dec 2025 09:50:07 -0800 (PST) Received: from Lord-Beerus.station (net-5-94-28-5.cust.vodafonedsl.it. [5.94.28.5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea82c5csm92552f8f.21.2025.12.18.09.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 09:50:07 -0800 (PST) From: Stefano Radaelli X-Google-Original-From: Stefano Radaelli To: vkoul@kernel.org, neil.armstrong@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, j.zink@pengutronix.de, linux-kernel@vger.kernel.org Cc: xu.yang_2@nxp.com, jun.li@nxp.com, Frank.Li@nxp.com, haibo.chen@nxp.com, linux-phy@lists.infradead.org, imx@lists.linux.dev, Stefano Radaelli , Pierluigi Passaro Subject: [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING_FULL register configuration Date: Thu, 18 Dec 2025 18:49:20 +0100 Message-ID: <20251218174920.359282-1-stefano.r@variscite.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clear the PCS_TX_SWING_FULL field mask before setting the new value in PHY_CTRL5 register. Without clearing the mask first, the OR operation could leave previously set bits, resulting in incorrect register configuration. Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning") Suggested-by: Pierluigi Passaro Signed-off-by: Stefano Radaelli --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/frees= cale/phy-fsl-imx8mq-usb.c index ad8a55012e42..9458b6e5fcf4 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -504,6 +504,7 @@ static void imx8m_phy_tune(struct imx8mq_usb_phy *imx_p= hy) =20 if (imx_phy->pcs_tx_swing_full !=3D PHY_TUNE_DEFAULT) { value =3D readl(imx_phy->base + PHY_CTRL5); + value &=3D ~PHY_CTRL5_PCS_TX_SWING_FULL_MASK; value |=3D FIELD_PREP(PHY_CTRL5_PCS_TX_SWING_FULL_MASK, imx_phy->pcs_tx_swing_full); writel(value, imx_phy->base + PHY_CTRL5); base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 --=20 2.47.3