From nobody Sun Feb 8 01:34:26 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51375314B84 for ; Thu, 18 Dec 2025 12:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766060247; cv=none; b=nhKgZWgG/wPqiyE3GvdvBE5hOChrRLxmGCNWvB1rD0n01wvchcgzhEbQzmchplE+OQvRr9LtcwvBZIkiLckVdFfsJU4QL8dTCOanCtP3re0tgqPjNI1ombinwsfj03sfHwJeMMsoHjhafgEVFBaVppQNX2on/C55zX3aj/mHzqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766060247; c=relaxed/simple; bh=qiG7O6UF/J2Ly/EAeGl0MYRrP6DOKAxr33FjUc3WicQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l6/kzg7U0/ZnEWKHKQdcwQjDXmEbaL+XraRrYekUWHRtzEGTSwU0OFVVh4Uc/uW9cMpGJ/OtxOkOZq5rkwaZP0dd6FuVWEMyKR2jn7PoKh9pUzshKn0gQInrWnvgYhHquoale75e1csFP4nmFwmmZY8Pjczmnf0eciL56pQEd9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E4kpIb4O; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E4kpIb4O" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-29f2676bb21so6923415ad.0 for ; Thu, 18 Dec 2025 04:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766060236; x=1766665036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jyVYm0ues4iUBaQ2lxXrnR7rIJDuzkZszrw1dntaQII=; b=E4kpIb4OPF74+NwP5RzyXm5hv+6BVsDAxxyonh23oKu/zVY3RrTf0p834ONc2vfNv8 1p07EPRO3W9Y+K/d20v79mkgrQ1BHkhZXFzaPXH91uKJ3gdVafPYiSOQSAmGjBHvxB+I Kn3Sznb1UpraKWneBPSnDysnGs9uuV/r56uXgie0paPlVffVCNaTiZHo7ijVaSC38nnr Ua3SihCDnhz5PxfsENy9qLYs1Alb/52VjdHe3LtsE5ofMTwk+MZfDYPbw8qB24kjM6EU KwC+DvYFLdZ0gHn4bYWlTiJCvC2xxXt+m6UvVWsN6VPOiyixZpc6/DJEs1/d3Sn1oeIW HcvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766060236; x=1766665036; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jyVYm0ues4iUBaQ2lxXrnR7rIJDuzkZszrw1dntaQII=; b=DLCK+fXbuZ0wVDlC1Kjx7Er5ncwhJafuyvbTQPdru2V8q1qhfh4RRhufr0X7MHTuI1 +wJhnlvffF6LbCq0afc1N7VBDtzwYpyu3733aV4QyaOIqrLEsvGn4ebzEXd1KEzmF8kl 8QpJ9RC20dDlYLcQhiDnIQWcfQPK60sdZ4TnfRSFL70Tf4EngzwWrr8EsjCgll+3N9HV Tj0yx6M8E8x5cu1ROdCM0TArXIkaAu84ggmTI0avJm7GsJGWJCO61lfuYerlGBumedPG 757WOqfF1P2mwdr9xpIBVDX3QCy4D3YNHmjRy4b11JPebG43UfQI0ubM28o7GgnUEoCg 82Cw== X-Forwarded-Encrypted: i=1; AJvYcCUAzIZMrwzucK6xWfjL/d0daOqIbCno/qmY+ybUJ0iMX7V4jX02O2RUx7GY8KfWmN8tIUBCBTmdE30dVMk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw31xDgywSmUQkRYPIw7ihCQRafzf2MdW1J9BFkbaO2amBU8+SC laA+kNr0LpVo5XbQs5arXEKuUBmOFSJBJ4VAXaJn+FiUIdzWnt4gLNAx X-Gm-Gg: AY/fxX7eCMhgjR+U24V0P6cwmI3FJbTEJuw14qDj6fvvOw872MXEbP0Zbd4LTcg+kVE ahLL/mwK9tcT1uf6Xxy12WNGwWTwRmeCdbjfNg32z/m3dPUq6VUbMAZLl84hNsYcx1TrfU8qdel p67biskM2aKRdSUVt/M3dA8eE1/ZMutEdsgsdSxrtBHn6h1X4OM7RxPfveV56sixJXC33u5ZGXN b+TBdCb8qp1zKbmjkvTbkv2p4D0o/WeG1XSbsJ5ms+KE/ZWLWo1ucprMoAAAzwx7roEfXeEpJEQ qdUH9zEMTAztDdpR3rrzgV9QmO63QOhEKtwmhY/xqLEqS2SXj7QshOBEt8Ov/9ebtk3ZOx7/mzB LU6QgRZZlLBNQ1ON4QNwtJT09ipOwTPNYSVcu/lZ6XCfyhMZanDmDwOyLGD9C+EUCgZDbQ6tRXo JCrTA4lQYrrjgJaDYBuJwmqw6E3wD5MwTaEVwYtKZxeWSbKzoRxr9MWsALPOuclTfTY7IeR0HDt jP7b0lo0iiG/A== X-Google-Smtp-Source: AGHT+IGbIWcKUdY11VJPO4+wnaa+X7Au3kPc/xDIiLaFc+Ni+fjNam+/tZZgcdZsJi3G1B1P5zkElg== X-Received: by 2002:a17:903:458d:b0:29f:135c:5f25 with SMTP id d9443c01a7336-29f23de670cmr202072965ad.4.1766060236465; Thu, 18 Dec 2025 04:17:16 -0800 (PST) Received: from oslab.mshome.net (n058152119183.netvigator.com. [58.152.119.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2d1612a35sm24006355ad.46.2025.12.18.04.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 04:17:16 -0800 (PST) From: Tuo Li To: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH] scsi: csiostor: Fix a possible null-pointer dereference in csio_eh_lun_reset_handler() Date: Thu, 18 Dec 2025 20:17:00 +0800 Message-ID: <20251218121700.11316-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In this function, rn is checked by an if statement. If it is NULL, execution transfers to the fail label. However, rn may still be dereferenced later via the following macro: CSIO_INC_STATS(rn, n_lun_rst_fail); To avoid a potential null-pointer dereference, return FAILED directly when rn is NULL, rather than transferring control to the common fail label. Signed-off-by: Tuo Li --- drivers/scsi/csiostor/csio_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio= _scsi.c index 34bde6650fae..feb1a9a9390b 100644 --- a/drivers/scsi/csiostor/csio_scsi.c +++ b/drivers/scsi/csiostor/csio_scsi.c @@ -2074,7 +2074,7 @@ csio_eh_lun_reset_handler(struct scsi_cmnd *cmnd) struct csio_scsi_level_data sld; =20 if (!rn) - goto fail; + return FAILED; =20 csio_dbg(hw, "Request to reset LUN:%llu (ssni:0x%x tgtid:%d)\n", cmnd->device->lun, rn->flowid, rn->scsi_id); --=20 2.43.0