From nobody Fri Dec 19 04:53:34 2025 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EC282264AA for ; Thu, 18 Dec 2025 06:29:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766039345; cv=none; b=ZRpUaZGqzx1rUu5hRAkryDIWXsGl2p8b0c+oBx3d39X6vFYxB0Hd55RbO+NrKLvj3rd3QNGPkG619qpboo9E5HoqtW4v3CdwvasMUCHaLXe3+HcKt/gVrvfJiKb1Pl8FaL9XCUEucDMLWglNWJF8fB6CGOTUsI9HZjNNkT1EcuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766039345; c=relaxed/simple; bh=fPng5ZUvz+0tNW3LaZLEKF9BeRtl6pux2h7RiYtCX9I=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uNCH0dvN23n0gv7XHCeTYInh+DgUdV4dcYMJ9TnPp6LhmPnOcRNeMz4wrnBFQCJ1ljtsF5etZ2pfLqUeCFD9TLl9L8Jq5S2cHZ+vTAxZd/vA0N9EGNw+5V2yE6qZA+RN1v5dVffO1Xp6fu8rXdpQIfOOWdlBC+HKX02SBy39/PY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N1/jOrdj; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N1/jOrdj" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-29f1bc40b35so5700135ad.2 for ; Wed, 17 Dec 2025 22:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766039343; x=1766644143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hjVQD1IMxRH0umBlmaZVMLvoLBONPloeFCT82Lq3Wpk=; b=N1/jOrdjFwT49rbOjI9LcxfqJ+Zrk5FPMg5eFLzqO8erAe8Gf0/7EqBCAb+XL+UHeX 7p03Y3d+X+bOkyc7lKMB9XJXxe9k9KspTWLH8Nw8E0XJk+JZhJUnYWNn75Q+xEKzupwN H8GhEgxi/7Pfc2HFnVmv/98Jd3y7TtLG7Fj47KHnHyKV/nyJKhIMBWkcrr0vHbDLQAGM ztd2u6H5o5PalcsNk3U6oIWJX+KeEqdBt9+GejU3swx8zKrVvbqg7yRgsn8aOCRB/Mps 81pymKFJ6ImNCk+pc8Rm7KsjTjOYZHJnftPVRx94gJiEudSTfoaBbPtnU7CPfYD5MHol TMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766039343; x=1766644143; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hjVQD1IMxRH0umBlmaZVMLvoLBONPloeFCT82Lq3Wpk=; b=R10V3/47nCCWp+zZsXzCP1MkOJ3KbtUAiem+O2fbkCItcXWpNE6KJDQf8y5tRtFyFj 8W1aIMmP65GonwLHQ972WVjOCOilQMbBDFOu2ncs0WcCHSFxNrb7rZMNmhwLl6PSfhsl y6EjJGU8b9rKKQcaBxN/jdcScy3P5m4AWYFaGmWnkiRIAVjJwWuTfMVegxAW8seMA3p8 npbfqqV4ZkkaIbKly33DWrNlyF/GLuWUKoNRlbcoZfe6DbAbTWnInLWDeojKIiRXxIQe QmflUE2/XNLagU8Yco42crlNNiAWrfibYKFU0bzST8vXsZXiJXY9sgvsU16UnToUTU/G YZMA== X-Forwarded-Encrypted: i=1; AJvYcCVBcnBdrK1hKR8f0etOWD905cWtAxpsCEjBw6+AS78MXNu3yM7I5yZjf1hZR52kLdpKsxKFg29chzk2aMI=@vger.kernel.org X-Gm-Message-State: AOJu0YyrxiB0sFUYB9ENY6iBWfSXkaXspwbGA73q2M8IzLNgKWLO3kC7 uC2hFs6E9DZYDfO9kbY9DKXeiCnQB2K9KBD8xnkFptNFjr+JHvdM3Wee X-Gm-Gg: AY/fxX79wqz9vMuv2jljCQLVmCekYYMaxp8c+FfcDjS2/lkFBjlBYfQKa7lWGAlfaiu xGh78Yke5Vg0qY0C01/uEnqE13mB7LCvr9uvTkGCTh7Do2fDxqkpmz3LluLRN2LRCkZNw3Tz+sa vLBcfDEVKKBSRvmd9wh9wCQ/9xkA631PBqE0DcBijcOZQM2SFQ0AE7DNbyZ7Ntp/9qHbj5YB7wO 18LaWMPLqIIDZuCUljIyh3P8iuGT6JgsDOuFebljd32okC2g6KKXkVAXUpoz82H0SQ0IQrsmkVN /oQ2eIQ95MbBa9OkGYP2FA2xEW4yqfYpKgLBXLxSFW+wohDhxGepHmeJdHMzgI+6o0iSRBI1uHM HdXUOqVRHTBg6tNbeV5/g18k7o0PLNSGaIb7PQynSLGUJQNWzJAcMS13W4rOZHmQF7GNDU6qA68 O9Tba3BOHmbVBocbjtoHsX X-Google-Smtp-Source: AGHT+IEkJR6e67q6TXoTlLRSLxdUZKbPYbKKJ8tztKLYDaWuDH6Gch/XODP95EpB/ke25E6NUlAMzw== X-Received: by 2002:a17:903:1a87:b0:297:e59c:63cc with SMTP id d9443c01a7336-29f23c73363mr222873065ad.35.1766039342643; Wed, 17 Dec 2025 22:29:02 -0800 (PST) Received: from xiao.mioffice.cn ([43.224.245.230]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2d087c64esm13308265ad.17.2025.12.17.22.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 22:29:00 -0800 (PST) From: Xiang Gao To: sumit.semwal@linaro.org, christian.koenig@amd.com, rostedt@goodmis.org, mhiramat@kernel.org Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, dhowells@redhat.com, kuba@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-trace-kernel@vger.kernel.org, gaoxiang17 Subject: [PATCH v8] dma-buf: add some tracepoints to debug. Date: Thu, 18 Dec 2025 14:28:53 +0800 Message-Id: <20251218062853.819744-1-gxxa03070307@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: gaoxiang17 Since we can only inspect dmabuf by iterating over process FDs or the dmabuf_list, we need to add our own tracepoints to track its status in real time in production. For example: binder:3016_1-3102 [006] ...1. 255.126521: dma_buf_export: exp_name= =3Dqcom,system size=3D12685312 ino=3D2738 binder:3016_1-3102 [006] ...1. 255.126528: dma_buf_fd: exp_name=3Dq= com,system size=3D12685312 ino=3D2738 fd=3D8 binder:3016_1-3102 [006] ...1. 255.126642: dma_buf_mmap_internal: e= xp_name=3Dqcom,system size=3D28672 ino=3D2739 kworker/6:1-86 [006] ...1. 255.127194: dma_buf_put: exp_name=3D= qcom,system size=3D12685312 ino=3D2738 RenderThread-9293 [006] ...1. 316.618179: dma_buf_get: exp_name=3D= qcom,system size=3D12771328 ino=3D2762 fd=3D176 RenderThread-9293 [006] ...1. 316.618195: dma_buf_dynamic_attach: = exp_name=3Dqcom,system size=3D12771328 ino=3D2762 attachment:ffffff880a18dd= 00 is_dynamic=3D0 dev_name=3Dkgsl-3d0 RenderThread-9293 [006] ...1. 318.878220: dma_buf_detach: exp_name= =3Dqcom,system size=3D12771328 ino=3D2762 attachment:ffffff880a18dd00 is_dy= namic=3D0 dev_name=3Dkgsl-3d0 Signed-off-by: Xiang Gao --- drivers/dma-buf/dma-buf.c | 51 ++++++++++- include/trace/events/dma_buf.h | 157 +++++++++++++++++++++++++++++++++ 2 files changed, 206 insertions(+), 2 deletions(-) create mode 100644 include/trace/events/dma_buf.h diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index edaa9e4ee4ae..59a5261cb26b 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -35,6 +35,28 @@ =20 #include "dma-buf-sysfs-stats.h" =20 +#define CREATE_TRACE_POINTS +#include + +/* + * dmabuf->name must be accessed with holding dmabuf->name_lock. + * we need to take the lock around the tracepoint call itself where + * it is called in the code. + * + * Note: FUNC##_enabled() is a static branch that will only + * be set when the trace event is enabled. + */ +#define DMA_BUF_TRACE(FUNC, ...) \ + do { \ + if (FUNC##_enabled()) { \ + guard(spinlock)(&dmabuf->name_lock); \ + FUNC(__VA_ARGS__); \ + } else if (IS_ENABLED(CONFIG_LOCKDEP)) { \ + /* Expose this lock when lockdep is enabled */ \ + guard(spinlock)(&dmabuf->name_lock); \ + } \ + } while (0) + static inline int is_dma_buf_file(struct file *); =20 static DEFINE_MUTEX(dmabuf_list_mutex); @@ -220,6 +242,8 @@ static int dma_buf_mmap_internal(struct file *file, str= uct vm_area_struct *vma) dmabuf->size >> PAGE_SHIFT) return -EINVAL; =20 + DMA_BUF_TRACE(trace_dma_buf_mmap_internal, dmabuf); + return dmabuf->ops->mmap(dmabuf, vma); } =20 @@ -745,6 +769,8 @@ struct dma_buf *dma_buf_export(const struct dma_buf_exp= ort_info *exp_info) =20 __dma_buf_list_add(dmabuf); =20 + DMA_BUF_TRACE(trace_dma_buf_export, dmabuf); + return dmabuf; =20 err_dmabuf: @@ -768,10 +794,16 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_export, "DMA_BUF"); */ int dma_buf_fd(struct dma_buf *dmabuf, int flags) { + int fd; + if (!dmabuf || !dmabuf->file) return -EINVAL; =20 - return FD_ADD(flags, dmabuf->file); + fd =3D FD_ADD(flags, dmabuf->file); + if (fd >=3D 0) + DMA_BUF_TRACE(trace_dma_buf_fd, dmabuf, fd); + + return fd; } EXPORT_SYMBOL_NS_GPL(dma_buf_fd, "DMA_BUF"); =20 @@ -786,6 +818,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_fd, "DMA_BUF"); struct dma_buf *dma_buf_get(int fd) { struct file *file; + struct dma_buf *dmabuf; =20 file =3D fget(fd); =20 @@ -797,7 +830,11 @@ struct dma_buf *dma_buf_get(int fd) return ERR_PTR(-EINVAL); } =20 - return file->private_data; + dmabuf =3D file->private_data; + + DMA_BUF_TRACE(trace_dma_buf_get, dmabuf, fd); + + return dmabuf; } EXPORT_SYMBOL_NS_GPL(dma_buf_get, "DMA_BUF"); =20 @@ -817,6 +854,8 @@ void dma_buf_put(struct dma_buf *dmabuf) return; =20 fput(dmabuf->file); + + DMA_BUF_TRACE(trace_dma_buf_put, dmabuf); } EXPORT_SYMBOL_NS_GPL(dma_buf_put, "DMA_BUF"); =20 @@ -971,6 +1010,9 @@ dma_buf_dynamic_attach(struct dma_buf *dmabuf, struct = device *dev, list_add(&attach->node, &dmabuf->attachments); dma_resv_unlock(dmabuf->resv); =20 + DMA_BUF_TRACE(trace_dma_buf_dynamic_attach, dmabuf, attach, + dma_buf_attachment_is_dynamic(attach), dev); + return attach; =20 err_attach: @@ -1015,6 +1057,9 @@ void dma_buf_detach(struct dma_buf *dmabuf, struct dm= a_buf_attachment *attach) if (dmabuf->ops->detach) dmabuf->ops->detach(dmabuf, attach); =20 + DMA_BUF_TRACE(trace_dma_buf_detach, dmabuf, attach, + dma_buf_attachment_is_dynamic(attach), attach->dev); + kfree(attach); } EXPORT_SYMBOL_NS_GPL(dma_buf_detach, "DMA_BUF"); @@ -1480,6 +1525,8 @@ int dma_buf_mmap(struct dma_buf *dmabuf, struct vm_ar= ea_struct *vma, vma_set_file(vma, dmabuf->file); vma->vm_pgoff =3D pgoff; =20 + DMA_BUF_TRACE(trace_dma_buf_mmap, dmabuf); + return dmabuf->ops->mmap(dmabuf, vma); } EXPORT_SYMBOL_NS_GPL(dma_buf_mmap, "DMA_BUF"); diff --git a/include/trace/events/dma_buf.h b/include/trace/events/dma_buf.h new file mode 100644 index 000000000000..35f8140095f4 --- /dev/null +++ b/include/trace/events/dma_buf.h @@ -0,0 +1,157 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM dma_buf + +#if !defined(_TRACE_DMA_BUF_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_DMA_BUF_H + +#include +#include + +DECLARE_EVENT_CLASS(dma_buf, + + TP_PROTO(struct dma_buf *dmabuf), + + TP_ARGS(dmabuf), + + TP_STRUCT__entry( + __string(exp_name, dmabuf->exp_name) + __field(size_t, size) + __field(ino_t, ino) + ), + + TP_fast_assign( + __assign_str(exp_name); + __entry->size =3D dmabuf->size; + __entry->ino =3D dmabuf->file->f_inode->i_ino; + ), + + TP_printk("exp_name=3D%s size=3D%zu ino=3D%lu", + __get_str(exp_name), + __entry->size, + __entry->ino) +); + +DECLARE_EVENT_CLASS(dma_buf_attach_dev, + + TP_PROTO(struct dma_buf *dmabuf, struct dma_buf_attachment *attach, + bool is_dynamic, struct device *dev), + + TP_ARGS(dmabuf, attach, is_dynamic, dev), + + TP_STRUCT__entry( + __string(dev_name, dev_name(dev)) + __string(exp_name, dmabuf->exp_name) + __field(size_t, size) + __field(ino_t, ino) + __field(struct dma_buf_attachment *, attach) + __field(bool, is_dynamic) + ), + + TP_fast_assign( + __assign_str(dev_name); + __assign_str(exp_name); + __entry->size =3D dmabuf->size; + __entry->ino =3D dmabuf->file->f_inode->i_ino; + __entry->is_dynamic =3D is_dynamic; + __entry->attach =3D attach; + ), + + TP_printk("exp_name=3D%s size=3D%zu ino=3D%lu attachment:%p is_dynamic=3D= %d dev_name=3D%s", + __get_str(exp_name), + __entry->size, + __entry->ino, + __entry->attach, + __entry->is_dynamic, + __get_str(dev_name)) +); + +DECLARE_EVENT_CLASS(dma_buf_fd, + + TP_PROTO(struct dma_buf *dmabuf, int fd), + + TP_ARGS(dmabuf, fd), + + TP_STRUCT__entry( + __string(exp_name, dmabuf->exp_name) + __field(size_t, size) + __field(ino_t, ino) + __field(int, fd) + ), + + TP_fast_assign( + __assign_str(exp_name); + __entry->size =3D dmabuf->size; + __entry->ino =3D dmabuf->file->f_inode->i_ino; + __entry->fd =3D fd; + ), + + TP_printk("exp_name=3D%s size=3D%zu ino=3D%lu fd=3D%d", + __get_str(exp_name), + __entry->size, + __entry->ino, + __entry->fd) +); + +DEFINE_EVENT(dma_buf, dma_buf_export, + + TP_PROTO(struct dma_buf *dmabuf), + + TP_ARGS(dmabuf) +); + +DEFINE_EVENT(dma_buf, dma_buf_mmap_internal, + + TP_PROTO(struct dma_buf *dmabuf), + + TP_ARGS(dmabuf) +); + +DEFINE_EVENT(dma_buf, dma_buf_mmap, + + TP_PROTO(struct dma_buf *dmabuf), + + TP_ARGS(dmabuf) +); + +DEFINE_EVENT(dma_buf, dma_buf_put, + + TP_PROTO(struct dma_buf *dmabuf), + + TP_ARGS(dmabuf) +); + +DEFINE_EVENT(dma_buf_attach_dev, dma_buf_dynamic_attach, + + TP_PROTO(struct dma_buf *dmabuf, struct dma_buf_attachment *attach, + bool is_dynamic, struct device *dev), + + TP_ARGS(dmabuf, attach, is_dynamic, dev) +); + +DEFINE_EVENT(dma_buf_attach_dev, dma_buf_detach, + + TP_PROTO(struct dma_buf *dmabuf, struct dma_buf_attachment *attach, + bool is_dynamic, struct device *dev), + + TP_ARGS(dmabuf, attach, is_dynamic, dev) +); + +DEFINE_EVENT(dma_buf_fd, dma_buf_fd, + + TP_PROTO(struct dma_buf *dmabuf, int fd), + + TP_ARGS(dmabuf, fd) +); + +DEFINE_EVENT(dma_buf_fd, dma_buf_get, + + TP_PROTO(struct dma_buf *dmabuf, int fd), + + TP_ARGS(dmabuf, fd) +); + +#endif /* _TRACE_DMA_BUF_H */ + +/* This part must be outside protection */ +#include --=20 2.34.1