From nobody Sun Feb 8 07:14:32 2026 Received: from mail-yx1-f45.google.com (mail-yx1-f45.google.com [74.125.224.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32FFA26E6F0 for ; Thu, 18 Dec 2025 01:58:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766023082; cv=none; b=n9NGhZOg4f5SBqBKtOL8wL9Yy0xggKlcj8iW73UYn3jxXQ+MO4iGBc0/miEVPWeKmnX57P20ar5AOc/6xGqLvT20pUUHpcBmKASDFDXoMtDOX4KHLu3Ny7aPCJ9HYJ1hM4/f5gLQKjqKrZp3a9KbcQ5EdJoUGv9HPsIlCcDlCTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766023082; c=relaxed/simple; bh=m5Qk89Nat20MUzAln1BuVH2Y8Xvr1iPdN2DmGMoekxQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kSN24o41yQZGoSh9+R+vq+CmfbCMyU07qVbRkb3S4+J81BP1hOhQAbdlwjDibHMlF6KTzgQ+BDYIFhL8j3Au6y3r4sKwRkGLQQl/RN9TZ/jadYX88TomvJU+fYhPaCApAM4+xcw/VzsC8xzgGsOEDF8TSyaFCiKJSlBKEv+aQXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dqI3vwE8; arc=none smtp.client-ip=74.125.224.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dqI3vwE8" Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-6420c0cf4abso90069d50.1 for ; Wed, 17 Dec 2025 17:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766023080; x=1766627880; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bQOfmftLH8KAfTXHZBw4TB9dKu3rPCHujQ+Dm7h606A=; b=dqI3vwE8hzP9pjO43J98QNeZ81Py47Lo9X/O6ynZBnOUlIqp6ppvcV2HS8WQC3SH9X bXpEzYZ8stg3kwd5FNcM9Q11uHdzQaJZzbbQi71/JCRa46HMAByYGp6rko8OslE6PCqu GzsAR0wFptlDIwYyh5Exom85+wgrS7bWH0f8xlPPA4LK9GSjRBWvmzOjMtXUxVhBmGnh D619rva1Z6FnfRMkwh/0mYX0rSv+xlpnaGVpme3rgQkRhVKLHsAV2muI2yDI/+QKjn1j EtC8AXemEAHlGHizMH/XFteOtGbjBETmOE60Jc1RNZQQDct++PZUDSqq3bGYE1neiJbr QWUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766023080; x=1766627880; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bQOfmftLH8KAfTXHZBw4TB9dKu3rPCHujQ+Dm7h606A=; b=q6pxRu6Drs1htu5Ol+h5Riutt3kQhJPiC+rcUtUxHCC75BkjfFD2REK3tN79+1iNnx bIlL2gFtk2uQ31j/O3OZ59BUulsp7qUpQTgu+SI7nmu7WcIjg/5aX0K6i2FzEWK/AHnC vkSwtSO87L/M4vsrc4c0bZa9Qki5vlIjGEGraEwbVZtuHsbtR6i5MrKW46KVjVP+x25G 6t3VgkSBkMxNdslMkpKYV2M2lbk7IJBeIrKRCLc/qDFgrJ625gffPE+936Oxa3ez6ecB JbxliP7+vhRf3CXBg6Z4z3iAVxn1DKAqXAB5E5vCw+J0h0gM0hrbHE+26uykQk2xM+Xb yr/Q== X-Forwarded-Encrypted: i=1; AJvYcCW/tQDQ8dUC+yU/LH/0D8mS/vQetv7Dh/MNvcj4QWwpl1TtqmcAxT2arv7DWUCgtDmyymnmGAjQfdIhvrs=@vger.kernel.org X-Gm-Message-State: AOJu0YzD+vJOtH7b8b0v3Nz0CNta9FgdnTSnNx/BGfO/WA6GDBQI/wcs m2YXEJ8mrVuPA1QT91wdvGM2uezFvIjkttbN/2G1SfKWggFlcZ4ysy7n X-Gm-Gg: AY/fxX5LNnCKCBgcmHj6XKv8+fqIBT+nfBcjfKtccGQVdREmeyXRk0uBix9VgpYwp15 konXpI7u7uVPVJYbDz3rKuCztDAaeKwFMtrPo0FOFFZ+DK8zfJflFgl2tP7oP5scXGpgblC+uJU QrR5SCVTFAIOdDDIr8BPwA4kGF+5FA3VOGmKjASD1se/32m34sBN3ZtkHmKm2NSszHGhF+31N/2 QveQ3tPPkweucn/kLe5QNm6nYfbEc/8whmoU6s0gf9AAm/VdF/4xD4HB/xAFzEOSSZsI7LwReGj qux/sHcRHoUStOK2rQ0IXxIn861Uq6Nst2o7MNSGwiPmhQsQhDEIi4iuUxXtq0iw802SwCcVg62 qWdLiPC5kpsbRAwTx3cN6PGapKxnTDileMXii1w4jfyUCh1mEVm+7q5mUdNrn3mbqe4RRpxmyfd 9grVxnxsQ= X-Google-Smtp-Source: AGHT+IF7Lkwj0sSdZaNQ3dsB15WX1orUqF+lFaxr1wSODVAJtotITBD0kMje1L4hZ+gr1DxEnLMwlw== X-Received: by 2002:a05:690e:1407:b0:644:60d9:865a with SMTP id 956f58d0204a3-6455567d629mr14606696d50.93.1766023080117; Wed, 17 Dec 2025 17:58:00 -0800 (PST) Received: from localhost ([2601:346:0:79bd:52c0:aec0:bf15:a891]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-646636e86ccsm472527d50.5.2025.12.17.17.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 17:57:59 -0800 (PST) From: "Yury Norov (NVIDIA)" To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" , "Loktionov, Aleksandr" Subject: [PATCH v2] i40e: drop useless bitmap_weight() call in i40e_set_rxfh_fields() Date: Wed, 17 Dec 2025 20:57:57 -0500 Message-ID: <20251218015758.682498-1-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bitmap_weight() is O(N) and useless here, because the following for_each_set_bit() returns immediately in case of empty flow_pctypes. Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Simon Horman Tested-by: Rinitha S (A Contingent worker at Intel) --- v1: https://lore.kernel.org/all/20251216002852.334561-1-yury.norov@gmail.co= m/ v2: don't drop flow_id (Aleksandr). .../net/ethernet/intel/i40e/i40e_ethtool.c | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/e= thernet/intel/i40e/i40e_ethtool.c index f2c2646ea298..e64880b6b047 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -3637,6 +3637,7 @@ static int i40e_set_rxfh_fields(struct net_device *ne= tdev, ((u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1)) << 32); DECLARE_BITMAP(flow_pctypes, FLOW_PCTYPES_SIZE); u64 i_set, i_setc; + u8 flow_id; =20 bitmap_zero(flow_pctypes, FLOW_PCTYPES_SIZE); =20 @@ -3720,20 +3721,14 @@ static int i40e_set_rxfh_fields(struct net_device *= netdev, return -EINVAL; } =20 - if (bitmap_weight(flow_pctypes, FLOW_PCTYPES_SIZE)) { - u8 flow_id; + for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) { + i_setc =3D (u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id)) | + ((u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id)) << 32); + i_set =3D i40e_get_rss_hash_bits(&pf->hw, nfc, i_setc); =20 - for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) { - i_setc =3D (u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id)) | - ((u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id)) << 32); - i_set =3D i40e_get_rss_hash_bits(&pf->hw, nfc, i_setc); - - i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id), - (u32)i_set); - i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id), - (u32)(i_set >> 32)); - hena |=3D BIT_ULL(flow_id); - } + i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id), (u32)i_set); + i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id), (u32)(i_set >> 3= 2)); + hena |=3D BIT_ULL(flow_id); } =20 i40e_write_rx_ctl(hw, I40E_PFQF_HENA(0), (u32)hena); --=20 2.43.0