From nobody Mon Feb 9 04:23:48 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8DA0242D67; Thu, 18 Dec 2025 01:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020459; cv=none; b=pw7BB5bMebmZOtMPaRubYfQzFSm+rNF6galmR5Go+oQhK9mL9uQAIp+EPMlMuejqScS9zS/5KoSNv5k7BlipCSLP8RBjkWM9k5FOg7oLIicHOM2g65YVw6gI0jGQnY6FMuJHB4fmdMdKDYljZuURbuWJzCPBjrnkBgVlKe2gYh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020459; c=relaxed/simple; bh=Mtlnram453y6WA9ocfNmMifofZaA1DQlSyXwXqaf6lw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r7UIRZ26sqUmyfQDY+NiLjT8CMNEYuY8MiKI7yaJC1okMQEFAyOIaxtkckFgXc41g3QznS9RaeFSYL1bFLuv/xQM4EXZakrIgJRn7JV+ZbdIvGf1WV1eibxaUdw7Ms1kkwR/mFQxUo+mCdxo27otDgc9e5GIJB1KKhV4iXsSEFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=QdUAz1BP; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="QdUAz1BP" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BI167bK4029723; Thu, 18 Dec 2025 01:14:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=9q99h +NETPzLq7590X9pwbBXqoBjjg6nivenp0WZwTw=; b=QdUAz1BPQ6K/O0Z0nhWj3 Tyd0BaveFUBcrKLeNfgQ/6FjRuzDd9Y71dDfMfZwP8WTd8r5hUqgYq9KFkOSbJpz G8r3+5o2MHcHCKOYTUCCjZu27I7A+FRPT+JvExS7rneQFKwvSle2CbQIFLXHoqDb B2muxDtv/ChDbIriFpPiy4J3mZlU+/azwGOHiaKjMItvoVMxNPomcYF5srYDxIZF gCLZnT8yPrPk/UcSffjszEtSuOL3rSixNoegrt3N8PD8V+B2zjyykn8ArpoqPYnx JMFhrN8ch4nDzhyONm2AhZMjLS+VmfBT2+OqUUwSDT6O+pL/0i/od1ObKNuQZ+FV w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4b47n8804s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Dec 2025 01:14:16 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BI195XQ025249; Thu, 18 Dec 2025 01:14:15 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4b0xkcgjna-2; Thu, 18 Dec 2025 01:14:15 +0000 From: Samasth Norway Ananda To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] staging: rtl8723bs: fix firmware memory leak on error path Date: Wed, 17 Dec 2025 17:14:11 -0800 Message-ID: <20251218011414.1781294-2-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> References: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512180007 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDAwNyBTYWx0ZWRfX7C0ZTAtmDWpL D3NX1T5uUEghLgcA04o0K28oOTDnEXYGBc0qF287tuDZWIHWvLNTTy4r91DOX0PO5Q/GNwuUcSR AUtTSnQYD/qwTQGtF1DHT8SSmZPO4t9jKON3sX86WNvDMnYB36KMykZjgD3f1abcgMpg3rU/V9s ETTlhWYezeh1CSCRKisFcsG6yCwTo3WxXEONXGWPUJm/UNVMbTnj4fnOQVB1fdfaTfSCDCFow9H qBY3F/Qk1tgZYvQ3JAxRmA4cVdnTZnZoQJ8GM5lB6/6TA6Xl0xfT22jANniqvj6KQLYcwFfbTKp sGspn/3ag+YDTgHOLf0o91GvIN5DgZsmiSyKAY5qnBnuncy99+A5+2Y00/N4GgKJL1WmcKGlLi3 GwCEl+7yJhlvFOYPBajm5KoTI9N5+Q== X-Proofpoint-ORIG-GUID: DnhdTG5w4TesJaVGKWkucoR8Jl9g_XLD X-Authority-Analysis: v=2.4 cv=Vq0uwu2n c=1 sm=1 tr=0 ts=69435568 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=4FbwR8H0EwRVJbgSqfIA:9 X-Proofpoint-GUID: DnhdTG5w4TesJaVGKWkucoR8Jl9g_XLD Content-Type: text/plain; charset="utf-8" Fix memory leak where firmware is not released on error paths in rtl8723b_FirmwareDownload(). After successfully calling request_firmware(), if the firmware size check fails or if kmemdup() fails, the code jumps to the exit label without calling release_firmware(), causing a memory leak. Add a release_fw label to properly free the firmware in these er:qror cases. Also add an error message when firmware size exceeds the limit to help with debugging. Signed-off-by: Samasth Norway Ananda --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..0eae624a36f0 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -345,14 +345,16 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapte= r, bool bUsedWoWLANFw) } =20 if (fw->size > FW_8723B_SIZE) { + pr_err("Firmware size exceed, max: %d, actual: %zu\n", + FW_8723B_SIZE, fw->size); rtStatus =3D _FAIL; - goto exit; + goto release_fw; } =20 pFirmware->fw_buffer_sz =3D kmemdup(fw->data, fw->size, GFP_KERNEL); if (!pFirmware->fw_buffer_sz) { rtStatus =3D _FAIL; - goto exit; + goto release_fw; } =20 pFirmware->fw_length =3D fw->size; @@ -415,6 +417,10 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter= , bool bUsedWoWLANFw) goto fwdl_stat; =20 fwdl_stat: + goto exit; + +release_fw: + release_firmware(fw); =20 exit: kfree(pFirmware->fw_buffer_sz); --=20 2.50.1 From nobody Mon Feb 9 04:23:48 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF3D6203710; Thu, 18 Dec 2025 01:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020459; cv=none; b=hajQSKtN+VA1kFjLOnYdGb31/TYZEs6Y24P69HD+J3JbbK7P61HAOb4r5NU24Ce3GRUpHIAdiLNr3jdtvylLzQNaNPpFYirkhedWugyAwBx3Pqwuv/qlKLxZQD5jK4Bjx5FI9RfFfekfCLyZsFWLYi0yUv/P5I+XGwVuhEen6FA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020459; c=relaxed/simple; bh=VBj320qmqVsfLUVJZAnB9NZzs9AlQ43D/LLGRmiSRC8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hk8Ux8g2ayphSfqCWKDPCfzLPQbH8t8B0tVNrXlGrdLnENZ0qi5zbMYhdFjFnfJ2Cvi4ZZTfH74M7a04FHkmEpYKgcPyU30n3PvwlZz5iXQte6/plgLs4zslL7ueC7uPcFjQR/4mB1HCm0PgJrqd1PpS3UNjuamv4n8H/SWUo+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=lR3b9oLp; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="lR3b9oLp" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHMNhhf4168326; Thu, 18 Dec 2025 01:14:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=LNqgl OVP8MzBxBpMF887kypIoX7uGBh7w+0vOnNA158=; b=lR3b9oLpD20Xvb3j9msv7 S6PNQoeXpqwRWCjex3yQ6C8LkDsbu2qd5E3SBqRSfytFc4b6khEs9Vfq7LYZJ0yO 3nu1i4GgCo9UiFUaoXmM1ijyiaxsJtnFCeMYpfaNawVqKl/SLqG7Dh+JgvwtgUwX XY+ow/mjYhJf/3hG7NGgD3sSv/Hg1PJBGFko6/UEYJlmE1mQluFO6VtgTfPzR6ZW qWputzeaG6zzKeKDJ72Zlu2a9qNbl7ySj/WjFzEjTAuCPPCKQauLCCLqWU6zt6/c i/d0Fgnu20U/6EHQA4tUqm5cPimKqdstBihchM4zoI5ZNgQ0Hdt2zwqiI5b2h3nl Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4b0y28f4gu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Dec 2025 01:14:16 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BI195XR025249; Thu, 18 Dec 2025 01:14:15 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4b0xkcgjna-3; Thu, 18 Dec 2025 01:14:15 +0000 From: Samasth Norway Ananda To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] staging: rtl8723bs: fix memory leak in rtw_cfg80211_inform_bss() Date: Wed, 17 Dec 2025 17:14:12 -0800 Message-ID: <20251218011414.1781294-3-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> References: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512180007 X-Proofpoint-GUID: S_JyHXCbFSaMQRagAmVG0HQupwsheTX9 X-Proofpoint-ORIG-GUID: S_JyHXCbFSaMQRagAmVG0HQupwsheTX9 X-Authority-Analysis: v=2.4 cv=fOQ0HJae c=1 sm=1 tr=0 ts=69435568 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=lX7pHSL-l9_-PgaVgB0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDAwNyBTYWx0ZWRfX2m/auvf68heD 5VOjR+BGF16o6EFPSYkYJBo4VY56gFHDHHspsjaJd6WaJb6Fqp2DHY4u5if4R1P4BiBeEUy+sSC Z9bKulsIMGypxAW8NLAa1B/dEzVnAQ5iubAOJ4oqSY4aQbb0vJ5hYp/g8VViaLfYCAwE1YO+34+ LhEkwh6PMXs15N0tb6WhF5AZb4iwqXJxJjXaYypVU2ZrIGxnlLa5N6xiOWaWI8A1YWOSF1aco75 PVW3PyJ970+m9FrXzRIpee3r9l2VrlDUBNOqBdaUDZbquBb77+59HWZKZZhwN0yVpoP1JbCrg0x bliSDfdw+v0ztsUnboZVMKtlBQv9uwnBEYgjFZWbPIk45l+ArF2uBMJkVxirGa74NEv26isq6y3 eEsY/D+hDONU23Dz3uXnqSW6A3Qs+A== Content-Type: text/plain; charset="utf-8" Fix memory leak in rtw_cfg80211_inform_bss() where the allocated buffer is not freed when cfg80211_inform_bss_frame() fails. After successfully allocating buf with kzalloc(), if cfg80211_inform_bss_frame() returns NULL, the code jumps to the exit label without freeing buf, causing a memory leak. Add kfree(buf) before the goto to properly free the buffer in this error case. Signed-off-by: Samasth Norway Ananda --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 60edeae1cffe..d80e23cfdf8d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -314,8 +314,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ad= apter *padapter, struct wl bss =3D cfg80211_inform_bss_frame(wiphy, notify_channel, (struct ieee8021= 1_mgmt *)buf, len, notify_signal, GFP_ATOMIC); =20 - if (unlikely(!bss)) + if (unlikely(!bss)) { + kfree(buf); goto exit; + } =20 cfg80211_put_bss(wiphy, bss); kfree(buf); --=20 2.50.1 From nobody Mon Feb 9 04:23:48 2026 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8002E243964; Thu, 18 Dec 2025 01:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020460; cv=none; b=Kk6IUFpa0GE5vCKWOSHwLh8mkGtMOPgEDmpjNDi/vcxBw3xMKoYmYLKN1ejME5qy42GpbkM0+dp7Jn3jl72kVJ2dZN9KyvSTyci+JkXEEKG08P89oyn/wg2JvJWcrp9qAluPzGAvZP8+N1cUz9/YWsf8xPatD+ICTLgnlgr3x3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020460; c=relaxed/simple; bh=DZmkBNn6fSAwHA+H+NQD/JFYsApKp1J7LL9Y/JmxmPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OE85Ymt8vtCz4VndWKgvAcs60QDcUGEzO0CvGcbT59AMbydf/XWutXQNeRWLkRTCjnY0YyXUV11qO1t+qjZiN8lDb9DfeXPqBuVmgyNcWBoAzD8x8DPLRoD39qCst55Ds27KnxVBHCjbhVrI8m9ePqh47Y0EP7afajJkb8HuWjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=A1Bsns1o; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="A1Bsns1o" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHMNWkQ3626095; Thu, 18 Dec 2025 01:14:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=Autse 1JLYzzWPXq5qspQlHSixczYzbnfZMa6hV0R9p4=; b=A1Bsns1oric49jcHlwwm9 Lc6fUrECwJ7RVky+WuYz8yOFm/CbuLFlCUCQ4lxcZ4afXE4aWOQ7nfmAFtIyLDf7 g28Us7FzlorIqrK7Kl8FvCf1L1VHbUxzowUlXg+RbYp/A2X0L8aSd71dPaxwg+mt MPwMA2MnOG18EjescbCsYcDN6n/8eJGju3cp9zTtKKVtQjHFmixFT74ETKFgLph1 usCArBkJCxCQbP2l42tEXNQ7IXxiO//emdygN56fyzTUjTPCmO0nK+LaxmZEJhif TVI9dauO1kJiE4iNX3tUQd9mYObIJELatOBTXWcM2JKvVWBg8InLiGfLrm0gkCdY g== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4b3xa2s5ce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Dec 2025 01:14:16 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BI195XS025249; Thu, 18 Dec 2025 01:14:16 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4b0xkcgjna-4; Thu, 18 Dec 2025 01:14:16 +0000 From: Samasth Norway Ananda To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] staging: rtl8723bs: add IS_ERR() check for kthread_run() Date: Wed, 17 Dec 2025 17:14:13 -0800 Message-ID: <20251218011414.1781294-4-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> References: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512180007 X-Authority-Analysis: v=2.4 cv=Ot5CCi/t c=1 sm=1 tr=0 ts=69435568 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=CcIRm4YFBE7ShbI5ndQA:9 X-Proofpoint-GUID: _TpnEyStYMmGijHgffcw7HxLHN1BajSq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDAwNyBTYWx0ZWRfX5Y+4gbvp4W9q Nx+liDcFAzzIRFVaYRykO/i3H0J0RRYY9+Z4B3D2+QFGonjw5yhL+XHnAdfjYkpDECVbvz233bu ZlcSfzSMQJpHraGVIfYRU27cStbtXK+lDoY88FYTcj+luNTD2GBDrNOe7sDeMOZ1iPx5YqPkBPu /YFGTLderQQHvj4wGve22Wi1Q01RCfvuLwpLFoQaAHNTGtjvw3+ytAM9T/AhGZ5qyf53vNj7Zk/ rjETl60Yu9yxqPiurlIuwvKvMn+WMWakIx0Wq9iooKVz3vMZmyTR7dU9+jTGOyH48XPgFbs7B9y AUK+bZ8+nTE4vBWzYWhTUGXyBfiTuPOLjNI9rIeFVKsROpJ3hK8EASXFhpDH5Rh6W31H+o5Rm9f XymFbVKj9ny7WXd9F5FuyedNJ0SOmA== X-Proofpoint-ORIG-GUID: _TpnEyStYMmGijHgffcw7HxLHN1BajSq Content-Type: text/plain; charset="utf-8" Add missing error check for kthread_run() in rtl8723b_start_thread(). kthread_run() returns an ERR_PTR on failure, not NULL. Without this check, rtl8723b_stop_thread() would later check "if (xmitpriv->SdioXmitThread)" which evaluates to true for error pointers, potentially causing issues when trying to complete or wait on an invalid thread. This follows the same pattern used elsewhere in the driver, such as in os_dep/os_intfs.c where IS_ERR() is properly checked after kthread_run() calls. Signed-off-by: Samasth Norway Ananda --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 0eae624a36f0..88ea3518bb67 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2926,6 +2926,8 @@ void rtl8723b_start_thread(struct adapter *padapter) struct xmit_priv *xmitpriv =3D &padapter->xmitpriv; =20 xmitpriv->SdioXmitThread =3D kthread_run(rtl8723bs_xmit_thread, padapter,= "RTWHALXT"); + if (IS_ERR(xmitpriv->SdioXmitThread)) + xmitpriv->SdioXmitThread =3D NULL; } =20 void rtl8723b_stop_thread(struct adapter *padapter) --=20 2.50.1 From nobody Mon Feb 9 04:23:49 2026 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C34324E4A1; Thu, 18 Dec 2025 01:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020460; cv=none; b=sqXfU0jruhSLf1zJjZ2qkFD+ANrzsOJyv4rglIUTDNpKAeUr1TCqKIEJOOBAGaBKTgnnEztucCAZGiAaTANeK+m656KLpjUgM9mXm3jPm0fnaTFDzAWOEzwxDdJja1TyLHAdmLeLFxOWe3VfskppQfHQjJrH4xtBnc+Cv4yygBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766020460; c=relaxed/simple; bh=4WdQ3QYIh2wIde1SJw5zV5Do5NFve00rX6yvj4+J1PQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GWd8WXszZ3Yq1l07OwlQ/EHNgo6l6ZfScuHx/R7hbl2Q+9xwhpfPUOMJp81fQLUCIspp0XLTMVwhZIiWTxJBT2IwnDLgNgmLyQHtOhQjNciWhVdT6GG2fXMrIC2cvud6zCz+siKZw/t32O2LmD2KCEPz9sRbt0XQsxhKINed4bI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=qhu5m7uj; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qhu5m7uj" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BI0hota3962311; Thu, 18 Dec 2025 01:14:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=THeIB JbrIQAufq9OFTrVIJ6Ek1ACjjoTDcEziBQzwZ8=; b=qhu5m7ujp23gv1bHHdbtz khduE7AYr/YNoIqscbH49Gf7ExiQm5tzcFwjOQrkxZBSgLK00eI/tk8weET85rsD E1zEc+GWH8OhA1J+5mBuAmGn8hYPF7I7seje1IlDNoGMPGWK9MbUd44mtn2BbQub fJDDwXKYa79L0armUCIO0+xyO8KJ5TONI8ck/WFJg/Ek87cwlg6u049LDqrWKi/I 7vWhQo6SM98Bw6otAOwLzAU8BRyt8+IWZ0VqMSrhdzHSxdNRPCFKXjUUI8gPColl Nud1MIgcOfA8u6XFZBG7aj56zL4Y/Gn3OL6jmIGkHrXzM7jCYX1UmZdgxvOzjMO4 A== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4b47ay80n7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Dec 2025 01:14:17 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5BI195XT025249; Thu, 18 Dec 2025 01:14:16 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.129.136.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4b0xkcgjna-5; Thu, 18 Dec 2025 01:14:16 +0000 From: Samasth Norway Ananda To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] staging: rtl8723bs: check return value of rtw_wdev_alloc() Date: Wed, 17 Dec 2025 17:14:14 -0800 Message-ID: <20251218011414.1781294-5-samasth.norway.ananda@oracle.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> References: <20251218011414.1781294-1-samasth.norway.ananda@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512180007 X-Authority-Analysis: v=2.4 cv=foDRpV4f c=1 sm=1 tr=0 ts=69435569 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=wP3pNCr1ah4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=QIGcSY2F6k5Ja1lceT8A:9 X-Proofpoint-GUID: -9fEAfGlRAETNy1bmics1gQKn6CaPJXh X-Proofpoint-ORIG-GUID: -9fEAfGlRAETNy1bmics1gQKn6CaPJXh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDAwNyBTYWx0ZWRfXzrfejlvWgywb eXWi8gxyoW0qX99iohZQVlE6MNGTmJml8ZQBoJ7WYQ74vweSJhsnw/ZZB6Nsmg63EYE+Tbwb8lo ObnC5ou5QCF6ChzlzQ+XsgYijKM44JpzubWzFTTDkFotMqhI8J5HyGQyQI3vTd3jDZ3QpMFqZPy MEuWZrUSY54BRh79M/A0Fu41sIrVF8Jb3OHE1PzzZ+y9/KQNpBORgaBAWsl9y9/do4oRV3yltvH x9ql1ccGxjaG7XF/nBePk492MdLxW+IDK1jGx2pgr/qVPa9Fzh7UQ5xSsXkAb2bFWHQVxl3x7lr I8xisBJOI8wx3Dxr5E1xgg9J8SePEjj19/dD0OgUZFveoDPurG7aV/GvUL8DX4ocN6PDgSIl204 daxJqY/3DTk2CRt7XLZMPvbBEMfsig== Content-Type: text/plain; charset="utf-8" Add missing error check for rtw_wdev_alloc() in rtw_sdio_if1_init(). rtw_wdev_alloc() can fail with -ENOMEM when wiphy_new() or rtw_zmalloc() fails, or with other negative error codes when wiphy_register() fails. Without checking the return value, initialization continues even when wireless device allocation fails, potentially leaving the adapter in an inconsistent state. Jump to the error cleanup path when rtw_wdev_alloc() fails to ensure proper resource cleanup and prevent use of an incompletely initialized adapter. Signed-off-by: Samasth Norway Ananda --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 1d0239eef114..432bc6aa1d90 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -296,7 +296,8 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_p= riv *dvobj, const struct if (rtw_init_drv_sw(padapter) =3D=3D _FAIL) goto free_hal_data; =20 - rtw_wdev_alloc(padapter, dvobj_to_dev(dvobj)); + if (rtw_wdev_alloc(padapter, dvobj_to_dev(dvobj))) + goto free_hal_data; =20 /* 3 8. get WLan MAC address */ /* set mac addr */ --=20 2.50.1