From nobody Sun Feb 8 20:59:11 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2167F33C533 for ; Thu, 18 Dec 2025 13:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064414; cv=none; b=b1ktOVCFsuwEIlYo3rr2OlLkZEDmpvHjbVp8a0/CfHSQWS3bi85NTW6ZisoCZB/z3uSP8RNNZyOue+IFTcdaSe3AdlutiKKH0O7jUZpN8LMy9/HD1277PJPjqGFS4bwyD226XwYuayCkoneuhq43hU2vAVrrrbzy7opOwUkvTBI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064414; c=relaxed/simple; bh=6+fNHOwf5B3Mr/H+++1aDzYmBahYT1JXyEW9NioMyYc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=REtglCUxncdPqHEofo3jo0/iBeZ+ICI+Gkc/YRsfL4Pzv1B2W1XFrXUzGbMDnSjM0dPqtNBob+WIcSRaO0pvwqw1R+iLqFcptRsCWmghejfFIP2WZ9S+7tPT8n3/NWeGQpcasNB3IqU8cxL9XhQyGF4CKQUTtBylaOdMwlA4Czg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=Q+CDFesK; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Q+CDFesK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1766064411; x=1797600411; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=6+fNHOwf5B3Mr/H+++1aDzYmBahYT1JXyEW9NioMyYc=; b=Q+CDFesK+3iDmJldB8xHuduPt/DjXcW64xUewjdm7PowdGVREAZ2pKXr Ag02ID5M9Mye3mVEZGrXfGQY4HC8S7R2w8KvcQCdJv/pgvUbSRFgfrrVS TAluCReQLxxMAy5tqWHlQz+C5KmmWXPVFRj9Zz54rtaVDz5czhDlzgHSl LZkUjppilye/XFgM64V66cez1dbQLDWMJdvzu6nL8o/hes0z9693eyfJp rVqioDrnpPZFLwzFaEG+a+tlPgVN0l6MG+Bf1proUanJTWylbHVtU9fFX J8ha07rjq3ZnLxzXZvSL0GLHUgMqNnl7kK+cIty2Du0uDqGu7wcYOTKoj A==; X-CSE-ConnectionGUID: 2/lmXmCJRTiQR6o8m97H0g== X-CSE-MsgGUID: HoMX2EtATVqNcLM7kPIctg== X-IronPort-AV: E=Sophos;i="6.21,158,1763449200"; d="scan'208";a="218051103" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2025 06:26:48 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex3.mchp-main.com (10.10.87.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Thu, 18 Dec 2025 06:26:39 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Thu, 18 Dec 2025 06:26:36 -0700 From: Ludovic Desroches Date: Thu, 18 Dec 2025 14:26:05 +0100 Subject: [PATCH v2 7/8] drm/atmel-hlcdc: use drmm_universal_plane_alloc() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251218-lcd_cleanup_mainline-v2-7-df837aba878f@microchip.com> References: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> In-Reply-To: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2406; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=6+fNHOwf5B3Mr/H+++1aDzYmBahYT1JXyEW9NioMyYc=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpRADxJCeXN8wMoRK2QGik2s1K3uFzsLStzA6lP /4JG0ZMm5iJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaUQA8QAKCRA+OeYT93tk LWPOD/9cwXbDaLa7/EexwyQcOYwedjwilzyuTyYKw0vMYSwVRe4hQEk/FOlSLaM7y+CY5YttyrH CCS5vcLriLlQdpugbtCa+Q4MuTRFDEV70QQk/qYLf57xXrfnE7kn3qZN7xTwaLpWC2rCdz52wFG /7oGvkHjwirMPQZUOoG2C+vB4BDDmtNjMIJq4zQmY2e7n2lK4taKwWuCRObnjww0vJsZGLEfmhu LdaEGmVzWz/3YHD8PzfmhxKIjN2V9OgIP8lNTpqCdpBA6cmct4Pc/Li5Uzk8dYVIx4xng939wBf dt+9Bb42/HeYbsgl1PefiwY4tk203PSAa95KrmkjuaTUT2jmfPbGHDqY39UBHcAVh+DmCCME7XB aP1rW71Dc2Ws8Ngz3wDtGS5qeiVhDA0ja5A1ddtSWLcGkrZ6rycBr7PYxmpNuIZxNECV2tFAusT o7ad5MEMpl6s8iqDjqGbe8Zz+x3KAyX5/oIwSqIdCkQosAPu44lcsNtOTEhR3zct4hRyH9O27mi kWlLivDekNnE09Gku1IVp1q2IpQuMaQ/tI5Pg1Y7o1kkGjd9u5ox/ZgibeOoKEuHa+NIs9NLK5v DKgGgveipKautIMsUIkKwvRUho9pEdWCNUv9q+9RIWvtlMaJxpzodwkgUDFwiJcB0U4VWUD+h2a /1E1MVDS0p8joOw== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Use the drmm_universal_plane_alloc() helper to simplify the code. Using it, we no longer need to register the destroy callback for drm_plane_funcs. Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/= drm/atmel-hlcdc/atmel_hlcdc_plane.c index 92132be9823f1e705d266f9547702ea9530bd043..c1f3aaae29fb9f6b947f81e2fb4= e7a61e10ac5d9 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -1225,7 +1225,6 @@ static void atmel_hlcdc_plane_atomic_destroy_state(st= ruct drm_plane *p, static const struct drm_plane_funcs layer_plane_funcs =3D { .update_plane =3D drm_atomic_helper_update_plane, .disable_plane =3D drm_atomic_helper_disable_plane, - .destroy =3D drm_plane_cleanup, .reset =3D atmel_hlcdc_plane_reset, .atomic_duplicate_state =3D atmel_hlcdc_plane_atomic_duplicate_state, .atomic_destroy_state =3D atmel_hlcdc_plane_atomic_destroy_state, @@ -1239,12 +1238,6 @@ static int atmel_hlcdc_plane_create(struct drm_devic= e *dev, enum drm_plane_type type; int ret; =20 - plane =3D devm_kzalloc(dev->dev, sizeof(*plane), GFP_KERNEL); - if (!plane) - return -ENOMEM; - - atmel_hlcdc_layer_init(&plane->layer, desc, dc->hlcdc->regmap); - if (desc->type =3D=3D ATMEL_HLCDC_BASE_LAYER) type =3D DRM_PLANE_TYPE_PRIMARY; else if (desc->type =3D=3D ATMEL_HLCDC_CURSOR_LAYER) @@ -1252,13 +1245,13 @@ static int atmel_hlcdc_plane_create(struct drm_devi= ce *dev, else type =3D DRM_PLANE_TYPE_OVERLAY; =20 - ret =3D drm_universal_plane_init(dev, &plane->base, 0, - &layer_plane_funcs, - desc->formats->formats, - desc->formats->nformats, - NULL, type, NULL); - if (ret) - return ret; + plane =3D drmm_universal_plane_alloc(dev, struct atmel_hlcdc_plane, base,= 0, + &layer_plane_funcs, desc->formats->formats, + desc->formats->nformats, NULL, type, NULL); + if (IS_ERR(plane)) + return PTR_ERR(plane); + + atmel_hlcdc_layer_init(&plane->layer, desc, dc->hlcdc->regmap); =20 drm_plane_helper_add(&plane->base, &atmel_hlcdc_layer_plane_helper_funcs); --=20 2.51.0