From nobody Sun Feb 8 21:06:08 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6AFE33B6D5 for ; Thu, 18 Dec 2025 13:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064414; cv=none; b=LlIP1CGiyyFz3TIBEMiMQQTTXuACRE5MCgw5+pu8chhbbQbJzXXx1T/9O2Httg/tIEwn0PMFdXuyNK6ktT3ej1UzirxvUM46JJytbGAdKTEaDYeeYU3cwhi1ktIaKM1lJwrogTXLcFc4M2xF2LzI+T4tEDqqCce/+BC5pomcfqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064414; c=relaxed/simple; bh=H4lz9IzPucH+8/psNxpuZMlk/rvyrt76Wj+dwW/qyMk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=sXle50EOpUQxg1Ed6lWj4wwKw3p6pcIK67dG2z1nfWR0SrDG1Xr7c7ccjUU9bpFifVBVzHE1N4cLZi+QBavHsIGJXGRYEq7uxvQD4mPk+HE6OLh7wrrxyCjJW47Im828bOdLk3TI98ednMYPtY7+TZYaylpiedTM9LN3l2fetgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=kDVRQZf1; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="kDVRQZf1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1766064411; x=1797600411; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=H4lz9IzPucH+8/psNxpuZMlk/rvyrt76Wj+dwW/qyMk=; b=kDVRQZf1m7HD9A9Y4qzMa+u+T9iprp4kkFBMKflVzmac/R9HqunaAGHu Ke8o82RLNeULLXq31ylbN99QqK1eSPvFsk3GF2+QUH3aJofx0EH3n5uZ3 24k0lNANz+oNPX7Ea/P5AtiLHqHH+C0nReCzLIdgSV8rvlqWUmaDfBHFh 0H80G7IA7xEDZhTmieqXeUSSmUv8C1YwuMVxMIn9O2sSJpgBlrdHzt204 FaIAKm8TnIg+HspAka27+vMpyCo83g6VCDd8BfuQmbCojLP1lXHGrctmR PGM0x8v2rLmUMBFSqdntJPB4nWw7Koaa1GAhz9Y84eUU6EzacH0H6ny5g Q==; X-CSE-ConnectionGUID: 2/lmXmCJRTiQR6o8m97H0g== X-CSE-MsgGUID: 2G7U0F7qSrejLDKfYF/h8A== X-IronPort-AV: E=Sophos;i="6.21,158,1763449200"; d="scan'208";a="218051102" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2025 06:26:48 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex3.mchp-main.com (10.10.87.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Thu, 18 Dec 2025 06:26:35 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Thu, 18 Dec 2025 06:26:32 -0700 From: Ludovic Desroches Date: Thu, 18 Dec 2025 14:26:04 +0100 Subject: [PATCH v2 6/8] drm/atmel-hlcdc: use drmm_crtc_alloc_with_planes() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251218-lcd_cleanup_mainline-v2-6-df837aba878f@microchip.com> References: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> In-Reply-To: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2868; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=H4lz9IzPucH+8/psNxpuZMlk/rvyrt76Wj+dwW/qyMk=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpRADxtrpSY4xe5mXFiCi30OuU2WXVgrLPk8OV2 2OPMMOSKyKJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaUQA8QAKCRA+OeYT93tk LS3ND/0WWZx3nxRsawY1DkE7jRoOUUN9YS7ELjs0+OXTRGywegRnTNxx9PDlorjWA9qpiaIDnM2 bZS3LTTByn30RYHLRCoHLYCxK2aCN9Hy8iPKH6qGZ4u9HsG1e0DR5uBQr2ngbrHhuwjDoLlnFLc +H+XDUI8ggRHJXA16QriEj1/vT8W8lvzNkRPxXdBEiSujA2CTIgPDtX5Jj4ON4rj1DaqhRz/3Vh AyHd/eIGMS1KMSi8j5ME9KePibIcgldjFKR1sBFys8r2+LguNCRHhUgUZd/nKpjj6d/E4safDlq d2KHXZ6JGUznJkPqItiQlxKvkeHsMldXFxf9lyh884DojJEw7zkhStqUiH75f7N5UbLzzqNJcuF l9ssCUXhjpL8JFUTSUYUAARKgkxtOsVfwAi9V0ByDYNnO6sQ92smGhg11kQrqjcneBsFfEnzw/J rjyZywV5vLfeDeNWHJtCvfuy71l6zOMEXO4smycWRRdb9hWMXSEirB67MoKRluuhfSOdZi575JR gbt7E03+4p1q1syjxwXn92+bNW6r6uP6CIxaLukqydURO+lk4+yvkzMdSXUc9haE+0xYGvQ6PsY 7+l43whavLtaoTgWLaHLumQQbyNsq0U7QHrnQ2FyNkImC1UwPR+ctZm+uVaV3fmzSfCAx24a5ji uQH7dRrOckQKwNg== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Use drmm_crtc_alloc_with_planes() to simplify the code. As we no longer have to take care about cleanup, we can get rid of atmel_hlcdc_crtc_destroy(). Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 32 +++++-----------------= ---- 1 file changed, 6 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_crtc.c index e0efc7309b1b256520eff29462431476f8589255..b075f291847f9eb91e07b784438= 2871f38ed5f81 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -509,14 +509,6 @@ static const struct drm_crtc_helper_funcs lcdc_crtc_he= lper_funcs =3D { .atomic_disable =3D atmel_hlcdc_crtc_atomic_disable, }; =20 -static void atmel_hlcdc_crtc_destroy(struct drm_crtc *c) -{ - struct atmel_hlcdc_crtc *crtc =3D drm_crtc_to_atmel_hlcdc_crtc(c); - - drm_crtc_cleanup(c); - kfree(crtc); -} - static void atmel_hlcdc_crtc_finish_page_flip(struct atmel_hlcdc_crtc *crt= c) { struct drm_device *dev =3D crtc->base.dev; @@ -607,7 +599,6 @@ static void atmel_hlcdc_crtc_disable_vblank(struct drm_= crtc *c) static const struct drm_crtc_funcs atmel_hlcdc_crtc_funcs =3D { .page_flip =3D drm_atomic_helper_page_flip, .set_config =3D drm_atomic_helper_set_config, - .destroy =3D atmel_hlcdc_crtc_destroy, .reset =3D atmel_hlcdc_crtc_reset, .atomic_duplicate_state =3D atmel_hlcdc_crtc_duplicate_state, .atomic_destroy_state =3D atmel_hlcdc_crtc_destroy_state, @@ -620,15 +611,8 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev) struct atmel_hlcdc_plane *primary =3D NULL, *cursor =3D NULL; struct atmel_hlcdc_dc *dc =3D dev->dev_private; struct atmel_hlcdc_crtc *crtc; - int ret; int i; =20 - crtc =3D kzalloc(sizeof(*crtc), GFP_KERNEL); - if (!crtc) - return -ENOMEM; - - crtc->dc =3D dc; - for (i =3D 0; i < ATMEL_HLCDC_MAX_LAYERS; i++) { if (!dc->layers[i]) continue; @@ -646,13 +630,13 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev) break; } } + crtc =3D drmm_crtc_alloc_with_planes(dev, struct atmel_hlcdc_crtc, base, + &primary->base, &cursor->base, &atmel_hlcdc_crtc_funcs, + NULL); + if (IS_ERR(crtc)) + return PTR_ERR(crtc); =20 - ret =3D drm_crtc_init_with_planes(dev, &crtc->base, &primary->base, - &cursor->base, &atmel_hlcdc_crtc_funcs, - NULL); - if (ret < 0) - goto fail; - + crtc->dc =3D dc; crtc->id =3D drm_crtc_index(&crtc->base); =20 for (i =3D 0; i < ATMEL_HLCDC_MAX_LAYERS; i++) { @@ -674,8 +658,4 @@ int atmel_hlcdc_crtc_create(struct drm_device *dev) dc->crtc =3D &crtc->base; =20 return 0; - -fail: - atmel_hlcdc_crtc_destroy(&crtc->base); - return ret; } --=20 2.51.0