From nobody Sun Feb 8 20:59:00 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27991FE46D for ; Thu, 18 Dec 2025 13:26:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064412; cv=none; b=G6wFOFD5JiLQP7j06CB0zv/HhszQlslZiOClRHVsTC9ZhzFl6t5YUNfIFEwCSq3cHGuz4Q+v0pUEfWuc0ycvLSNreDS4tDPRwGMzLM+BbzHZfsCgPwYzonTXnAtEZ8+z1/Q6HN8QP2XdoxVLUuoTvdC6oEYQ9yIbar4Ix510qQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064412; c=relaxed/simple; bh=B5OMjTtB3KvSOSitHSwKvJyc6OwPvRdH+hvUZpIHPnI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=XnB8VznGY1Y2s5rIdXczhxI9prdIAJ2YM0qMCf+I5ibVhWbmHRJWthVw3IykUO9xkBIg1NV7XJihDPWA3EFnbqXuL+b3gte7lsHO8gHVGmIWyZq7mLPIjZfv/NOOhIcBI9UOaw6fZHsnDH/VVEJSg7CCyyu0mDpcyD5caLMiFxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=md+Bluqg; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="md+Bluqg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1766064409; x=1797600409; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=B5OMjTtB3KvSOSitHSwKvJyc6OwPvRdH+hvUZpIHPnI=; b=md+Bluqgd4RSBQL21oDQNsxmI+4JLP7/LbSkrfBuOxf0HvHUh8ZbvnkL OvGj7wOTkLfYDLdcfX/+dGcFFyyKyMGaoOEowjsKCSXB70zmQyp1ZMDQj 3+uZ3/B5SvUjYy1wgHmLz0gMjT75RxMmdVW85A+OiGPukI2PNzSe+UeKk 5UUTo4qD7yrKBpz1p52uaA+pnSoZniewR9kt+oXZfsoKMXTzQUU72RGsH trON/VC7G/gm3JFpmz9BTE/VNn+9Ct8FeZ9rEWn7oeH9lTGlRZnaPurNk /9VXIDLwtfleIn9+eDSBHog7Fn2y0ZeL/CPEtl8T6UbuQU/fSMRkOGf/f Q==; X-CSE-ConnectionGUID: 2/lmXmCJRTiQR6o8m97H0g== X-CSE-MsgGUID: vqkeqlxMSF27mt6zgOc2/w== X-IronPort-AV: E=Sophos;i="6.21,158,1763449200"; d="scan'208";a="218051099" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2025 06:26:46 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex3.mchp-main.com (10.10.87.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.29; Thu, 18 Dec 2025 06:26:25 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Thu, 18 Dec 2025 06:26:21 -0700 From: Ludovic Desroches Date: Thu, 18 Dec 2025 14:26:01 +0100 Subject: [PATCH v2 3/8] drm/atmel-hlcdc: use drmm_simple_encoder_alloc() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251218-lcd_cleanup_mainline-v2-3-df837aba878f@microchip.com> References: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> In-Reply-To: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2109; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=B5OMjTtB3KvSOSitHSwKvJyc6OwPvRdH+hvUZpIHPnI=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpRADxmkT1ZVBs1iBWhVCsdRGhMAVx0EtZocCfg GPMEdN15hGJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaUQA8QAKCRA+OeYT93tk LdtsD/4tDMttbpQ8n+8yJUQph2yvedsFtEUcrui5cfdF8Fg62QRTSyAohKRNCHXQEGmt6cGJvrp LDaqprYJO3e5buwhYxZbdBKLVtCIrM6LY6Ty4gN2d1iuTUf+V2jbYKR2mgBAFa7AhP7MkfjN+OZ 5qBv8s/+4XQdUXA7VspAo+rhaPiPSNnRbokBDKdOAsNhS9EYZEfO8UTpqWUHlgoUT3rYnBJVbUO aLZL3DB+kmArIA0Fxi2UzJFNWVNxGq+k8z8m7wLnDaqx35MUjz1JYf20D4BYVSnKvtToDUG/Q8a S+VjZ4ZpBbqg9PnRJKItPX5WZppiMH2NP06fNSYGB7yHdlertS1Uw15saLln8uXvFredbNwl/gI yBod30u9B7eiSp56VZ2sYnLla9dyy2GziW5oRdivyStQy3XoSlHStWWlsOkmCrA0ChJUlmiB5Rp PCFPsdXbZK7ZQHrsxPaCQT86/AjwhBRSergVMRJluxeYTpBJUXC8X+lB+bbjGPnD8ug5xconAQa mikuwhuJMETYPnb60qGLexmbez4GDqcluNoggkNv8NTLE1+IOVyIgBpTaQv92lW3dQeUe3FyIUY 4WkaBVcEC7Ni9QSKzlHwon4Cy6q+ns78z9TSRduaUbQ+A3e7X3zpxZ/vKO9eZr1p1LUFqMgFw8W 9QnnScHv2Z91OMA== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Simplify the code using drmm_simple_encoder_alloc to handle allocation and initialization at once. Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 27 ++++++++------------= ---- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu= /drm/atmel-hlcdc/atmel_hlcdc_output.c index 0b8a86afb0965ca3085dd5524983a0072199ec0b..1f43e0feeedae54321a17efc266= 654e72e8b9d8e 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c @@ -73,22 +73,19 @@ static int atmel_hlcdc_attach_endpoint(struct drm_devic= e *dev, int endpoint) struct drm_bridge *bridge; int ret; =20 - ep =3D of_graph_get_endpoint_by_regs(dev->dev->of_node, 0, endpoint); - if (!ep) - return -ENODEV; - ret =3D drm_of_find_panel_or_bridge(dev->dev->of_node, 0, endpoint, &panel, &bridge); - if (ret) { - of_node_put(ep); + if (ret) return ret; - } =20 - output =3D devm_kzalloc(dev->dev, sizeof(*output), GFP_KERNEL); - if (!output) { - of_node_put(ep); - return -ENOMEM; - } + output =3D drmm_simple_encoder_alloc(dev, struct atmel_hlcdc_rgb_output, + encoder, DRM_MODE_ENCODER_NONE); + if (IS_ERR(output)) + return PTR_ERR(output); + + ep =3D of_graph_get_endpoint_by_regs(dev->dev->of_node, 0, endpoint); + if (!ep) + return -ENODEV; =20 output->bus_fmt =3D atmel_hlcdc_of_bus_fmt(ep); of_node_put(ep); @@ -97,10 +94,6 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device= *dev, int endpoint) return -EINVAL; } =20 - ret =3D drm_simple_encoder_init(dev, &output->encoder, - DRM_MODE_ENCODER_NONE); - if (ret) - return ret; =20 output->encoder.possible_crtcs =3D 0x1; =20 @@ -120,8 +113,6 @@ static int atmel_hlcdc_attach_endpoint(struct drm_devic= e *dev, int endpoint) drm_panel_bridge_remove(bridge); } =20 - drm_encoder_cleanup(&output->encoder); - return ret; } =20 --=20 2.51.0