From nobody Sat Feb 7 06:45:03 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA60D340A47 for ; Thu, 18 Dec 2025 13:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064420; cv=none; b=LVrrT1G9IsJVvGnDvUOkveM0O7YToecMfuKgJ1xhWTwHXVWDee6JSjGuEnU2TJyWyiIV2Py0Yq0GbJhJps4ny2UQqB8ojALGnBCvgeVOgNI5dA+3x6D4Wx72yD8LwRVrTrG0S37/O68DR9YvIf4Fqn7qE/xX1Co6UcoPAnOsDM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766064420; c=relaxed/simple; bh=aemOi5IutzwP6lzpzpNVxlpvX5r89JXmAras5OUfufs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=MeV+khVY1/q4lp5iUD4Q+w05RlnWmAPgsjUiOSwVWdzV8CBpyfTi9rqvZARX5M8ikk+uAYczaZkvoH2s9ZogAA1f4ZHOVJZvYdarfKDIj+x8Q28RgkPrCOQIqtsSN4wat4Y6Jvg2qmU8Pf7jMBjytUMF1iY1Oth4rM9EVIiqWZU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=0La/3OTh; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="0La/3OTh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1766064417; x=1797600417; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=aemOi5IutzwP6lzpzpNVxlpvX5r89JXmAras5OUfufs=; b=0La/3OThKbpIkzxBfJ3Btx7AMlvcZ3VkAP1Suxg8v2WEntbQbXyMSTcC GMwurAk55UYuaOfYmfHFf+TRU6udq6HIMZ5SNvzwnOoVhOtZ7Ck/OtziN R0jGzdwHN7cJ5l51PE8iEAKYupAaGyw0ZpBjKYeBMY5WRbmEYCtN7+6ra UOU3JYjUFEIRPFFtUHFRlUhlydkpP9U79WtHCWHcFFz13OSmLfqP8DUxW T0aTMNGwnqu56mUGmb+n6Gf2an1YugQqzIlTWB2Jzke1nZ7z9KtA2US1g /2++AyV7RXa9KH1VkgiImv72ESLEAnevw46drisCSKJPsLD6P4Q9UptvP A==; X-CSE-ConnectionGUID: Lg3y3LbkSzGyFPXGFP98mg== X-CSE-MsgGUID: z7LVbWcKRm2KQ7t1eMjcjw== X-IronPort-AV: E=Sophos;i="6.21,158,1763449200"; d="scan'208";a="50046772" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Dec 2025 06:26:56 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Thu, 18 Dec 2025 06:26:17 -0700 Received: from [127.0.0.1] (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Thu, 18 Dec 2025 06:26:13 -0700 From: Ludovic Desroches Date: Thu, 18 Dec 2025 14:25:59 +0100 Subject: [PATCH v2 1/8] drm/atmel-hlcdc: use managed device resources for the display controller Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20251218-lcd_cleanup_mainline-v2-1-df837aba878f@microchip.com> References: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> In-Reply-To: <20251218-lcd_cleanup_mainline-v2-0-df837aba878f@microchip.com> To: Manikandan Muralidharan , "Dharma Balasubiramani" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea CC: , , , Ludovic Desroches X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3275; i=ludovic.desroches@microchip.com; h=from:subject:message-id; bh=aemOi5IutzwP6lzpzpNVxlpvX5r89JXmAras5OUfufs=; b=owEBbQKS/ZANAwAKAT455hP3e2QtAcsmYgBpRADxD2mOmOLcjoZAScPDgMH8yZoRCwCc2wQIF FtOI+W/6tCJAjMEAAEKAB0WIQQAMEvJiWmsW41tNU0+OeYT93tkLQUCaUQA8QAKCRA+OeYT93tk LZrpEADFqpD68JK3n2UfJP7k1dEld/VBlI+1Bn7f+42+131qcXhnOWUS+4Y1up634zqkGi3x+Wf LfUyx88Nv4DCo83OzztNsUFJf2oUAiY2UHKCf/OqreAKwHM2VbIuWeZL2YeUVirQmGRshkKSTUW Vw2gmP4HhCrr9w+gcqD4HmSz9FrqwKZFj+H1CSCaYIksbOiVccKVIBowv2nic8HpaZ16VGMU02Q WBIyGzK3iNNmBnW+eNEkHgmeq/RCEyPHcQuI9GnRjpaIzT7J2nYylI/puSLECaUhq6cqS1zoGi2 Ikx4LqvxvJ1GsBG9HSil/hiZWGXbPeiFWxV+ec2em7MSpAl/X5JTtSSk1izNglqIKPv7tDQn7ok yCs/hCRMf1lgzrAkqEpSYfnAON0fcyG533u2+CRzjnPM56+5O+lmgqXI24y4Y0STWVfMm11XB/b lxoPmVsaC3giqPyFkl/rs2ZYV/bULyZwpl5y8iW4tikEcKepG/cOjHoMcOgVyhSzMapYxHnLu73 krr/pBcAy6fLoEtbjF/Su3IKTWPje+rI728Uhe3edxXCdya9TpQRMjJhi5lZ5EUPS207eXUr5J7 PADkseHx+SeN6YC1p+1lAwOgy4ey9vCOzmiVOBsB0pwDH4EamuzXoPnDOT1raP3vEBxFHyybcok S+kisep92P2Y1AQ== X-Developer-Key: i=ludovic.desroches@microchip.com; a=openpgp; fpr=665BAA7297BE089A28B77696E332995F09DCC11A Take benefit of managed device resources to reduce the risk of memory leak and to simplify error paths. Signed-off-by: Ludovic Desroches Reviewed-by: Manikandan Muralidharan --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 25 ++++++++++++------------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 1 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm= /atmel-hlcdc/atmel_hlcdc_dc.c index dd70894c8f38e7303e06167594ac289cb345b510..8ed029381c555db10d596efc8d5= 2753c47767633 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -751,11 +751,16 @@ static int atmel_hlcdc_dc_modeset_init(struct drm_dev= ice *dev) return 0; } =20 +static struct atmel_hlcdc_dc *atmel_hlcdc_dc_of_dev(struct drm_device *dev) +{ + return container_of(dev, struct atmel_hlcdc_dc, dev); +} + static int atmel_hlcdc_dc_load(struct drm_device *dev) { struct platform_device *pdev =3D to_platform_device(dev->dev); const struct of_device_id *match; - struct atmel_hlcdc_dc *dc; + struct atmel_hlcdc_dc *dc =3D atmel_hlcdc_dc_of_dev(dev); int ret; =20 match =3D of_match_node(atmel_hlcdc_of_match, dev->dev->parent->of_node); @@ -769,10 +774,6 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) return -EINVAL; } =20 - dc =3D devm_kzalloc(dev->dev, sizeof(*dc), GFP_KERNEL); - if (!dc) - return -ENOMEM; - dc->desc =3D match->data; dc->hlcdc =3D dev_get_drvdata(dev->dev->parent); dev->dev_private =3D dc; @@ -853,16 +854,18 @@ static const struct drm_driver atmel_hlcdc_dc_driver = =3D { =20 static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) { + struct atmel_hlcdc_dc *dc; struct drm_device *ddev; int ret; =20 - ddev =3D drm_dev_alloc(&atmel_hlcdc_dc_driver, &pdev->dev); - if (IS_ERR(ddev)) - return PTR_ERR(ddev); + dc =3D devm_drm_dev_alloc(&pdev->dev, &atmel_hlcdc_dc_driver, struct atme= l_hlcdc_dc, dev); + if (IS_ERR(dc)) + return PTR_ERR(dc); + ddev =3D &dc->dev; =20 ret =3D atmel_hlcdc_dc_load(ddev); if (ret) - goto err_put; + return ret; =20 ret =3D drm_dev_register(ddev, 0); if (ret) @@ -875,9 +878,6 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_dev= ice *pdev) err_unload: atmel_hlcdc_dc_unload(ddev); =20 -err_put: - drm_dev_put(ddev); - return ret; } =20 @@ -887,7 +887,6 @@ static void atmel_hlcdc_dc_drm_remove(struct platform_d= evice *pdev) =20 drm_dev_unregister(ddev); atmel_hlcdc_dc_unload(ddev); - drm_dev_put(ddev); } =20 static void atmel_hlcdc_dc_drm_shutdown(struct platform_device *pdev) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm= /atmel-hlcdc/atmel_hlcdc_dc.h index 53d47f01db0bd4d906b73f9f2a46f2ef7326d8c6..26b26185cf34ac1678f385982ca= abd2dbbc22630 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h @@ -350,6 +350,7 @@ struct atmel_hlcdc_dc { struct dma_pool *dscrpool; struct atmel_hlcdc *hlcdc; struct drm_crtc *crtc; + struct drm_device dev; struct atmel_hlcdc_layer *layers[ATMEL_HLCDC_MAX_LAYERS]; struct { u32 imr; --=20 2.51.0