From nobody Sun Feb 8 07:07:57 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16FC913B293 for ; Wed, 17 Dec 2025 21:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766005334; cv=none; b=iRky45QifGybu+AIKpTocdlOYFHNe4foexeyaj4HIV4morvfs6iP8Asvu0CQ9W52bZq30sUfEune2lBXKPSulrvMQkIk3rMO1G2eVP7YlHamzvrRU7Vw1Jg2/F4yjBaq9PXy5d8oRYQQgRR8xCgydPcg/qJFub+98YRGXkSfbzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766005334; c=relaxed/simple; bh=BaFe8NVmB4jyIE4pQ/4p6zOG8BM4BGZxrRHSXBFWy64=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gqwe+YO/VWTjAacLeEgW5U5sDhL2Z8zk2U0d6uNm3t0yZqBPOaqm915mtDjbZ80rM/9mcy9OxrBw1g92nMdGnlFC3aCl2SgeQyJqz8rVPUO/7p8C9vpkh8d+ZNQlgSplEuRjQ0xW+BY869bkjJAqaDyiaSue+FL4yD+MUT2Yqc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fi7cY+9C; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fi7cY+9C" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-34c1d98ba11so5956946a91.3 for ; Wed, 17 Dec 2025 13:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766005332; x=1766610132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=llYlRwQLctWSGZQDxd2QIS2AvLGcZz6Ye2pGmxI1idA=; b=Fi7cY+9CIy6f7tgHaLa6B1tXYXBu4Y9mYQ6rm0ihxIzulfQxjzvmCIPE8qypSCzPjf hM1CUaAgzdbSgdGlbxakWVNFVz+qhbH5RGjwoRmS85vHtU7IvUmNMNNetuHPu7wE5jFe HLbaGnIPkYYObXTGIGPnwIe4rrcnJxXk09mSDcu+CHtkTJjXwnwBztS6bik1u3+nhHfY Ic4S7K3CDhonjwYxHmPMpoFXRyB9cFUk1q483pL4sV1YKVn0vBG319MQiI5p9PhdraaJ LHuoGv6kXvjPGei3xDemflMjJTzlj3B+wzhx9oxp+/yT6WWabShkfnoRWjRQwM57BOeK Ovsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766005332; x=1766610132; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=llYlRwQLctWSGZQDxd2QIS2AvLGcZz6Ye2pGmxI1idA=; b=JbK2n7VM01H2qe22bC9dPBDoD9VQ60qjBnF2l7WhLjtNGq+Rhx+7AVh+qrG5TcRcN/ 1uhXtYtH7IpJ471AdLho+3+cIT82fEOg/4lUAOJvsG6Ssu+LvJOqYv6I+3xHhzlp7h2/ z5xfOTJfVbBsPh21Z53zaFtKz2GdsGtSrBz61pDOpaG32y/4oI5nutVqYf0ILHPPEA/p 098OzcUG4pSDYKSMID/BaKKZO8acsexruoxH8wXgiYQwNErNTrv2g2pvbpEuVIrx3c/F 4iBkUwXHXBQFznQuvcUCG4bMz0/vPQfYfmUzfAqMRMKQ29lKmUMPSzi+90sJp0Wee9Qs Dkqw== X-Forwarded-Encrypted: i=1; AJvYcCXpTTjTDVt9btcV+RzDewDEpDHq/98wzJ9RFhmSPQkmWwFxgvpYRj83S5W3gPVwC+3GEZ2R4jwF5/MKI3Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyYUWzHVxzt5/5jGTj7BnL1VvJ3Q6N9T6tYwdY/7Jqld7xJloxH nqnpRnvbKqIq9OMABi7SZ7Ja1wU/8yTiFFdXshjCH0Bb/jLE4qg9I2MlOnfYNw== X-Gm-Gg: AY/fxX5NU2W0qk1v1DFzL26w4Avv096xouoiaCkbWe+j8sHgq6DhBhfeawJpoQY4L/B VTKbkk3tFpV6/XLEQPfafsSNvuk5gLXqNg6DBNS7BFD7lhmilgGg74pWpH9u4fdoGvd/yDRa3fP 7jcaBwF0bAqPzsqYB9Es6I/dEEMXtdMmL+2OQOI/MPtm3k1SKRQZRz5a2taYwWxOFmza3CEojOr 0LNtW3OLaQuBDujflvBkfq5h5jsZsw3Eb4p5RfU6qrG2BULBgvMcS49EPR3gUSyRptrIyOCWk1B GIdtzYWVlAouHlz8WaxJnsX86fL8+gJ4RmtX+Cua4svVWHpBMAP56lq3YHKGxGlzmRB0Y9ElrAe vS+Vtnxlq7/KulFtMCtP3BBAeC80CM3lGMCUmUhVq5TcW1CvBSdBYKGot/A== X-Google-Smtp-Source: AGHT+IEfkiMxQaMnFr3ApA+fVWSCLZvNJY1nONC5zfJUX5Mt4Ma9hUMxG5kOaGcNWruRLKZ1j3Rqug== X-Received: by 2002:a17:90b:1d4c:b0:341:8ac7:39b7 with SMTP id 98e67ed59e1d1-34abd769977mr14636782a91.25.1766005332256; Wed, 17 Dec 2025 13:02:12 -0800 (PST) Received: from ryzen ([2601:644:8000:8e26::ea0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e7722726esm13810a91.8.2025.12.17.13.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 13:02:11 -0800 (PST) From: Rosen Penev To: netdev@vger.kernel.org Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chris Packham , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: mdio: rtl9300: use scoped for loops Date: Wed, 17 Dec 2025 13:01:53 -0800 Message-ID: <20251217210153.14641-1-rosenp@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently in the return path, fwnode_handle_put calls are missing. Just use _scoped to avoid the issue. Fixes: 24e31e474769 ("net: mdio: Add RTL9300 MDIO driver") Signed-off-by: Rosen Penev --- drivers/net/mdio/mdio-realtek-rtl9300.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mdio/mdio-realtek-rtl9300.c b/drivers/net/mdio/mdi= o-realtek-rtl9300.c index 33694c3ff9a7..405a07075dd1 100644 --- a/drivers/net/mdio/mdio-realtek-rtl9300.c +++ b/drivers/net/mdio/mdio-realtek-rtl9300.c @@ -354,7 +354,6 @@ static int rtl9300_mdiobus_probe_one(struct device *dev= , struct rtl9300_mdio_pri struct fwnode_handle *node) { struct rtl9300_mdio_chan *chan; - struct fwnode_handle *child; struct mii_bus *bus; u32 mdio_bus; int err; @@ -371,7 +370,7 @@ static int rtl9300_mdiobus_probe_one(struct device *dev= , struct rtl9300_mdio_pri * compatible =3D "ethernet-phy-ieee802.3-c45". This does mean we can't * support both c45 and c22 on the same MDIO bus. */ - fwnode_for_each_child_node(node, child) + fwnode_for_each_child_node_scoped(node, child) if (fwnode_device_is_compatible(child, "ethernet-phy-ieee802.3-c45")) priv->smi_bus_is_c45[mdio_bus] =3D true; @@ -409,7 +408,6 @@ static int rtl9300_mdiobus_map_ports(struct device *dev) { struct rtl9300_mdio_priv *priv =3D dev_get_drvdata(dev); struct device *parent =3D dev->parent; - struct fwnode_handle *port; int err; struct fwnode_handle *ports __free(fwnode_handle) =3D @@ -418,7 +416,7 @@ static int rtl9300_mdiobus_map_ports(struct device *dev) return dev_err_probe(dev, -EINVAL, "%pfwP missing ethernet-ports\n", dev_fwnode(parent)); - fwnode_for_each_child_node(ports, port) { + fwnode_for_each_child_node_scoped(ports, port) { struct device_node *mdio_dn; u32 addr; u32 bus; -- 2.52.0