From nobody Fri Dec 19 03:44:58 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00EB530F7F2 for ; Wed, 17 Dec 2025 17:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765992109; cv=none; b=c99IktoCfazZSWPXH5WfmwRSKjaobD7dhy6DNSRV5ncAGB/2FIhHc6hERsgJL7Tv1s1Ua5Gw3tMcytkmm6/p09rKmg0fxRFa0EIXSZcZsQq8j8UL9g5BSFjAoFSVmp5wilPLV268czyZWk4J3aFHezCO54jtYIjS6sddYsZh9Ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765992109; c=relaxed/simple; bh=6VkB+qk6Vk9qrLdbL758GmX2r6bPUKfMgZsehXkLIpY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aeADKMRbJ5qXBo7b9H/Itrkr2t7vnzMpsnVfLdVe8UsCZZbmOvpOH/ofAYYuPxrbJhfycPnXWzsVDGY/5uIQep0PsAESACyNI/1Ro5CY1rOuzvhfaPAtM3TP6SaPyqXkqC/FLiimtIqS2crimvVYBIXMfS+Y6ixgynjim2F9fqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=fail smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RslZ72y6; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RslZ72y6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765992104; x=1797528104; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6VkB+qk6Vk9qrLdbL758GmX2r6bPUKfMgZsehXkLIpY=; b=RslZ72y6hhpDp3QX51ZLEDO4LiMW13rR7rv8ZgwZP7+j7EfMWiOv/jq6 AyxnjG+DmO37PUKpIG7UIKsYUiNN0kzvOqMLnU4aeoaHMWi55/lwYiOM2 HEvzioxOa32phiy889C4pkWUwIPZ7gQXjxJp6uPKqzZKGDB3uKWoEggGT rXVk8D81BH1FhD+Win96uvi6i2G5Ac1TVU2v9C/xlJTG9aPcojSly/mH5 tmoDGpBLIMjqgrHj0dCmMUnLhckPuOUtYs4hidvrDVdtXsbr4I8dJ/jjf mWLP1NpkuOSDzaWaGXIiS+j3o9Uu3YRhBwEgToY1f32STXsI7TR40zkh3 w==; X-CSE-ConnectionGUID: OihMrfD2SZCHUyaAOzAKFA== X-CSE-MsgGUID: v1YoLJ1QT8KJ0AImC6FdMA== X-IronPort-AV: E=McAfee;i="6800,10657,11645"; a="90594640" X-IronPort-AV: E=Sophos;i="6.21,156,1763452800"; d="scan'208";a="90594640" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2025 09:21:32 -0800 X-CSE-ConnectionGUID: X0GdadOJSie4O/uD5tNlKA== X-CSE-MsgGUID: y1OONoGKTOGqEuOtmhxedg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,156,1763452800"; d="scan'208";a="221748159" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO agluck-desk3.home.arpa) ([10.124.223.131]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2025 09:21:31 -0800 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Chen Yu Cc: x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v17 04/32] x86/resctrl: Clean up domain_remove_cpu_ctrl() Date: Wed, 17 Dec 2025 09:20:51 -0800 Message-ID: <20251217172121.12030-5-tony.luck@intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217172121.12030-1-tony.luck@intel.com> References: <20251217172121.12030-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For symmetry with domain_remove_cpu_mon() refactor domain_remove_cpu_ctrl() to take an early return when removing a CPU does not empty the domain. Signed-off-by: Tony Luck Reviewed-by: Reinette Chatre --- arch/x86/kernel/cpu/resctrl/core.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resct= rl/core.c index 49b133e847d4..64ed81cbf8bf 100644 --- a/arch/x86/kernel/cpu/resctrl/core.c +++ b/arch/x86/kernel/cpu/resctrl/core.c @@ -604,28 +604,27 @@ static void domain_remove_cpu_ctrl(int cpu, struct rd= t_resource *r) return; } =20 + cpumask_clear_cpu(cpu, &hdr->cpu_mask); + if (!cpumask_empty(&hdr->cpu_mask)) + return; + if (!domain_header_is_valid(hdr, RESCTRL_CTRL_DOMAIN, r->rid)) return; =20 d =3D container_of(hdr, struct rdt_ctrl_domain, hdr); hw_dom =3D resctrl_to_arch_ctrl_dom(d); =20 - cpumask_clear_cpu(cpu, &d->hdr.cpu_mask); - if (cpumask_empty(&d->hdr.cpu_mask)) { - resctrl_offline_ctrl_domain(r, d); - list_del_rcu(&d->hdr.list); - synchronize_rcu(); - - /* - * rdt_ctrl_domain "d" is going to be freed below, so clear - * its pointer from pseudo_lock_region struct. - */ - if (d->plr) - d->plr->d =3D NULL; - ctrl_domain_free(hw_dom); + resctrl_offline_ctrl_domain(r, d); + list_del_rcu(&hdr->list); + synchronize_rcu(); =20 - return; - } + /* + * rdt_ctrl_domain "d" is going to be freed below, so clear + * its pointer from pseudo_lock_region struct. + */ + if (d->plr) + d->plr->d =3D NULL; + ctrl_domain_free(hw_dom); } =20 static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r) --=20 2.52.0