From nobody Wed Feb 11 05:36:52 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B88CF37A3C4 for ; Wed, 17 Dec 2025 13:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765979557; cv=none; b=QKF2BMZZYtbMVnvu0WU/FCuuI78EF1rYAzGKWbkAZvZMF7891xTPB4RX8HItnMNuawM72Ahv59Qa4HOPRJurEcEXPQa2IsgrZZdHPR7u2mgSliEqVQ3K0UpIHpRlZ3lguj6Z39rWos/JpYjDSfUQm30vd1NEtomDcHrn7BnoeQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765979557; c=relaxed/simple; bh=gEmoRtjLtJIWXeIxbyc1ZwCZe9AbS1c3qYMrSFz21rg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u19pDgZGXSY95PSpFxiobiODFwo21y0IodecPjqFfJBuAJd7sJSXkOkaMX+mYBX68upHA31IwAHRM3XRG+H90CkX9p+TrL76c67GC6RWYlqToKFHCQPKTDIXDhtLPlK6jcJHbA7n8ap75AqwuvYfa4u5DfaOsIoimdJOgw/yO5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=MBAqUXyC; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="MBAqUXyC" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so4266072f8f.2 for ; Wed, 17 Dec 2025 05:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1765979549; x=1766584349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zGVStpQwPomlTdstFsandqO2eIQ1hd4Sclxyb3yiqx4=; b=MBAqUXyCqdf5c1rgnBVnMqf5nLaB6TW/OIrvqEHlB3bTxHe2Q+9eyiu/8JaBTNjkLk FYy6WTKM7ydojbdWWPM7wSkROg+uGXPARNNebu/kSsSNDFhtJ7nMlWbnPL8pOOLC/eXE jCV68UOKrdqG6AudBHUEFCHZewJIaEGzOIP5KjaQIp/3MyxjJ3O/PnJX0DxrfK0vtmVD KMC/WpWUfYXHzPZOaMQbzKar2gCh5uAPrQd72lCA7PXiQQzECXjl1fNyWsScqY165BNI Fp3WJny1p+nZIHWtaIEqMmY6wbYSpm6Ivu6Ahbo5hrv+RE13L/6rlHiK6o4Uv1aGFm9e KTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765979549; x=1766584349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zGVStpQwPomlTdstFsandqO2eIQ1hd4Sclxyb3yiqx4=; b=ZJdUYxh7dtIcXEIMSiRwTniGzM8bvHs8nHCF+1UBtmZ8X2G4Rz/aBVaIc0HeVk7AQQ lV7DFg0QbnRXtVdCHP5C+imkNOwUEKzIZeEtiMuhIP9I60/8T0L86g+LzM7JjqbYpDlH mWFO6LtSwk56tBsTnfzw5h8AxwOhvJyqsB4IhoM3a3Mp3WdYGTGOCyhDdtG6bIbZ+/BT HxKgInq7X1XN0D9KOxPYygXEtwKlJZCKKfdDFqW7u9TU8yuJE54UxUmEa/WvSfe22Z9x fkWoUuEcJu/rfTJ4rzcU5hlVpsV8kwiY3/nOGHSArpVC5y0y99W9/w1U0/kWFv+Tl0DX e2FQ== X-Forwarded-Encrypted: i=1; AJvYcCV7/JQFiGkbqvcKk7t5LCd/95sQt+inVBUQgEZWEsr+Drm+L8bAquQJ2iebKZcjCowjy84ZjyAS4dmI6Mw=@vger.kernel.org X-Gm-Message-State: AOJu0YyMnpP+N83/lNB1XdWB0g80FW/XDC1RP22DucE1SDYt8ay6hHBQ OmoGFM1mBuTRWGdUrm796G4yofEQ5jQ0OvH+2JpuC/PkB3CgV4KJYWaQjPgjGg66r7I= X-Gm-Gg: AY/fxX7fHhAX0QQLl40Ud7aAzwBDJmXQgj1uQNOrFkgQmIzjNeSz45LKGrEozKrp0tZ jivK9a5IWelLUmRQBIACfXGd+llf0Xzz8jUMoJeGIYneF8GFF39z/u5iICJLDLkxwzqk8DVREO7 nncOXKZGvBEUvhRBOFd8Jq/v1//fkoAQ1E5jmvRu6SesouXu4xCdEVYeNTjkbuikG+gh1BRO9Ra WTi3ek6Dy8OWnnPrkIwDHS7CiWhbdb4ZLS/Xj5W7+OVPj8XI1ZeSHEzD8JNgA8dTL4UWwLNKm69 ZeIG9vEnXpcIBHAe2UWYz4y3Hkp3VwCe1+/ngysj2ePsS+AbS9liF6+MM1I5xdxt5KtcFdd1GQr w/g8c0/Op5vgl4+DA8qVf+vaNmZeAI+mS8XyVjMPXa/+ZBaP/+Z9QS6KF7xJxoPpBO/X/9FYc9g yyLm/FrkC5IPBe5T8vluOtzP2JEr87cVF8tlTfQWzQ X-Google-Smtp-Source: AGHT+IED9HanqqLjN0QtB0ReE4lGpkn+FHqD4ofAHtZbJtmJpbrl0xl9aY+9K4+DrVBoQRCemkHTLg== X-Received: by 2002:a05:6000:4202:b0:431:1ae:a3d0 with SMTP id ffacd0b85a97d-43101aeacf1mr10038607f8f.25.1765979549499; Wed, 17 Dec 2025 05:52:29 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4310adf701csm4508000f8f.42.2025.12.17.05.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 05:52:29 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, fabrizio.castro.jz@renesas.com, biju.das.jz@bp.renesas.com, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v5 3/6] dmaengine: sh: rz-dmac: Drop unnecessary local_irq_save() call Date: Wed, 17 Dec 2025 15:52:10 +0200 Message-ID: <20251217135213.400280-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251217135213.400280-1-claudiu.beznea.uj@bp.renesas.com> References: <20251217135213.400280-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea rz_dmac_enable_hw() calls local_irq_save()/local_irq_restore(), but this is not needed because the callers of rz_dmac_enable_hw() already protect the critical section using spin_lock_irqsave()/spin_lock_irqrestore= (). Remove the local_irq_save()/local_irq_restore() calls. Signed-off-by: Claudiu Beznea --- Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index c013bf30fa5e..ae8a4bd9d7fa 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -267,15 +267,12 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *ch= annel) { struct dma_chan *chan =3D &channel->vc.chan; struct rz_dmac *dmac =3D to_rz_dmac(chan->device); - unsigned long flags; u32 nxla; u32 chctrl; u32 chstat; =20 dev_dbg(dmac->dev, "%s channel %d\n", __func__, channel->index); =20 - local_irq_save(flags); - rz_dmac_lmdesc_recycle(channel); =20 nxla =3D channel->lmdesc.base_dma + @@ -290,8 +287,6 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *chan= nel) rz_dmac_ch_writel(channel, CHCTRL_SWRST, CHCTRL, 1); rz_dmac_ch_writel(channel, chctrl, CHCTRL, 1); } - - local_irq_restore(flags); } =20 static void rz_dmac_disable_hw(struct rz_dmac_chan *channel) --=20 2.43.0