From nobody Sun Feb 8 01:51:40 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C16B35CBA8 for ; Wed, 17 Dec 2025 13:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765978997; cv=none; b=StRXfFa6ZpLrhskoLfH8T2RqsU16IDdMKY1X2QeX9dw4i0SFpDG4MI1wNa/6do8/zo6zzbSoHJu3iJkNkbrYNPg0n7mA++qUMxmA8JYuCVbGpOpajGBM/wJr1Iq70mbwnQpc8SVzgwzAQa/MMQItVmIX8z5V7VBIRvYoaosaHOk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765978997; c=relaxed/simple; bh=xzcy3HjWUqXX71bMT9BpZUGsDULODmY5SAKDf2KyML4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kSCY0poFXwTWKso/ECMxlrOH3NFbN04fPzL9MAXq+JZZcpl/ZAlrPmq38xabrfh44tYYhXJ253Pp4mQuVLBMQekQSScgpF/Cu5AmkWEEbUaJty0jkbSigTceONaPT7HfDeFTi/8CSrb4QGIw/NCe1Ra+xUVapOCaOFpZInPZM+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KcjPAu3n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c9v6XuD7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KcjPAu3n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c9v6XuD7" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHCKpQn2683512 for ; Wed, 17 Dec 2025 13:43:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=cdziwOSusQZFFmsDftNk4xkwlCTEsElfD6j qGnoVzgs=; b=KcjPAu3nTvTGPBI5IuCIKSh7FcQSxEJXF0KRDkX3+15Zznlkya1 PyY62sD2NeNmTV3ly246H/yP2S4PTo6qkTuVHLyj17py67hnPMiGdGDs0K9cVxde Rl52Lrf92W/7W/QrYofN9uQZr251ZitYVeBqWmoTBwok2zuywrah4EBk3JRKhV0y XiJ+JekgnEByFL79rA1S52UjXf9bS3hC4cqEiTFOHS6M4jqWookQCFbb5f68RLHh nIeJjdwO54QZS6sI/198V2pDICci1QHBJ1un4Yz7JdabCRH78JUrAdbIcP5ieBaR vnvDdPjJ8X7J1WxJeCXvsz+lVYAUVdJmrSw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3kkesy6g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 13:43:13 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ed7591799eso124876801cf.0 for ; Wed, 17 Dec 2025 05:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765978992; x=1766583792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cdziwOSusQZFFmsDftNk4xkwlCTEsElfD6jqGnoVzgs=; b=c9v6XuD7xZHe+NpMrR1di8i6DqnGI+sbAt0wzjNHe9u1cmxQgkuU9Oq4KYeCzVPIUR KD2tp0pkS5F1YgIaxy4/rXq/s6WKimiJ7FCkpaYDst8OFvvb0ci2UrIPPrcvOj6Hj+/g n58an6ljsEUrxrkiRrlt01yxrpZgaixmr4c96JzN3GYrZXOuagVU6diWcT/AtPzTA6y/ HoJ0WlCPvCjXeVyyassO1UEVKFJtqHR0l6p+JIhCmqOWG61T0kB/sjIaNMXIZWrKLUbu UGhFm3tS02Ew/aV3+V82554Qv7IbyTUthcQDCytZzXVBiFLIjA7E6FI78JxFq488Ustm xrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765978992; x=1766583792; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cdziwOSusQZFFmsDftNk4xkwlCTEsElfD6jqGnoVzgs=; b=g1al69ESjySmwD5odV7xdb9j4q5A2qjKBUulqdiJB1E8vNXYjfGBRauDvjGpXYSlVx AvpKNEtkSQPuYHiftCJX1anZjOjRHTDUXGzp/YgBJAC4NoBiU/aBIiIBfrJ0uA19ONfy ZG4VwPtGcaezki6vFCheLpeF6vCpk0FUJlGnuzCUxEvGgg1Arglhg2GYl/8NIIFoBPvZ AFKRBl9UBk4jf5dPQHH7K7yqzciQn9S2ZjOFyET7U2bcmL+DZQgJRPAdf0WP0N3SOazg B5sVnfUnVv4n1jAvvAX+RKSqkVRjiBJR3ZlqAfTL7eekaAXy+0rnlKcEjE10DFfp9lnh Gc6Q== X-Forwarded-Encrypted: i=1; AJvYcCXwYXrQo54WFxcT1QOHL4o0y+/5vw2kUoc/jYrwd+jA0pb04drjR0rLSapD0sqZgjLjskU4A5RNhOKYeMI=@vger.kernel.org X-Gm-Message-State: AOJu0YxfhTVPJNI5XE903OHId/UVeXNfob+yJN2zJMaE03IHwPiQ4kLB NfbxBPOZV+6m+G6+QJ2/akne1nQnQUm9ovGUA6w3yJA8Amw0I1AvGuYkPmJlr8km2+ynjV03C3e WrJ0I26USR8H6TxaQsEAwPwVCMMyayMHyj9LuEmWahrpMgTeeMQGEF8PYnNzrQWT4Svg= X-Gm-Gg: AY/fxX6JXDbn87aecUiP56CYaqJ4u4XJrAy0Z9O0V7NoqqU8PPyAeQ4va6IdB2VvvJE QMcNWcdG5uj7RO2QcLWPiYhaVzSirmXtHcVZ3qpLO/b5PMcVcVx7CpcGHurccS+CFGzzEz32KHr HXQZN6RBchdG17JwqGkRTWNpJ+dNhUONBNem03ddWG3eoomtN30QD/3ART6Wztv+N3IIT2aFGTl G27ecUg4SeMIUeIM7BDIxoD2AFNHbxNFWfQcQOR4oSx8MHzXaYEYWphOqMjhpgtmFXeAnEl8kar 1djQj0WMXUhFKd+/8KVyS3uJUB2ry78FtHEA1mK/XuSg4fRtMuluHKOWg9P8Q6wlAEkTr5qFIgB 5iOwL5Y+kAwJIdHT5fiFr2SJ6YclilvqbyPLY X-Received: by 2002:a05:622a:1791:b0:4e6:ebe3:9403 with SMTP id d75a77b69052e-4f1d059d261mr218026651cf.41.1765978992305; Wed, 17 Dec 2025 05:43:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGs5UKb7XzshQZgu3oZhlbIG5d/CYa5SbbpOYCX3AHnIMwcfk4nwbnQU4m5au02CHMdtcpjXQ== X-Received: by 2002:a05:622a:1791:b0:4e6:ebe3:9403 with SMTP id d75a77b69052e-4f1d059d261mr218026361cf.41.1765978991819; Wed, 17 Dec 2025 05:43:11 -0800 (PST) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:772b:e322:5e20:58e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc23c2b0sm38598635e9.15.2025.12.17.05.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 05:43:11 -0800 (PST) From: Bartosz Golaszewski To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2] of: replace strcmp_suffix() with strends() Date: Wed, 17 Dec 2025 14:43:08 +0100 Message-ID: <20251217134308.33839-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEwNiBTYWx0ZWRfX8czBDll5QhLd oj4TPfuVUFcKm1xp4Uo3ZEizFw4d/Vt7/nDDJiKd8zbdCoyBu6Tlp2V97iocRCyf/MejoCD/0G9 14umD88N1DtrwJwdnc8DFoohmWSMydlDW/QfCntxMuytmfJ006vgsSqmzY70DGHjJ1XKfZoWSBw kLwfjaIs2zC65kLYriN0K3940DJinj2vnb44140zeI+NBj8RkR65j6I6+toMpH2WvzBHU2Tw4MU zWv1meYpGcuUePRx4572Llxh+TmJIo+3310K3KZiUOq3TjpYB4pghM6EgHnS6JQr4drchjjv9nC qRjMhZw2SlEKr/GayWsk1UZNPKslnemCEfhiMBJvsScD7mOaW75vfUVC2931PgNxfWF2UDKfT0h vAVdcn4AnUjLE2LIVzxkfE8hIKfMJQ== X-Proofpoint-GUID: jAr3mX-xQai5aB6xE9JzNeI0qq7kit9B X-Authority-Analysis: v=2.4 cv=Fcw6BZ+6 c=1 sm=1 tr=0 ts=6942b371 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=u7-1JQUhpAEVokYvez4A:9 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: jAr3mX-xQai5aB6xE9JzNeI0qq7kit9B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170106 Content-Type: text/plain; charset="utf-8" string.h now provides strends() which fulfills the same role as the locally implemented strcmp_suffix(). Use it in of/property.c. Signed-off-by: Bartosz Golaszewski --- Changes since v1: - strends() actually has inverted return value logic from strcmp_suffix() drivers/of/property.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/of/property.c b/drivers/of/property.c index 4e3524227720..ce5ada040d7e 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1294,17 +1294,6 @@ static struct device_node *parse_##fname(struct devi= ce_node *np, \ return parse_prop_cells(np, prop_name, index, name, cells); \ } =20 -static int strcmp_suffix(const char *str, const char *suffix) -{ - unsigned int len, suffix_len; - - len =3D strlen(str); - suffix_len =3D strlen(suffix); - if (len <=3D suffix_len) - return -1; - return strcmp(str + len - suffix_len, suffix); -} - /** * parse_suffix_prop_cells - Suffix property parsing function for suppliers * @@ -1331,7 +1320,7 @@ static struct device_node *parse_suffix_prop_cells(st= ruct device_node *np, { struct of_phandle_args sup_args; =20 - if (strcmp_suffix(prop_name, suffix)) + if (!strends(prop_name, suffix)) return NULL; =20 if (of_parse_phandle_with_args(np, prop_name, cells_name, index, @@ -1416,7 +1405,7 @@ DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") static struct device_node *parse_gpios(struct device_node *np, const char *prop_name, int index) { - if (!strcmp_suffix(prop_name, ",nr-gpios")) + if (strends(prop_name, ",nr-gpios")) return NULL; =20 return parse_suffix_prop_cells(np, prop_name, index, "-gpios", --=20 2.47.3