From nobody Sun Feb 8 05:42:48 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE473BB44 for ; Wed, 17 Dec 2025 11:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765969278; cv=none; b=RSOVAgSSkE3cOgS0ibMrwZbFeaAvVSefJHiXwH3DfrbqEFTwuvwJt4ZulGO9XlnTLl1TeebEEEUL/lytpGH/5WxiEjkV4dLKB1P3MLF1NCdKJImqThnUqS/NlvPpjVV5Kyu0LgHpQ/imZ3VkFMsCSP5+AFlV7a1fHb0aw+SP6YI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765969278; c=relaxed/simple; bh=X3bYA0WrDEfWOzj5bMVf+TdTcSX6CVPnicK8sEKlTgE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=h+ZWOSpQ75WNp/5bOJuoUr9yR6RQwUyh0ie5aDBQAnNr5UsptwAJjdbdk2Ng21IFwtcwKVcndJOn/aSgUFETXPy5cZRMJZ1dFYnK5U3VqfheXwJ+Zj2p2sRsqocfAEBkbxWIJX4Rt4VWDZXU9gp/q24QurYtwV5OsYhTwFEjFWk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RfJL0izJ; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RfJL0izJ" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b7a02592efaso839659866b.1 for ; Wed, 17 Dec 2025 03:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765969275; x=1766574075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SwVWde6ca06mMHyo9dvW0rPByW8h45B/CTH5c+8Srp0=; b=RfJL0izJ/hxlF2CORmmU8GvqX9YTmKMtaKCgiwuRkv8lm/EZ3w2g1+9lp4pyPId3X+ s/MgkJt4SOgdjA9T4hq2hRjCXJMthyzQzZx49He9t6CRDKpDK22r7TLRSg8JkflS2Zqw sEb+/ZGsNLzHYMr4iVa+s4xl3OyUazFik4DbYFsmaOB8/lnHvt+kU5EpNzXAy0ji5pRX ppuWTTI0S0TZr7P2wzClrziRgSvgWZ/HQXxdcvHoT9i4TH5PZ6uVP3aoNr6Fi4PwqrNL CBjc38/LWXPef5WTIDmVIoRzI1GFhu3vDqE2dJrJGveKG/qTN0IE/PkEYWxpo89iCfcL 1Osw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765969275; x=1766574075; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SwVWde6ca06mMHyo9dvW0rPByW8h45B/CTH5c+8Srp0=; b=FOgPFNIZ7pruNoT5LnI4cLEV8rDAOrARjQ5vxVnAL5KfKWre7oxaXkv5lLDONJyb/s aB+ku7epJ++8HCWK0vcLb+3K4kMDAd+mtcKjwtTdGibzidCjOqsI1ss9QZQ4Jy8gq9Jg S8RFHjVAM4ESf959WYvQND7sIO1F7ulrbwFqdCglkd59bL7hzdFijt45Hw5OoTtCy4m0 sfEFYBEwANNMXNMLD8kw5olkhKc0hkeDUrlAOq/2+d6rbj1QUUnaIW+L8e+jbhCkFPR0 8XuhnxHUgBV+Sr3TivOqWXOGFDBdurm75R6tbFvdRM6wbL7M5wzPu5TWR9Cm9W4/3/gs OKyg== X-Forwarded-Encrypted: i=1; AJvYcCXwAjQMfJL9dGbRWpGNp9CMa0RbqpbGEBcUxIEFwikqz5v4kShCflX7K7YbqUMp9Lkn/qRtzinHB8I2SEY=@vger.kernel.org X-Gm-Message-State: AOJu0YwoPtIiPtVu5PHoL7XaTZz9GhvYRhN+uPNwViISfnsIeV7XmCIi 1jgCGgahBcY+MFmuPS8JIXtFCIyyZ1ufSceVIJ9hP5ciuDT2uQtqczUdNhVYIw== X-Gm-Gg: AY/fxX57iVah3j+JXeIqhLmcw3N6rEqbi7ClUr/F4hyBizaSUHv43aCpULpaJmURARg b0pJGR6Xh6ELBKnkApy0SYIjbxRlBDz1nj5oNlVRcnKHs+kRW1AJALD1/YXc+Lk0N5uMQurkaRf bb6WLEWg5fr4rzMeqO4t5RSEmW+Ns3JnWPgmrVkN2prII4HOTW+IAuY2gCJjN23T4TAE6v8cfyO s1olnJO6ldN864eqqy70OSdmOCtTyvxCCcjkPkds5ti4XO721Wy+gOp3FmbUujGmygDlXBFVivi PMeVdrxZeNCVfRUZTS4P8vTKrobc9Jd2rNZLYeD4lD66HW0uypWKpZLZvr/cA71+raoeYXyJJPJ owJIev0VSOpQcWuGuejAgE9ZeYv4miZYs9oJesSpFOoQEz7Duf8wFBr6s3PJaC2o4t7PpOK1Bo2 gazkBvzoGKvamumH5hY9zx00bJj46+aeq0Tl4sbeqH6zILk7oWgZr+Kb4HFdv2QGbGU3bdFCPG X-Google-Smtp-Source: AGHT+IF+182bbS72e3lghIBttelXo0y7zyfZsyZD6i4hXODhAKYAaX0bK9xstuu5/O7fqEeoBsceRg== X-Received: by 2002:a17:907:d8e:b0:b7c:e4e9:b125 with SMTP id a640c23a62f3a-b7d235c847fmr1751922766b.1.1765969274813; Wed, 17 Dec 2025 03:01:14 -0800 (PST) Received: from f.. (cst-prg-23-145.cust.vodafone.cz. [46.135.23.145]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4f5a3csm2073412a12.12.2025.12.17.03.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 03:01:13 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org, viro@zeniv.linux.org.uk Cc: jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, clm@meta.com, Mateusz Guzik Subject: [RFC PATCH] fs: touch up symlink clean up in lookup Date: Wed, 17 Dec 2025 12:01:05 +0100 Message-ID: <20251217110105.2337734-1-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Provide links_cleanup_rcu() and links_cleanup_ref() for rcu- and ref- walks respectively. The rather misleading drop_links() gets renamed to links_issue_delayed_call= s(), which spells out what it is actually doing. Finally ->depth zeroing is moved to a place where symlinks are sorted out. There are no changes in behavior, this however should be less error-prone going forward. Signed-off-by: Mateusz Guzik --- this assumes the LOOKUP_CACHED fixup is applied: https://lore.kernel.org/linux-fsdevel/20251217104854.GU1712166@ZenIV/T/#mff= 14d1dd88729f40fa94ada8beaa64e0c41097ff technically the 2 patches could be combined, but I did not want to do it given the bug this booted, so it must be fine(tm) Chris, can you feed this thing into the magic llm? Better yet, is it something I can use myself? I passed the known buggy patch to gcc -fanalyze and clang --analyze and neither managed to point out any issues. fs/namei.c | 54 +++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 69d0aa9ad2a8..af6d111d6ccb 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -766,7 +766,7 @@ static bool path_connected(struct vfsmount *mnt, struct= dentry *dentry) return is_subdir(dentry, mnt->mnt_root); } =20 -static void drop_links(struct nameidata *nd) +static void links_issue_delayed_calls(struct nameidata *nd) { int i =3D nd->depth; while (i--) { @@ -774,6 +774,35 @@ static void drop_links(struct nameidata *nd) do_delayed_call(&last->done); clear_delayed_call(&last->done); } +} + +static void links_cleanup_rcu(struct nameidata *nd) +{ + VFS_BUG_ON(!(nd->flags & LOOKUP_RCU)); + + if (likely(!nd->depth)) + return; + + links_issue_delayed_calls(nd); + nd->depth =3D 0; +} + +static void links_cleanup_ref(struct nameidata *nd) +{ + VFS_BUG_ON(nd->flags & LOOKUP_RCU); + + if (likely(!nd->depth)) + return; + + links_issue_delayed_calls(nd); + + path_put(&nd->path); + for (int i =3D 0; i < nd->depth; i++) + path_put(&nd->stack[i].link); + if (nd->state & ND_ROOT_GRABBED) { + path_put(&nd->root); + nd->state &=3D ~ND_ROOT_GRABBED; + } nd->depth =3D 0; } =20 @@ -786,20 +815,11 @@ static void leave_rcu(struct nameidata *nd) =20 static void terminate_walk(struct nameidata *nd) { - int depth =3D nd->depth; - if (unlikely(depth)) - drop_links(nd); - if (!(nd->flags & LOOKUP_RCU)) { - int i; - path_put(&nd->path); - for (i =3D 0; i < depth; i++) - path_put(&nd->stack[i].link); - if (nd->state & ND_ROOT_GRABBED) { - path_put(&nd->root); - nd->state &=3D ~ND_ROOT_GRABBED; - } - } else { + if (nd->flags & LOOKUP_RCU) { + links_cleanup_rcu(nd); leave_rcu(nd); + } else { + links_cleanup_ref(nd); } VFS_BUG_ON(nd->depth); nd->path.mnt =3D NULL; @@ -838,7 +858,7 @@ static bool legitimize_links(struct nameidata *nd) for (i =3D 0; i < nd->depth; i++) { struct saved *last =3D nd->stack + i; if (unlikely(!legitimize_path(nd, &last->link, last->seq))) { - drop_links(nd); + links_issue_delayed_calls(nd); nd->depth =3D i + 1; return false; } @@ -884,7 +904,7 @@ static bool try_to_unlazy(struct nameidata *nd) BUG_ON(!(nd->flags & LOOKUP_RCU)); =20 if (unlikely(nd->flags & LOOKUP_CACHED)) { - drop_links(nd); + links_cleanup_rcu(nd); goto out1; } if (unlikely(nd->depth && !legitimize_links(nd))) @@ -923,7 +943,7 @@ static bool try_to_unlazy_next(struct nameidata *nd, st= ruct dentry *dentry) BUG_ON(!(nd->flags & LOOKUP_RCU)); =20 if (unlikely(nd->flags & LOOKUP_CACHED)) { - drop_links(nd); + links_cleanup_rcu(nd); goto out2; } if (unlikely(nd->depth && !legitimize_links(nd))) --=20 2.48.1