From nobody Sun Feb 8 05:42:33 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC45F3570CD for ; Wed, 17 Dec 2025 10:47:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765968451; cv=none; b=CwBPjrR0zGNbnsRjx7jYQAHEYp7CAc+eFqsHDeA1HVgm//AHQHlOlcJhb+wkH9vi59s2kRG+YXgzHenYwpMWiLn8nxOUNIWxzYCQMqT12KJOckzJqyp2phNhsZWj3srottKhgED35YqxloGbfDtZJ2coAL5Ej9qXB6qQB/24evk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765968451; c=relaxed/simple; bh=x2crzMrwC1YF1Uj6aI9F/aTg0iMkHiRCUhVdgtWjS8g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V7YqH7EDszURL/YuVFeGQJgfy7p8RjHOFunMZbgGqNjTYL7rX3GKR6pIXwxgQhhDAEtxK+j+89I5Zsa9QeKWgPOmjRQqvd4yXcQGALdp0Ti4Hj8y75DxD6UaNSbbO8OEsHMEUu/Eg1cz6BUlDB5J+Bv/liQ5o2x+l9Iaiv6i1fU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IFEO71BH; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IFEO71BH" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso44875635e9.3 for ; Wed, 17 Dec 2025 02:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765968446; x=1766573246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4JrBoh6ZHRDCasNvYBX4L6Fc3JvSnZBFF85CYLlaotQ=; b=IFEO71BHsjScCS7lpKlFO3qsWwPCA4BRAPFdFa0xMfaPEhQSioRw1jaLI1Wf1PVb+K InukhCurZx58mqQpK5/unv/NuNf04XNEpI6tb2VNHbDzBoSqdk0ilnOR6DesiRfWIHFE DMndV2l5qThspc2imJeP7g7KUmF+7csqmUnJxAzxKQNIBJDdiF76HmiLiGxdm0ljFgel o+4UFSqOgNdnWgAZ57weqcrdpYHbIcDDMCAL1gFNfJmKtegHEuV4H4QTdiBm+UED/avZ /XR8ENUXyJkQxiq7vrjPP8dWjUEf1Qj8F9zpK3lY0PHIv9YDX+Vua15Ktn5eL8ks5tYx 75Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765968446; x=1766573246; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4JrBoh6ZHRDCasNvYBX4L6Fc3JvSnZBFF85CYLlaotQ=; b=oOVTqJu2WUKJeK8aAtXLvcmZlBajRZC0DcYQKIV21J9ZuTAENaxuPmyZKHIZkEUowW uYhw3CeR/Y/MYs5awK0GwydDKIGOdL2sTIngDFBgLqmLjTEqDw2irLp5zUcVhvkFh3DV Cph2KxUdj6YbOFdEXRAnWGMhO+pn4oQHsNDfws4x0B7q6axruO7zVIu2igem7lhepqsF c/BxhLP9ZncuT90m35i7Yfno8X7k0k07LrKOYw9j87YaLlDCkAuB1jLfydXZH6TVEZGd 5klrMAHp/JMltFzqfi7dLRy+6l+RBFnpuSar0PdO3fNbnhZUdEBeYDTlXFsqn6LOeMR8 YpFA== X-Forwarded-Encrypted: i=1; AJvYcCXcI7Rstcvf9xTOLeWkb/q49yhWIYxPcmnPJJAXXOjIJRGXYCSfCcwrDuzdN3rPgCsBnuqaDxtpkKLpGj0=@vger.kernel.org X-Gm-Message-State: AOJu0YzuEVAI87UifzNWYFIZF2EbF1vwAijM4uweIeTzqZmK37VRgfOX vZ5w0sk01tImuLUc70jKLEor4Ky0VUTZ7OWZZovvDQwnRNPb5F1q0467 X-Gm-Gg: AY/fxX4Y0WUdOvI63WSKC5X+helKACh40raGTTI9+NG+bjYsBcCA+Vn9K5CPxb2R3B5 G8PrOQ41ohYNphyS2dqfP1SjZP8YVTtEzJ/fMurmr3zSiCxykJ7dRPYwcWytXXajesY9hgP3MfD tAvAQrvvqHFLXmSNMun763J3x+usG53fkVop2kSqg8ZZ+UckT8mFbWfESZS120WZxx4ObPotZv3 r2rESYpkutj3UrXLO9p41CVWsYmMzYYEPYx8Gw2KqXprpWdPjpBQbpsllXsR8X2CDL+GhL+0R0s huge33gCWHuDLc6aszEGRwbbUGB630T0WehGMlz4+8bzI31ndrE5QEo7ujlSfJ8q3YvJPLkNiAK hLti/+wamaAlIv1HIgIh0hqcxHPWx5//OCmII52rmIsszGHO6gfeB1sR7D8L/qdPlGyWEcwlHYb eSz03gKvc4h7t5Uw== X-Google-Smtp-Source: AGHT+IE9ogSuZjkOdNM7usVL/c+ivA2aguGNrJCKqrLzx3ayA8e6EmMBTISExPe4ocx/2ybifO0/Zg== X-Received: by 2002:a05:600c:470b:b0:479:2a09:9262 with SMTP id 5b1f17b1804b1-47a8f8c00d1mr160023635e9.9.1765968445675; Wed, 17 Dec 2025 02:47:25 -0800 (PST) Received: from gmail.com ([136.226.167.107]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bd95c8fe2sm32873305e9.1.2025.12.17.02.47.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:47:25 -0800 (PST) From: hariconscious@gmail.com To: oder_chiou@realtek.com, lgirdwood@gmail.com, broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HariKrishna Sagala Subject: [PATCH] ASoC: codec: rt298: Use devm_request_threaded_irq to manage IRQ lifetime and fix smatch warning Date: Wed, 17 Dec 2025 16:13:58 +0530 Message-ID: <20251217104356.60839-3-hariconscious@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: HariKrishna Sagala Replace manual "request_threaded_irq()" with the device managed "devm_request_threaded_irq" to manage the IRQ lifetime and also it removes the smatch reported warning. Remove the manual "free_irq()" in the "remove" function as free_irq is tied to device teardown. Signed-off-by: HariKrishna Sagala --- This patch replaces the manual management of IRQ with the device managed IRQ API. Also, it removes the smatch reported warning. sound/soc/codecs/rt298.c:1298 rt298_i2c_probe() warn: 'rt298->i2c->irq' from request_threaded_irq() not released on lines: 1298. Removed the "remove" function as IRQ is managed automatically. Thank you. sound/soc/codecs/rt298.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c index 02247593513a..7d532a5a5f73 100644 --- a/sound/soc/codecs/rt298.c +++ b/sound/soc/codecs/rt298.c @@ -1282,7 +1282,7 @@ static int rt298_i2c_probe(struct i2c_client *i2c) rt298->is_hp_in =3D -1; =20 if (rt298->i2c->irq) { - ret =3D request_threaded_irq(rt298->i2c->irq, NULL, rt298_irq, + ret =3D devm_request_threaded_irq(&rt298->i2c->dev, rt298->i2c->irq, NUL= L, rt298_irq, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt298", rt298); if (ret !=3D 0) { dev_err(&i2c->dev, @@ -1298,22 +1298,12 @@ static int rt298_i2c_probe(struct i2c_client *i2c) return ret; } =20 -static void rt298_i2c_remove(struct i2c_client *i2c) -{ - struct rt298_priv *rt298 =3D i2c_get_clientdata(i2c); - - if (i2c->irq) - free_irq(i2c->irq, rt298); -} - - static struct i2c_driver rt298_i2c_driver =3D { .driver =3D { .name =3D "rt298", .acpi_match_table =3D ACPI_PTR(rt298_acpi_match), }, .probe =3D rt298_i2c_probe, - .remove =3D rt298_i2c_remove, .id_table =3D rt298_i2c_id, }; =20 base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 --=20 2.43.0