From nobody Sun Feb 8 12:58:20 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D2B3BB82F for ; Wed, 17 Dec 2025 10:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765967831; cv=none; b=DpWFaEbYAcUyiOzSbz8HbvHYMZND/6T3aoBtFGxzx+G9eh9/ZKWFrzH/CJfbiFtpecePTZZemcQfbpUAh8av6tvtFXziVf6dBnbWceOR8q/JSA/N1uiWQRS9EkkN0wrtw115c0hAu3lBkDI5ee+olaimzLlyWZnkmENROeBwR+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765967831; c=relaxed/simple; bh=0IwkmUujrEfrRf+r7HujbMtigGcx69h1H/EKUwEUfhw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GoooK4Je5eYOhGJZE5vKJALxVngGpiUrtWPf7MgHf8nTutp+pPs7iGKwhznx0v93J8v5dAOIWkTNkKe5g8tyyIZKCoUQS/mmOypjV/yp4x6PPISN8tipkeJsvos07M4DLiNAVqXy4ZR3EqMGynHFcTOJpAF1bI5J3nQSfIyu2yY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N4WegwgE; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N4WegwgE" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-47a9567bcd9so4433655e9.2 for ; Wed, 17 Dec 2025 02:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765967828; x=1766572628; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=82l9YOaC/f73jZwrcIeqTDFF04uex1FP9G0AQGYcRDw=; b=N4WegwgE6yBVFdc3pHf1q0wAYd3ZRtxxnVwyg9UEK6XsBnlPXPzbxN7TnsevC5kdCW 6SDzDJdyYTfmUObo7Rz4HJvybsZYullxAMpv0X2iI4FhydrQHKZ3iRjsRQGQonTJSGme mS6fbiZ7QSB40zZIouTXxGWJowCqAyV0ne17ZBTIMwTgyINhe213oKWHcjh3puk+froK lSl3IIMuNgKAW8opDsfWRS4FfblNGieKORjago6nBHVmO0Aj4ecmYIi30iRfShknH/Yo w5cKKuwKVn3mZ0sp7pm+Yt26QjOwldDQuoHSzxkGn6QX9axUnWbmml1H+emJqQJU7X5q zohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765967828; x=1766572628; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=82l9YOaC/f73jZwrcIeqTDFF04uex1FP9G0AQGYcRDw=; b=a3JgQlwVWTx762dCOQBT9AWXWqJoYDolFp50dimd84O2B4ji1ekTlX33EiZGWhl2JL vG7RCkWk7/pU1yyYxDph6dsNs0CjoECHiDg/RUANZ1h24BcqH6Lea1WTKrfAek2pzyQ+ s+42pMvhl8D7XxKiflh/NC5IFDYcyVM5RfXEKIm5PrIcRtBrgnveCbGL4qUX4unNDNDp O3s7MyQxUjgrNGplxCxf/90kLAwvQJnYGprcI7P0QNJoKlmRWucShZhWAqGkFCeOKVJf ix+/PSHUWeyambJgrJdHMYxp7mltZ6gPeIc6b+79xAkotsvekXJ9Y6Y/t6nrxadrQC4W dRFg== X-Forwarded-Encrypted: i=1; AJvYcCXq4uJ2+Ip2If/9o6smfmU2w5XA2Pr0wDxgV+qnn4DHsCIje+Ag+S1SVMcaowY7O3gVpi4gM82XsnsRUz8=@vger.kernel.org X-Gm-Message-State: AOJu0YyR0EmlAmOIXMW6ku3Pm94Lk9N0tZlXA27U5JJ4lSMQ95U9cAap uRxpTYSNnaEs/0qfCR7KCjszLEtGiYIttyb3/ZDpSUJjuxBSTh+urV3k X-Gm-Gg: AY/fxX5ow0HLy67ogb3YgGiWSuPWEPL3ZoTTc4IlGHMYYrJm+axTxPt4MMQny+WyNLq aW2/OqHhSxj41g3UTEur8c+5dZXNFCSeqfMQ1S+TVAocCoZ6E8x+yCaPt3JoxPmEzZhtLvuqznN ZJHLspCFj9Y8keJimhcSjxFv6Ytw+EtyAyMVhB5DrzjG5SI8Nt5n3OksvyhWLGiR46CjmTlIKOv hOpCqWh+XlBIWBrpoHQ3gV8D9oQHU6A9gDUnSWTRumYk/MRA4vpCvI0e5JMiujAvMyk4NmG3ifH ETqXuPdBl0UuWPJ/PtzBJcJY4fS0r80AERzH1/HXrCeUxKnfj7+ibFk3yxTNot/rxOc7+r9kGpc 4kHTW1vvb5KKS7yHymp3ExM9ADY2vJhiZCTmNnqt5VqeFUAHkLC+Va7XvXNJ0HCglTi3BbtSN7C 10KmIRtLUK11ml6VnK978t9qR0Tn9vohx9F2XfxAiyJQkRoSdHqPdneewG2ZXIG4EiZ3xY8si/r 76vyFo= X-Google-Smtp-Source: AGHT+IEc9c/iXKKpqtn4WaK+3xTBlq6Qc8k2XqpSMw4oXSdehCCr4nOOh4OfbEzmV8mLtgo/Px3XMg== X-Received: by 2002:a05:600c:468f:b0:477:7bd8:8f2d with SMTP id 5b1f17b1804b1-47a8f931e37mr121012425e9.8.1765967828066; Wed, 17 Dec 2025 02:37:08 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-215.paris.inria.fr. [128.93.83.215]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-47bdc2314b5sm32153705e9.13.2025.12.17.02.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:37:07 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , "Lee, Chun-Yi" , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Maxim Mikityanskiy , Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/x86: msi-laptop: add missing sysfs_remove_group() Date: Wed, 17 Dec 2025 11:36:13 +0100 Message-ID: <20251217103617.27668-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A sysfs group is created in msi_init() when old_ec_model is enabled, but never removed. Remove the msipf_old_attribute_group in that case. Fixes: 03696e51d75a ("msi-laptop: Disable brightness control for new EC") Signed-off-by: Thomas Fourier --- drivers/platform/x86/msi-laptop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-l= aptop.c index c4b150fa093f..ddef6b78d2fa 100644 --- a/drivers/platform/x86/msi-laptop.c +++ b/drivers/platform/x86/msi-laptop.c @@ -1130,6 +1130,9 @@ static void __exit msi_cleanup(void) sysfs_remove_group(&msipf_device->dev.kobj, &msipf_attribute_group); if (!quirks->old_ec_model && threeg_exists) device_remove_file(&msipf_device->dev, &dev_attr_threeg); + if (quirks->old_ec_model) + sysfs_remove_group(&msipf_device->dev.kobj, + &msipf_old_attribute_group); platform_device_unregister(msipf_device); platform_driver_unregister(&msipf_driver); backlight_device_unregister(msibl_device); --=20 2.43.0