From nobody Fri Dec 19 20:14:32 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35DE233B972 for ; Wed, 17 Dec 2025 10:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966320; cv=none; b=kFsH5B4EeNBGzxI3XDGX14VreICsoyPNgExrjJ8YpsaJeuiAg+m1qN1tFlLT+I/POyIP0YXo29aEbzLQdmASQjMU54si4NtoJ4zxV6mTfJnSuIuJL0DKKF0ZslVO6FB3+VmgmOFCz018tZtbQu3IZ+AkInrulSRgiqD9dCO9JeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966320; c=relaxed/simple; bh=TmUYZB8WjESDVweOp5hzlAfaWP1RU/QdK0bqBK+51BI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=llMrnNgv7JqxXJNxcYY5w4/+usPG8o5fJsHWJn/MM437l0nSEqVO4K/H/u0af5NXe3qaMpCKxjKuSYpp/o65sZv6jkI98+vAr5rGI30aJpDgW0qrZ3dUp+PjBVFhaX1Zhj0u1Nj5QvV2VCnNzk0gHxN/Fh5oTKvZGLIDikXMaFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=fail smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YNnqs2JC; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YNnqs2JC" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2a0c09bb78cso3107655ad.0 for ; Wed, 17 Dec 2025 02:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1765966316; x=1766571116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K04ow0eNGFdOpSpME/SmZeUSWAE32cTHhjE42HTO9TQ=; b=YNnqs2JC7Z2mbTUrpQZqxpTXfsFsO+r3K9RE/OM6XnqNf3Y6EVfYsdryCRk8pEQKpR hHYt7N7tamX/GudQeP8AleaDNsW7YrbuxoIS1PNqZdxciSxsU7lDQjS7XobuO9cl5/rK EhvBxxxkEOoV8afQLUs8BQk95Jt3KLeLVCvI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765966316; x=1766571116; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K04ow0eNGFdOpSpME/SmZeUSWAE32cTHhjE42HTO9TQ=; b=doPLQQxk9f6rMPAnfC4P9GMuX4n/r1l/TtbtapXBN1rpql46WMb/bD8d6AH6twDJdk XXR6mUFBL0KTcRQqf+doNY0eX7sFXe/LQMwFsWaNcavFNO2c5SO6VLrYZm7lSDpNBcZf d3ov0Ir9pD4KNxL+yqgqjsrm1iNJ0at4T/0nWDRq9cnJK9/B5J+xa4u6rqQaWwNnmMph 3WhDy/fI1rfDpxs39DAnj6ilHleAXsdd+hK+2i3oAFonbJdNv3mL6XT+NfcIIMcJ5Y14 idBX8YAfTs1FZo3c+2kqFmNjwytlJ0HSOhNEp8fLutI9vQVivHJz2rSDftq66m8/4BU8 t+Bg== X-Forwarded-Encrypted: i=1; AJvYcCWXkcqCR0M0LA1GQI/myBspsBUn1Rr32dEqMZKgy5LS4mIskLjt0UiIM3wABmYkmdxkJibPlluu0M/IpMw=@vger.kernel.org X-Gm-Message-State: AOJu0YzyGu9WrDkGib5k91YSMSBZ78nwW0WNzDyp3aZ13mIyFDe9pI4J ukgic0LHpme1gXGo5aoJ3IEaOeAoLWiGShoE+VNSy/qaumS4OCtxmGIODwj5Kc8X7g== X-Gm-Gg: AY/fxX5Y2DjDi4wyEpy/6LLStjGS9nEsY8dl0EhPD+vXD8EDRu2/jB3+gxu62TYGlss iuIn3M5pt2zX5jVGXqMeNiDVGtzr/Bnvq3HHRFBRHR8eHgg7md7vGQO+2WFbn99MA8DZau9tddQ VzEjSctGzHfA8gf+tiI4fv2egbjs2ul1oYjPXhDjzycaQNWOkZTkp1yqzU4eLfQKm9jNxEU/nSt WiuaNVogN96u9+TfyWOYXOOqyniq6Ej1FM1lU0kJbrQKpjCthVINVIu4Ydb/GSyVldOL6IMMVNG AWdy3cpLgEw6d3NMrx6F6qLYACPMc+dSNEB72CtRNgUYAal5ELz2+LymzTEz2YGm5+dsqoNgKEf Rk6PQlv3Q8yNtezgIryv/zOwFtMA/R6MUr+mstqHQd8Nbv0ax66xeIljk68NXXYg6SXgqnh+Qvl PV98ukCCvQrDG/DyE6MREpIYYnJOlN0NOpn902LoBLTSiq7eM3eFRa2v7FxpOWFjGKZDrf X-Google-Smtp-Source: AGHT+IH9JDk9/8ttnmED8uX+Mmzi2jbUa2ALm/TceQ9Kmj2oqUNGhg7IR2LAST5VvPsW7hnAHuK+Yg== X-Received: by 2002:a17:902:ea0f:b0:2a0:9238:881d with SMTP id d9443c01a7336-2a092388d07mr158621885ad.15.1765966316255; Wed, 17 Dec 2025 02:11:56 -0800 (PST) Received: from fshao-p620.tpe.corp.google.com ([2a00:79e0:201d:8:6cf9:c1ec:793:b8d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0cf143804sm102912045ad.73.2025.12.17.02.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:11:55 -0800 (PST) From: Fei Shao To: Mark Brown Cc: Fei Shao , AngeloGioacchino Del Regno , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org Subject: [PATCH] spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ Date: Wed, 17 Dec 2025 18:10:47 +0800 Message-ID: <20251217101131.1975131-1-fshao@chromium.org> X-Mailer: git-send-email 2.52.0.305.g3fc767764a-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This driver is migrated to use threaded IRQ since commit 5972eb05ca32 ("spi: spi-mt65xx: Use threaded interrupt for non-SPIMEM transfer"), and we almost always want to disable the interrupt line to avoid excess interrupts while the threaded handler is processing SPI transfer. Use IRQF_ONESHOT for that purpose. In practice, we see MediaTek devices show SPI transfer timeout errors when communicating with ChromeOS EC in certain scenarios, and with IRQF_ONESHOT, the issue goes away. Signed-off-by: Fei Shao --- drivers/spi/spi-mt65xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c index 4b40985af1ea..90e5813cfdc3 100644 --- a/drivers/spi/spi-mt65xx.c +++ b/drivers/spi/spi-mt65xx.c @@ -1320,7 +1320,7 @@ static int mtk_spi_probe(struct platform_device *pdev) =20 ret =3D devm_request_threaded_irq(dev, irq, mtk_spi_interrupt, mtk_spi_interrupt_thread, - IRQF_TRIGGER_NONE, dev_name(dev), host); + IRQF_ONESHOT, dev_name(dev), host); if (ret) return dev_err_probe(dev, ret, "failed to register irq\n"); =20 --=20 2.52.0.305.g3fc767764a-goog