From nobody Sat Feb 7 07:09:56 2026 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD05346FB5 for ; Wed, 17 Dec 2025 09:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765965311; cv=none; b=SVXz0J08LTh3btF3NtC9JGlBVo2KbJxhdU618qkeg1gqQAMG82I3Ky6uc0m7NioMha4HSB1F/1ild54BbCuIulpZJVthj5gNEN9nt1R7IJKw6grQv3wNqt6pr70SeQ/lpp8wh8u23vNvOYHG3V16M47qy6hDI6LvvQ6EHQMJrI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765965311; c=relaxed/simple; bh=jNDDbcagd7GAuu2ax19vRmL3haiq1I8BaTv4/D338Qg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cv1pq15zAIJp86uQ43SwHqUT5rq9qJn+i2vthK0kGhOfDVP1D+Ge8/ABSITnjmYtVOyT9D+MCp0sHmMV5R9fTfVehRq7uayR1PzqYkonCf/o/1cygakY3pZbfRozO3A1I8G7k7XVkstj9aFBFKfHl6C3HfCcHhTg0Rd54MsH1VY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MP9jn1xi; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MP9jn1xi" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a0d67f1877so40254105ad.2 for ; Wed, 17 Dec 2025 01:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765965308; x=1766570108; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uqU7Z+qRZovJUMSBsI+FDu17KbC0yuT8froZI9mKrQc=; b=MP9jn1xi0iE4uyh0iTVjLkcKV3V1Y94KL82so/SPnbVLs+QYkZ+o0q6VJkyP5cfJ54 sOYDHtnzv4fe26+hIcFE2ErUJd67fbm90Tv4TBBfD+2oIue9lmQ3HngRtzoaPPXE3kzl h4CV8ngd/UqgvfWbHMggps9H+XC3wz8bnLMng+1E1SFgXEZlfiw+BU4HuDwwKWMqFqP4 j2eDadkQyu7vZVjPnhUMPLMFAMcVTowHPoD2e+LIokG/NlYfc6wCvY0D0VCUON0eKNrV aSvE0zlqiQNJUWHiiUFcfHWk0vI6t0XKWXRse6RJdXZJTD/lnTE/78fbFmacGTgrdj93 f8Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965308; x=1766570108; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uqU7Z+qRZovJUMSBsI+FDu17KbC0yuT8froZI9mKrQc=; b=Cwev4zhOTwdRwFtEE5+MR4SUA9w6HEIzNNhSiNUjhRPfbiHzQdiwhfgVSWJwW+TS8l bCQaztHZbqOGBnEvAEJ3qF7WKXo1E4d0MORL4F3pZK1fkYWLaZnbSriz17CZcjJWn4jB CaTpiqgFVM7QDtPecSlz0ndaDineAkE3Gu0ItNBnq8V/foQr6/pLPrpW0Q/OIU5gHRrL 7y401yYTvf06PwI77KKuLrrhRvov7EmEweVrI4QAf4aNj9GpWJI7SR2EwY6u3zlWv6vn yM5BIXGlCXWN6dmCVIe9XAnNgXXGZNIirWm+iZjOAJPQVNdxel2hNJecVeCVlg/xBGCs a+mA== X-Forwarded-Encrypted: i=1; AJvYcCU6ShHB8Xfrm73IwoR2tbzFY/M3/vJEYnjfHKFBXSoiBJCgve6bnZSb67yUF7U0d2o18gEkDWv6uTieaZI=@vger.kernel.org X-Gm-Message-State: AOJu0YyK2VXaDPLAVs7LfK7eqHOAz/mQj1yuykLvM73tZZB1dLM8YZ4+ w2WQe27i1Pu1NEgRsow8ETlGbqUdGgOpMidmRIeFmpfswsdCqm0UdM6T X-Gm-Gg: AY/fxX4ymifwMa4oCpspxIgLdCr4gvFNmc55E1mo+HpJ7Ldwuokd8MmGCflLUaARSxx 3+WaID42TPZ+my1+DJjDG6hcmM6EFBKkYK3XcVDm0apzhVEySR3fsEj/7xdTM2lg56uBesRZR2l OPcog1FxAMRQqUdDPU2WKirrrVKI5njSR7P/m/167/IUy60cKNTX/IiGNr+qIwUN59SG1ZyGwug 0SkQwbUqJRfp6p42rP0KbCGAX/JbojSGvaDSeTkCWet426EwgkJ5NnPt3uqG7XD38eTNgzusaba Q9cI524U+Hi5I7FGsIO/UeTdFGIJku4/JECYlDsin5GqeOkYdRcLr2h/FgEPhDyXOh2pnGFWNYq e1aMz7DBYX4dNBJ33KAkQeW35XShHgNVwUXiZhpgeqzwm720uVI9Vf9Ngx1JCmLSp450UKtdnsi uZe4jVJLg= X-Google-Smtp-Source: AGHT+IFILQ9PCGB1k7TzRUfGk8NAtRn8WD9pgKOijI5EAUlfitwWLOp+2LpFyNyqCtqlHGTd0BF75w== X-Received: by 2002:a17:902:f54b:b0:2a0:8963:c147 with SMTP id d9443c01a7336-2a08963c3fbmr154939745ad.45.1765965308289; Wed, 17 Dec 2025 01:55:08 -0800 (PST) Received: from 7940hx ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a07fa0b1aasm140715945ad.3.2025.12.17.01.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 01:55:07 -0800 (PST) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org, andrii@kernel.org Cc: davem@davemloft.net, dsahern@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v4 2/9] bpf: use last 8-bits for the nr_args in trampoline Date: Wed, 17 Dec 2025 17:54:38 +0800 Message-ID: <20251217095445.218428-3-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217095445.218428-1-dongml2@chinatelecom.cn> References: <20251217095445.218428-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For now, ctx[-1] is used to store the nr_args in the trampoline. However, 1-byte is enough to store such information. Therefor, we use only the last byts of ctx[-1] to store the nr_args, and reverve the rest for other usages. Signed-off-by: Menglong Dong --- kernel/bpf/verifier.c | 35 +++++++++++++++++++---------------- kernel/trace/bpf_trace.c | 4 ++-- 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index d399bfd2413f..96753833c090 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -23275,15 +23275,16 @@ static int do_misc_fixups(struct bpf_verifier_env= *env) insn->imm =3D=3D BPF_FUNC_get_func_arg) { /* Load nr_args from ctx - 8 */ insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); - insn_buf[1] =3D BPF_JMP32_REG(BPF_JGE, BPF_REG_2, BPF_REG_0, 6); - insn_buf[2] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_2, 3); - insn_buf[3] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_1); - insn_buf[4] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_2, 0); - insn_buf[5] =3D BPF_STX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); - insn_buf[6] =3D BPF_MOV64_IMM(BPF_REG_0, 0); - insn_buf[7] =3D BPF_JMP_A(1); - insn_buf[8] =3D BPF_MOV64_IMM(BPF_REG_0, -EINVAL); - cnt =3D 9; + insn_buf[1] =3D BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xFF); + insn_buf[2] =3D BPF_JMP32_REG(BPF_JGE, BPF_REG_2, BPF_REG_0, 6); + insn_buf[3] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_2, 3); + insn_buf[4] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_1); + insn_buf[5] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_2, 0); + insn_buf[6] =3D BPF_STX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); + insn_buf[7] =3D BPF_MOV64_IMM(BPF_REG_0, 0); + insn_buf[8] =3D BPF_JMP_A(1); + insn_buf[9] =3D BPF_MOV64_IMM(BPF_REG_0, -EINVAL); + cnt =3D 10; =20 new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, cnt); if (!new_prog) @@ -23303,12 +23304,13 @@ static int do_misc_fixups(struct bpf_verifier_env= *env) eatype =3D=3D BPF_MODIFY_RETURN) { /* Load nr_args from ctx - 8 */ insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); - insn_buf[1] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_0, 3); - insn_buf[2] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_0, BPF_REG_1); - insn_buf[3] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); - insn_buf[4] =3D BPF_STX_MEM(BPF_DW, BPF_REG_2, BPF_REG_3, 0); - insn_buf[5] =3D BPF_MOV64_IMM(BPF_REG_0, 0); - cnt =3D 6; + insn_buf[1] =3D BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xFF); + insn_buf[2] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_0, 3); + insn_buf[3] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_0, BPF_REG_1); + insn_buf[4] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); + insn_buf[5] =3D BPF_STX_MEM(BPF_DW, BPF_REG_2, BPF_REG_3, 0); + insn_buf[6] =3D BPF_MOV64_IMM(BPF_REG_0, 0); + cnt =3D 7; } else { insn_buf[0] =3D BPF_MOV64_IMM(BPF_REG_0, -EOPNOTSUPP); cnt =3D 1; @@ -23329,8 +23331,9 @@ static int do_misc_fixups(struct bpf_verifier_env *= env) insn->imm =3D=3D BPF_FUNC_get_func_arg_cnt) { /* Load nr_args from ctx - 8 */ insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); + insn_buf[1] =3D BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xFF); =20 - new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, 1); + new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, 2); if (!new_prog) return -ENOMEM; =20 diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index d57727abaade..10c9992d2745 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -1194,7 +1194,7 @@ const struct bpf_func_proto bpf_get_branch_snapshot_p= roto =3D { BPF_CALL_3(get_func_arg, void *, ctx, u32, n, u64 *, value) { /* This helper call is inlined by verifier. */ - u64 nr_args =3D ((u64 *)ctx)[-1]; + u64 nr_args =3D ((u64 *)ctx)[-1] & 0xFF; =20 if ((u64) n >=3D nr_args) return -EINVAL; @@ -1214,7 +1214,7 @@ static const struct bpf_func_proto bpf_get_func_arg_p= roto =3D { BPF_CALL_2(get_func_ret, void *, ctx, u64 *, value) { /* This helper call is inlined by verifier. */ - u64 nr_args =3D ((u64 *)ctx)[-1]; + u64 nr_args =3D ((u64 *)ctx)[-1] & 0xFF; =20 *value =3D ((u64 *)ctx)[nr_args]; return 0; --=20 2.52.0