From nobody Thu Dec 18 23:23:14 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E932328617 for ; Wed, 17 Dec 2025 09:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765964230; cv=none; b=aLGav5/Qo0k+QMree8nGGoWcbKGwe3AoN3SAu1K+FWRsVbHC0xdGIAZIroWo2iluTsGaJbyR/TUfODPz/K59ykzB5LWOOSoYPT1efB8o28jBm5HyLnMl+w8dKXPshj/6TEle2OZZNW27dpHZ0t/3GjQnBSOOJyl6xq5fawoVZD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765964230; c=relaxed/simple; bh=ADLWZB7heMvI8C75+SC62FWj4QS0Sqtg+MDBZq15gwU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bUP2RrD7gGx1NZ3UqTQYZ/Otww+2tYDkbE4/hSccdsjenPmkEDLnbWAt4c15opBQMuiL2LUQyaq1nd3SfLNvcL3PBV72fRHkVbf1oQ/k39/ho4Vbql3wkgDQAKnSSv4i6NUkt+F5JoXpjha79lQhep/CX5T46U+BK/PBCiWWb4k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SBJNXi3A; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SBJNXi3A" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4779b49d724so11338595e9.0 for ; Wed, 17 Dec 2025 01:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765964226; x=1766569026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z1GOk404zfyFe5sUCnK+WQVcDYCJq/p7/vBWn+8ExHM=; b=SBJNXi3ASWHbgGJylnJ3AEY9CcismYr44Ta4PWdOrVv4dx9FKjg7/4ouhOp57R49aD d90BZicsaFq/W8qwLLz6U1byxcgytYtYVVrKwdUOl7Ifh9h2IHavoeIEkOYbaSbSsRbz zFOzb9EqpL2oiACatE/8lB5bfPq9egtHHKCxLEXOrNTqihxlK+gtzVSK/4gGVjrDmOA/ +l9gEp7L+kH+kUiqk4up6TLLDuqWVMoF0J7ptppNcBe/Si4PYakaBQ52k56BNDR0pEla ZrYqYRjNHqLUdppjvuxhBIDqk6OZXyaepJgV76RGe3et4H8gp7zeFD3Q8GCuT9ynTvn8 vMIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765964226; x=1766569026; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z1GOk404zfyFe5sUCnK+WQVcDYCJq/p7/vBWn+8ExHM=; b=HqEY0vfTVUb/qvqmzfJAqCFFY5ki4wZTNPKu3AHHUHNabC6MKqNYgdznCqUzIC5fsr 0A0lseYuBd8norWZWslkDt8QDFJjRi4ojCjSzU8OnKPsCaT6Hm0mrp+CWHSXYMMYVjos gylKZJ3pcJHE8dJJFA3suMoJXqGrKSIJvUAxk+Fa9V+Il/p5H+INsC2uEts3AFgfPnyh t8B0tEGXwr8B4H6ihLwm9p4bHdjlVvJcqfMrdc+mjYxXv+WhOyKJElY0AwWQ3e+fveol vbpbMf95CLba9GB3WsGqWzKpd71GIHNlBn7rLbpO00+YlyF5g2KehZBlWc0bMdsgwou6 8C1w== X-Forwarded-Encrypted: i=1; AJvYcCWNk99na+mydzzhkMf438hVfxYi5v8m5FlKMWAerK43sGDb/tPC+lxXiz72udI3IX/S6vcJgGs9yXbdjsM=@vger.kernel.org X-Gm-Message-State: AOJu0YypZwVtI/UTyryDf+WLr/U2K0bclAyMEQBWMabpKQ8wxjmVJHbH qudK+3y10PKSje+CVLSTocFxEWT1jKQXmDhZQ5cXhelYC6clyrb+fVw2 X-Gm-Gg: AY/fxX7LWJELyv+2weIS6PMRIKmkeL7pgPAvbtYI4AopMsxmVPJKR4kPP7rx0Z5dCs7 oBoPMjxg6cBjvjJalP3S1C8pqG+J7nUHl+lrqsoXRY1bqgiSM2vJSLWJfj7WPf7JDchixzLCWji v0bEeNWlwImwbpoyB0jncqTz4InIHLel21dzNSVMc16BemMGAyh7VoZDgcmRdUMQORGv+G5B7IO pzgkNG5V5vFrTISXdf3/GgDrXtIJVvsW4S2MGWAiP9IOQYV/S24V0LSW6B9x4Q+bmt9LU0re06L +x78V9Jzl/yiz0hx/HeQ1e/ke64S/+wCqZg+2Tiu1GdKfYl1xLSVLD2UARoUlUmGw9RfQch7249 54AwdseRzL6FsePotDiA05DxLEzUKm/ofzkJkYUV6hokqDUZvDvbexjYPnUH5RBdU2VrBFElsnJ 2Za5cR8cL1oy+DE8aegjFfMijR2HreS9C2yU7ihde8JO+nPGKQXmZWNk7MwwG7u5Wf8TsXOzR97 A9+c+Q= X-Google-Smtp-Source: AGHT+IHgamaBo+e2Pgz14lTDAZNfZl8uQyf8niiu2ktv7qlyAEpoAjbF5VQVzy++0hTE9iQhnltqOg== X-Received: by 2002:a05:600c:8b62:b0:471:1387:377e with SMTP id 5b1f17b1804b1-47a8f90f781mr120237745e9.6.1765964225630; Wed, 17 Dec 2025 01:37:05 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-215.paris.inria.fr. [128.93.83.215]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-47bdc1c2076sm29854865e9.3.2025.12.17.01.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 01:37:05 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , "Md. Haris Iqbal" , Jack Wang , Jens Axboe , Md Haris Iqbal , Lutz Pogrell , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] block: rnbd-clt: Fix leaked ID in init_dev() Date: Wed, 17 Dec 2025 10:36:48 +0100 Message-ID: <20251217093648.15938-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If kstrdup() fails in init_dev(), then the newly allocated ID is lost. Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname= & blk_symlink_name") Signed-off-by: Thomas Fourier Acked-by: Jack Wang --- v1->v2: - store id in dev directly drivers/block/rnbd/rnbd-clt.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c index f1409e54010a..d1c354636315 100644 --- a/drivers/block/rnbd/rnbd-clt.c +++ b/drivers/block/rnbd/rnbd-clt.c @@ -1423,9 +1423,11 @@ static struct rnbd_clt_dev *init_dev(struct rnbd_clt= _session *sess, goto out_alloc; } =20 - ret =3D ida_alloc_max(&index_ida, (1 << (MINORBITS - RNBD_PART_BITS)) - 1, - GFP_KERNEL); - if (ret < 0) { + dev->clt_device_id =3D ida_alloc_max(&index_ida, + (1 << (MINORBITS - RNBD_PART_BITS)) - 1, + GFP_KERNEL); + if (dev->clt_device_id < 0) { + ret =3D dev->clt_device_id; pr_err("Failed to initialize device '%s' from session %s, allocating idr= failed, err: %d\n", pathname, sess->sessname, ret); goto out_queues; @@ -1434,10 +1436,9 @@ static struct rnbd_clt_dev *init_dev(struct rnbd_clt= _session *sess, dev->pathname =3D kstrdup(pathname, GFP_KERNEL); if (!dev->pathname) { ret =3D -ENOMEM; - goto out_queues; + goto out_ida; } =20 - dev->clt_device_id =3D ret; dev->sess =3D sess; dev->access_mode =3D access_mode; dev->nr_poll_queues =3D nr_poll_queues; @@ -1453,6 +1454,8 @@ static struct rnbd_clt_dev *init_dev(struct rnbd_clt_= session *sess, =20 return dev; =20 +out_ida: + ida_free(&index_ida, dev->clt_device_id); out_queues: kfree(dev->hw_queues); out_alloc: --=20 2.43.0