From nobody Sun Feb 8 05:37:14 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74D533A70E for ; Wed, 17 Dec 2025 08:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765961473; cv=none; b=o16obe+l08ztO8YlABds3ua7FLBEAD3y8Vmgv902iV3tCNOY2oJ6V0tGgFuBr79aEL5Q+Nqn6nzGgDydSx849sKimWPIqAnA1fDqor5UsenO7gkYvMUd4WaSWffX6Al/L8XL9mlnTOWUhRhxhliUPMRw3Bo4lPDDGD61oyTs8b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765961473; c=relaxed/simple; bh=dpOQWuBh0QYcp41epU4bOBn1YkCEX2RBE5dAA6qahPU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ETg1yS2eC5uad+KKPXcu3QfTy4nUt5NKxt1wqqw3od7J8zIxvbiL2FmU/CJ7nLK0bAgMBuwvwsmofxSsb34A5B+h9VrTkXR7taR/vR6rIE2Xwx7DHrRu+5xiH7Z7M30AUBuBARKX7fDvky+MHUvjJAJem/Aay/tlhMY4qW/czss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=htG3QTef; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="htG3QTef" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-34cf1e31f85so902635a91.1 for ; Wed, 17 Dec 2025 00:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765961471; x=1766566271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=InBMy9THL/+AKttWz10fgYUD/zq8kVUZDf3eTuw65J8=; b=htG3QTef0iXqh5jPkxxW1NF4xyts36wIELh65mN2+VxJG8nTMO2+fA7pGnNQyndHYB /Lt1vfDzr2FwKL+oDPGts88BRjJJav3kKOFkE+z3y52S7SG51rB3BsrSt46jyiNpCiQi A4kL8dLjQ+qKzirSBp8/g//ARqiCh8nyX79uAVFlb6YozlB8g6jsXFICIsZ27Ny6AZm2 H49+o1rxK+IOj9Yw4ycs77fzpkRvJ11bj0c408IY0yWbfPQWdqDtAZyGtm0ntnjV0uRw ylM8dkOjOa7Hu8TfVfyHLUgusypglH5N4it/ULbZq+gtydgBFvhNMsDAP7/70M5VHfDv rp9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765961471; x=1766566271; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=InBMy9THL/+AKttWz10fgYUD/zq8kVUZDf3eTuw65J8=; b=DbCCw2Ve/6oD4k/Cl3OFK99tPsRdzf7np0Q9HU81flkBaEVGxnzOe4rbDFYs983E1g sMgRhLbWoscXaHO08ahbtatggb/X7HZXIc9ypOXjMGExiuGLxjJz2IbTdBSLmkVT4YVd GuNJ5/44zuVpEWIKoOSk6mCrh0EHC1JAn5jHFqRw+E+NlLkCZOcMCRzQIc+PNExKJuik vTGmmnVrnCbvE+81HBxZItdEhZ17NTxtNf7Fmq8HpXA3HjbIn3H3Z2O+kb18/5tWqeY/ 4Z6HzkIdpaLnSSaY8K8vdMoGmvE7pGIRA+5JOduG2H79jMh7eNwclM+FxrbPiCKQ18yY GtEw== X-Forwarded-Encrypted: i=1; AJvYcCU8psPDACt0K2R2EpZhJxw3kTrVHXAfGUkvPBIRs0lTamAHM26IXUshyR/KPAIDGCwRz+fRuBhKj6rmR7M=@vger.kernel.org X-Gm-Message-State: AOJu0YzKS3Iodiy4CJwCCAb1w4SO0LwyBJusDk2EGewHRd6E8WShhz22 gHHzXZ7ckGZrCRuKNVaZYgQtLtZsSGUOSrxK/NXsyaQmPjow2bQnWZQh X-Gm-Gg: AY/fxX77jO//ThaU8y9fRUXWDZy7852t3QJp3suAgg3Lb+MWIyJsB28lwfIK26YqKT5 Al3Mrv9kGueR+RxnPCheNk9PkckGGsqyl6An5jF3h5wbJZaTw38Aayfm8zptO8BEfM8UqGRbt+o p6SYsI5INIxJsJz3dsqfF8wUpFqe/gHTKOmsl4dLi5HuEFfsFYNYL6yEtx2S0siN8SecOXmzb0N WqLIASujOD3x3eIgVp4iGyoPNT8h6ztNwN0qMZ58HDYaOBvZe9aLkxKNpDga4uRJUI3SNd7Domm N9LIKnRSsG+aaSKtRA6OK3PtSGjj/eiqlYMLiKsCyUa3YAgji+Zwvk33bJqxY5Y+CvD20QnnpDV k0PZBUgYEVMY+TlRZ8NZjRrEQ02quxmUXN46w7dtzEpKjpKw4bERgYuBAMkRbNlj2qQtw1inT77 5VVMosJBj9KDJDtGJidKCFNDnNn2E12bCivru2o2MNTLP3aJx4iGHFVTa+73VKclbRdi8= X-Google-Smtp-Source: AGHT+IEZIbsXjRYAzwthqUL9izCT0P/bBYc6ctvrcCaiRWG4w6M0LZKqWuthurxHYK2J2E0kB/Ip2Q== X-Received: by 2002:a05:6a21:6d96:b0:35f:5896:85a4 with SMTP id adf61e73a8af0-369ad5e9564mr16560809637.5.1765961471020; Wed, 17 Dec 2025 00:51:11 -0800 (PST) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:d95a:1e5e:256b:2761]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c2b8e0fb4sm17531670a12.25.2025.12.17.00.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 00:51:10 -0800 (PST) From: Deepanshu Kartikey To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, khalasa@piap.pl Cc: o.rempel@pengutronix.de, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+3d43c9066a5b54902232@syzkaller.appspotmail.com Subject: [PATCH] net: usb: asix: validate PHY address before use Date: Wed, 17 Dec 2025 14:20:57 +0530 Message-ID: <20251217085057.270704-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ASIX driver reads the PHY address from the USB device via asix_read_phy_addr(). A malicious or faulty device can return an invalid address (>=3D PHY_MAX_ADDR), which causes a warning in mdiobus_get_phy(): addr 207 out of range WARNING: drivers/net/phy/mdio_bus.c:76 Validate the PHY address before returning it from asix_read_phy_addr(). Reported-by: syzbot+3d43c9066a5b54902232@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D3d43c9066a5b54902232 Tested-by: syzbot+3d43c9066a5b54902232@syzkaller.appspotmail.com Fixes: 7e88b11a862a ("net: usb: asix: refactor asix_read_phy_addr() and han= dle errors on return") Signed-off-by: Deepanshu Kartikey --- drivers/net/usb/asix_common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 7fd763917ae2..6ab3486072cb 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c @@ -335,6 +335,11 @@ int asix_read_phy_addr(struct usbnet *dev, bool intern= al) offset =3D (internal ? 1 : 0); ret =3D buf[offset]; =20 + if (ret >=3D PHY_MAX_ADDR) { + netdev_err(dev->net, "invalid PHY address: %d\n", ret); + return -ENODEV; + } + netdev_dbg(dev->net, "%s PHY address 0x%x\n", internal ? "internal" : "external", ret); =20 --=20 2.43.0