From nobody Fri Dec 19 20:10:27 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79A5B20F09C for ; Wed, 17 Dec 2025 07:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765955005; cv=none; b=uv8G2GxK9RZ7PQxLyZ+SUaPoPMXG0H5FKV2ZN0pvwS3U6T+ZMz3pb9TyOtivp7G6XcsOX3umAz2poUTevS01Hz2qGp1e6yECZ1YhSZVAN2ib/Aq4YU228LBxoUJLI5NejxXYTprLnqz0aBPp3lNCP5ifruFWP8GZ7OYRpas1Gs8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765955005; c=relaxed/simple; bh=bsvP+mFNCY9G0fXAKZvclr7VxNWWKALYdGQRKB9n1W4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BocllD7LDHuHfu/mYdCY19nx6OX65bd1aEAVkcIb0jM/r+Zp30AQKIY4GYr0VV1VlW8Q5DsNR92U1cbNQzEMmVhH9xMbOmksG8iNJNnf7Pljw0sNqAQMr+NvCHfSGIHnd2WK1f2H8MDcx+qFn1ESCA1dREc0OF+tQhKbE5hNT/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bMGcdQz2; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bMGcdQz2" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a0c09bb78cso2097365ad.0 for ; Tue, 16 Dec 2025 23:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765955003; x=1766559803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iADtR7py4dtGWy06rD42XqEtE43GI8bd+5EMoGfsWAc=; b=bMGcdQz2IgLZVVEM53Rn60AZPprsrWfrEuFSw1yf8DYF0D537pOzOcVE8yedShoVf3 r/01qZdKMSJSezCmeIPxLSFlB29W+6HNOliO8B6BwmgIEIMaINH7ENYatXVc9YEmis47 YtFHHkkUnyHGNTC20bWPdq4HBLDJlxKPy301HM8vov9SCclgveds6KBqeiljWV9lx5gS v/VptrOh25COREREal84FDKBHjwq3AWu0mMWdPjVFob4MlLCeO5PMp0agCvmw39mJDZV Grie3yOqI3YyDEakftcfeTajpMPCZtG6CNCTAyzJXOJTZWuS6BUGrd2bidGfFPe064PS SX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765955003; x=1766559803; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iADtR7py4dtGWy06rD42XqEtE43GI8bd+5EMoGfsWAc=; b=K3XM3FtoG/9DfhjVWTXwicu+gYgM144vqgL9+LJbtGX34kt//ZI4MnaayxIXuR4uVB NsF7ty+MrMub7QWJzMX+KXiaAjpTWmpNcT6LqcO0wPVyuKj/iMvwKeHFmxn2VjhJrk3U +As2yNuJ4fWwy6POavzROZZy/7K4PYdRu/wZRLldbvqpsSM8zpdGkA/r4P+P+D9e2sXH rzt0p1VIZ503iGSmtZk8j/MLXRrJHK7Y5t6HCuWmIQ2fR6R4qE4P1bUrTcOgALSdpB/e 2ioU9/aRQSrfRj3+XrIsMfk62G5DHKlH5ksIa2idT0lYuHi8tCKFtDxYZoBtm6ewoCbc 2I1Q== X-Forwarded-Encrypted: i=1; AJvYcCUKu1ET8xOzg6RKAHR/8p94YrFaWIQjQI/gVH9Du5B9EtTIKRJ+t/y7wnSoNYHSBZe4yf9yJyIKPu2KDZM=@vger.kernel.org X-Gm-Message-State: AOJu0YyK2Agnzx4J9A6mnanGcFHrHSjhaupIKSRs7+5ePwvwgRkiSS2e 4F9ZX3K5jjRJm53ys+HAAbddLiMetMoZ4x/SIbY60Om0CERtcPxdzHsl X-Gm-Gg: AY/fxX73EcU3BdlfF/r+RihZvmL2rC55L3uw1QDQBrGrZ81LeFkPEMKVnHpqNGHNSoK VBwqGje+SuUyQsi/vgh1i2M5HoZnN0qXGplZ2DrfjvAA/yATqSKKgsIHBPjd6qBia1dWx6AFj2m veKV7Ks1iQKWDR7zJEpCO8YgK/AneApNDiU7I7ONIR0TlaDkzxBlZHTN51aBhGSCHB/kGprHg0R VW+q4zz5gNmCqt0HoPy0HocvVW5g3uUF4DAPpD378i2kBVB8v+3UJedEUWOaFadsRKeZEjfKtaC 5zZQ0rUorz6kyQLZs7AtDe/A8SPJnf7c+X2DaHIgdvq2lfKm8ZoDspaOgsgkliYEJgJTYSwjI7k Vg54jiLawnEOrtnVyS1EE7LsHpm9ditele18N0JWYWcSxTNLLlrzzPsJl0l1TlIR6RH6CAMdvJ6 AUONRWHZkjfclfICnt90ZyEFhiqrNz X-Google-Smtp-Source: AGHT+IGCYU18Ca2RWUMvCJ0sVnyeC8Bodbi6VqfzMnMmAkitSTRJ6ok0SBgg90i1lNAaAHGXG3JSBg== X-Received: by 2002:a17:903:19ed:b0:2a0:b432:4a6 with SMTP id d9443c01a7336-2a0b43206d4mr128905375ad.15.1765955002656; Tue, 16 Dec 2025 23:03:22 -0800 (PST) Received: from rahul-mintos.ban-spse ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29f173823dbsm159876425ad.12.2025.12.16.23.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 23:03:22 -0800 (PST) From: Abhishek Rajput To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, abhiraj21put@gmail.com Subject: [PATCH] drm/mediatek: Convert legacy DRM logging to drm_* helpers in mtk_crtc.c Date: Wed, 17 Dec 2025 12:33:03 +0530 Message-ID: <20251217070303.689913-1-abhiraj21put@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace DRM_ERROR() and DRM_DEBUG_DRIVER() calls in drivers/gpu/drm/mediatek/mtk_crtc.c with the corresponding drm__err() and drm_dbg_driver() helpers. The drm_*() logging helpers take a struct drm_device * argument, allowing the DRM core to prefix log messages with the correct device name and instance. This is required to correctly distinguish log messages on systems with multiple GPUs. This change aligns the Mediatek DRM driver with the DRM TODO item: "Convert logging to drm_* functions with drm_device parameter". Signed-off-by: Abhishek Rajput diff --git a/drivers/gpu/drm/mediatek/mtk_crtc.c b/drivers/gpu/drm/mediatek= /mtk_crtc.c index 991cdb3d7d5f..9f7e2c7fee93 100644 --- a/drivers/gpu/drm/mediatek/mtk_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_crtc.c @@ -227,11 +227,12 @@ static int mtk_crtc_ddp_clk_enable(struct mtk_crtc *m= tk_crtc) { int ret; int i; + struct drm_device *dev =3D mtk_crtc->base.dev; =20 for (i =3D 0; i < mtk_crtc->ddp_comp_nr; i++) { ret =3D mtk_ddp_comp_clk_enable(mtk_crtc->ddp_comp[i]); if (ret) { - DRM_ERROR("Failed to enable clock %d: %d\n", i, ret); + drm_err(dev, "Failed to enable clock %d: %d\n", i, ret); goto err; } } @@ -343,6 +344,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_crtc *mtk_cr= tc) struct drm_connector *connector; struct drm_encoder *encoder; struct drm_connector_list_iter conn_iter; + struct drm_device *dev =3D mtk_crtc->base.dev; unsigned int width, height, vrefresh, bpc =3D MTK_MAX_BPC; int ret; int i; @@ -371,19 +373,19 @@ static int mtk_crtc_ddp_hw_init(struct mtk_crtc *mtk_= crtc) =20 ret =3D pm_runtime_resume_and_get(crtc->dev->dev); if (ret < 0) { - DRM_ERROR("Failed to enable power domain: %d\n", ret); + drm_err(dev, "Failed to enable power domain: %d\n", ret); return ret; } =20 ret =3D mtk_mutex_prepare(mtk_crtc->mutex); if (ret < 0) { - DRM_ERROR("Failed to enable mutex clock: %d\n", ret); + drm_err(dev, "Failed to enable mutex clock: %d\n", ret); goto err_pm_runtime_put; } =20 ret =3D mtk_crtc_ddp_clk_enable(mtk_crtc); if (ret < 0) { - DRM_ERROR("Failed to enable component clocks: %d\n", ret); + drm_err(dev, "Failed to enable component clocks: %d\n", ret); goto err_mutex_unprepare; } =20 @@ -646,12 +648,13 @@ static void mtk_crtc_ddp_irq(void *data) struct drm_crtc *crtc =3D data; struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); struct mtk_drm_private *priv =3D crtc->dev->dev_private; + struct drm_device *dev =3D mtk_crtc->base.dev; =20 #if IS_REACHABLE(CONFIG_MTK_CMDQ) if (!priv->data->shadow_register && !mtk_crtc->cmdq_client.chan) mtk_crtc_ddp_config(crtc, NULL); else if (mtk_crtc->cmdq_vblank_cnt > 0 && --mtk_crtc->cmdq_vblank_cnt =3D= =3D 0) - DRM_ERROR("mtk_crtc %d CMDQ execute command timeout!\n", + drm_err(dev, "mtk_crtc %d CMDQ execute command timeout!\n", drm_crtc_index(&mtk_crtc->base)); #else if (!priv->data->shadow_register) @@ -776,9 +779,10 @@ static void mtk_crtc_atomic_enable(struct drm_crtc *cr= tc, { struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); struct mtk_ddp_comp *comp =3D mtk_crtc->ddp_comp[0]; + struct drm_device *dev =3D mtk_crtc->base.dev; int ret; =20 - DRM_DEBUG_DRIVER("%s %d\n", __func__, crtc->base.id); + drm_dbg_driver(dev, "%s %d\n", __func__, crtc->base.id); =20 ret =3D mtk_ddp_comp_power_on(comp); if (ret < 0) { @@ -803,9 +807,10 @@ static void mtk_crtc_atomic_disable(struct drm_crtc *c= rtc, { struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); struct mtk_ddp_comp *comp =3D mtk_crtc->ddp_comp[0]; + struct drm_device *dev =3D mtk_crtc->base.dev; int i; =20 - DRM_DEBUG_DRIVER("%s %d\n", __func__, crtc->base.id); + drm_dbg_driver(dev, "%s %d\n", __func__, crtc->base.id); if (!mtk_crtc->enabled) return; =20 @@ -845,10 +850,11 @@ static void mtk_crtc_atomic_begin(struct drm_crtc *cr= tc, crtc); struct mtk_crtc_state *mtk_crtc_state =3D to_mtk_crtc_state(crtc_state); struct mtk_crtc *mtk_crtc =3D to_mtk_crtc(crtc); + struct drm_device *dev =3D mtk_crtc->base.dev; unsigned long flags; =20 if (mtk_crtc->event && mtk_crtc_state->base.event) - DRM_ERROR("new event while there is still a pending event\n"); + drm_err(dev, "new event while there is still a pending event\n"); =20 if (mtk_crtc_state->base.event) { mtk_crtc_state->base.event->pipe =3D drm_crtc_index(crtc); --=20 2.43.0