From nobody Mon Feb 9 00:41:57 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADE951D5CC9 for ; Wed, 17 Dec 2025 07:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954849; cv=none; b=lMdVLcSR5/zOR7cd80i3249uWoPZr7pF1ORDSHfQvcihDnZjqHotpejLP+1M40V7EsirXF7yeAqZEKeO2T3eRItMsdoqX29DZCbv4zMGzqKMyzGnEMv40T5My3Y3Mo1rUIU9ia04W5H9SwZpvg1PHtkvDJgYz8YNEVFLU0+Us+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954849; c=relaxed/simple; bh=sPKacZIe7PsmymKfnz+K97b17Hpq8CB9VA6Pbt8GvzQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Yr1iUTNlNRtT7KvDPsQ1uSvR3Gv/xZIlZSdRXkajm7AIP5uUEkGWHoUQGI1bD2rsWQV3Mnx6NfzL77p6a0zuKvudRU8cQTFy0tIdk7Bjp3mCdG5n5ICiEVL0hr4A3bU1UCANuHbEH6bDv8LSb27YGuYl4T4kMx16aKmzeZmEBJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jtIEWtRI; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jtIEWtRI" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7bb710d1d1dso8205684b3a.1 for ; Tue, 16 Dec 2025 23:00:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765954847; x=1766559647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RmU4hWw4xrboqwbmsn76bL7tP1QYQP2wK+DLEr2Puic=; b=jtIEWtRIdA+LWIU2oRbsYR1Vl3q/QnDDDPV9Av/f5qwrZlkFUDp8qnpqZtLDzHzSCE ZrYBJIArpzD8bIlXdtRnE5akOTmF0ulKFtqpikuI9HIDBJj/dhcO4aaWA5GJJm9Oyt3l VX3mGxnRAht4xmZh9w0V9AZNaxanTf8iF9dr6z/5HLRv2UBvrlfLyu9m9taZmkoPsbMX tIuNEsA1gz7w7Jcnzi5gcHp6L/nSyegI2NI0BcQj9p29NUw3qPLZnrNvpt7m2vMjBDtB r69VGoyLD9K39OfY67ksVYT3ZHWBLPrvWX8989fpANcJY3hGSac+WJJb3Qvc5JpxLkE0 Fzjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765954847; x=1766559647; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RmU4hWw4xrboqwbmsn76bL7tP1QYQP2wK+DLEr2Puic=; b=MpB/iO85oriy5+n2RRlh96YFxcAWHVqcLAGHMXx9eawaXiZHCM47LBzGcKvxA0zjKD RNtGuSJB058v+4ZxoHI2rmhfNFT56hQbtKKMLdg0iPtPg8xJ5rKjJVGXhYA9BJ1f62Jx LR8VWntydMRgAPWhrfpnZaKa405kUn7g32tSUpbkVy6GB4tmHKUHXCfZ5MTcPaRqCol2 xVDiyEBCP5AaFl1StvCUxeSOBnij/QLAs+IZvs886fNvDj+yr1RzBzLwWbrTBHeqInru h1zJvWMfUn+01iVa5+BOgidyqH1c8B9pUMWwXFYaRMs1KQz4byajtDs8UyE0hBO1JL6e jhkQ== X-Forwarded-Encrypted: i=1; AJvYcCW6wE5oCTgJnHXdL/mDi2PS5iZFVcmWGQMCvVzpil96uVqftiTWDOxIbcpALouQF2x7VXi5lNIFRpaLFl4=@vger.kernel.org X-Gm-Message-State: AOJu0YwsV9b6R/EFrvYdJsvYtvTDhfI6E+bT+Nomv/K7uuem0wbD5UP4 5mi9JdWno8pMNOIXFM+FPO0n3+JmmUeK4uVS20O7QVaSilJcksnwLlra X-Gm-Gg: AY/fxX58UVDxrQYai/C1p+6O5aVLSLAnLECwKUIXx/aWbfsj/m8PQbnKB1O/g0JaK/e 6RfvB+COkMN1TjI8+J6I97mS1VxZf9ql+Zt7vc6KrYf1czPxVvcKMm8OoFKGXQGjG88PNEjcA+w aIRLyBHzZHluEAdTgbZudUfov65X8sVZ0EbY9dguF2kPST6l75S8vJqeEe1wNPUdr9gA9MTCSj0 dHRP2FfKOxrYXsb/0fuTD5QodKoXE0HPkMHGd3uaWjoL/fRuwQco6Hyv6qT6SkwBllsahutdIkw RcGT8g7m3xIHNywCLNARjj8KeJ3bxUs2rPzbDsW7I9JDVr9KVKb8UbP4Nqgiz7AqZkh11jUA7ab nVUaB+dhi7Kue0Bb0ONUSSHhrmn5V659O43TiKB7QG9kPlW75iBSpTObsR+gHuSlKOB6MRzLdRw +lxuAR6kr4XHAgVsQTdKWFUl0r X-Google-Smtp-Source: AGHT+IGZGUIfev1vCE7mVSbi8V4ludqF3bnj8sLr1zLybZhWAGnrmCDbKWdvZkqrnn2Jp64BLjbAlA== X-Received: by 2002:a05:6a00:b904:b0:7af:19bc:ca71 with SMTP id d2e1a72fcca58-7f667934131mr15680958b3a.19.1765954847000; Tue, 16 Dec 2025 23:00:47 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7fcb8f1dc6bsm1644983b3a.23.2025.12.16.23.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 23:00:45 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: peterz@infradead.org Cc: vincent.guittot@linaro.org, dietmar.eggemann@arm.com, linux-sched@vger.kernel.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] sched/fair: factor out common sched_entity stats/task lookup Date: Wed, 17 Dec 2025 15:00:40 +0800 Message-ID: <20251217070040.8723-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fair scheduler has several update_stats_*_fair() helpers which open-code the same boilerplate to retrieve sched_statistics and the associated task (if any) from a sched_entity. Factor this common logic into a small static inline helper to reduce duplication and improve readability, without changing behaviour or control flow. No functional change intended. Signed-off-by: Zhan Xusheng --- kernel/sched/fair.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index da46c3164537..b4a9319a5753 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1243,6 +1243,15 @@ static void update_curr_fair(struct rq *rq) update_curr(cfs_rq_of(&rq->donor->se)); } =20 +static inline void +get_se_stats_and_task(struct sched_entity *se, + struct sched_statistics **stats, + struct task_struct **p) +{ + *stats =3D __schedstats_from_se(se); + *p =3D entity_is_task(se) ? task_of(se) : NULL; +} + static inline void update_stats_wait_start_fair(struct cfs_rq *cfs_rq, struct sched_entity *s= e) { @@ -1252,10 +1261,7 @@ update_stats_wait_start_fair(struct cfs_rq *cfs_rq, = struct sched_entity *se) if (!schedstat_enabled()) return; =20 - stats =3D __schedstats_from_se(se); - - if (entity_is_task(se)) - p =3D task_of(se); + get_se_stats_and_task(se, &stats, &p); =20 __update_stats_wait_start(rq_of(cfs_rq), p, stats); } @@ -1269,7 +1275,7 @@ update_stats_wait_end_fair(struct cfs_rq *cfs_rq, str= uct sched_entity *se) if (!schedstat_enabled()) return; =20 - stats =3D __schedstats_from_se(se); + get_se_stats_and_task(se, &stats, &p); =20 /* * When the sched_schedstat changes from 0 to 1, some sched se @@ -1280,9 +1286,6 @@ update_stats_wait_end_fair(struct cfs_rq *cfs_rq, str= uct sched_entity *se) if (unlikely(!schedstat_val(stats->wait_start))) return; =20 - if (entity_is_task(se)) - p =3D task_of(se); - __update_stats_wait_end(rq_of(cfs_rq), p, stats); } =20 @@ -1295,10 +1298,7 @@ update_stats_enqueue_sleeper_fair(struct cfs_rq *cfs= _rq, struct sched_entity *se if (!schedstat_enabled()) return; =20 - stats =3D __schedstats_from_se(se); - - if (entity_is_task(se)) - tsk =3D task_of(se); + get_se_stats_and_task(se, &stats, &p); =20 __update_stats_enqueue_sleeper(rq_of(cfs_rq), tsk, stats); } --=20 2.43.0