From nobody Mon Feb 9 19:25:26 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09D7432C336 for ; Wed, 17 Dec 2025 06:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954287; cv=none; b=FmuuB9sDSkYr08qI9ijh4Be9q6a3CKKw86S/A0q1K5DbmFCS3IZohcOPiZoJXSdP2W20jG3+/6JMzA9YGcoXEAteaN93cgTTDAVT/AO48W+RXzVRqoRvUhAtjpUZYncmlbsdIHB09ZuJFb+65WXdSjBpmPkrAh/Wn/mHIWAZCPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954287; c=relaxed/simple; bh=n5Sih3s6jryc4fF2MY9dv+Gd+rAfVNaFbJvhtbsBlRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zna5QcYuPwOrbt4TbSY/W44gV9MMEA5PdXeWIXjusqCfhwjLxLtwZJfejTITP8HRedUQulPTZmcePTzaejujF1wi+u/5B8WjSCLG8m0KpClYiE9fBtH6oGclrMpgax7FVmKvxEpJ5hekpJBdXPZThldScLBt84eMVeNn7bU+nJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W5g/UOyj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UwiB7uWE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W5g/UOyj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UwiB7uWE" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH3F2cu1872023 for ; Wed, 17 Dec 2025 06:51:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=4iEXzkIhLRU 2sQ9AE5qIvZK9w6C3kkeCAzjrneXwTAA=; b=W5g/UOyjFYjrrGewB/wQNKJfm9m PLgYFYKYftWriqqVUNEAUQ65OrqjDKBlR/nuUFx2mk+v13DmzLWAOi4MIjLMLngl R1SmDSriarL4xw2FGc2qFxDjzraM2JUDs7yqndpNav8t09cKF49cDmI48ny/RUeM YpB3SKjqbt+jb0eWgtRQ1bMFynkjHLDnetWZJeKA7xjwz9WUJwn12joSJu+/eIkf YdKmSed/6fhjgbX1qK84xYa0PTPc8/czUF2ZeJGAk1pWA8s001Q93U57BPWTObWc RJFkO2fguilcj517dVEUGVV/qGf1O1xr80VE2aeMwYY6e/1ex+5xaEySC6A== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3jgq8vq3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 06:51:21 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29f2381ea85so83073755ad.0 for ; Tue, 16 Dec 2025 22:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765954280; x=1766559080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4iEXzkIhLRU2sQ9AE5qIvZK9w6C3kkeCAzjrneXwTAA=; b=UwiB7uWEe+H7C7NUL0+08TCprWb4pAyR9sbXykmPG1Y0jMlN+hQniQ6jzcs9t/2JRw 1coqnSLUsRK/+tjubqjpeGIxUw/vs0ipQzZCkIt+cXBNHxn6QyJDnbN2c7sA3Hetarqy eEdLNX4zRev/KyEPbDXjZ0ZNcSF7GKjMl8zEGBWlbYB1gCaz70WvvCUC20kPpcKHS5sq +pXE5uuFJ2c6JYIEdzUKasKtk7yvqpE9M6W3hnsDsuIIGTkuwcgxhZm3ObhfpE6BfBl8 wXtnIX7Elm9rL66UPeMikxa1muWkjxlz691Lk/z8znEy0qi+mDYGsz0mLvd9eBbfKEZF Pmgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765954280; x=1766559080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4iEXzkIhLRU2sQ9AE5qIvZK9w6C3kkeCAzjrneXwTAA=; b=U99SEz74dSY2f4cBIgenJw51X/SQDRbOJSB14q4QObeSSkZGIHGXUtOvLjk/nzuZoS cJJGitvuF//hUcAFr9B1/uUrzl56sMzvXpHe2hvIwGTrVl+FwazRYRpAi9KnWIjfLrY9 r454b2KbT0XJS49kxsThXs9960PSNM0UZvWMPuFKyPWRd/OpJNWKhP0qgwTfztmtjy7a 5T9JH6pf9D+HBrXg3n7HZKNEGe+PSeEyRwUbzwvNiYil5WhGJHenQ3sxVYsrwsDjZ+8y V+Hsp0FIP576eJxhpLe2082Mzn2ZcE7NRHVt1g3IPvS2XuR1gg/UHp6paWMD0IMA6qG2 gEoQ== X-Forwarded-Encrypted: i=1; AJvYcCWCx6KYkr5npxks3A21joHV/p2qUKFtLGcr0VJIFNnG9y2gSc6mF18Er8s76hLUKg9GexfCjQ3LBxOiOkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwHBEEVkVCgDtcpUBD1oK6rvnL/DMEabN7etD4Aq46LbGBBX76/ fIvZJShQys2eZq0i5DrnOvMl8tTWbBJSoZ8EC8ritW9xbMLDCs6EYcL6KJWZUnbJIS79p1CwN6G b0FWxQC1FEupYkyv/dvMDAHyqhN6t5V/oR8+6Gp8oY+c2qxenS4nWeZfga2wze7X0vjgrnvRL8W EoMg== X-Gm-Gg: AY/fxX5H1ux5mP4IL5Q5KEfbKI7Zsia2j6zOUZ7xE8Sff61TGywfmQCPTuicdf282TU cQOa63bWBL3ESPNfHos3fsA4C53xZV9sUlpj+yMqbsIKFaVhzj7LCOhwiayKN0cZRkL3u5VrtsA 2dODAJY7EXKeSxZ5Jr0B2XdRyJwinB3oOFiFI1q7f9peUEGgDjTtnqsl1BjlSZfihb83Q3IlNz8 CJG+kqKrmOJ4JYSKACdf656PhDYq60R+6FMrwPr7Xdv/K044c2X2BdBnywndjW12HCut5uHviKc Wqrh+Y2mSITAWRijHdUcGUJW0pNV6ilTlB6U//ah/9C6AZ+r7V5J+vE2onmVXZfRSEalTJZBcf3 qrEEkuiH37/xZ3nQR12qwP0U0YaGKit9GP/hynEXL4QUkARvFx53QxtPu7KGLjv0j3w30vZBRRt mJ X-Received: by 2002:a17:903:1986:b0:29d:7a96:7ba1 with SMTP id d9443c01a7336-29f2436da68mr156682855ad.46.1765954280354; Tue, 16 Dec 2025 22:51:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIbB9Knwe9bfEuTzW2OVz/ykkHTd22n1PPWbVEsjNZs6oAXaLe1AKuG0gZ8WAQKZuVACtHPg== X-Received: by 2002:a17:903:1986:b0:29d:7a96:7ba1 with SMTP id d9443c01a7336-29f2436da68mr156682715ad.46.1765954279899; Tue, 16 Dec 2025 22:51:19 -0800 (PST) Received: from zhonhan-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0993ab61dsm118846515ad.46.2025.12.16.22.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 22:51:19 -0800 (PST) From: Zhongqiu Han To: andersson@kernel.org, mathieu.poirier@linaro.org, corbet@lwn.net, rusty@rustcorp.com.au, ohad@wizery.com Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com Subject: [PATCH 1/5] rpmsg: Replace sprintf() with sysfs_emit() in sysfs show Date: Wed, 17 Dec 2025 14:51:08 +0800 Message-ID: <20251217065112.18392-2-zhongqiu.han@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> References: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VLjQXtPX c=1 sm=1 tr=0 ts=694252e9 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zeoL4EY6mI-QDyTLeegA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA1MyBTYWx0ZWRfX9xbi7y7R0tr9 Hf/NwuF0OjkyZRZIbfPqwTa1ko7PUIh7pV8GTu+0WYIB9ehN3TV+IJJe1LPENKll+lLru4FIhpZ tcYUDwN0ECazQHuPNu9CE3Ag5DGWKf69gg0wqRN/z2Drwvw1fCq9E5S0dUaXmq5F+SqgGn8Jdnw CuHROVIYTSWHoxu4JkOCBn5WUjk5B47ouXSfVjlo5u+4sabYOeTsw7sbLDhnVXOdblOznlXaMtF FXRUnRnUOSahb2M2EJrsyPOnAoZozgpAmYrTC4VD4mcK4Pm1r1xFyUd/HBPkoEQzCU6Xb+l3app Iw/WotpIRcOt8BHZOQZefn8ddCAeyHEFkvSGZEv0bvKdQNiBpy7EFITO88Yy6DiRr11L4sGTVBW ifBL8GGRZKPN/9PQs27FElPQkf4IDQ== X-Proofpoint-ORIG-GUID: zCnfioMR-2Qstgd32DFSgWACJugWwEPP X-Proofpoint-GUID: zCnfioMR-2Qstgd32DFSgWACJugWwEPP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170053 Content-Type: text/plain; charset="utf-8" Use sysfs_emit() instead of sprintf() in sysfs attribute show functions. sysfs_emit() is the recommended API for sysfs output as it provides buffer overflow protection and proper formatting. No functional changes. Signed-off-by: Zhongqiu Han Reviewed-by: Chris Lew --- drivers/rpmsg/qcom_smd.c | 2 +- drivers/rpmsg/rpmsg_char.c | 6 +++--- drivers/rpmsg/rpmsg_core.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 42594f5ee438..2793096aba45 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1458,7 +1458,7 @@ static ssize_t rpmsg_name_show(struct device *dev, { struct qcom_smd_edge *edge =3D to_smd_edge(dev); =20 - return sprintf(buf, "%s\n", edge->name); + return sysfs_emit(buf, "%s\n", edge->name); } static DEVICE_ATTR_RO(rpmsg_name); =20 diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 96fcdd2d7093..3287e7941c8c 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -365,7 +365,7 @@ static ssize_t name_show(struct device *dev, struct dev= ice_attribute *attr, { struct rpmsg_eptdev *eptdev =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%s\n", eptdev->chinfo.name); + return sysfs_emit(buf, "%s\n", eptdev->chinfo.name); } static DEVICE_ATTR_RO(name); =20 @@ -374,7 +374,7 @@ static ssize_t src_show(struct device *dev, struct devi= ce_attribute *attr, { struct rpmsg_eptdev *eptdev =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", eptdev->chinfo.src); + return sysfs_emit(buf, "%d\n", eptdev->chinfo.src); } static DEVICE_ATTR_RO(src); =20 @@ -383,7 +383,7 @@ static ssize_t dst_show(struct device *dev, struct devi= ce_attribute *attr, { struct rpmsg_eptdev *eptdev =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", eptdev->chinfo.dst); + return sysfs_emit(buf, "%d\n", eptdev->chinfo.dst); } static DEVICE_ATTR_RO(dst); =20 diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index 96964745065b..bcfd17e5309e 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -348,7 +348,7 @@ field##_show(struct device *dev, \ { \ struct rpmsg_device *rpdev =3D to_rpmsg_device(dev); \ \ - return sprintf(buf, format_string, rpdev->path); \ + return sysfs_emit(buf, format_string, rpdev->path); \ } \ static DEVICE_ATTR_RO(field); =20 @@ -395,7 +395,7 @@ static ssize_t modalias_show(struct device *dev, if (len !=3D -ENODEV) return len; =20 - return sprintf(buf, RPMSG_DEVICE_MODALIAS_FMT "\n", rpdev->id.name); + return sysfs_emit(buf, RPMSG_DEVICE_MODALIAS_FMT "\n", rpdev->id.name); } static DEVICE_ATTR_RO(modalias); =20 --=20 2.43.0 From nobody Mon Feb 9 19:25:26 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBFC732C950 for ; Wed, 17 Dec 2025 06:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954295; cv=none; b=a2Gy/47FcSSAOCy70YXoVvkOLqNdjKewfvIywly8hjLGcaLJEES+ySfxbtYjj9rIsNZcRhQIfYANKxSOrm8QM0qvfJte883150k3Av9r0+2r8IQKZK+Oe6mJXOXGRJPcySMxsOFt3cN5KKsB0idQM3Qz7mNQkr33PYYeQ51+27o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954295; c=relaxed/simple; bh=VP+rBUGF7qVbbXP2x/EhbFqX8g8zi65PFtLqGlmueNI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u96lmlNa+l+xpf/iik6XMmvQJA+kIxsSpFCFSMCO6ANdIw59MDrDGTjDFTXQ9Lz0v9FnCFvlZJaNMFUzU1vLOEueAtRinxukXrv/gptdJ9aALSSxTsD+KAUJnUpuUfdezOjSv0Fs1ouaP7aM2173ssRn5KUb92yyj0y2tY24fY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EVcZJkyi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=APCekDP7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EVcZJkyi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="APCekDP7" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH3wahN1904167 for ; Wed, 17 Dec 2025 06:51:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Dq7HdBaR+ND Ov/4A5+SkcbKsybvvsE5z7g6twcyjF/c=; b=EVcZJkyi+tKjvtCbFZaRg1uqURK aKOJWOL1hxwaslQ2c94co3dW7fgwYakXEFWHwOzkJaGhN0HNqU4GtPlBmcahJNI6 4gKBQLOFI21pcZrAnesZj3sIZB9L0yfqXMjoKy3ceQt51qUAwOAXYBUSrt4pfvON sueW3OQ9JY1ikcTWI0MeAIL42EkOJK4gUT/l5wHoq48Mt65rACXtJVA+2rxuGuUl UAMWN2vcPyDLd7nwX1Ag3qw9WxevvhVS4zr4on4abzcdw7ZgU/ngEjAHxEgQc2ml LxCXvAlMX/gaax7uQG42ydoQIK0JgepSSrDxI0/AOibI7oejcoMU72QXfoQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3n330g98-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 06:51:24 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b5edecdf94eso9797376a12.2 for ; Tue, 16 Dec 2025 22:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765954284; x=1766559084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dq7HdBaR+NDOv/4A5+SkcbKsybvvsE5z7g6twcyjF/c=; b=APCekDP7n77WtoPYL1q1OREvCWNj4vtX6/KWecu4Rdw6cG810aRXa6iYBcj9YhQ8W8 nFn/5fR+1g6oBLuSn0Z7kcxz/a+7XPXz7f1jnnNF8fHE0emcoVya2V2dAAZtvVUEPxXz wj4r8ExJnihgIzoTCk4x06B91pw3/mdemvYa+zkp5OCiIBUwRCd+NjGKYHvuNpSN+tld FHufiFpdR3HDoOOPHoP2suzYg7cEP01QZ2UqXIltUkkxhwXiB7RQezj/N0EL0J/AnLnr mFrfsgINhww5fKStfS1wQ/lkLT2U8hXCDPjYRAVpk9DqPET2QHFVkOKtJBXFUFBoNKH4 WuVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765954284; x=1766559084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Dq7HdBaR+NDOv/4A5+SkcbKsybvvsE5z7g6twcyjF/c=; b=OimjeEb7UNIeqK5a0yMFKlV0LEX/M55q+Pz/lSbqwDpAAC5aY8VXiEifF+vyE7kuJ3 F0ukjd2T6Yn8NqzhIPus+mrfV/k/z9WVbdFv25uXo5RMMVMmKKKov/LCJjdCisL3epY9 VDcmp8A7TTO9+5iLnkFVuLcALxg9ZC3+xlrN6tXSk710DsDOJf2/ChWiY4PfGMaOPNCQ 5ygz2jxKtDQP0t3aYOe+K1hVmrqNISxiGjx6ei3Ar36BL8pCDJ705Vekghjb31rjtZqY /8r1eCmvvnP6skjCz6ACkUTJuboNlxksntPgJysoOyj8LssYy9w8d4ew+r502ERC+9bK xtLA== X-Forwarded-Encrypted: i=1; AJvYcCWYWId/a3Gi2KVbLFpq5ZTpOXd2aPNo/hS8cAHUAEOcQazRrspmvFoijkor57GVu1J7zwiWL6rb5CYc8fA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxgnz3HA/WZSiYVZsajFPItkXPILIpjvQCj/C3nc2RKIHgQvMtC 4g3RwzM0BxCndnFjnzyrTDCcf/upreWFlpnCVQ4cABstSjSTX7kCxLEeFvdrFZL/bWwtytKAwn6 G4p560GukfaNr0yEZ53UmVv81AgBd7NGfOthaC7QG0m/NWVygX7ePDEV36kvCweFel8c= X-Gm-Gg: AY/fxX5TwyAluPJxyAi3IF7ZyXrr2oGEhzOsuru3khSHqP0oJxN0vRtp7hyYhcYIKV9 HQbY0VbKC9ukh2GFScmrRSdasmhQFoz4cQpQ+4ntGecopDTbHQj1yXP7G7S84VaNGcls7OX/6Gu o6nqTUtOf5MTHaxMszwSX64ED6Ku4VOdLTLXGXCl0jVAjkNFEIwwLxl0nOcTifza1WN8Mz5HMoz HY3pdvotxCLCcccUe3weHa78J8YnrvwX8xEo96lvAIPaENWnG71QPr0YOlLX1yT+gYbEpeyqZZl vDsjjqePXT7q2ZlsP1cgdmh5813X8mxNp31OE9e6RpB/wA3zw8zwNCH8fxIsAX/2e+qmULWsVIO fGNt0Z2X9kHoF53FLaQE0c7ozoKUUcgYoUvfgtUKRU8tKOf8D5uZy4JyMswQPuWEpi4AjKe7Vfq nJ X-Received: by 2002:a05:6a20:72a3:b0:35b:b97f:7471 with SMTP id adf61e73a8af0-369adbc913bmr18285870637.4.1765954283766; Tue, 16 Dec 2025 22:51:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZM57x3z2KMv8n/8dDpTON5UMcn+/BZFIjIc6sGg09joQLGKprkmLRzvfNxzJGnpGzmQ8N3Q== X-Received: by 2002:a05:6a20:72a3:b0:35b:b97f:7471 with SMTP id adf61e73a8af0-369adbc913bmr18285848637.4.1765954283344; Tue, 16 Dec 2025 22:51:23 -0800 (PST) Received: from zhonhan-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0993ab61dsm118846515ad.46.2025.12.16.22.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 22:51:23 -0800 (PST) From: Zhongqiu Han To: andersson@kernel.org, mathieu.poirier@linaro.org, corbet@lwn.net, rusty@rustcorp.com.au, ohad@wizery.com Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com Subject: [PATCH 2/5] rpmsg: core: Fix incorrect return value documentation Date: Wed, 17 Dec 2025 14:51:09 +0800 Message-ID: <20251217065112.18392-3-zhongqiu.han@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> References: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA1MyBTYWx0ZWRfX2qPLNJU4A5Fi UAbYIWm/8XvOGIyoPDkNFBhedynlSnIP3Pu5eOFz3DGHAL049fS/PKEzSa7D5pcTZcMregWooiw v/N5X6znizdj5yUKR5LZpE9yTCqvupqT5cvz/YTARPTKDocETuteWi5HjK1tLNvsKth/WwU2KeK yZ/en6AvJdf/d0WGqOwdZO0ke2WwD0Ruvh6cmiPyo9J3hWKUo7oR0yu/R7WA05rd/nsKy0ekTTP puPGgLduFKjlWx042FQ/4dKyaI4X5qofkDjXhwdE9K0d1Rox0fl/6zcGdFBl+rrVIDhejjuZvsk vW01B7TYAC+ztH5/hIyJE5P7sokmHYjFkv98BsL+X980ZD1kRH7NRyTWvNZhcOQmkD+C80p4gKG WJqYVrY2YsmucUDdBWnPCWCZxLZ75w== X-Proofpoint-GUID: NPjEoSQaby92f7jwKqcxqMGuq9_g8zeg X-Proofpoint-ORIG-GUID: NPjEoSQaby92f7jwKqcxqMGuq9_g8zeg X-Authority-Analysis: v=2.4 cv=U82fzOru c=1 sm=1 tr=0 ts=694252ec cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=EyzG0aFrAOtqPBJHxvMA:9 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170053 Content-Type: text/plain; charset="utf-8" The unregister_rpmsg_driver() function has a void return type but the documentation incorrectly described a return value. Remove the incorrect return value documentation to match the actual function signature. Fixes: bcabbccabffe ("rpmsg: add virtio-based remote processor messaging bu= s") Signed-off-by: Zhongqiu Han Reviewed-by: Chris Lew --- Documentation/staging/rpmsg.rst | 1 - drivers/rpmsg/rpmsg_core.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/Documentation/staging/rpmsg.rst b/Documentation/staging/rpmsg.= rst index 40282cca86ca..11fc22f3736a 100644 --- a/Documentation/staging/rpmsg.rst +++ b/Documentation/staging/rpmsg.rst @@ -212,7 +212,6 @@ be probed with. =20 unregisters an rpmsg driver from the rpmsg bus. user should provide a pointer to a previously-registered rpmsg_driver struct. -Returns 0 on success, and an appropriate error value on failure. =20 =20 Typical usage diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index bcfd17e5309e..a5dd09f19b14 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -627,8 +627,6 @@ EXPORT_SYMBOL(__register_rpmsg_driver); /** * unregister_rpmsg_driver() - unregister an rpmsg driver from the rpmsg b= us * @rpdrv: pointer to a struct rpmsg_driver - * - * Return: 0 on success, and an appropriate error value on failure. */ void unregister_rpmsg_driver(struct rpmsg_driver *rpdrv) { --=20 2.43.0 From nobody Mon Feb 9 19:25:26 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91F8832D0C2 for ; Wed, 17 Dec 2025 06:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954300; cv=none; b=tqjCTodH437P867uHhtvkTUyp993qe9nZQJnyVqTLWa+mg16nmBhnxZjN4Q879QcFFNpHTEogFePrHAWKBdqvdZcYk+F9wW3+tH4r+QSrAx/ohXHgztHirShViI7v7avCdNkYYF8jz7yT6holUQa2Ako+jpbhL6QjPUIjOwjHvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954300; c=relaxed/simple; bh=WU4YCpuN2WnD6U8Z8IJ4kJne3uzXJ2vUUx1RNzxXTBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m8qa4BfsiyLXHSZQR+DXvCevC9NrnY6VbY5K5ttzKVT9IZEju75CM8iWrvsYqsn51jxHmbnxIFf180uw1vlAdgYGsvAlvshBKehRed71eS2juCWCFDTYPmdqQubXFrrng/genokXgoHAkt/G7BCU7m+E+ExOEb3P1sX7H7UiQ1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FuQi89Fg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g1hSSJdt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FuQi89Fg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g1hSSJdt" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH3wLLn1903871 for ; Wed, 17 Dec 2025 06:51:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RwaICuxiYsG3y9nIJZac4i/l8YIIA0taYYtciFqIqkw=; b=FuQi89FgPujVhVeB AXZOxriGnZsGxtyrKz44h93BrOPjeRBbKhq2R+Dq9vQyAxyPNkkbag3ppMpVZUdt 5Lv7//DOfRxnrs4Q7BC4B7MeukLYRAvKuKY7aWkhPzkUuxbAaXGvO9pVMCYvdhzj GQrYjI34BMIhWGGb4y+JXCufBEM3BUj3YdaaxHrHpUGW2kVa8K+MjTNjzA+7eV7n bFvqIHKFJi+CZ3XbaT94T7M3gVLkLrqV5pMabYbP3lTbiiGadTgxxIbhAgS/P4Uj rTn10k9Jr2C8Bm05RP5lM0xZNh+DJgW8ZvO8JqPZ6eAEC23sl4LQXFmEoMzVdLUz wu7OWw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3n330gax-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 06:51:32 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a0a4b748a0so91065695ad.1 for ; Tue, 16 Dec 2025 22:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765954291; x=1766559091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwaICuxiYsG3y9nIJZac4i/l8YIIA0taYYtciFqIqkw=; b=g1hSSJdtoWXZDS484FVLR71Q8C7+4kkdv+QITBeL1aQgovEWpqrDPGMYnhmw1DIHWg vijpIMtVb+G2X8DjCtov1UpqliguOa8O/sUg8WFhjr4keyDgUzP0pB51NKWiU2KMFLaH Wm8edBtLUZIFHgo55aX26LupX5/DNFxCePejjzCgRf3UevFzjEiRfRQBar4l0kgumEXb 1WRIMArRV/n6C6yvndIkkkZVVXAtSlKuaPFNJ0+95NEnthbirmBdJf3WECbDJorGy6iA Bnop04ziVXeQNUDX2pmjGE5GPsGhMzKBghIn7COJWTaZtj5mh2XsMbnLPQELBpBs3Qhb VDjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765954291; x=1766559091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RwaICuxiYsG3y9nIJZac4i/l8YIIA0taYYtciFqIqkw=; b=cc/itR7H7R/d/pdnzlVRbYmUTqJzoJyAu9ASFonYN6t8Kasi6vXh63gRfgqoNCSchU /ahZIEBhIoSq8uQI9KCbLPHAI2EbWE4pbyIQc2bKOS5yOQPSKAZYBlAwCL53b1e5RcRo s+Lf+h3wW1Z0IJJouBcIN7ULzHykLtl1a2DgqAUAus71rXMaOXNMcw4mvuBc0bbYLCwx 3M7GCd0mJjjo747czrxZm7gLcAHpb7Hp8iMS49CoejynrAAxoNos7uIuP4siRKbO1uqX mD5cUHjYPK8etJRRjyV721Q+7st1+fE/ZVBYIdqlIldVRlwB9RqQ5FOIZlzEAslLtOsI a70A== X-Forwarded-Encrypted: i=1; AJvYcCXrQHJgbQFzI1kA8+BmqM6dKtgIGgP8wWidTbsYYtq2dprEbePPpowGt9fxxbAdAczTqcMlIVSpKhdQgz4=@vger.kernel.org X-Gm-Message-State: AOJu0YwBY7/sigAM8mAG+kGilOvovPfoPlbw6tFHYrgzFHwVUm+0fg2S AInjvPenBWmq45U9MsVEl+EVmiEaOLvYsbNOPUkMTnXnA8W8DmZdj80HEl31dXOTXhMrTxqWM9R 38DXdoz+rzvjBOdLJhxn3d8gfEF6cF6CjkY1tpkIwbBhK5713g9t31/25voQ73dmElGs= X-Gm-Gg: AY/fxX7WQUvCXRDuENg0+DeJVTVGmswUSFW7xnatb6f0k3DLpbiDUjjtnogNIDsI2c5 wQ+rGM+et+YTc3+YCnRlCWrrpRoNgCIMNoQnbYLyx63xcXvxKHXlifMD79zzI3Q9kWKeqfQFGTi WLG2HtgXm12EuWJI9xjL8vo/Tj3AGAWBza5GDl4xlJhuetxmzi7h1swdS6LgZp8BZdaTokQjvYE hcTOG4a4u79jKVvGpxAuDwUOaf2J2O/VFADh4qY4TqNKwyacvPmm+LZIklFZUhtz/U1g/XY+MIz uDQlmXKTK5AtBXQVmhjKaO6w8skaJ9rSUPzECzpg6vq99m7zVumZScfF9Wiyb5X3y6HYhHiNZfr yyRiUOM5Noc12ch9+0Ewd9og6qqgA7bHi+ra8CU5aDM4Hpf7Ujo2AFZV8MhmOAxMjgoqoa8UimU 0/ X-Received: by 2002:a17:903:1aac:b0:298:5fde:5a93 with SMTP id d9443c01a7336-29f23c677edmr164280255ad.32.1765954287155; Tue, 16 Dec 2025 22:51:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IF58BJXn3L4f73R4hK7FiOEUWAG+6wWfw5TzAMcuw5HCxg3IPDoRUMpLvbBG3oYJf7SYmLA2A== X-Received: by 2002:a17:903:1aac:b0:298:5fde:5a93 with SMTP id d9443c01a7336-29f23c677edmr164280045ad.32.1765954286732; Tue, 16 Dec 2025 22:51:26 -0800 (PST) Received: from zhonhan-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0993ab61dsm118846515ad.46.2025.12.16.22.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 22:51:26 -0800 (PST) From: Zhongqiu Han To: andersson@kernel.org, mathieu.poirier@linaro.org, corbet@lwn.net, rusty@rustcorp.com.au, ohad@wizery.com Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com Subject: [PATCH 3/5] rpmsg: char: Fix typo in comment Date: Wed, 17 Dec 2025 14:51:10 +0800 Message-ID: <20251217065112.18392-4-zhongqiu.han@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> References: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA1MyBTYWx0ZWRfX1q+3MbwB2tid hPXle36IF5sQfUO9LndstvUYK6vlr/mbRG8tJVClTgb0RgnYZ7HaLks420o5Dmkp2SHN33ontNU vBoNUz6QE1LzX+bjIQmr1QrFSJgib+GGw/q6Ngvgs0tX/TLNEV0ZW6ymBJLGdUGhcldb/HfXnwO I1yj8xSbLjmeT+6iRqXnEPkYkpP+5o7JlPgFZ5RBCbykVD5q4/U5oRkEyzlsppXLE5Xpd2fGBab JRei+lf07aWXQDdPbnHz5VTTTeT56tTWPHzqXYBvDAdtuCI7SOnYPRjJPp+bkEYX4QEiDVio7E9 HNXs3sPuqWNT4XiZcMOzSI7G8Ar4i7HeJ23jJ+SGIkJHyigF9upovhG7Trh+AC4iTQ5LtmARrDc LwUCrJtjzY2+tJONWz08JCVWOlI7KA== X-Proofpoint-GUID: UGpSXEWj7cUq7arDuMppjoGeswYsY3c8 X-Proofpoint-ORIG-GUID: UGpSXEWj7cUq7arDuMppjoGeswYsY3c8 X-Authority-Analysis: v=2.4 cv=U82fzOru c=1 sm=1 tr=0 ts=694252f4 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=sB-E2kKsXCsxT4_ri-wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170053 Correct a spelling mistake in a comment: "Storedit" =E2=86=92 "Stored it". Signed-off-by: Zhongqiu Han Reviewed-by: Chris Lew --- drivers/rpmsg/rpmsg_char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 3287e7941c8c..073d56858b88 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -504,7 +504,7 @@ static int rpmsg_chrdev_probe(struct rpmsg_device *rpde= v) =20 /* * The rpmsg_ept_cb uses *priv parameter to get its rpmsg_eptdev context. - * Storedit in default_ept *priv field. + * Stored it in default_ept *priv field. */ eptdev->default_ept->priv =3D eptdev; =20 --=20 2.43.0 From nobody Mon Feb 9 19:25:26 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3986A32C958 for ; Wed, 17 Dec 2025 06:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954303; cv=none; b=HXz32Wc4BbOVtO56nUE/SuG5ooHFWk79UKI+by4dY+tf+zZ2WOT8F/jG99JofX9Nk3A6fB0zegZXiQ1ziaMHPNWEgofr1KvYqBFBDIpmTbsmvlW4YYrCKLcPL6TZyGMceyd+l/61zVUOQLO7VMtOHib2ph6BEgCTGVXT6vVT198= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954303; c=relaxed/simple; bh=pJMvf4gE2407W+gdv4k3Yff8Slpho2ovd+794M5ZMsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kSE18UxYScsGfYma46cC8oyyNqFiPZ+mUpEC4EcpS2AVeyXX8BPqeCo4Mj8EtYD7tjDys9x1U6yNln04jqFlpS5bHAU9xEGgoQq+Za0TAtQJsymNABYH0ZcC43EJlKPtRy8JEpdUMoNYXouSSDmNrdW+0lPw48b3aqrQjaWFRrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lvAUBtua; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e8j0pshZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lvAUBtua"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e8j0pshZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH3Ev2r1871277 for ; Wed, 17 Dec 2025 06:51:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ob5zAEDq9ei IuOeJH/1kBFZzN1Bl+vkD4rqBtnGwSaE=; b=lvAUBtuakOsB/1RYpCYNFp7RKeg 3AEwA0HA4CvzRAVT2AfkOVwOP3lnJ5bhL4iFatXtBjMOH8f+5ipgaVdteUJdlIgj xmbQ7EBHCmWFmSoXLG8ZrbphzJ20cSoqmogwQWgTSwWnzMYg+FluVRQmgweBoncs v56QZuu4oGCneQEyzo0p+pj1jUr8zsXPo1HRtaSgJnDYH8h1yt0jAYEqmeIebOmi SmduESu4vVcyuk7n/QEBurQwbdkgqHRRuby+tDpEFL3Q0QB5cDopJGXveN8o/9fc FqGYPFZBFzng837BYsJdAixi3PVL33lPZUVlD9IhA4ourVukaimQygecjAg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3jgq8vqh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 06:51:31 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f2b45ecffso74279685ad.2 for ; Tue, 16 Dec 2025 22:51:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765954290; x=1766559090; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ob5zAEDq9eiIuOeJH/1kBFZzN1Bl+vkD4rqBtnGwSaE=; b=e8j0pshZHDbU6FBHVU0sidcUn9+xlVGe3ldirHRe7fWY57LzrHuqkJHcikfZeV03G7 9kPy0x60YJPY6oIL1NSLDt4V0Aal32KXw1ADyfR7rYMTWS+4vJ8xG6dj2UTO6yMMRfLx 9X2xrgjR/i/+ZDSnT3BdUG0snbxYTETVHLyacS+vs8yp4Dhcc6AsB6mRkyW+tsmFXnmZ YZLpdKkfLQ7kKA+Ojvk16Lj8+sg1DWrJPH8CYkct6dtRTyHq+HJqdQekVKxO5t9u7O4k F8pfhzvMYz8lb3ZHTu2rYc4x7owgtZb1AeQeKu+Af57v8m1KxTExxdO3DK1UdERoVDLX wBYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765954290; x=1766559090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ob5zAEDq9eiIuOeJH/1kBFZzN1Bl+vkD4rqBtnGwSaE=; b=t3VNnydA3iUuoUNZFdDulXcLzZPwCQmAdfQX4w+KemChpC4ThIAJgZBWEc+0TjOIt/ tOhvXl4Xp9+P4OILLuHtvNTVaYIkBEj5k5AuWL/quoHA+rXOQM9NoLXsjDlJD8QCobZQ iHFx8ASn/jkP4C/49hmGEdQpy7HWbK0uQIVwsQNrtkFRF93bNuTFSUY7dw6Mx5qcUTn+ ycCod1osOybEvWFwY9e0VrKJ5oMps9ZKhp8XcXbtfpRh7maA1VBwcKMKXOfOE/j4a8uD MrHowCU0qYTznZcPoTqqAwsimQvwamF8SVm9rqxl0zwNPIhcSGpVQiapHsn6S9E4nuqj yFsw== X-Forwarded-Encrypted: i=1; AJvYcCVW8JOtV43g8o6dW9dnLMyzdhG17xbwuQtc0rJ81cJHG7QVIBlSkG2D6GwPM1d2Pp0bg7mbIO4qULezgjs=@vger.kernel.org X-Gm-Message-State: AOJu0YzmxQnZkH38UDhYx2jhsauUpg06xft+56+VfC84kOy6IRiZ2HU7 0DQGuStJT8rYgp9JlRh54Tml+sNz2604NFCi8DuxVGN/BIC+HLQZjbNmcWp5NoUdfc1M+9POfK8 lnRj9AAGU8C7nJihTKeKha3wiS+Z8BstvfIQEgYzbqG3BVNCvqH+pfmBrNlWJl+qu3hY= X-Gm-Gg: AY/fxX4g1TWQ+ygVKhuUP0SaTehymySy+KEQ0f/IKFtNH3yfT47ZIRQM8FirvyuATG5 1uaTzj3zdCtdrHdYVvkmPB2BJxAJ0/N6RpaIdX5SdEhvkDscZWvPf5QCIn1wxpbvdt2D4o0nlPl wcfZqNFf0XuYAYVWeBw0qA19AaU57ujJO/1QiigPJmoGQiDfJwFk6LBVvFzmyzoaC8N/p0upTL4 9WpIM9A79jj4zyt99W7LrXNtApsKaX5i60kuAyrQsihw2+da07HATlAdKVmj877sSKHlJxjpEWR RqsvqNtkXkP6dh6XaK4JPI/ZjZ2/nlMN9piTxcguqilj7gJEdHIIFgUQKg6VPimzyd2whYGNyft ZCYnu6ODKfisU1UWAy9Q1IdDV7xC9CUrEd2eUIPInRQkbk1pDppGknzvdjv/pHUBIyn7DMI8fcs v+ X-Received: by 2002:a17:903:41c4:b0:2a0:e195:b846 with SMTP id d9443c01a7336-2a0e1a4fcd5mr111457495ad.54.1765954290239; Tue, 16 Dec 2025 22:51:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+jLipged6UvMrD3Na8ulynn8bBpRtRrg63DRf/JcDs+2XzdYdiq9BaBHF86AMCoyglgGi1Q== X-Received: by 2002:a17:903:41c4:b0:2a0:e195:b846 with SMTP id d9443c01a7336-2a0e1a4fcd5mr111457315ad.54.1765954289763; Tue, 16 Dec 2025 22:51:29 -0800 (PST) Received: from zhonhan-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0993ab61dsm118846515ad.46.2025.12.16.22.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 22:51:29 -0800 (PST) From: Zhongqiu Han To: andersson@kernel.org, mathieu.poirier@linaro.org, corbet@lwn.net, rusty@rustcorp.com.au, ohad@wizery.com Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com Subject: [PATCH 4/5] rpmsg: Handle dev_set_name() failures properly Date: Wed, 17 Dec 2025 14:51:11 +0800 Message-ID: <20251217065112.18392-5-zhongqiu.han@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> References: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VLjQXtPX c=1 sm=1 tr=0 ts=694252f3 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=R6Is9h_wUuj108RMq48A:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA1MyBTYWx0ZWRfX6ZFKsnrhBe7g RsBWld2lNrWt7NORAaHi05vL+nqh4gDD+TMxJHO2vZaSc4451CzQf/dYuSlYwaVO41e5oEr3111 cIHxCFZ/KTU6IbdJj5c7SxEZccHtEGdmTzieY6cdGrQHRNqTUx7IpxBLRrOIg5ZjZ8yebmwAE9I QvAJxnrXKxyT/6iR8PWir3pvl1VGWQcodlw4pOr37Gk5AlKmJxmffDNhhAXxBjrQhBQnT/V77bR nyYiC/yFaQ7ccOwaPQJTcRQ794huQJiEGuW/x/q66tJG7yXkZU+ogE8MyYkjg83fI3QhkXFMvcx P8Xt7R+SuQtH9yJ3Mqi+XNlcEfexre66Gx2e9zvTFodfHS8sgRejgeHVGskvyrTNXGW+ZlDMgvh KCdTmp+ufGqjKyyX92WA/7hCpnI3eg== X-Proofpoint-ORIG-GUID: n60tSbweC-qVB6hJbm0vAtMqIqaxt8L9 X-Proofpoint-GUID: n60tSbweC-qVB6hJbm0vAtMqIqaxt8L9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170053 Content-Type: text/plain; charset="utf-8" The dev_set_name() function can fail and return an error code. Ignoring these failures leads to undefined behavior as the device lacks a proper name, which may cause subsequent operations like device_register() or sysfs interactions to crash or behave unpredictably. Add error checking across all rpmsg drivers to ensure proper error propagation and resource cleanup. Signed-off-by: Zhongqiu Han --- drivers/rpmsg/qcom_glink_smem.c | 8 +++++++- drivers/rpmsg/qcom_smd.c | 8 +++++++- drivers/rpmsg/rpmsg_char.c | 5 ++++- drivers/rpmsg/rpmsg_core.c | 8 ++++++-- drivers/rpmsg/rpmsg_ctrl.c | 5 ++++- 5 files changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_sme= m.c index 7a982c60a8dd..843bf04eecb3 100644 --- a/drivers/rpmsg/qcom_glink_smem.c +++ b/drivers/rpmsg/qcom_glink_smem.c @@ -239,7 +239,13 @@ struct qcom_glink_smem *qcom_glink_smem_register(struc= t device *parent, dev->parent =3D parent; dev->of_node =3D node; dev->release =3D qcom_glink_smem_release; - dev_set_name(dev, "%s:%pOFn", dev_name(parent->parent), node); + ret =3D dev_set_name(dev, "%s:%pOFn", dev_name(parent->parent), node); + if (ret) { + pr_err("failed to set device name\n"); + put_device(dev); + return ERR_PTR(ret); + } + ret =3D device_register(dev); if (ret) { pr_err("failed to register glink edge\n"); diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 2793096aba45..61f580ee04ec 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1494,7 +1494,13 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct = device *parent, edge->dev.release =3D qcom_smd_edge_release; edge->dev.of_node =3D node; edge->dev.groups =3D qcom_smd_edge_groups; - dev_set_name(&edge->dev, "%s:%pOFn", dev_name(parent), node); + ret =3D dev_set_name(&edge->dev, "%s:%pOFn", dev_name(parent), node); + if (ret) { + pr_err("failed to set device name\n"); + put_device(&edge->dev); + return ERR_PTR(ret); + } + ret =3D device_register(&edge->dev); if (ret) { pr_err("failed to register smd edge\n"); diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 073d56858b88..89d232d80df2 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -450,7 +450,10 @@ static int rpmsg_chrdev_eptdev_add(struct rpmsg_eptdev= *eptdev, struct rpmsg_cha if (ret < 0) goto free_minor_ida; dev->id =3D ret; - dev_set_name(dev, "rpmsg%d", ret); + + ret =3D dev_set_name(dev, "rpmsg%d", ret); + if (ret) + goto free_ept_ida; =20 ret =3D cdev_device_add(&eptdev->cdev, &eptdev->dev); if (ret) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index a5dd09f19b14..49737d69b44c 100644 --- a/drivers/rpmsg/rpmsg_core.c +++ b/drivers/rpmsg/rpmsg_core.c @@ -553,8 +553,12 @@ int rpmsg_register_device_override(struct rpmsg_device= *rpdev, if (driver_override) strscpy_pad(rpdev->id.name, driver_override, RPMSG_NAME_SIZE); =20 - dev_set_name(dev, "%s.%s.%d.%d", dev_name(dev->parent), - rpdev->id.name, rpdev->src, rpdev->dst); + ret =3D dev_set_name(dev, "%s.%s.%d.%d", dev_name(dev->parent), + rpdev->id.name, rpdev->src, rpdev->dst); + if (ret) { + pr_err("failed to set device name\n"); + return ret; + } =20 dev->bus =3D &rpmsg_bus; =20 diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c index 28f57945ccd9..3e2cfd16df6a 100644 --- a/drivers/rpmsg/rpmsg_ctrl.c +++ b/drivers/rpmsg/rpmsg_ctrl.c @@ -165,7 +165,10 @@ static int rpmsg_ctrldev_probe(struct rpmsg_device *rp= dev) if (ret < 0) goto free_minor_ida; dev->id =3D ret; - dev_set_name(&ctrldev->dev, "rpmsg_ctrl%d", ret); + + ret =3D dev_set_name(&ctrldev->dev, "rpmsg_ctrl%d", ret); + if (ret) + goto free_ctrl_ida; =20 ret =3D cdev_device_add(&ctrldev->cdev, &ctrldev->dev); if (ret) --=20 2.43.0 From nobody Mon Feb 9 19:25:26 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A30B32D0D9 for ; Wed, 17 Dec 2025 06:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954303; cv=none; b=q2aO1RuIFEJAjw1mRI2GY7SheTs27SayZwciz/RPS5lwfgG2jnCRSY+rW47IFecp180FIO6NQA5rWSjLm+8y0w/v0wO44P9ZryXgEklRBv5dNo/fwqWvUOJByt4lcwQpZeyPpDSrL1aSJ0ZxX8N/fjqR6W+Qmu7zzlQ1ni1ulc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765954303; c=relaxed/simple; bh=0I0qvqymRF9QoC70JOSPLWPw0M52SYeSoFmasyfSf3g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gukWjWVwDrIfwOwiexsNRymEoAi/7e52CFe9SRWeNQ32s2IiRTvGTsIx6q/Cy3DVm+yiBHhmjtKP+xkkDu7rw9NpB3KZD51tW8MPNceYE/Ynitm+eqhAXqL+rVYE29xWRqZ/eKUvqQLjK9XNdTCKOv4uRg6nYnQbA7r4TirSXfg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Li+DlOsu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QsjiMA3X; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Li+DlOsu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QsjiMA3X" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH4XXj42316229 for ; Wed, 17 Dec 2025 06:51:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=yyqEdTkNehZ DD9905IPSA7Oq8e/eLNXhAbCD4frPgqQ=; b=Li+DlOsuK5SgcvNPolNg2yRB9hL OXELOynD+JAaSPlxYOAsc8cFFWR/GOUyv1q5c0xEGITWS21zrgDZFr/hVBCDEu2R dFPwCuGCuBRz79bN/9TL513SbB2u61G/qUCLm7ktK77TVGd90zGFdSKN1R/Eo0Mt 4+fxlHgug8ixnR753JETKkqufgWhrImoeGUjp/oXbgwRS+mbTqW3utC0Duhg1eRM jhNdg3JmskjBKHd2NSE0E2JlqIh/4smmtlmsRoYSiZMeCAYMOYnHtZHGb1MFfLj1 YfDcnB3V6mOxYSuhxQuJ5IjgY/yj4qxx7QPpKGviFJVMPIsQJ8Z9yqcacmA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3nkkgcss-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 06:51:34 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f1f69eec6so58426635ad.1 for ; Tue, 16 Dec 2025 22:51:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765954293; x=1766559093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yyqEdTkNehZDD9905IPSA7Oq8e/eLNXhAbCD4frPgqQ=; b=QsjiMA3X/TPlaZfTKZ2zJbK9myO1itwW/VwNRnJt+ylPBBuIvuGtMXIPpRVWA7g6nt xSVdKh1ZY02ntCiIG2IIGGWKlEA4VQG1/fWfv5X/NHWCGgdprjvyZ1bhEXCcAiDZjN5h lW1Uc58F4tLr/fwI8UYrDiOXmVIYSEVmylssjQOXLcvWA2K4w1DHsM3NFQbNy0iUipB9 WzEvcSY+B5RW+nmdbp7VGk9bdiAC3XnNYCauRULIwG+g/LqwgNA7V1EsytEix5TF65UD 9P7+0apw3ACHaSmXkIlvdaxG0DQbvXcY702h24EYEdJyDUdckHCrausKCzdjH+iLyJhW WZww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765954293; x=1766559093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yyqEdTkNehZDD9905IPSA7Oq8e/eLNXhAbCD4frPgqQ=; b=gQ4KSxQtIWmOUMzit1P9XqdP9g3VJtc2gUdZW+v/eaLy1vDPFiMRd5P99APbJxMiyu yFoIQxY8nGS/RbFDi5cWqtso4+NFd7K7Wu7oN/IAGe1soLsaUu2lz1yPM72bHdfZ3xjr 08IajfmDthWKUul+7HC5uhVEvhn0BTl449b7yAjRAK0I2bRFPWXBUqbjumrUIR34Q86N d1lZVRsG9qN7inVTsubuDrjHwLVojR6zIV23S1dNfGgwXoNQHDSx/oN91xadE1EH4V/w 3FA7bLNwh2KRp/J+I1MF4wJnbJ5mDCPOQ6aznZ49i6pUMBUBLTgwpyDjwkwqbWg997YA PmWg== X-Forwarded-Encrypted: i=1; AJvYcCUS/bBMDyhPfVtE8vfNExTRWiOG/s2ZKQiwu1lUDUGOXg1+6T7Map1pYh/3W5rYCjW5E0cntR4T9E/YSvc=@vger.kernel.org X-Gm-Message-State: AOJu0YzOFvBI27FYERZDIFjuE6PNWL+alcnYaspcI59gUaS2f1l6tJwr 57+jLeow1gt49qnEwAdK+hetsG8SGrdonAtFl5G7KRJqsA+UukwcB+d2nX+4k1bUxLZ8NX3G+tu Qdfe2PeILPuW82ld0oAZkB0P0KQDkyzZEYbj2XWobenIUW4Edf2LD+IcNkj5HRDvleso= X-Gm-Gg: AY/fxX7AeC/lGe6HNf7QPqWWicsvaCIqJIUFsgRE7i49qzl4P6TI2+KnY7BVZvkW1lg DOF5MmUE8+K6YKCDxAauxzrooaN3jB5KGXCUgkGrkUE6suFKcq/WnNAjnD42xF79cyH6mSjDZKn Bn+TVZu3On2jI4oepsrFbNyjX2jkzzewAZROLpzUsYOlT/HdVFPMBc+ikgRAGxfxHeWCvh49ffY /rS/ktgmolNTrZp90q1Z2U+jY9GZmmUmwCWZxYoKhSjvqvCec1a9It2/Mwx0VrSVj1ImyyklP/n ByHRn0KWXafCWeQtopTs/yEHn35l6O9rgcRiBSE4Ny90lsAd2wGZv+Eg/IxY4b73vTArtRdWN8k OBMwW6KFdwKBud/d1HgR2R+QK75pbKQ4wNMuqxWK9v6GtuuzpoTX7/h7PK4Nhn7u3WAPWQ6UIjc 1d X-Received: by 2002:a17:903:11ce:b0:2a1:3cd8:d2dc with SMTP id d9443c01a7336-2a13cd8d5c2mr49204275ad.57.1765954293260; Tue, 16 Dec 2025 22:51:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtqz6CiOwlW1tkl+yctLuwFblPw8bJgxrwHp/33FxU5mFEQrIOanR0EDlUZNhr30xxaWfvwg== X-Received: by 2002:a17:903:11ce:b0:2a1:3cd8:d2dc with SMTP id d9443c01a7336-2a13cd8d5c2mr49204035ad.57.1765954292751; Tue, 16 Dec 2025 22:51:32 -0800 (PST) Received: from zhonhan-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0993ab61dsm118846515ad.46.2025.12.16.22.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 22:51:32 -0800 (PST) From: Zhongqiu Han To: andersson@kernel.org, mathieu.poirier@linaro.org, corbet@lwn.net, rusty@rustcorp.com.au, ohad@wizery.com Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com Subject: [RFC PATCH 5/5] rpmsg: virtio: Optimize endpoint lookup in RX path with RCU Date: Wed, 17 Dec 2025 14:51:12 +0800 Message-ID: <20251217065112.18392-6-zhongqiu.han@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> References: <20251217065112.18392-1-zhongqiu.han@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 0bn7zb1gqNyP3GkkLBaQFwFwQsImuymq X-Proofpoint-ORIG-GUID: 0bn7zb1gqNyP3GkkLBaQFwFwQsImuymq X-Authority-Analysis: v=2.4 cv=f/RFxeyM c=1 sm=1 tr=0 ts=694252f6 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=4XvfFkW6Ni2-fQWSjOsA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA1MyBTYWx0ZWRfXzgm/wJp0lGsf BrYRiuEhMruUOQm5GYccyZImzAmArFOcKO7ETRANSEV2CQ7mOuw0kyVc83BqhfrpCXW4DaKfC5i CjNlj1vt67i9PFSgumWfA6IDDi099wbjo0Ntb2YDK+Ke1Cu1onP0x1Bw8r7IwEkGsR4Vh1K+rD6 wchwgRin08LJg4mtMo5rILEpHhqVgNAKJpSUUaziG7ZiDTt0UEF2la2HCCFxdYpWDdV8IMysH65 uwhW+95CcvaU+weRaKH/wMKKZnnRORkslQQbqL4WOrchRYHB2kg4eNJzxxBPY15VZ8UKrmOG1Ix NDQv3eRdsr21GjqoWT2IM8FfRydHC3vSjTNUHCHWib7kDfCWHE1jRJetGtoES9EvaxFOR5wT1UM gJuBlwuI27L53G36sQ+c8XBNcGsquQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170053 Content-Type: text/plain; charset="utf-8" Endpoint lookup in the receive path acts as a demultiplexer routing incoming messages to the appropriate endpoint. This is a read-heavy operation (frequent message receives) with infrequent writes (endpoint creation/destruction). Since idr_find() is safe under RCU read-side protection, RCU can be used to optimize this path. Convert endpoint lookup to use RCU: - Read path: Use rcu_read_lock/unlock for lockless lookup - Destroy path: Add synchronize_rcu() after endpoint removal This reduces lock contention in the hot receive path. RCU safety note: When idr_alloc() returns, the endpoint becomes immediately visible to idr_find(), but ept->addr might not yet be set. This creates a theoretical window where RX could find an endpoint with uninitialized addr. This is safe because: 1) When endpoints are created via rpmsg core callbacks, initialization completes before announce_create() is sent. Remote processors only send messages after receiving the announcement. 2) For manually created endpoints, drivers control timing and typically do not announce until ready. Thus, messages only arrive after ept->addr is initialized, making this RCU optimization safe. No functional change except reduced contention. Signed-off-by: Zhongqiu Han --- drivers/rpmsg/virtio_rpmsg_bus.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_= bus.c index 79d983055b4d..4cbb8a8aaec5 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -297,6 +298,12 @@ __rpmsg_destroy_ept(struct virtproc_info *vrp, struct = rpmsg_endpoint *ept) idr_remove(&vrp->endpoints, ept->addr); mutex_unlock(&vrp->endpoints_lock); =20 + /* + * Wait for any ongoing RCU read-side critical sections to complete. + * This ensures no one is accessing the endpoint after removal. + */ + synchronize_rcu(); + /* make sure in-flight inbound messages won't invoke cb anymore */ mutex_lock(&ept->cb_lock); ept->cb =3D NULL; @@ -680,7 +687,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp,= struct device *dev, } =20 /* use the dst addr to fetch the callback of the appropriate user */ - mutex_lock(&vrp->endpoints_lock); + rcu_read_lock(); =20 ept =3D idr_find(&vrp->endpoints, __rpmsg32_to_cpu(little_endian, msg->ds= t)); =20 @@ -688,7 +695,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp,= struct device *dev, if (ept) kref_get(&ept->refcount); =20 - mutex_unlock(&vrp->endpoints_lock); + rcu_read_unlock(); =20 if (ept) { /* make sure ept->cb doesn't go away while we use it */ --=20 2.43.0