From nobody Sat Feb 7 05:38:26 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D378A24468B for ; Wed, 17 Dec 2025 05:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765950452; cv=none; b=EjrRvagPOIMYS18gJkLeTro/AwvtW80oNprYK6DeqrvOr/LJ8YA38bxZ1hT93wRYX8PHMII9DiuQbphSFRgTN7ikaSdAJT1COwU7PnXFAe2230NU/+jIsTwGg2uBOgcTJcCDBu+goxALrXIWyGSRtVFct0kcf6rL2Oa1cUSQomM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765950452; c=relaxed/simple; bh=Wqg2OkAwoAPvHpfzGdew9bAtWM4ALZqBy5yf/17p6Kw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mfpD2uiRWieDGc5fqLg+odYJ8iL8JBJ7hqvX/a9wBufDG+AGtPrca3bDE28pvtZ7K9789QcuyNf3y/N3i6BXVJzBPBZ8GrsC/XlyhdLKwXH4WU9zdLRK4j9RPxL26F7Gg85C//2cQAAf7oZUBh0mKk6yhta1iYnPn5lVSsk9U4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A1eBVy2n; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A1eBVy2n" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4779cb0a33fso63677945e9.0 for ; Tue, 16 Dec 2025 21:47:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765950448; x=1766555248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=78dFlraoKK894E/v95kDcWXupSqcG52RKepDqDlHiRM=; b=A1eBVy2njGSZtd7JRo0/71NjlN2MV6kY/eHDFnubOK8KJ2hLheLdnJKHPFOsbetbm8 KW8ZDsIspNxpv6m2SptzlGEg5VYhvOf6WFdG1u241j4vZ/rZJ22vxK0947do8mBTXoAB mH7PkOURO0i3ZcTjeCAB0utZYZZ8SZm+JrNpAalox8sevhes+yeLUqQfu1LZt9NHrwrp 3Qw6jUDEKb6cbqdEgmhjghbzJC6s+oiDVUpqhGttGRGRWoJR3Au5jw1wUNFnTxgfpA4+ 1khcRguXn0N9VyPEZ/W1XNZyRTTI4v71g+j76BnwfiPFvg5X9qLHRQGGnRdBFspWkGSb vuxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765950448; x=1766555248; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=78dFlraoKK894E/v95kDcWXupSqcG52RKepDqDlHiRM=; b=jWIPfwgGYBYA8mUGgIeaMsRYDFJRNst3pu5Sc9wXWNK/JQqs7PJs5dgza+A9hNCXU0 1I+ZZy0Nf6eE+rr/MDryTabqtASssR2hbCWYsJGZQcMxpdJjgcmVLH9sllvC2teuJpaX Y5+E3F3TtZts78puDcrHYUn5hqD3cmP75mrmjHD+DuYq2iMZHcFIlpcSnfcmNOs7wYxg S7n1osAC6c1YzULHzAwyAagHmtEV1zszEDNb7PdwXnzoURTiBGGzftaBSQhP0X8QabLI +kYX9NN0O5R+R1gLUtI2pzEW5Simcybk4OISPDFS5r8S5jnSbcy/wzMu7DDhoKOCEcv4 sTpw== X-Forwarded-Encrypted: i=1; AJvYcCXQa5wBksFJlvuMQP6Nwq0QI9FqFDcp6yFIUzitj5HnbFHncYoY0nLlbr1nMfx53lycu7vC7Nh9hYJMhd0=@vger.kernel.org X-Gm-Message-State: AOJu0YwnRJ6yg7AGE7zA9q4nY1ETSb3k7HmPK2h+GZ0enswYMnL7zrGm 8rc55utf/B4YX+Q9q2wYlyHXLMWwhMRAL0SIoUa1IaSJpq0f+wLZzqXK X-Gm-Gg: AY/fxX4wNfjuF/Iz4wbLFLKxO0Xs+G60Hm1P9G+SF5rNVSvVI2WA+p2LaFXp8MFyS0Y QNLbbXEfT/P1sIDLYoUMXD0DTdSv5aLPFl7xPOdwoAsfI+Ubl+T6zf9cibVBM8NpPM2qCKQwh1M NZT5Mz9kaTtnbEj8NBMgyClJERwkzwSMeooMf/AvF13bnAUqZdv/eDd6GPHY5Bw68fN0SVDp6V+ hDTNBGgIzdlC/a858/6htJta1LxWzJPLaYL4StQkkiXCf+PDDfA6gITDhaPTSIYtXPzbSpuOolk tg2+uNDWQYAPgJauyOmkyQMqF4NM4bDCYGa/qm/qCCnzGBBIgFnC7pG2ZMEQltfOHiI+t9e6OPz dZF2NLF9ef+nenz3C03Dz96fNfcgn58iFoZHRxy5+4fNXozaBdd6RMJk87Q52VkAYCqWJYaxgJD 0CKrtGYXG59WpKcQ== X-Google-Smtp-Source: AGHT+IEJnQD+wtWuoMRDLkZscCdThtw8fDQbJjJHtIPtXKe8FCUM54PfYp3g7xZABjP755Na+v9/mw== X-Received: by 2002:a05:600c:8b62:b0:477:abea:901c with SMTP id 5b1f17b1804b1-47a953da53fmr134204355e9.11.1765950447932; Tue, 16 Dec 2025 21:47:27 -0800 (PST) Received: from gmail.com ([136.226.167.107]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1e6ca3sm20611325e9.12.2025.12.16.21.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 21:47:27 -0800 (PST) From: hariconscious@gmail.com To: oder_chiou@realtek.com, lgirdwood@gmail.com, broonie@kernel.org Cc: perex@perex.cz, tiwai@suse.com, khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, HariKrishna Sagala Subject: [PATCH] ASoC: codec: rt286: Use devm_request_threaded_irq to manage IRQ lifetime and fix smatch warning Date: Wed, 17 Dec 2025 11:14:59 +0530 Message-ID: <20251217054458.38257-2-hariconscious@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: HariKrishna Sagala Replace manual "request_threaded_irq()" with the device managed "devm_request_threaded_irq" to manage the IRQ lifetime and also it removes the smatch reported warning. Remove the manual "free_irq()" in the "remove" function as free_irq is tied to device teardown. Signed-off-by: HariKrishna Sagala --- This patch replaces the manual management of IRQ with the device managed IRQ API. Also, it removes the smatch reported warning. sound/soc/codecs/rt286.c:1252 rt286_i2c_probe() warn: 'rt286->i2c->irq' from request_threaded_irq() not released on lines: 1252. Removed the "remove" function as IRQ is managed automatically. Thank you. sound/soc/codecs/rt286.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c index 2fbb5860c421..195658f626cc 100644 --- a/sound/soc/codecs/rt286.c +++ b/sound/soc/codecs/rt286.c @@ -1236,7 +1236,7 @@ static int rt286_i2c_probe(struct i2c_client *i2c) } =20 if (rt286->i2c->irq) { - ret =3D request_threaded_irq(rt286->i2c->irq, NULL, rt286_irq, + ret =3D devm_request_threaded_irq(&rt286->i2c->dev, rt286->i2c->irq, NUL= L, rt286_irq, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt286", rt286); if (ret !=3D 0) { dev_err(&i2c->dev, @@ -1252,22 +1252,12 @@ static int rt286_i2c_probe(struct i2c_client *i2c) return ret; } =20 -static void rt286_i2c_remove(struct i2c_client *i2c) -{ - struct rt286_priv *rt286 =3D i2c_get_clientdata(i2c); - - if (i2c->irq) - free_irq(i2c->irq, rt286); -} - - static struct i2c_driver rt286_i2c_driver =3D { .driver =3D { .name =3D "rt286", .acpi_match_table =3D ACPI_PTR(rt286_acpi_match), }, .probe =3D rt286_i2c_probe, - .remove =3D rt286_i2c_remove, .id_table =3D rt286_i2c_id, }; =20 base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 --=20 2.43.0