From nobody Thu Dec 18 23:25:18 2025 Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7F1C7261A for ; Wed, 17 Dec 2025 02:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.16.166 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765939694; cv=none; b=jdL1VaXHEvHO002AXwbXAId8LOPtab/iHaU7RV6kdTaHB991kz57oqTTcv37Rkydx4gVIuJynJ6YrdV/08t8rfRiFpVsYstO4abQ9MM3AvmfryWtUS0RdsLLTTTGaq8wT9uMBOREDkfJPpdP/2d/rASMrkkJ7DtCwZ43eMRbUtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765939694; c=relaxed/simple; bh=UHKm9TI4ZdpWJLWVpz2JjTDYczdpHIpenz3cWIkg80Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BG5+fCIphq0VBNJ8fUxhr4zOubfVd4H1je+itIawPEuRkEokplyzSh+YavAFkw/uRzJIYrUhXlXoforqauwAP+YH3oJTGFBFOEKChKung6RXUTvQ3VcsrFEYNAPY6up7rCtKKRF1rFpKsVFHhPfzHY1aUmXp3Z71Xdrzj/Ijq6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darknavy.com; spf=pass smtp.mailfrom=darknavy.com; dkim=pass (1024-bit key) header.d=darknavy.com header.i=@darknavy.com header.b=mKugvDtm; arc=none smtp.client-ip=54.206.16.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darknavy.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darknavy.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=darknavy.com header.i=@darknavy.com header.b="mKugvDtm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darknavy.com; s=litx2311; t=1765939636; bh=ROQvNZbGtVaOwmB2aZDpQMJr/nQT8HEfc1sbfIF6BGw=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=mKugvDtme8CsBfYuqxwyD6MqgcAMtM6EduG5zyPXDoNCndkrZzxPxrXWwQwxS+aow qHiScuYMuak0V5EIt1ApEyxLjsLgWFztFFyVu+ykEO99mmvi48MauiwpL67DuElJ5H fNKT1IGUZiF02MR5oBWl9cmxjryHfJw1AUQLmjPE= X-QQ-mid: zesmtpsz4t1765939629tdba55e21 X-QQ-Originating-IP: meVduVQoajiEDmTa4YA95Uy5Asd9c1/mrh8e4BkxZzs= Received: from localhost.localdomain ( [58.38.42.157]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 17 Dec 2025 10:47:07 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 12894234897604456030 EX-QQ-RecipientCnt: 7 From: Shipei Qu To: tiwai@suse.de, Jaroslav Kysela , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, vr@darknavy.com, qu@darknavy.com Subject: [PATCH v3] ALSA: usb-mixer: us16x08: validate meter packet indices Date: Wed, 17 Dec 2025 10:46:30 +0800 Message-Id: <20251217024630.59576-1-qu@darknavy.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <878qf2g0tm.wl-tiwai@suse.de> References: <878qf2g0tm.wl-tiwai@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:darknavy.com:qybglogicsvrsz:qybglogicsvrsz4b-0 X-QQ-XMAILINFO: NHHBtKpbeb7pJdv5HyMt90wyBg1IhtdmuFqQr52Nmvch6gJALze4s+Gg Q7YsgDda+tx4cNXwQP/yxvZdx4k9lBIDXdbZ/0crDJ2p3F1B9fzEd+03zwvtnKcBHGr0BDX dT08BO3Prga2mf2CnzYzJ3aBe2nDvoBmYWM7woHeLNGQWyai1pIH7DCPVvP2eL+I427VxhC 7UEEPF4PCeb5swnGgS6M2J38YIp/V06Ar90FcuF7VU/E5+dYJxlof+0VxUFQ3bkelxwUSUD BQnwHEueNGoFfoIVtnqHG26CQU22FAoRUnMPvIOHdubHcqK8coNnylf7wAs/0uiflURtkeY RoeUbv3oDzyl1ACT13JdV262xBHXSppeiGlV/HiMxURMr8013AH3cguumm+kfGAzVc6zs4P jMgWNiIcLtECygAXZHGTKwVbMvBtodBGT8n3TliBwwRniw2sqAgxMhr63I8QXLUms2RFtrl WhePmDYTJmhSp/XSlymKdED4XOy5Kpuy9LN0lALdi5ruKx5QPJjBFj9XFcPhHjGfZmv8pjf brk9TYxhk4AoFAGFN6BYjZGWDX+T/i92OkTnNKNLExxt9T5qHHzk9a40b4bdvavjBTiE2FY 8wf5nlw0dPFVga/Yk5EC8JSHaiSM3a+QQz8jZGVySZj89SbYYdCFoqbAkOPtd2bW6RHv0Mb Flt4RwmoeumvzOu64DXc+Xs5lBKOC8Zd8sOoOMJWhzdlAPOLmgj8tmJBICFuitjiMpJoOPc gqmkNLpZSITBc7wKAP2JqqUbPfsQJZaihIDh8BiwwDE8+ih7GUHZSfelNWsfD2taohRmNIm mDYsFLSaB9jQab+MaJsh8MMA8JELuWtTfRRdfM0scw/DrbmdeHuk8eGxQmQP8pRfrgEDroO Ibf3W7yMrz9uNKgHpjNxAJOpLpc9T2G8BDvJ4FbAMHpudzqbqiBDGHPNbMnCX5FpKfqQNzb WeQkqa8O1h1wNsy8CLDdzeOy5ZHeymSCM5EIVlgTqqDhKWPvqMlFDTBaYYF+ak1E5mZPxiD M/xhVNSw== X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" get_meter_levels_from_urb() parses the 64-byte meter packets sent by the device and fills the per-channel arrays meter_level[], comp_level[] and master_level[] in struct snd_us16x08_meter_store. Currently the function derives the channel index directly from the meter packet (MUB2(meter_urb, s) - 1) and uses it to index those arrays without validating the range. If the packet contains a negative or out-of-range channel number, the driver may write past the end of these arrays. Introduce a local channel variable and validate it before updating the arrays. We reject negative indices, limit meter_level[] and comp_level[] to SND_US16X08_MAX_CHANNELS, and guard master_level[] updates with ARRAY_SIZE(master_level). Reported-by: DARKNAVY (@DarkNavyOrg) Signed-off-by: Shipei Qu --- v3: rephrase commit description v2: resend with properly formatted diff sound/usb/mixer_us16x08.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c index 1c5712c31..f9df40730 100644 --- a/sound/usb/mixer_us16x08.c +++ b/sound/usb/mixer_us16x08.c @@ -655,17 +655,25 @@ static void get_meter_levels_from_urb(int s, u8 *meter_urb) { int val =3D MUC2(meter_urb, s) + (MUC3(meter_urb, s) << 8); + int ch =3D MUB2(meter_urb, s) - 1; + + if (ch < 0) + return; =20 if (MUA0(meter_urb, s) =3D=3D 0x61 && MUA1(meter_urb, s) =3D=3D 0x02 && MUA2(meter_urb, s) =3D=3D 0x04 && MUB0(meter_urb, s) =3D=3D 0x62) { - if (MUC0(meter_urb, s) =3D=3D 0x72) - store->meter_level[MUB2(meter_urb, s) - 1] =3D val; - if (MUC0(meter_urb, s) =3D=3D 0xb2) - store->comp_level[MUB2(meter_urb, s) - 1] =3D val; + if (ch < SND_US16X08_MAX_CHANNELS) { + if (MUC0(meter_urb, s) =3D=3D 0x72) + store->meter_level[ch] =3D val; + if (MUC0(meter_urb, s) =3D=3D 0xb2) + store->comp_level[ch] =3D val; + } } if (MUA0(meter_urb, s) =3D=3D 0x61 && MUA1(meter_urb, s) =3D=3D 0x02 && - MUA2(meter_urb, s) =3D=3D 0x02 && MUB0(meter_urb, s) =3D=3D 0x62) - store->master_level[MUB2(meter_urb, s) - 1] =3D val; + MUA2(meter_urb, s) =3D=3D 0x02 && MUB0(meter_urb, s) =3D=3D 0x62) { + if (ch < ARRAY_SIZE(store->master_level)) + store->master_level[ch] =3D val; + } } =20 /* Function to retrieve current meter values from the device. --=20 2.45.1