From nobody Thu Dec 18 20:17:54 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30D3A346FB3 for ; Wed, 17 Dec 2025 09:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765965131; cv=none; b=Fu7p48+7ZDjzX7u0BEqadNnQNbpBd0zKAPxAtKyGZo72YdMqXmN3zp3oRy3YP1dzfIl0/9ZbuPmzQ1ALCvMayvSK9xWH7L337kc9vX/gC6ICNZBO645MzvKLl+O4iXy/ceRGaOt5rmUVHqrVgrttFBzB0RJ7hRsaYNEaw+xZYmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765965131; c=relaxed/simple; bh=3n8ScSa9U5u4J9FORj/r+W2S9YcBhcL6ToUsDlBBb8w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rGZ+WpqCSibKPRNMakCiNhGkYtr+lNBR2cNZt3lnoMJgXqO/sIP0Abva/acMU38kHVUVV4IsD++cLwaVjnSp8B66NXW2wlHeOwkoN1XJeeAgB7pyTQkFRVu2cVTGSnzKHge0X668VZckDR55TU6s1RHO9FxeP8XDgIEZyGOkYpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=laq0HF/L; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=juKMJUSS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="laq0HF/L"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="juKMJUSS" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH3F9Xq1591261 for ; Wed, 17 Dec 2025 09:52:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YWkiFRWGmUEeIfo9pk1+SznEx7y/iiY47QRvAY739P8=; b=laq0HF/LGyXfijqu FTHG4rbbN7SEiZsOUGovNlD8nXA0T65Gb70OzfkhoEdmuMi7s2jUyQjXrzJhyePm oySKe+8VcfuZpVhcJEUwu8egzrZPMqMmsUHtyYQhyPrBa8zTujvepb06Tw+vhmql G1vb3NIkVWKrNEisJZcQbkuN9jy0NuAKQ3Sf3ESdiNIrO5kfoto0UnUehgORy0zF HCj501w61dJMeqNHlMaliub2C3ZwEqhnufVZxLM2eg2PfgdrRpmZ1qu84rz0+pc5 SSqp5foCBhNc3B11x8R4SYAN2gfM+5oyjeXSFkaqChjiKadoXJMrcYHjcjnjxvOR pRGABQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3fefhxdc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 09:52:08 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8824292911cso8830096d6.1 for ; Wed, 17 Dec 2025 01:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765965128; x=1766569928; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YWkiFRWGmUEeIfo9pk1+SznEx7y/iiY47QRvAY739P8=; b=juKMJUSSj09dgv5lrSJ+js214tk2rkexd5Ma6LRK2ociHT2cDhcc6+Mg5S7ThfoP7v Y/F+mJCyxF5tAGzcXGrlGuSWvTbfyKICXMn5Mm9hNsti9G2V5Bv1P96yOeQ5oN6DXGG9 3lr/JJUK8Hnu6Ujw3oOmzWU1JEenNghnav957L1mR/kPdfyLt4zIghRw8FpLymoitkwJ A/PUCwqioakgmI2G+bCDmSDT+xFOGpts2nSQ+fTs6qnHUWOsLZ3EGR24oA/HxaewI+HW B4YfcbxqkCcM0hRjBUCQIM/vM7MZqdtwF8g67qyg9IOz4GBjIGjntmvERXbmx+MjJw/v 746Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965128; x=1766569928; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YWkiFRWGmUEeIfo9pk1+SznEx7y/iiY47QRvAY739P8=; b=KTk/d1RU/lHocoOEbT6qnFDijDYlAlyYt5fbnDEPho/T1BSW6JwsNmgDnUIYi+DJ57 Xf1tJUfbTGMi+AK7RuK1p5eoJtdScIPLKtbB7lbZmCEdsL4qlrukKBaF1KieDCUJEHoK DulHDa09UR5VduWuYGhxFAyhmaKpgY88+9z/bj7PbSzyrooJWoVBoNXjh6TcLvEeOIXL iGGg3ASH1rtwkZuE3FKqx0vQQxpetxnDM5wWFz8Ljua7BS0gEem9bxk/ggF4eiGf7kDn jsaRaQer+etZuStOgHz+p+jywhyLnDdt1bmQzAyJPbCd+icxaFm/oE94TchT5JSyG1Su 51vA== X-Forwarded-Encrypted: i=1; AJvYcCXBJLtXFrNbycovPx1YtpxVGjQv+gXtYO1DBmeEY357j483h/CIGkEk49eCtGyGCQhN0Tyfw8wwARZ9Zfg=@vger.kernel.org X-Gm-Message-State: AOJu0YziBLmUi7nnmfSz1VXEhY96ARPz9ABeYS5RDH6lSTBquv5pIIBV eqqYbwmz56vIAF65MDTL4+MgWxKjYC6Ipw0Yh39LxEtKtTUsqypO17lGabWDxGyrudGIJUJ7cgN W0icM+BbWdQLIjakeLzbsxgqoLj0ut6N7PgfzjWb7DD8lisnjpGH1kyx6JIZFPii5Rno= X-Gm-Gg: AY/fxX4RmomovW9E1OkHF1asNTFmpPnGMI1K6PehPEb0bjlHKG2XDZv9gAp6YJtLpAs ddlYUhFPdcXkHbjRD0imtqXUnQAmEkiPmy7zBc046LNcDbAURER8nz6B8UKhSOKMrtf2Ox8cUyZ t7+KFNkbx7icI8YL5eZPwBjc4ZoA/cwLNNnjl35ToaOFmEWQo1vz3dfQRIEL29ThFEn85FTDBnA 4PwwEVV8QjZGkhiLi4Zv8KZo7TmIYJK2JZttAyjCFikvzs6o37evOHdkAq2qtjMQmlxJ2/e9VfA MR9N07G3tFrqo7UutLohrCrmXuh1TRiUPW85EQc3VEDnad5kaRHTCX8r6FI9sg4RY1FBsNeC3sW FgEKreNuI3teEDb99X48YSh1zqcMDlsNS X-Received: by 2002:ac8:7f13:0:b0:4f0:2211:d08b with SMTP id d75a77b69052e-4f1bfe5615dmr312364191cf.33.1765965128286; Wed, 17 Dec 2025 01:52:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsdR4N3vHyv8amDOPM/OH89kFgMV/Z5oKndrL89pNMc4wMQxwekHFD2SeSkPhEiaDcPXyjQw== X-Received: by 2002:ac8:7f13:0:b0:4f0:2211:d08b with SMTP id d75a77b69052e-4f1bfe5615dmr312363981cf.33.1765965127700; Wed, 17 Dec 2025 01:52:07 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.51]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f5630easm1981969a12.22.2025.12.17.01.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 01:52:06 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 17 Dec 2025 10:51:57 +0100 Subject: [PATCH v2 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then: and constrain more Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-watchdog-s3c-cleanup-v2-4-79d8caf65ec3@oss.qualcomm.com> References: <20251217-watchdog-s3c-cleanup-v2-0-79d8caf65ec3@oss.qualcomm.com> In-Reply-To: <20251217-watchdog-s3c-cleanup-v2-0-79d8caf65ec3@oss.qualcomm.com> To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3929; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=3n8ScSa9U5u4J9FORj/r+W2S9YcBhcL6ToUsDlBBb8w=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpQn0+2GgQ2ETAUn4PXAy+s3AdxFmkRonLCHYok G+Ib60KmcqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaUJ9PgAKCRDBN2bmhouD 1yxeD/0cQIN6Oy3QfGVCiba73/vXoSj1fnzE0ZaYR/b6K9i75xua8CCcvW8mdiPzW+rWSNBUtri +45+dwL2x1XbjN9qf4kLaAgsqR/PoER8qhQ0AROmHF/xy8vACNA6QhYarzeZF5DoPQIuCDa34YE hNPyG9ifW1sw0Glv3xa2u5JzbyYJhf9XtySjYdBZq/dkdMayQTwK2GnDMKpm2ztXL9zlYH+Je4k 7XLAB/XvNEAhyKzNarDOa4084QOGsK3gXzC9XbPwmJHSxAwn3luGaCqfdQLYkTCna8yy36/tT20 bPzrcnzBwHZZOQ94Dt7u0AKdCix07LxYTQjVVFaT8xiAP0RVUFTCHo2y3wUM+IA0VlzouudH5L7 coBvGE/90gCZzgR7Qhvhq5dSis+Ug4867hTUOQKmHT54xke3EoroBY/RL8D41WqXIpOT+ZF0Xhm 2qIaYPZiKmnWPPyDffWKNgS1hJ8g+ucMgDHM4v1yueQovcD0+axcvyVfJ/122hZ0j+ffTkX94gP 5UM4kXOxh9NrReg9HJgl5HSAj4E0BmW8DbpuKIW4J+c9BcaU2UefRfgZtvDsqlTqQI5Vrt66QKI kXAnpSmkH2MfdnhH2H5s8d6U5kRPDm+SuygOffxjHJeJUOKbKqD0ynu20UsecCV2F8rG1JU4th+ hUCAjzLdWUi6IfQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA3OCBTYWx0ZWRfX4L4fx270U3MK cm/+Rw0uS+qnWkTBcuNDiVfsbufdCj8TxOkfNJVQC4UP/U2YqBUuMzXbxYEuT91KdQrOkpuw4Ey GtLX42p0XBcnWDWj+jXwVpYYKSotHLCZ+i/Q+paPTGR9hLv0ITFIhS2p/oxYZCxiyRyKVKBfoq8 C3rCUqHucV9f9jo+gx673sJFeZ/E8CPhxVxlRxmSHVg3xIiMcbWGcImbE0IDHAsVjwSEvoDnnJy zvHz4IfPVXXMrQYg8C231XWgG59GUIILatA495SImJt4ptkCaTNhYE61VEfvAXOn0c55GWE5rkf DLWQ6X4wDgui7yAlis8tqiyTMkNULD46wLQL8ENxUrOSE5Y8OmtQ/saZTCH74RLK6+WEUKhgyUz R4ZhCNxEZtr214W1I7If21+9wfMT1g== X-Proofpoint-ORIG-GUID: GgTQDWQ9ZVMsmbzdRgrg1_t5d8sN9vvi X-Proofpoint-GUID: GgTQDWQ9ZVMsmbzdRgrg1_t5d8sN9vvi X-Authority-Analysis: v=2.4 cv=R48O2NRX c=1 sm=1 tr=0 ts=69427d48 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=hmARNUlj3OVxZ3RlbIsQyw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=_jlGtV7tAAAA:8 a=VwQbUJbxAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=l-N3HDM6Fn6Kim4WiOwA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=nlm17XC03S6CtCLSeiRr:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 spamscore=0 impostorscore=0 adultscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170078 Binding defined two if:then: blocks covering different conditions but not fully constraining the properties per each variant: 1. "if:" to require samsung,syscon-phandle, 2. "if:" with "else:" to narrow number of clocks and require or disallow samsung,cluster-index. This still did not cover following cases: 1. Disallow samsung,syscon-phandle when not applicable, 2. Narrow samsung,cluster-index to [0, 1], for SoCs with only two clusters. Solving this in current format would lead to spaghetti code, so re-write entire "if:then:" approach into mutually exclusive cases so each SoC appears only in one "if:" block. This allows to forbid samsung,syscon-phandle for S3C6410, and narrow samsung,cluster-index to [0, 1]. Acked-by: Guenter Roeck Acked-by: Rob Herring (Arm) Reviewed-by: Alim Akhtar Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/watchdog/samsung-wdt.yaml | 70 ++++++++++++++++--= ---- 1 file changed, 52 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/= Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml index 51e597ba7db2..41aee1655b0c 100644 --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml @@ -74,24 +74,7 @@ allOf: contains: enum: - google,gs101-wdt - - samsung,exynos5250-wdt - - samsung,exynos5420-wdt - - samsung,exynos7-wdt - samsung,exynos850-wdt - - samsung,exynos990-wdt - - samsung,exynosautov9-wdt - - samsung,exynosautov920-wdt - then: - required: - - samsung,syscon-phandle - - if: - properties: - compatible: - contains: - enum: - - google,gs101-wdt - - samsung,exynos850-wdt - - samsung,exynos990-wdt - samsung,exynosautov9-wdt - samsung,exynosautov920-wdt then: @@ -104,9 +87,41 @@ allOf: items: - const: watchdog - const: watchdog_src + samsung,cluster-index: + enum: [0, 1] required: - samsung,cluster-index - else: + - samsung,syscon-phandle + + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos990-wdt + then: + properties: + clocks: + items: + - description: Bus clock, used for register interface + - description: Source clock (driving watchdog counter) + clock-names: + items: + - const: watchdog + - const: watchdog_src + required: + - samsung,cluster-index + - samsung,syscon-phandle + + - if: + properties: + compatible: + contains: + enum: + - samsung,exynos5250-wdt + - samsung,exynos5420-wdt + - samsung,exynos7-wdt + then: properties: clocks: items: @@ -115,6 +130,25 @@ allOf: items: - const: watchdog samsung,cluster-index: false + required: + - samsung,syscon-phandle + + - if: + properties: + compatible: + contains: + enum: + - samsung,s3c6410-wdt + then: + properties: + clocks: + items: + - description: Bus clock, which is also a source clock + clock-names: + items: + - const: watchdog + samsung,cluster-index: false + samsung,syscon-phandle: false =20 unevaluatedProperties: false =20 --=20 2.51.0