From nobody Tue Feb 10 01:50:20 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB8F13B293 for ; Wed, 17 Dec 2025 10:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966259; cv=none; b=sKI+WnlAoTdjFwD9aqxKVDUyRZ1BBATyX5RzuAUt9aLmoKvALiZ9F3LBC4jP+GuT9lbr2nSrmHKkvrzhPfJLTSSC6e8VdoWUjQfgEyEg3ju9JiIuRl6jNiBtFSQMbSU2Yo6NaBrCj+ZW4VftM7jIU9d/NHVwe0sbLTY6Ln6JUOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966259; c=relaxed/simple; bh=H6IMjnPI8ZwYq64P5YA/CKhuGWLFID4mb3NAeF/Wkyc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PoEaiy4b7RaGmCnkh5DFtVdk0b78X8Hi/IXX7iSU582BxvXL3QyAjAu6HSvyOpmWgMIR55PGlk0wgyZb6cmnFI/z6HgePvfwGJ7r905MavZirip/QTZ5wBRN85gxI4ek0A8nHB5c5WCuouHtdaNAEGzAET6Osxjqdf6u1E93mY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZZCbCOny; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZZCbCOny" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b7a72874af1so854748766b.3 for ; Wed, 17 Dec 2025 02:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765966256; x=1766571056; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eXjtVLazU4FisU7iYDrCs/cvEQo0Kb5lMS6lWuXDtFU=; b=ZZCbCOnyoob/cYwp4TjRRXMFpsBeO/8susIx1iu2K3LQO7UFhY/fyIMEdyzZzkE5xU VU9X651P/DEne1HlKkZQOqfkhgK35p3r07lOLDkSyVmI2WsdXB4W0WLj9XCBGLDsIxFr D02RrChZJr20pClz+h7E3bqNXSo3BCneelwF+Gtbt45JyiBC2QXdYVKaqxnxKnMAskY+ eMhEao0N2TpJrbElvQ0yxZkn1k2ZiNPUQu8dqv+vWsvE8fq4qPwwrFpht+rtNjma14tI nfAmUYnvvYqsq3/amO/96wg/boz3t3abJUgn6RP2yT8Ir9xRNjG0ThD7R6KqB4QOUL5D Dj3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765966256; x=1766571056; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eXjtVLazU4FisU7iYDrCs/cvEQo0Kb5lMS6lWuXDtFU=; b=a9sbl9CWsR2mjVG/svGRC9sh0nUB9Qx3gOOiD0GUinQSJG0QDFSOtcLgBAotZG22Mv 1ylPO1HkW407JZBBrF0AxFBNIYLjkYxg7FpQdlwaPpx1UnXqo4egzPWvh6pAznoAsNXw tV9+E76BPH4xW+UzZ3VicsAxQh5/7H5JkBHD+EvmncQxxiCaJa54ykzQf6XEvk37DmdE vI9Tf+sKPqbLI9QMfA2vXOscFng8QRGtr0QuXkqye98E4/+kUELCCO2cAE4vamY+xsGC rQsj6DkFEosoZDvpGfKYPsJ3vG83yUZ/OkxyYms02L2uJe9YwGJLG+abz5zrcDTJGLK6 oaiQ== X-Forwarded-Encrypted: i=1; AJvYcCXu2V12nqHcIXbhREnfOnjaQBT9Ec3C4q3CccFzTlUYsjUVazlDG/2KwmBsVrcbVgV64QifvwnnZnefck0=@vger.kernel.org X-Gm-Message-State: AOJu0YwkrX5zsFsGqpTn/WOUQLWgbMZaCjVnBuuNogrNFpzn1zSPrlll UOdSF41g6camaOx7AKllJ3ZjeJcpmuzpwq7/9UovyKQsy4Cg0EQ6q3Os4CPTbfasRQ0= X-Gm-Gg: AY/fxX7iC5/UUevgfCg+cMMLCfTvX/EzBywEK2KkeaDjlxueMAGcjaWURnwzIcLdSZS /LjcfOF7fuWHs3J/b97WC7/1d6Ze5JIZE2rthNN2WO9v4kSTDQwBzmwuzO6c2yY/zJE6j51eLqK hGKMe6gw+KaF7WdfLa7qW2UH5hHrA9x+kRQgoP81C0dxSCEmHK1/tVDErOZZsXSP3y+fvBW+cpp Uh+QUNupgTWIRP97L982SbM5kwrOtWZ3Jytoca/I4YYOAbNd4erZQ61biSXiUa9ngVMkmAZa8Lo meIK25rdlt35Pze1ILlvLPL6jib1SAUgHkKyvQLi5FU1vhlpSAMoehznSUKi4jWppWYi07ZA4vl yCMb6FsW453hsWpY0d2o2OJFLkOuvrt8ugGbKx7RNiqTGZtJtxZWV++4JIyoOcnAEJp6bqjQMqY lm3TI3wJDXbVMYV46fknkSBb9tIBgHl1+Gq43yeEMpyoA1XLvUwlgMFcM5px3QHl+UCBqUEUUV6 mxzOQ== X-Google-Smtp-Source: AGHT+IHyMM6etwDYB06WTSrwaBUmwLHwdFRBAH3MZ0Riio860UC6heeeZnSPn7h1ka6K1Zx6Y3HXtw== X-Received: by 2002:a17:907:6d24:b0:b7a:1bde:1223 with SMTP id a640c23a62f3a-b7d23ad88e6mr1656378566b.64.1765966255551; Wed, 17 Dec 2025 02:10:55 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4f5a22sm2043811a12.9.2025.12.17.02.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:10:55 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 17 Dec 2025 10:10:49 +0000 Subject: [PATCH RESEND v2 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-s5m-alarm-v2-2-b7bff003e94c@linaro.org> References: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> In-Reply-To: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The core driver now exposes the alarm IRQ as a resource, so we can drop the lookup from here to simplify the code and make adding support for additional variants easier in this driver. Acked-by: Alexandre Belloni Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b= 01fc384735007 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include =20 @@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; - alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev) "Failed to allocate regmap\n"); } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; - alarm_irq =3D S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) - return dev_err_probe(&pdev->dev, -EINVAL, - "Failed to get virtual IRQ %d\n", - alarm_irq); - } + alarm_irq =3D platform_get_irq_byname_optional(pdev, "alarm"); + if (alarm_irq > 0) + info->irq =3D alarm_irq; + else if (alarm_irq =3D=3D -ENXIO) + info->irq =3D 0; + else + return dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL, + "IRQ 'alarm' not found\n"); =20 platform_set_drvdata(pdev, info); =20 --=20 2.52.0.351.gbe84eed79e-goog