From nobody Mon Feb 9 09:21:27 2026 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4B530E849 for ; Wed, 17 Dec 2025 10:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966259; cv=none; b=MXTN2XPtR0rZ+PB+JlqcJgyErYkvsCZN9DYgVFTzA6kaF/oHjj5sZTgIfk5P9LuwdEIlO8JDFx2jOEQdLwMRva2YbOTC5xpVFLyKktjXQpN6mQNydj3C0b9o0xauoZYOdwYUacMZhFzUa0e9LH0GEDrdjTjja6JusRMKuXXzLxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966259; c=relaxed/simple; bh=vZuZvZxOilgG99K1CCus8hp1iS1vINW92yTYPy99geM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gXxtpZEKqizvDKCEurM08nV6hDlYYeqH5IX/eZlfWW4voKa+PEXgBMQBRVqDvcysG+nkjmdAXVUbSyNbvVmelm3tIMz3anHxLOQkCR5aNynGd/KbJVBw/gUXxpR8QSIia3KZ5XYnJB2JKIXehRTLXh/RFrf4lIxO/2r88FZrGZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oTNQGCBT; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oTNQGCBT" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b79ea617f55so522673566b.3 for ; Wed, 17 Dec 2025 02:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765966255; x=1766571055; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2I1z9PKfucHgXypI2JVRh4FRyFEf87RZSzZ/ck7bvnU=; b=oTNQGCBTouX8ExG6Yk40GlGAUWeke6Mf6YidWjme1iQXhoNEbkTjmZsfZPHtlp3ZJd P8YUrtioBgYYKR0cRyjJ+Vf19oeigivYXBja8fwn7fkibZl85gVqjua5BiyzscX92sa5 dQOy7QKBPJn9f8w6/NXZPDEGX0BGhw3z6a8vRetUckRnn/yUlFDcGQDeT9Je+BWEF5SB 4fADzEaIgHaEz9komKU5cgegNY5SRvHkuLUqZ1vcHT/m6gt91U0mL9/qtr39axQ9sIGg 0gJgJjdOgiq6Z69EZ1xdI8HmB62LOIK79sjGSRD7wlKiPSRFg24rrIBA8qUvOg8PgW3A tBKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765966255; x=1766571055; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2I1z9PKfucHgXypI2JVRh4FRyFEf87RZSzZ/ck7bvnU=; b=xCEwVeL45FbYAXw1DFQFT7al/Ev84CKKFFr6Jca+TlBI0mZjYdLVaNQbjB+Rswf/1X h5LaeJGCy6JEQaZ2JJFxRHRxz7PHlzUT39ETpVHlrnYDZoXE7AJGZCkDFJoofkOlzVcU kh9eViTSVJ8Bw7XwXEBZqHTTDKmzmP2O+3rBfhE/w3a6ZCyRC+Rky0EB4Ma3HmIss9M/ ItsP9zDJXoWAefpmMrJXKMRvdCbIz+DJpA+MCNUL4bomiAMaTq7xr1UaVuVZ2HfYjYB4 bnK99//xg9vmLlWmfWk83xV7O9UzYTSgj6877sjKJcldaTg78kg83kTlDrs9YJ0nkb5Y WSNw== X-Forwarded-Encrypted: i=1; AJvYcCVG48PHz+2rICsxXz1UUWaUzG5kIw/oJAEq9/claeDedmhhNVM3CQvL+sHjW74cUBexG3MulXF5olwRQGQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv6L0bDnlVHQV+2NOFwK5ON2NcfOyxQP2cKyY604qgdwQEwedP eu/TUSuit1vd76FywYsQzkLJLaRHnCWUV7KRUJYfg0kHTg4bnHIB7NvEsv0SeicPdO8= X-Gm-Gg: AY/fxX7OPruegzwUS3oyo48A96bWZclH1BGovldKh4kpEkUaSRLwZkrrIE/cAFGbX8U 0mKT2KIP+tUoWtbxNHBnoFQyVoAZd1nxTNBTmV3WC9LUVHlB4Y+qKvJrrtXnVN2jnva3utgeFIx RKsPe2ZckBBy0PNVw5kRnHcU29Ol1jp6LxzJmp1Cb2oAA5oldF6gXzp7kmL3cHWpbfSSo1f5yBd 9KdCvlhDsreVJZTfin1ElNaj0JpSb0kLAmtR/D7W7oHH9GaCnFsATTznovgDQpS9Y6e80RPQ6a6 r+ClIHFSbPw1PPG9I9wgc6yGpozk6Hmwyt3m9RwUnL8NtuSR7asJgd79I+TMyY09CG+gZEuFELp 4tp1A7x6yCoac4i11mcYbTs5TpTtK3IXamki6vh8kVtXG44bbpUQxSqkkwOb5gILLjmBPFVrkol bAS/JgGu0Ocg/6rX1OP82FHN47xLrlnKGge0Ts0EzyWeSxnWR6GBN4YT7sECFfSQ8zj8EeEy2X2 63WMQ== X-Google-Smtp-Source: AGHT+IEw9OR6970NlwrrVo2N5ViWtBVHSFhvWHB7PcDIt2dJr50vikuCJE35Z5BDLGoFltIUs/2JMQ== X-Received: by 2002:a17:907:9282:b0:b79:f4e4:b544 with SMTP id a640c23a62f3a-b7d236c0376mr1941191166b.21.1765966255102; Wed, 17 Dec 2025 02:10:55 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4f5a22sm2043811a12.9.2025.12.17.02.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:10:54 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 17 Dec 2025 10:10:48 +0000 Subject: [PATCH RESEND v2 1/3] mfd: sec: add rtc alarm IRQ as platform device resource Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-s5m-alarm-v2-1-b7bff003e94c@linaro.org> References: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> In-Reply-To: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 By adding the RTC alarm IRQ to the MFD cell as a resource, the child driver (rtc) can simply query that IRQ, instead of having a lookup table itself. This change therefore allows the child driver to be simplified with regards to determining the alarm IRQ. Signed-off-by: Andr=C3=A9 Draszik --- drivers/mfd/sec-common.c | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 42d55e70e34c8d7cd68cddaecc88017e259365b4..77370db52a7ba81234136b29f85= 892f4b197f429 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -23,9 +23,13 @@ #include #include "sec-core.h" =20 +static const struct resource s5m8767_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S5M8767_IRQ_RTCA1, "alarm"), +}; + static const struct mfd_cell s5m8767_devs[] =3D { MFD_CELL_NAME("s5m8767-pmic"), - MFD_CELL_NAME("s5m-rtc"), + MFD_CELL_RES("s5m-rtc", s5m8767_rtc_resources), MFD_CELL_OF("s5m8767-clk", NULL, NULL, 0, 0, "samsung,s5m8767-clk"), }; =20 @@ -33,50 +37,66 @@ static const struct mfd_cell s2dos05_devs[] =3D { MFD_CELL_NAME("s2dos05-regulator"), }; =20 +static const struct resource s2mpg10_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPG10_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mpg10_devs[] =3D { MFD_CELL_NAME("s2mpg10-meter"), MFD_CELL_NAME("s2mpg10-regulator"), - MFD_CELL_NAME("s2mpg10-rtc"), + MFD_CELL_RES("s2mpg10-rtc", s2mpg10_rtc_resources), MFD_CELL_OF("s2mpg10-clk", NULL, NULL, 0, 0, "samsung,s2mpg10-clk"), MFD_CELL_OF("s2mpg10-gpio", NULL, NULL, 0, 0, "samsung,s2mpg10-gpio"), }; =20 +static const struct resource s2mps11_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPS11_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mps11_devs[] =3D { MFD_CELL_NAME("s2mps11-regulator"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps11_rtc_resources), MFD_CELL_OF("s2mps11-clk", NULL, NULL, 0, 0, "samsung,s2mps11-clk"), }; =20 +static const struct resource s2mps14_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPS14_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mps13_devs[] =3D { MFD_CELL_NAME("s2mps13-regulator"), - MFD_CELL_NAME("s2mps13-rtc"), + MFD_CELL_RES("s2mps13-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps13-clk", NULL, NULL, 0, 0, "samsung,s2mps13-clk"), }; =20 static const struct mfd_cell s2mps14_devs[] =3D { MFD_CELL_NAME("s2mps14-regulator"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps14-clk", NULL, NULL, 0, 0, "samsung,s2mps14-clk"), }; =20 static const struct mfd_cell s2mps15_devs[] =3D { MFD_CELL_NAME("s2mps15-regulator"), - MFD_CELL_NAME("s2mps15-rtc"), + MFD_CELL_RES("s2mps15-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps13-clk", NULL, NULL, 0, 0, "samsung,s2mps13-clk"), }; =20 static const struct mfd_cell s2mpa01_devs[] =3D { MFD_CELL_NAME("s2mpa01-pmic"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps14_rtc_resources), }; =20 static const struct mfd_cell s2mpu02_devs[] =3D { MFD_CELL_NAME("s2mpu02-regulator"), }; =20 +static const struct resource s2mpu05_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPU05_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mpu05_devs[] =3D { MFD_CELL_NAME("s2mpu05-regulator"), - MFD_CELL_NAME("s2mps15-rtc"), + MFD_CELL_RES("s2mps15-rtc", s2mpu05_rtc_resources), }; =20 static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) @@ -220,7 +240,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, NULL); + NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); if (ret) return ret; =20 --=20 2.52.0.351.gbe84eed79e-goog From nobody Mon Feb 9 09:21:27 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB8F13B293 for ; Wed, 17 Dec 2025 10:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966259; cv=none; b=sKI+WnlAoTdjFwD9aqxKVDUyRZ1BBATyX5RzuAUt9aLmoKvALiZ9F3LBC4jP+GuT9lbr2nSrmHKkvrzhPfJLTSSC6e8VdoWUjQfgEyEg3ju9JiIuRl6jNiBtFSQMbSU2Yo6NaBrCj+ZW4VftM7jIU9d/NHVwe0sbLTY6Ln6JUOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966259; c=relaxed/simple; bh=H6IMjnPI8ZwYq64P5YA/CKhuGWLFID4mb3NAeF/Wkyc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PoEaiy4b7RaGmCnkh5DFtVdk0b78X8Hi/IXX7iSU582BxvXL3QyAjAu6HSvyOpmWgMIR55PGlk0wgyZb6cmnFI/z6HgePvfwGJ7r905MavZirip/QTZ5wBRN85gxI4ek0A8nHB5c5WCuouHtdaNAEGzAET6Osxjqdf6u1E93mY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZZCbCOny; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZZCbCOny" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b7a72874af1so854748766b.3 for ; Wed, 17 Dec 2025 02:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765966256; x=1766571056; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eXjtVLazU4FisU7iYDrCs/cvEQo0Kb5lMS6lWuXDtFU=; b=ZZCbCOnyoob/cYwp4TjRRXMFpsBeO/8susIx1iu2K3LQO7UFhY/fyIMEdyzZzkE5xU VU9X651P/DEne1HlKkZQOqfkhgK35p3r07lOLDkSyVmI2WsdXB4W0WLj9XCBGLDsIxFr D02RrChZJr20pClz+h7E3bqNXSo3BCneelwF+Gtbt45JyiBC2QXdYVKaqxnxKnMAskY+ eMhEao0N2TpJrbElvQ0yxZkn1k2ZiNPUQu8dqv+vWsvE8fq4qPwwrFpht+rtNjma14tI nfAmUYnvvYqsq3/amO/96wg/boz3t3abJUgn6RP2yT8Ir9xRNjG0ThD7R6KqB4QOUL5D Dj3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765966256; x=1766571056; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eXjtVLazU4FisU7iYDrCs/cvEQo0Kb5lMS6lWuXDtFU=; b=a9sbl9CWsR2mjVG/svGRC9sh0nUB9Qx3gOOiD0GUinQSJG0QDFSOtcLgBAotZG22Mv 1ylPO1HkW407JZBBrF0AxFBNIYLjkYxg7FpQdlwaPpx1UnXqo4egzPWvh6pAznoAsNXw tV9+E76BPH4xW+UzZ3VicsAxQh5/7H5JkBHD+EvmncQxxiCaJa54ykzQf6XEvk37DmdE vI9Tf+sKPqbLI9QMfA2vXOscFng8QRGtr0QuXkqye98E4/+kUELCCO2cAE4vamY+xsGC rQsj6DkFEosoZDvpGfKYPsJ3vG83yUZ/OkxyYms02L2uJe9YwGJLG+abz5zrcDTJGLK6 oaiQ== X-Forwarded-Encrypted: i=1; AJvYcCXu2V12nqHcIXbhREnfOnjaQBT9Ec3C4q3CccFzTlUYsjUVazlDG/2KwmBsVrcbVgV64QifvwnnZnefck0=@vger.kernel.org X-Gm-Message-State: AOJu0YwkrX5zsFsGqpTn/WOUQLWgbMZaCjVnBuuNogrNFpzn1zSPrlll UOdSF41g6camaOx7AKllJ3ZjeJcpmuzpwq7/9UovyKQsy4Cg0EQ6q3Os4CPTbfasRQ0= X-Gm-Gg: AY/fxX7iC5/UUevgfCg+cMMLCfTvX/EzBywEK2KkeaDjlxueMAGcjaWURnwzIcLdSZS /LjcfOF7fuWHs3J/b97WC7/1d6Ze5JIZE2rthNN2WO9v4kSTDQwBzmwuzO6c2yY/zJE6j51eLqK hGKMe6gw+KaF7WdfLa7qW2UH5hHrA9x+kRQgoP81C0dxSCEmHK1/tVDErOZZsXSP3y+fvBW+cpp Uh+QUNupgTWIRP97L982SbM5kwrOtWZ3Jytoca/I4YYOAbNd4erZQ61biSXiUa9ngVMkmAZa8Lo meIK25rdlt35Pze1ILlvLPL6jib1SAUgHkKyvQLi5FU1vhlpSAMoehznSUKi4jWppWYi07ZA4vl yCMb6FsW453hsWpY0d2o2OJFLkOuvrt8ugGbKx7RNiqTGZtJtxZWV++4JIyoOcnAEJp6bqjQMqY lm3TI3wJDXbVMYV46fknkSBb9tIBgHl1+Gq43yeEMpyoA1XLvUwlgMFcM5px3QHl+UCBqUEUUV6 mxzOQ== X-Google-Smtp-Source: AGHT+IHyMM6etwDYB06WTSrwaBUmwLHwdFRBAH3MZ0Riio860UC6heeeZnSPn7h1ka6K1Zx6Y3HXtw== X-Received: by 2002:a17:907:6d24:b0:b7a:1bde:1223 with SMTP id a640c23a62f3a-b7d23ad88e6mr1656378566b.64.1765966255551; Wed, 17 Dec 2025 02:10:55 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4f5a22sm2043811a12.9.2025.12.17.02.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:10:55 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 17 Dec 2025 10:10:49 +0000 Subject: [PATCH RESEND v2 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-s5m-alarm-v2-2-b7bff003e94c@linaro.org> References: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> In-Reply-To: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The core driver now exposes the alarm IRQ as a resource, so we can drop the lookup from here to simplify the code and make adding support for additional variants easier in this driver. Acked-by: Alexandre Belloni Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b= 01fc384735007 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include =20 @@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; - alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev) "Failed to allocate regmap\n"); } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; - alarm_irq =3D S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) - return dev_err_probe(&pdev->dev, -EINVAL, - "Failed to get virtual IRQ %d\n", - alarm_irq); - } + alarm_irq =3D platform_get_irq_byname_optional(pdev, "alarm"); + if (alarm_irq > 0) + info->irq =3D alarm_irq; + else if (alarm_irq =3D=3D -ENXIO) + info->irq =3D 0; + else + return dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL, + "IRQ 'alarm' not found\n"); =20 platform_set_drvdata(pdev, info); =20 --=20 2.52.0.351.gbe84eed79e-goog From nobody Mon Feb 9 09:21:27 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B376A26ED3D for ; Wed, 17 Dec 2025 10:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966260; cv=none; b=VQDpxRYGlz+1tNmCpyvPubwlCxIxskFXvcnHJTRlGZjlgTMEhQWPpSbNwp9YXunk0Mtba8Gn3Bj1zMc7oh+U7GniOijPMscWbY0+XPd75hpoZ1IS4Xk5gUapGa/FIOZtNz+D+UM2QPf6qcWsxpCwx+bJo8MzyB1Q+P/H0wUxqAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765966260; c=relaxed/simple; bh=1ahqAflc+U7L4meIC3Q9CdG5wz6HKX/Zum9NhLjDog0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jCrALd9FObTOgTd1on0OCukcpTdERanhE+U14W+YMagRkKdqZ6KcMfpN0LTEIRKektV9WKd/UJa+RyVd2l7xwgglMBbYaC11MQGxxJ2D8LNIAG99g7YS/oR3DxdrNk+heL0Ry1jILipkJNu4t6zeqTCzth1qgFHT0O6l0DjsvH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gtvZq2/8; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gtvZq2/8" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6492e7925d2so6610666a12.3 for ; Wed, 17 Dec 2025 02:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765966256; x=1766571056; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gu64FyOC35e6HYruzEiAR601OIEUitARDAoJ4iQ8jiM=; b=gtvZq2/8vXUBbG/vZ1n2maKZEtIdhbB6VPVwkbt0yYht/WVAV6N0Zen2l3yCtTRY+O HvnEzymZc0A5AF3AjcM4NveM/biKaGTC1MpqHZJZBcm29Rzp+SgAQz2dGGBkdT11NIAt PS+8tmDVL3vhnPIKL3jNhSqp2XNrXhzfcQPWDAQ3ThN7r14VX6ABg8CrUwodve/JF+L7 FO5A6sZCBXs6230r3/sKYDEIEvozcPS7qgI8J1+MAu7krSZUkWxJlcNpsz8tMVjfUAb6 3iUqiQzJatXLhNrbA28Syo0fsa6v6ME/CcfjSsZZw0CnzWg/o4RyAJeSq2ZyR3MxgYk2 tDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765966256; x=1766571056; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gu64FyOC35e6HYruzEiAR601OIEUitARDAoJ4iQ8jiM=; b=FA07ws5uKEbKHm1zGVsJTr6ZvltLKm13pc/x3Ju4UzGgEoeTleEaBu1JWB73tZBEte +odbxY05+xLF9/OOV46jW7R1ukE3/GSFGUIZ0vjn/BtKONTbfwS31YE4HZ+gaXgudc3/ hGcJWOfgIeVoS4yZdHkqwbc8rQf2CePylTp6H3ryce9Q4KrxDYsBKd4PMPhITfgtdatR Y9rBR8mdBQmo8IOUB6B1pDaCawHMa6jY+862FD+BfkCaGPPIG5wHnd5D4TOnEP+Om2hj 1Ae/qvvL1cp+w4RYDEFIPoFIGTLNuCCo52BRfDKkbGYjHGtrXrmPExEkDyMfU+nSXe2U Dv/w== X-Forwarded-Encrypted: i=1; AJvYcCVoyXWyT/lsxPyfnrIUiQR27GhwkNoiA95K+I+vQpi5Ed1x1LkbGQrbr+0dGVZNy2Eb/KlExo4WyO2uHhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8R+ga9RpgDjLULX0XpcIgSmqvDxNVezseunABd+ldne8gqCfT YxcQM6WG4IkTDQxIDsfrNvNHtOeEO/42FDw0SGNPrxyK/k4wyRxh7n0e722Tu47RYXc= X-Gm-Gg: AY/fxX7tf3F/A30DPb68szEMb62sE+vWvS/oCGSLdXrrQkYu5+ohjSM9l5f6m97n6Eb ocxDRohv1y1v5Ay8Rfi8M9gHK74ZdBBDvwGM9BBRMCTn91s/hIH/SeJhzqfLovIAfVDbq6kXETb VdAqqUkn41MEqOXfsKARsIOCw3u0q+6AHhN+LmOXOhiGqhmRyEQ96qu2i6GMoz2v9L+y1Dxzb5I pvw3S6+zhwiZ3oAEJbYBJTmDQVYzgtXhU0cfu6V3/BffG5F6z9E04l41C/FIwoeV40IWtLYAhsm z/UYznxBjz8ec+PgGTdBST12Q4VFja+GSaM6kkhM+ckmRYKhbt0T2pVQ47wReQWRj2CPIK2QVLo j5IFULmGyz3fuqmNX7fXGL7QMtrYA+iP1WCp1GMINb/z2Z9geBTxIpnxtu9XOSwQ3ICyKMTNlHQ 10VMkTaq8VK1OIymwK9kqSJwl0tNKzJFF7MDy3rXGw6QOiH6dOytRfcYC3++hCDHs+38aLvlwLB RJPbyRFmFMieLD+ X-Google-Smtp-Source: AGHT+IGVdu+ouqQOHhPYhLM2bOTsHHu7go67EW76bydcCzQOcwGZ7xaopeNrmww5IZt6oCl8mH3roA== X-Received: by 2002:a05:6402:1e8a:b0:647:5544:77e with SMTP id 4fb4d7f45d1cf-6499b1e4cb3mr15208957a12.29.1765966256023; Wed, 17 Dec 2025 02:10:56 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4f5a22sm2043811a12.9.2025.12.17.02.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:10:55 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 17 Dec 2025 10:10:50 +0000 Subject: [PATCH RESEND v2 3/3] mfd: sec: drop now unused struct sec_pmic_dev::irq_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-s5m-alarm-v2-3-b7bff003e94c@linaro.org> References: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> In-Reply-To: <20251217-s5m-alarm-v2-0-b7bff003e94c@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 This was used only to allow the s5m RTC driver to deal with the alarm IRQ. That driver now uses a different approach to acquire that IRQ, and ::irq_data doesn't need to be kept around anymore. Signed-off-by: Andr=C3=A9 Draszik --- drivers/mfd/sec-common.c | 9 +++--- drivers/mfd/sec-core.h | 2 +- drivers/mfd/sec-irq.c | 63 ++++++++++++++++++------------------= ---- include/linux/mfd/samsung/core.h | 1 - 4 files changed, 35 insertions(+), 40 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 77370db52a7ba81234136b29f85892f4b197f429..0021f9ae8484fd0afc2e47c813a= 953c91fa38546 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -163,6 +163,7 @@ sec_pmic_parse_dt_pdata(struct device *dev) int sec_pmic_probe(struct device *dev, int device_type, unsigned int irq, struct regmap *regmap, struct i2c_client *client) { + struct regmap_irq_chip_data *irq_data; struct sec_platform_data *pdata; const struct mfd_cell *sec_devs; struct sec_pmic_dev *sec_pmic; @@ -187,9 +188,9 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, =20 sec_pmic->pdata =3D pdata; =20 - ret =3D sec_irq_init(sec_pmic); - if (ret) - return ret; + irq_data =3D sec_irq_init(sec_pmic); + if (IS_ERR(irq_data)) + return PTR_ERR(irq_data); =20 pm_runtime_set_active(sec_pmic->dev); =20 @@ -240,7 +241,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); + NULL, 0, regmap_irq_get_domain(irq_data)); if (ret) return ret; =20 diff --git a/drivers/mfd/sec-core.h b/drivers/mfd/sec-core.h index 92c7558ab8b0de44a52e028eeb7998e38358cb4c..8d85c70c232612d1f7e5fb61b2a= cd25bf03a62e0 100644 --- a/drivers/mfd/sec-core.h +++ b/drivers/mfd/sec-core.h @@ -18,6 +18,6 @@ int sec_pmic_probe(struct device *dev, int device_type, u= nsigned int irq, struct regmap *regmap, struct i2c_client *client); void sec_pmic_shutdown(struct device *dev); =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic); +struct regmap_irq_chip_data *sec_irq_init(struct sec_pmic_dev *sec_pmic); =20 #endif /* __SEC_CORE_INT_H */ diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index d992e41e716dcdc060421e1db8475523842a12be..96f53c3617da4cb54f650f9b98c= 0b934b823ceda 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -268,26 +268,28 @@ static const struct regmap_irq_chip s5m8767_irq_chip = =3D { .ack_base =3D S5M8767_REG_INT1, }; =20 -static int s2mpg1x_add_chained_irq_chip(struct device *dev, struct regmap = *regmap, int pirq, - struct regmap_irq_chip_data *parent, - const struct regmap_irq_chip *chip, - struct regmap_irq_chip_data **data) +static struct regmap_irq_chip_data * +s2mpg1x_add_chained_irq_chip(struct device *dev, struct regmap *regmap, in= t pirq, + struct regmap_irq_chip_data *parent, + const struct regmap_irq_chip *chip) { + struct regmap_irq_chip_data *data; int irq, ret; =20 irq =3D regmap_irq_get_virq(parent, pirq); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get parent vIRQ(%d) for chip %= s\n", pirq, - chip->name); + return dev_err_ptr_probe(dev, irq, "Failed to get parent vIRQ(%d) for ch= ip %s\n", + pirq, chip->name); =20 - ret =3D devm_regmap_add_irq_chip(dev, regmap, irq, IRQF_ONESHOT | IRQF_SH= ARED, 0, chip, data); + ret =3D devm_regmap_add_irq_chip(dev, regmap, irq, IRQF_ONESHOT | IRQF_SH= ARED, 0, chip, + &data); if (ret) - return dev_err_probe(dev, ret, "Failed to add %s IRQ chip\n", chip->name= ); + return dev_err_ptr_probe(dev, ret, "Failed to add %s IRQ chip\n", chip->= name); =20 - return 0; + return data; } =20 -static int sec_irq_init_s2mpg1x(struct sec_pmic_dev *sec_pmic) +static struct regmap_irq_chip_data *sec_irq_init_s2mpg1x(struct sec_pmic_d= ev *sec_pmic) { const struct regmap_irq_chip *irq_chip, *chained_irq_chip; struct regmap_irq_chip_data *irq_data; @@ -302,27 +304,28 @@ static int sec_irq_init_s2mpg1x(struct sec_pmic_dev *= sec_pmic) chained_pirq =3D S2MPG10_COMMON_IRQ_PMIC; break; default: - return dev_err_probe(sec_pmic->dev, -EINVAL, "Unsupported device type %d= \n", - sec_pmic->device_type); + return dev_err_ptr_probe(sec_pmic->dev, -EINVAL, "Unsupported device typ= e %d\n", + sec_pmic->device_type); }; =20 regmap_common =3D dev_get_regmap(sec_pmic->dev, "common"); if (!regmap_common) - return dev_err_probe(sec_pmic->dev, -EINVAL, "No 'common' regmap %d\n", - sec_pmic->device_type); + return dev_err_ptr_probe(sec_pmic->dev, -EINVAL, "No 'common' regmap %d\= n", + sec_pmic->device_type); =20 ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, regmap_common, sec_pmic->= irq, IRQF_ONESHOT, 0, irq_chip, &irq_data); if (ret) - return dev_err_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\n", - irq_chip->name); + return dev_err_ptr_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\= n", + irq_chip->name); =20 return s2mpg1x_add_chained_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,= chained_pirq, - irq_data, chained_irq_chip, &sec_pmic->irq_data); + irq_data, chained_irq_chip); } =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic) +struct regmap_irq_chip_data *sec_irq_init(struct sec_pmic_dev *sec_pmic) { + struct regmap_irq_chip_data *sec_irq_chip_data; const struct regmap_irq_chip *sec_irq_chip; int ret; =20 @@ -331,7 +334,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) sec_irq_chip =3D &s5m8767_irq_chip; break; case S2DOS05: - return 0; + return NULL; case S2MPA01: sec_irq_chip =3D &s2mps14_irq_chip; break; @@ -356,30 +359,22 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) sec_irq_chip =3D &s2mpu05_irq_chip; break; default: - return dev_err_probe(sec_pmic->dev, -EINVAL, - "Unsupported device type %d\n", - sec_pmic->device_type); + return dev_err_ptr_probe(sec_pmic->dev, -EINVAL, "Unsupported device typ= e %d\n", + sec_pmic->device_type); } =20 if (!sec_pmic->irq) { dev_warn(sec_pmic->dev, "No interrupt specified, no interrupts\n"); - return 0; + return NULL; } =20 ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, sec_pmic->irq, IRQF_ONESHOT, - 0, sec_irq_chip, &sec_pmic->irq_data); + 0, sec_irq_chip, &sec_irq_chip_data); if (ret) - return dev_err_probe(sec_pmic->dev, ret, - "Failed to add %s IRQ chip\n", - sec_irq_chip->name); + return dev_err_ptr_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\= n", + sec_irq_chip->name); =20 - /* - * The rtc-s5m driver requests S2MPS14_IRQ_RTCA0 also for S2MPS11 - * so the interrupt number must be consistent. - */ - BUILD_BUG_ON(((enum s2mps14_irq)S2MPS11_IRQ_RTCA0) !=3D S2MPS14_IRQ_RTCA0= ); - - return 0; + return sec_irq_chip_data; } diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index d785e101fe795a5d8f9cccf4ccc4232437e89416..c7c3c8cd8d5f99ef0cc3188e1c3= b49031f4750f2 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -69,7 +69,6 @@ struct sec_pmic_dev { =20 int device_type; int irq; - struct regmap_irq_chip_data *irq_data; }; =20 struct sec_platform_data { --=20 2.52.0.351.gbe84eed79e-goog