From nobody Fri Dec 19 07:35:10 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04BB638E148 for ; Wed, 17 Dec 2025 14:34:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765982095; cv=none; b=L1PM1BBkZlq2hSVRymz6pIe7+NPG3YzPLgDB8Ef25BcDWiBSFw3Z48zLJCr7vn8au2SgCiwae56Fv7/ou77XX6VxMjxCY+51UaCeB4EYRJhfEgLGEqVUpz2HGRTghJhGd7sCJQbZMtNC9x53D6gkcdnzrWCfTbNYMqHJe170BNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765982095; c=relaxed/simple; bh=Vgro1cjPjBOP0oKKJfd+hsrYIQI7IBwz4lNTXyboEWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JvazU+LvcyGlcabNJdyZ4wme46ejvW5sjAb591b+1QOdCKpcuvw/o/btAqj9Vth4SiGc1ETlKRSqber+/mccoO4fnWwpF5pv8Z3FtUnuELK55JlM/D5G0W6fUlwuGprX8xZjoBmegrg38xy0+yzJoA2IWhYQCv6tboFW+wuW2+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OAC99GUs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GK6uHdQl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OAC99GUs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GK6uHdQl" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHCKqpi2465154 for ; Wed, 17 Dec 2025 14:34:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FFJ8v0oPyVcNSNyZxT/vXlxD/LUOZfTyE1joNeBDrrc=; b=OAC99GUstwT/eC67 OaBRx9GpHAJCIo/BetDeyIctlUpQI2HTXwNcmF2FkgZudW0XCGQsXgKezYYuCN0o 2QOlJhEMHhRRhqjvAd2GUU1XmrydLr1rXh26ravPpmSZgCJtUg+vXsgrOgH/t8gr K6j6WLj4syMoGrDvY4W9dehyG9kGkToa8iKXaifpwWlzmqA60hot0iYGpC2y2Ukk K5liLPFr5nLYG2yNzHE32CVJhHn4mihKoKHTUm5K0CpRnDs+VWi7QNpTaum9IOhH uwJGadNMLttDXwyK/7daTfD6IUr+BYsZvOsdCSXycE6qX2brJqAEXkV6gKX4KWrv 4EPi+Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3fe2arhg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 14:34:49 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f26fc6476so88862695ad.1 for ; Wed, 17 Dec 2025 06:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765982089; x=1766586889; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FFJ8v0oPyVcNSNyZxT/vXlxD/LUOZfTyE1joNeBDrrc=; b=GK6uHdQlAid3b95E5kgXBWXSLP+ar3iLcdlApRxY4zf9w/bikCIN8vrqDmV+fX/63Y eyzmZSerueH0zkIq1NgRk5Gc4n1fZtLo/PrjhSuoHfdxljNKtvA69e13zOmuwJjXDPVA T9Dww6gCAFRZPJDo7VWL+unA9lhve6Qr8woFgsrowVqtnf2IJq5baA9IgF05SBNa2rN1 AM/BDjLz3s88XMbpSs4SiHxBob7FOwWtpSZ2wJ7tyZj8cyOt2eWSSvJqYbzOQJGYSM2b 8bfNnwpJiFL+LG+rJCaa5ORpOO/oSrLUAReX9lGHlpkmrOzCkIYuSqqSo90vLcIMQ0f3 zTRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765982089; x=1766586889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FFJ8v0oPyVcNSNyZxT/vXlxD/LUOZfTyE1joNeBDrrc=; b=mybxx1r0PnO4N4MVwF4Sc+ltzGd+o/CNKxOfgYXJbFuqkbCia2mjul+V7RlpLGOeC1 M9kxsUoIHmkR/wF3ZyWVYIPGXyeSCl0CpNj60dc9hV3jbHP9wo8mfZ23FbBtY77H5zCa fKP+e0vN1yjPRiBlq8AGc8LDsJHOdWR2Zpl3VoGMUCH4QhY8AYFz9pCa/A3lhrL/pZHf 3i+t5ptrPQ8OtZn5ICW2hYMtAMnSA1yMf2VlLuiggqJpvzE4VzYK1xrHgd7aTr0+JLBR 9H0CNzGXhb8cQ12/q5ayOwxzM0MhUBZgi5tm+5h4GHeqecrs7XkK8F6tQXw6Bow8iHnq VtFQ== X-Forwarded-Encrypted: i=1; AJvYcCWQyOA8MkrafrEmPh1/ZAZ7FXdolF9fzj8WUdp1VmPP52DLN6ArUugAi6Uta72fqbM030MeA3+E72jfmVo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8KYrFWvDH4hS8rJ5Sl8NsWSMvmwNK+duXGpFJ6TU17wiDhy9L jt6E9OA7pqYIIImcz/XdeRuhg2FHCAy15JFF/GTEwV3COSeSyEvJT18ZayP38MdLm3zVSsFJU2T hpVHcT+mLBQrO3ZN5hp47G7mPZ1NL0DlQS+QtX5leKXbpPqZLV7vw0WvBr6w53J4seq1i9BlmIp U= X-Gm-Gg: AY/fxX5rIbKqlbL2lKBxeG4XNM4zcSYEqqW4uk5KaWIHa/0Ff5P/kepg7G1Q4RcjwWm 2XGBtj6GZBjv2Tqn3NEJR7ylfsyRYva8IQJYekTs35oq/522/edvkFAjfEM96rBXtXdmOmSN8U0 tqN9TnYwrMxAD9bVmlKBDP0zFtklulvye3k8HNYmv0C2PJkDobzJ+LNBKm449QeMhAOClAWPIay wW0hnCLmZZ8e6yXpl3SaQ17HChbQ7XXSYCqt9nu6bgK3QIa2awJDCfj5a/6dvq4CBkMbSIV9dnq xdOfLm0WLQ97GrATiGiMhs0DjP11oISwY+vp7Dla8/iyZQMkTk2dUK8EqvLmdpdtUPV7N7gxx4G Hgs/gq0aYAJqbCwCH1hu7mtao3NROhj3hAm0Zpoe3+9jDTg== X-Received: by 2002:a05:6a21:3383:b0:2fa:26fb:4a7b with SMTP id adf61e73a8af0-369affecf43mr20638897637.57.1765982088900; Wed, 17 Dec 2025 06:34:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYa+ZlFXS4xg9zE2y9Pno7asvPy9BZHd5hGorvl2ZSNy0X/YzH3/UAdfmsYhjDCU3ooCNk+A== X-Received: by 2002:a05:6a21:3383:b0:2fa:26fb:4a7b with SMTP id adf61e73a8af0-369affecf43mr20638874637.57.1765982088492; Wed, 17 Dec 2025 06:34:48 -0800 (PST) Received: from hu-spratap-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34cfce5eb5csm2615529a91.0.2025.12.17.06.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 06:34:48 -0800 (PST) From: Shivendra Pratap Date: Wed, 17 Dec 2025 20:04:21 +0530 Subject: [PATCH v11 3/3] firmware: qcom_scm: Use TASK_IDLE state in wait_for_wq_completion() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251217-multi_waitq_scm-v11-3-f21e50e792b8@oss.qualcomm.com> References: <20251217-multi_waitq_scm-v11-0-f21e50e792b8@oss.qualcomm.com> In-Reply-To: <20251217-multi_waitq_scm-v11-0-f21e50e792b8@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Unnathi Chalicheemala , Shivendra Pratap , Mukesh Ojha , Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765982076; l=1437; i=shivendra.pratap@oss.qualcomm.com; s=20250710; h=from:subject:message-id; bh=UFzZfFwsKZRwzUpgUGE1qk+oD3O1tdC+4IJxq3oO4ZA=; b=JoKGThCOEdcPnLX0utb8N+LC9tSZ4gLNtV6AaThCHIXYWi1yZJ5n80Rjg/qbDmyEZTz470Epe UAJmrbCV0K3Ahepd7gR2lCpU2c1pFr6aZ3cMzpPtl2QpOpxmgujMtGW X-Developer-Key: i=shivendra.pratap@oss.qualcomm.com; a=ed25519; pk=CpsuL7yZ8NReDPhGgq6Xn/SRoa59mAvzWOW0QZoo4gw= X-Proofpoint-GUID: XU-brB4fWDjKEXUUctoxTmIKxLx7eUl1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDExMiBTYWx0ZWRfXzVWWgEqGy0vY NmPO8Mxmqj2ZUbC/7drRa3QjJLXLOsH+HNHrDvN4z3v6UYwqvLIRhrQYU1cA5IiNyHtNyodksG+ 8UQxfXJ03KjqC/C/WD7MMNK7U0Wsp+GbC/nYiR89wD+Kgj7ki8kp2psBSBAspqatdr2qWhJS/jO dihJ1/d65TRCrY0mONi2gDVMreGdS1kVvlGQO0PK5yHoHzXMIBzsGxn0mFLkZ6tkDqL7V5W2mkv b2WXCBPapujl6NVO+U/mECGO63mFpYf8uQej7A1WMRWFp5OEqqRyeoq9I54D9m2FNO09RK4/jCc kRJDZh9jkmYg9GqPuFICO9D6m68v/P+tlyJqvI3O5qbO+Qt2jIyyZXt5/E3iBjpv5e1biXX7hCQ mo0uAAE6hSoNMtEKGq4aq58Ku0Smug== X-Proofpoint-ORIG-GUID: XU-brB4fWDjKEXUUctoxTmIKxLx7eUl1 X-Authority-Analysis: v=2.4 cv=HpN72kTS c=1 sm=1 tr=0 ts=6942bf89 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=CXMSIrXqJIVyGMYrj-4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170112 From: Unnathi Chalicheemala When the kernel issues an SMC (Secure Monitor Call) and the firmware requests the kernel to wait, the waiting thread enters an uninterruptible (D) state. In case of an extended wait request by the firmware, any device suspend request, cannot proceed because of the thread stuck in D state. This blocks the device suspend. Replace wait_for_completion() with wait_for_completion_state(..., TASK_IDLE), so that the waiting thread, show up in TASK_IDLE state, instead of TASK_UNINTERRUPTIBLE (D state). This allows the thread to block until completion, without blocking the device suspend. Reviewed-by: Mukesh Ojha Reviewed-by: Bartosz Golaszewski Signed-off-by: Unnathi Chalicheemala Signed-off-by: Shivendra Pratap --- drivers/firmware/qcom/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index e16dbf18f731be9b0098dd683f478c8c8fdeaf20..3d8eee354cad55773d9b827ee8e= 32aab1f192510 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -2305,7 +2305,7 @@ int qcom_scm_wait_for_wq_completion(u32 wq_ctx) if (IS_ERR(wq)) return PTR_ERR(wq); =20 - wait_for_completion(wq); + wait_for_completion_state(wq, TASK_IDLE); =20 return 0; } --=20 2.34.1