From nobody Thu Dec 18 23:21:39 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426B929D280 for ; Tue, 16 Dec 2025 17:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765905762; cv=none; b=BfTbSCHFU4RtBaunF08nGwac3LINxnPrLjZb7VfeovIjNGNGSjKkYnCnLA/WSrf/1zf+51jYDExGmXPAoYPCn4XhCkMezuOnkUTnC2LuE09RW93P2WCFHgytrDcjSpLYODXoLks7/oDgMiyy46fx5S3enTuacqtL+TAzP1SoC40= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765905762; c=relaxed/simple; bh=UFuXGJl87VVFRtOHjho6NIFl+kVD765QpReolS459wU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=b+cWeOxapKxTryTGaH+WhwcGVzuszV4ZtatNJM2Gy2smlg3UggkpXB3LPxNGjoUhpakq1TMGY/jHuLzyBis4pr+x3SjuE+RsDgNonIt2rLyOUJmNlcz8V2u4JgVPvQ3tNDWSVoBLN9ClXeNnE/HPSUb0T+5iaOOcQCz8eCV6hGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WeJXlrfC; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WeJXlrfC" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-430f3273b92so128237f8f.1 for ; Tue, 16 Dec 2025 09:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765905759; x=1766510559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mKyLdQEGhgJbQ0rcfGz63d+VAIFpbamsmpk3rRxDquY=; b=WeJXlrfCU9b2BeOuO6FhxXCKu+1LGv1gwxMq0vkr7PA15yPbD42humEPlmrCoU9ZMJ ktDCCdFISzk/+pOIOP5yDHYN1DFvv+canLb/jxvmhwTNuz5aklg+YP2O8yrjJgLzyaeS tO+dRAaeo+2zwiRNw1rIBXdDtNDEER5MYaNwiVr4D24/ooRkq8iqUFoBnkP2z20MJClj DjHTsviPLm2bXzZ53q5GDhrHRjTg1Lk0AkD2gO7QSKdZ2boxSzlB51Nz2wbk/B9hNnLu br7ZI8+KIt/CE6ZxD7r7vxeFk5F7W0Pv4Zos1hlgB1EfMGidDrMe71+Ug+cMwsJRBB+T Cdpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765905759; x=1766510559; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mKyLdQEGhgJbQ0rcfGz63d+VAIFpbamsmpk3rRxDquY=; b=Vy3410j0K2k0sZeAzGuK2qQtOBDGcFcaLAoWUctKpObrGG9jol9O6xApvRfQnjXm2S 4sw09XXCXnWfWEYNsYZBNeAtuYK0hTsNZidLjmmHnLHJiY+MjsR1ltyMKDhXEPvB+Dw0 lcmmQtBXThrEwNJGujGV9cRrLiOKBOsXZcOzz8RaxzjkHSFTKMWaewU8xZlhugLLz6rM U1MNy5W0Vxf9IZF92ScHEZXgtKmAHAcNJRQbtp70kusSHK2AMvGKkJEMSW6BItSVV+5i h59gBt+vPlp4m8Iewnxe5jYBxW+230ehZlu/u2kZ73Eg2cEvocjnr7I+jXIklFiFNN1f 6DYw== X-Forwarded-Encrypted: i=1; AJvYcCUlkoNcb7dRhvN/YWtXSOxRaOWQBRHWNHLuliUxX8Sv80dvQJXzWyf55Bgrr+jfJVRYGB0yoxICV29+W08=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3aeNyA/sdD7wSZHlbSX89tHKWy8iyTFShAahrt5QgzD4tOM8f r/rOfn+QxisowDShtypGl3Tp/0poIMKvusN8FBdGEtoTvv+O0/e4V0zc X-Gm-Gg: AY/fxX4f5quW5t9OTf6S/sLpoSKbvv1P22OqB9eWN85hvgZWORifSQm0gvSt56bDUhn CeDif4NDHbFpibPDLYfNvKlt0PCScFbRRWIekeCrkykQEURRogAVwcOYh71fFuZ9bvl9YAMlcza We2GnC16q752IHD+clmtY8P+MuG5OocgJByhwTIVCbDlGyZ99i1rIXsY34Pw2pAMrAjLZ8HOJmh jZbJFs6J9sCCjiZIRXdpiP8U1cQrvb5YVKuUwrL37vnhr3Q8Mw6c4i2zV+Gr6HN6XKrw5SI0QX0 Yn27alZg8MDJU2Ohc9XxgaPwJDSK53jrfbLdTKZ74ei6LDtoRTCPUyesbZVOEbEYWgFlXGyFGXV EOLvcuMsgEn6Fmr1dKUpMO65kfa5gUOuv9oe0mRmF8Jokiscx36o8YwHObdSdTwJPOvi3Hlj3x1 i2rLV/URpwaLvqP3yAHVLDsB9iNkC4YWA0pIJ8u1NX5D8FL/sn3gTTY7ldwpWYg2D1Yw7q6zMJz GoxKfs= X-Google-Smtp-Source: AGHT+IHmQS6RGAHTr+Y/wsnGe/COASXW2A2kF5M/0v+c+2mbcCvu35+0lzvO+L74CHYn9f2xAPJB6Q== X-Received: by 2002:a05:600c:3146:b0:477:a450:7aa2 with SMTP id 5b1f17b1804b1-47a8f8a8e4cmr107678965e9.1.1765905759518; Tue, 16 Dec 2025 09:22:39 -0800 (PST) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-83-215.paris.inria.fr. [128.93.83.215]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-47bdc1ddf2csm231635e9.7.2025.12.16.09.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 09:22:39 -0800 (PST) From: Thomas Fourier To: Cc: Thomas Fourier , "Md. Haris Iqbal" , Jack Wang , Jens Axboe , Lutz Pogrell , Md Haris Iqbal , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] block: rnbd-clt: Fix leaked ID in init_dev() Date: Tue, 16 Dec 2025 18:22:01 +0100 Message-ID: <20251216172203.48947-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If kstrdup() fails in init_dev(), then the newly allocated ID is lost. Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname= & blk_symlink_name") Signed-off-by: Thomas Fourier --- drivers/block/rnbd/rnbd-clt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c index f1409e54010a..d33698eb428d 100644 --- a/drivers/block/rnbd/rnbd-clt.c +++ b/drivers/block/rnbd/rnbd-clt.c @@ -1434,7 +1434,7 @@ static struct rnbd_clt_dev *init_dev(struct rnbd_clt_= session *sess, dev->pathname =3D kstrdup(pathname, GFP_KERNEL); if (!dev->pathname) { ret =3D -ENOMEM; - goto out_queues; + goto out_ida; } =20 dev->clt_device_id =3D ret; @@ -1453,6 +1453,8 @@ static struct rnbd_clt_dev *init_dev(struct rnbd_clt_= session *sess, =20 return dev; =20 +out_ida: + ida_free(&index_ida, ret); out_queues: kfree(dev->hw_queues); out_alloc: --=20 2.43.0