From nobody Fri Dec 19 04:23:16 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4E1A34EF0A for ; Tue, 16 Dec 2025 12:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888460; cv=none; b=lI2Zgv3l7nzuTzVY6+hg+Gs7gn3ctl5e3ZjO5C05iyGhQtXwmmm5J51nBW50BkizpmVJdTmdD6V7d20y4TP75Nx0HOHRHeNUl2McJXi1AnvQWFY2nczCwKYv19bt689lJBk3rRg9Ob8XKzmX12WDST8nezr4AkHg+gnVFNSSXPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888460; c=relaxed/simple; bh=Jrn70/zkp34ABHutcBfNa/rpfpcgJTF2oVccTZVgBQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YzIez+OjO5hpHZjP/OlKSYr5UgWorkWsGmLCdRkElpawVz3zYv0lwiWgE2D8pgyMoyIRx5STEAx6Aq5XAZtm4oV9kj/JSMWTdN2kvtlgumlcpef3kC9yPqvDrFAOOjeR/kcqOMd0Fyd4VGze1aH1aJ/Zp4dyJ3bPMZX2Ebbr0/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ejZ4JXYR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ejZ4JXYR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B946C4CEF1; Tue, 16 Dec 2025 12:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765888459; bh=Jrn70/zkp34ABHutcBfNa/rpfpcgJTF2oVccTZVgBQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ejZ4JXYRbL47E3dWehXyB/jaHZpKTq5lLjgGVrAS5pGpuqNqW3FAtasqfSxRxpTq9 hPDPBJV/mxqUdeXjRI5UKxDm9OBn2wkK91ANuc2MEpNbjkwKoyk7v0zVCLSIH4voVo KAIwgOqUXijJBIhyiC8/sHWVTUPdHNx7YiIQ4wZ/BN+YpivHGAWn0T6oAhoN3Jplut b0VqT/hRmLo58hddK6E2Vub7DYdfo4PaviPwNG/KQUs7o0254FWgv/QMbCsD2pmf+N IOPTEo1Z5Wr0axzdagyn2qXm07sY1kh+hywzpIGg9lnSZQurXFurdBCxRtQn/3XPSv 74PMAXhcAP6Dg== From: "Mario Limonciello (AMD)" To: Yazen Ghannam , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Jean Delvare Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org, "Mario Limonciello (AMD)" Subject: [PATCH v2 2/7] firmware: dmi: Adjust dmi_decode() to use enums Date: Tue, 16 Dec 2025 06:33:49 -0600 Message-ID: <20251216123354.9219-3-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251216123354.9219-1-superm1@kernel.org> References: <20251216123354.9219-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dmi_decode() has hardcoded values with comments for each DMI entry type. The same information is already in dmi.h though, so drop the comments and use the definitions instead. Reviewed-by: Yazen Ghannam Signed-off-by: Mario Limonciello (AMD) --- drivers/firmware/dmi_scan.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 70d39adf50dca..80aded4c778bc 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -484,14 +484,14 @@ static void __init dmi_memdev_walk(void) static void __init dmi_decode(const struct dmi_header *dm, void *dummy) { switch (dm->type) { - case 0: /* BIOS Information */ + case DMI_ENTRY_BIOS: dmi_save_ident(dm, DMI_BIOS_VENDOR, 4); dmi_save_ident(dm, DMI_BIOS_VERSION, 5); dmi_save_ident(dm, DMI_BIOS_DATE, 8); dmi_save_release(dm, DMI_BIOS_RELEASE, 21); dmi_save_release(dm, DMI_EC_FIRMWARE_RELEASE, 23); break; - case 1: /* System Information */ + case DMI_ENTRY_SYSTEM: dmi_save_ident(dm, DMI_SYS_VENDOR, 4); dmi_save_ident(dm, DMI_PRODUCT_NAME, 5); dmi_save_ident(dm, DMI_PRODUCT_VERSION, 6); @@ -500,33 +500,33 @@ static void __init dmi_decode(const struct dmi_header= *dm, void *dummy) dmi_save_ident(dm, DMI_PRODUCT_SKU, 25); dmi_save_ident(dm, DMI_PRODUCT_FAMILY, 26); break; - case 2: /* Base Board Information */ + case DMI_ENTRY_BASEBOARD: dmi_save_ident(dm, DMI_BOARD_VENDOR, 4); dmi_save_ident(dm, DMI_BOARD_NAME, 5); dmi_save_ident(dm, DMI_BOARD_VERSION, 6); dmi_save_ident(dm, DMI_BOARD_SERIAL, 7); dmi_save_ident(dm, DMI_BOARD_ASSET_TAG, 8); break; - case 3: /* Chassis Information */ + case DMI_ENTRY_CHASSIS: dmi_save_ident(dm, DMI_CHASSIS_VENDOR, 4); dmi_save_type(dm, DMI_CHASSIS_TYPE, 5); dmi_save_ident(dm, DMI_CHASSIS_VERSION, 6); dmi_save_ident(dm, DMI_CHASSIS_SERIAL, 7); dmi_save_ident(dm, DMI_CHASSIS_ASSET_TAG, 8); break; - case 9: /* System Slots */ + case DMI_ENTRY_SYSTEM_SLOT: dmi_save_system_slot(dm); break; - case 10: /* Onboard Devices Information */ + case DMI_ENTRY_ONBOARD_DEVICE: dmi_save_devices(dm); break; - case 11: /* OEM Strings */ + case DMI_ENTRY_OEMSTRINGS: dmi_save_oem_strings_devices(dm); break; - case 38: /* IPMI Device Information */ + case DMI_ENTRY_IPMI_DEV: dmi_save_ipmi_device(dm); break; - case 41: /* Onboard Devices Extended Information */ + case DMI_ENTRY_ONBOARD_DEV_EXT: dmi_save_extended_devices(dm); } } --=20 2.43.0