From nobody Sun Feb 8 10:29:56 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3361134167A for ; Tue, 16 Dec 2025 11:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884912; cv=none; b=CVz0+jHF1jokFiCHbbFQdvsGZMYbA4kZysz2EjXANsJKF5yTj1EAA2RD1DY84SwbQJrUECZkV3GyhwhqzRKz7Rj0UcPIxgId0qHgTEQzmj2vjcawLGIKF4S2uCwjcpLvXfJQDRx6OdeeErrtlU712uB9siPBnS4AyxQ8DcBpPMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765884912; c=relaxed/simple; bh=7Ng6cOzBWaVAN8sB8ImGFB9WnRkcD7FTemvHnnoD6Uw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l1LSFIuEbYJFZFOfNY5PzpL2lRfXul5GGC9Y/p4hZsXlkEmAuxnkkJ+J5Nsrrc5dX1qYrZhywGEqGk4LAF1DBRf+nDhooyz7s9yOYuu/eEFgMmjOUiS2a9KfsJMqLtusAucNbPPi4RwvLxCl4P2qxZKsu34LbIykbE0EaTTEtiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QUhzeYdp; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QUhzeYdp" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a110548cdeso20901315ad.0 for ; Tue, 16 Dec 2025 03:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765884910; x=1766489710; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dNyMQo50MvCPMYMV7kY9HjLSNhtx0TsG7Ml7tk8tygg=; b=QUhzeYdpoPq486xWS5CUTiFHOXHXOkrqTQIcA8arCgXoKPn5INapjKdc5DCJQ217Nt QCI4Iz7qmG6Hmd/HQEMktlJ+oZKp+wydU3s8Xqp50PIUB1tM8ej+GeLqzfNYlDWIME7w VmqY+Lq6XTdJaWlsmbzDW0THHxwI1v4rZj7AtpaV1opN3nOf854IjiF7GpJqk3vPivSF 9SfErAXmBtJ/s2UoaJyfUfEQRXrXJaGGT7pYfAEmOsn+Bvok3b7LAm0SHGJoGoFEfLTs xyFTKVGJU5po1Qtm/obZ5CfYCtuN5sYGCKK2KufClkfezrxowVQzrxCIDMHDMmppkKb3 7dmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765884910; x=1766489710; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dNyMQo50MvCPMYMV7kY9HjLSNhtx0TsG7Ml7tk8tygg=; b=ZC7La8ufpd4N5mt6egYdvgC/bL0qRRpcXCIF7ERTzRuk55pYUVXwxLKXjOAdhCkk1g cbt8wchVm/StKPeo3wa8vyoPRq1JAbyMn9hfU8Gj6cUP1zhwBsd71PqgWC+1DZ9GLqmc JbMwCXEqm+UkoDlUfAXiSZsyGgvfoA1NNGgErZM9duaYW+af6XMRIl/mUqaYQIyx9Tex NecIf4sHY5QBHmOy4Wb+md+bCUWhdvOAe3/3nPlyCaGELRvGXnLSUL7lSatqFWlo4MAA 0B3/4qJV3uTatDdP79GD2t28uIf3pHJPICQYXMdJAv7AIBkR3hHDwZTNo/5MsusyadVQ WpBw== X-Forwarded-Encrypted: i=1; AJvYcCX+nk5eA88o5FA7682iN95mUkFMSHG9sI/+2nZrFw62Qd26VjrBc+a+mn+8ENGif7L3/ftuJoxKS+S0i60=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3QubJjVp3wEBKIgvFVxpS4ka6fyJFXd5oFMAifOa+nGk7oAWK xrTbIZK5SJdJaFHJq5GLNypQwB7oScZKXGCUsFpp3+OQf0mbyZF0273z X-Gm-Gg: AY/fxX4TBygfJwW3o8JNn4NBoJfLpUJEi3hgcbvAIvntG3kMZjoekLSxfxLcdeoHL9c UmP6gaTxwoDbF0t14vwuU04bGAJRon50WP3M6HBmQS02AROQOnYkv2R/ZPwmWN11wrGRIh6RAAD UhFrkBwszDRIUTpLdQnTzSDMHJdmE6o3Z2OkXypoepIWz0ehGN0pioHddMDvH26nxJZybUmE2/l sPC+oZe6tslUpHTCeQtqXNPGGA3ydRTl6aNQdhsv5Tsb5H3IPbV38wCcPVO7kMsNKd2CXXgbvKO Vge0nrS2TVx0F+3JOCTe/Hv1cgUy0miYRdZOmf+hmdYb5v5kn4rBdxDrsg9o7cAWr3XIk6NC07t EvRfncmurvqwjJ6DgJ+m7pk7muLzDDa5L57CwPtechD/PtZWKOw+ZXJQCG0J1OEDbOmYmfCGwIm SGp9W4FmVN1ZKAGQ== X-Google-Smtp-Source: AGHT+IErTs5c9CgixuwPe66I1GrE+7CrIdKOxcUVXSYOh9APmUqT1anvr8jNO2CVyH2qF3wF65kKhQ== X-Received: by 2002:a17:902:cecc:b0:2a1:3895:e0d8 with SMTP id d9443c01a7336-2a13895e17dmr20413945ad.60.1765884910053; Tue, 16 Dec 2025 03:35:10 -0800 (PST) Received: from localhost ([2a12:a304:100::105b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0ced60ff4sm73566345ad.76.2025.12.16.03.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 03:35:09 -0800 (PST) From: Jinchao Wang To: "Theodore Ts'o" , Andreas Dilger , Jan Kara , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jinchao Wang , stable@vger.kernel.org, syzbot+f792df426ff0f5ceb8d1@syzkaller.appspotmail.com Subject: [PATCH] ext4: xattr: fix wrong search.here in clone_block Date: Tue, 16 Dec 2025 19:34:55 +0800 Message-ID: <20251216113504.297535-1-wangjinchao600@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" syzbot reported a KASAN out-of-bounds Read in ext4_xattr_set_entry()[1]. When xattr_find_entry() returns -ENODATA, search.here still points to the position after the last valid entry. ext4_xattr_block_set() clones the xattr block because the original block maybe shared and must not be modified in place. In the clone_block, search.here is recomputed unconditionally from the old offset, which may place it past search.first. This results in a negative reset size and an out-of-bounds memmove() in ext4_xattr_set_entry(). Fix this by initializing search.here correctly when search.not_found is set. [1] https://syzkaller.appspot.com/bug?extid=3Df792df426ff0f5ceb8d1 Fixes: fd48e9acdf2 (ext4: Unindent codeblock in ext4_xattr_block_set) Cc: stable@vger.kernel.org Reported-by: syzbot+f792df426ff0f5ceb8d1@syzkaller.appspotmail.com Signed-off-by: Jinchao Wang --- fs/ext4/xattr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 2e02efbddaac..cc30abeb7f30 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1980,7 +1980,10 @@ ext4_xattr_block_set(handle_t *handle, struct inode = *inode, goto cleanup; s->first =3D ENTRY(header(s->base)+1); header(s->base)->h_refcount =3D cpu_to_le32(1); - s->here =3D ENTRY(s->base + offset); + if (s->not_found) + s->here =3D s->first; + else + s->here =3D ENTRY(s->base + offset); s->end =3D s->base + bs->bh->b_size; =20 /* --=20 2.43.0