From nobody Wed Dec 17 12:44:18 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25FDC327207 for ; Tue, 16 Dec 2025 08:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765873556; cv=none; b=IHzC991WLYA9Bl0Te4B+SZjfS0YpDOGJFxd5bjvhpYw1xMrxBhtwzvl2LZvivTqahryvvGdqoVi5+kmjXIzjl2L2JQ9zV5wuoz4w6ZAgYaReH3VhoVBJxtug2VDuRK0x27hoqtTrkQjiKEIVOiKPmj2zJ5cckPmsC+/pi3WLhhk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765873556; c=relaxed/simple; bh=5Dl5hNXi2ABTDA4h1upVqdOUPVNs/2K2JYxczm3DJTI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZdLcBUAOl2YsC16B5MEdzP0kFxqGry7mMAPtfKs+epbOtVjjHGXS+/djxS2dv+jFzv91KPZiz21zwmgzfgXt2sfDA4MpYU+JmW4SBD4xWI6ByMSvp0CuyxWKX4qQDWN79xK1Coc87jUv0V5iyBmsAK0yteLLSypSAYmoAYD7BgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SlORRaS0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SlORRaS0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765873553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LxZuDficpsxht2y5/1g+Ss0ZtX3L7w3OqfgkU4mgrZA=; b=SlORRaS0MAslzy1JqNjIzjV2UAKIAaCQDtnaK2QHn05cY/ePFjy+vruvG3v2fj7HAXLK1V dmnNjMRv271vmPVJCVYIjA0u3idsV1lr+A2mi5I4+WcXVyUx8M8czbjZZMO7Jnnr5nvvLx PWOtlAkqYj4CiSWIFZ5XIR4Xzn9vRg4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-2U7Lqs-IP_eBPMFE3pjlSQ-1; Tue, 16 Dec 2025 03:25:48 -0500 X-MC-Unique: 2U7Lqs-IP_eBPMFE3pjlSQ-1 X-Mimecast-MFC-AGG-ID: 2U7Lqs-IP_eBPMFE3pjlSQ_1765873547 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C9F6F195608E; Tue, 16 Dec 2025 08:25:46 +0000 (UTC) Received: from hydra.redhat.com (unknown [10.45.224.146]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 590AB18004D8; Tue, 16 Dec 2025 08:25:43 +0000 (UTC) From: Jocelyn Falempe To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jocelyn Falempe , Javier Martinez Canillas , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v4 1/2] drm/panic: Rename draw_panic_static_* to draw_panic_screen_* Date: Tue, 16 Dec 2025 09:20:38 +0100 Message-ID: <20251216082524.115980-2-jfalempe@redhat.com> In-Reply-To: <20251216082524.115980-1-jfalempe@redhat.com> References: <20251216082524.115980-1-jfalempe@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" I called them "static" because the panic screen is drawn only once, but this can be confused with the static meaning in C. Also remove some unnecessary braces in draw_panic_dispatch(). No functionnal change. Signed-off-by: Jocelyn Falempe Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_panic.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index f42be7f1d8c2..30c615768efe 100644 --- a/drivers/gpu/drm/drm_panic.c +++ b/drivers/gpu/drm/drm_panic.c @@ -476,7 +476,7 @@ static void drm_panic_logo_draw(struct drm_scanout_buff= er *sb, struct drm_rect * fg_color); } =20 -static void draw_panic_static_user(struct drm_scanout_buffer *sb) +static void draw_panic_screen_user(struct drm_scanout_buffer *sb) { u32 fg_color =3D drm_draw_color_from_xrgb8888(CONFIG_DRM_PANIC_FOREGROUND= _COLOR, sb->format->format); @@ -545,7 +545,7 @@ static int draw_line_with_wrap(struct drm_scanout_buffe= r *sb, const struct font_ * Draw the kmsg buffer to the screen, starting from the youngest message = at the bottom, * and going up until reaching the top of the screen. */ -static void draw_panic_static_kmsg(struct drm_scanout_buffer *sb) +static void draw_panic_screen_kmsg(struct drm_scanout_buffer *sb) { u32 fg_color =3D drm_draw_color_from_xrgb8888(CONFIG_DRM_PANIC_FOREGROUND= _COLOR, sb->format->format); @@ -733,7 +733,7 @@ static int drm_panic_get_qr_code(u8 **qr_image) /* * Draw the panic message at the center of the screen, with a QR Code */ -static int _draw_panic_static_qr_code(struct drm_scanout_buffer *sb) +static int _draw_panic_screen_qr_code(struct drm_scanout_buffer *sb) { u32 fg_color =3D drm_draw_color_from_xrgb8888(CONFIG_DRM_PANIC_FOREGROUND= _COLOR, sb->format->format); @@ -801,10 +801,10 @@ static int _draw_panic_static_qr_code(struct drm_scan= out_buffer *sb) return 0; } =20 -static void draw_panic_static_qr_code(struct drm_scanout_buffer *sb) +static void draw_panic_screen_qr_code(struct drm_scanout_buffer *sb) { - if (_draw_panic_static_qr_code(sb)) - draw_panic_static_user(sb); + if (_draw_panic_screen_qr_code(sb)) + draw_panic_screen_user(sb); } #else static void drm_panic_qr_init(void) {}; @@ -879,18 +879,18 @@ static void draw_panic_dispatch(struct drm_scanout_bu= ffer *sb) { switch (drm_panic_type) { case DRM_PANIC_TYPE_KMSG: - draw_panic_static_kmsg(sb); + draw_panic_screen_kmsg(sb); break; =20 #if IS_ENABLED(CONFIG_DRM_PANIC_SCREEN_QR_CODE) case DRM_PANIC_TYPE_QR: - draw_panic_static_qr_code(sb); + draw_panic_screen_qr_code(sb); break; #endif =20 case DRM_PANIC_TYPE_USER: default: - draw_panic_static_user(sb); + draw_panic_screen_user(sb); } } =20 --=20 2.52.0