From nobody Thu Dec 18 19:42:32 2025 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E21CC2D8DA6 for ; Tue, 16 Dec 2025 04:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859772; cv=none; b=c1frF+Gks1Ksd3RNjBu4Sz2sTWiqJob22M6x6tDHhbO3w/u/K7/O0oNcz5bLo1D+mWOXWtuuYBlJmbV77ESelV2Y/FXG7qzWdwA7T7z1cm9hhmnJ0IE2VQr+TM6irSqPqW+OuQthIZAEv4Yseeu2nnkVPpWYb/w3kKebDo1n2YM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859772; c=relaxed/simple; bh=Hs1exUeSzwg2t2C/V9bP5kzbgTCR9I09qV2Wslv8HpM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LWTgqibBeNzMmvpudpc7baKjdtPMykIbe+u6SYqITQImvmCH7eCdHhjyaEM7NVim4+IiH7G6lHmnlfPlEkXKqPhmeo9vN/SO4UN313B0af/uWUuB3l0tEJhotgC4RQ6rTnxXfMVh4f0lz3rEZjG4BhRv3s0hTWKt6k5OBPcoKXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GNd9sYwQ; arc=none smtp.client-ip=209.85.161.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GNd9sYwQ" Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-65962c714eeso2428748eaf.0 for ; Mon, 15 Dec 2025 20:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765859759; x=1766464559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T7VGHKNtM1JC0CBVAGFFnYSWZgu9YXfXL47IE3gej6I=; b=GNd9sYwQut4XIbXU0KfSimOXexBPF0OJapfALj4PsUFImA0hFu8gtCXLqfMIf1M6+7 hLmZ8uSQuV7x+LsxEFimMRGAvK/EbpOxgK6ylwk1Okh7u0bLwm2OemDYrLXoRtLsZgru VkOgvbApUYCVWkC66MQGiuCR+yf8Uc18+WVdh3wZZ9Fm6ZkofaG0BJy2Fn8L0AHRmQXf JhBskyatFRNJeiw1jTX6N86l23knL50fxA38vEHtweuhFxXWBnCD6jQCJtfwh0+JLLZL cyLUnd64PL1ROr75iI+rYGU9/AKQd+nAkxvLg6v7BjErze4ex5zqn6BTfE0YtplC1ypd DotA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765859759; x=1766464559; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T7VGHKNtM1JC0CBVAGFFnYSWZgu9YXfXL47IE3gej6I=; b=iwpZ3yBsLuzatyOmAB9v2+cSZZN5nWW9JFDuG6JiYutPOv5SxZvC+8SkYW8dx3fo6H U7/Fk27mkt+BCrYCITqCfUSPoPt53oXoxpMu4Q6he3+RchyAYeTKW/HQ8x9RqJxsS5Ng 7RPj5h5awdJqJfa026povlJb1RNshxQWljZuanrOq/AVUxAjgjNdL7yi4yEctxlRxWFJ cD9IkCJrH7bdz5qZI+kEGATtTcha1Q5sxGoAiP+RVqa9qpmAUYdLqbpB8Net39oeasYS n+dQ7WrjKhQfZyuU9HbhbIkLUCZGfydZ9YD5PzF7AsHfL22B7a538EAnViWW5MVb6nHO MKjQ== X-Forwarded-Encrypted: i=1; AJvYcCX7UxeMBkM9nX2SdT1eG2hFob0sIvmcxi3T47Gb7GT/8R2HPpkrqshUdKkOOjRNpOrdJ2tR4s+hQjstJmQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxPr7oWl3QM8jRNss+U9ijvnmxXUTC/wH6jMvLBUsIJ6qVISqfM sqgRdYhUV9xYoEDu2WkO9673kuNcWT5Y/bBoB0JwZ7FRKrqjAoAVlr62 X-Gm-Gg: AY/fxX7egt8NB1nI2vBHd3v81ZtEf4poxpkGzJXgp7mCuTn9XTyYcK5C0JbMWKlI3eg KMfiJd5OxxmN6yyAE6aBj/iCGm8LFoJsa3Nx0+1mGmCs2isopsni2OF4yqlDTeO2pokurAP6ePj rBW3ucpP6FkG0qTsImR9VJ34kQASLbgHxnKc+QQTNUXPSTWlHsIEI1lnKvkzZtNFbeglHAQ1ldl 4wkWT/2wNsalo6Rcr5Sfj4Z+EbXXmI/eeOYrmkbid+oezFjIRC4TFBmrP2WFlz/z6znzV3iAK/Z NFkroFJJlEZSZb1Uc0eGhml6OvgtQg23vUWV6gHtdnpsLW6/hvCj3jIMmrllYL7m30vMcnNf7py S9WoXqkTvLxRrkiNuCx51FW3SVzfJCYEjliOszRR66CSIpe9vNQiDD9nzsNSZep0UuP/Rf8znr3 XFalMxIqsw63w75etoJPJvXtUAh+n+sbnw2w7adYcLzgur6tKu4491v/abFUIaVfXl93CpLu2TZ hxWB0YMdAnC26pcXbae9qPowvPx X-Google-Smtp-Source: AGHT+IH+TqIPuUN/dMFCU97t7Q8gftaVx3eoTbjPNaDmHr9yxJL5QssQktaf3+BhVZjdlEzRjDOxmQ== X-Received: by 2002:a05:6820:16a6:b0:659:9a49:8eda with SMTP id 006d021491bc7-65b451879f5mr5787893eaf.14.1765859759054; Mon, 15 Dec 2025 20:35:59 -0800 (PST) Received: from nukework.lan (c-98-57-15-22.hsd1.tx.comcast.net. [98.57.15.22]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-65b35f2b1e5sm8948353eaf.3.2025.12.15.20.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 20:35:57 -0800 (PST) From: Alexandru Gagniuc To: ath11k@lists.infradead.org, Jeff Johnson Cc: baochen.qiang@oss.qualcomm.com, Alexandru Gagniuc , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params Date: Mon, 15 Dec 2025 22:35:52 -0600 Message-ID: <20251216043555.628296-1-mr.nuke.me@gmail.com> X-Mailer: git-send-email 2.45.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It is initialized in, core.c, a different file than the array. This spaghetti-like relation is fragile and not obvious. Accidentally setting ".max_tx_ring" too high leads to a hard to track out-of- bounds access and memory corruption. There is a small ambiguity on the meaning of "max_tx_ring": - The highest ring, max=3D3 implies there are 4 rings (0, 1, 2, 3) - The highest number to use for array indexing (there are 3 rings) Clarify this dependency by moving ".max_tx_ring" adjacent to the array ".tcl2wbm_rbm_map", and name it "num_tx_rings". Use ARRAY_SIZE() instead of #defines to initialize the length field. The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its map, so use a constant to express the correct value. Add a static_assert() to fail compilation if the constant is accidentally set too high. The intent is to make the code easier to understand rather than fix an existing bug. Signed-off-by: Alexandru Gagniuc --- I am trying to make ath11k work on IPQ9574. My device uses a IPQ9570 with a QCN5024 as the 2.4 GHz wifi. I spent a few days tracking a memory corruption bug caused by erroneously setting ".max_tx_ring" too high. I think I would not have made this mistake if the initializations of .max_tx_ring and .tcl2wbm_rbm_map were right next to each other. Changes since v1: - use "num_tx_rings" name instead of "map_len" - make sure debugfs.c is correctly updated - add a static_assert for ath11k_hw_hal_params_qca6390 special case drivers/net/wireless/ath/ath11k/core.c | 12 +----------- drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- drivers/net/wireless/ath/ath11k/dp.c | 12 ++++++------ drivers/net/wireless/ath/ath11k/dp_tx.c | 9 +++++---- drivers/net/wireless/ath/ath11k/hw.c | 19 +++++++++++++++++++ drivers/net/wireless/ath/ath11k/hw.h | 3 ++- drivers/net/wireless/ath/ath11k/mac.c | 2 +- 7 files changed, 35 insertions(+), 24 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/= ath/ath11k/core.c index 812686173ac8a..07199ceecbeb4 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -100,7 +100,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D false, .fix_l1ss =3D true, .credit_flow =3D false, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX, .hal_params =3D &ath11k_hw_hal_params_ipq8074, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D true, @@ -184,7 +183,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D false, .fix_l1ss =3D true, .credit_flow =3D false, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX, .hal_params =3D &ath11k_hw_hal_params_ipq8074, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D true, @@ -271,7 +269,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D false, .fix_l1ss =3D true, .credit_flow =3D true, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX_QCA6390, .hal_params =3D &ath11k_hw_hal_params_qca6390, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D false, @@ -358,7 +355,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D false, .fix_l1ss =3D true, .credit_flow =3D false, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX, .hal_params =3D &ath11k_hw_hal_params_ipq8074, .supports_dynamic_smps_6ghz =3D true, .alloc_cacheable_memory =3D true, @@ -445,7 +441,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D true, .fix_l1ss =3D false, .credit_flow =3D true, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX_QCA6390, .hal_params =3D &ath11k_hw_hal_params_qca6390, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D false, @@ -533,7 +528,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D true, .fix_l1ss =3D false, .credit_flow =3D true, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX_QCA6390, .hal_params =3D &ath11k_hw_hal_params_qca6390, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D false, @@ -619,7 +613,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D true, .fix_l1ss =3D false, .credit_flow =3D true, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX, .hal_params =3D &ath11k_hw_hal_params_wcn6750, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D false, @@ -662,7 +655,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .qmi_service_ins_id =3D ATH11K_QMI_WLFW_SERVICE_INS_ID_V01_IPQ8074, .ring_mask =3D &ath11k_hw_ring_mask_ipq8074, .credit_flow =3D false, - .max_tx_ring =3D 1, .spectral =3D { .fft_sz =3D 2, .fft_pad_sz =3D 0, @@ -698,7 +690,7 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D false, .idle_ps =3D false, .supports_suspend =3D false, - .hal_params =3D &ath11k_hw_hal_params_ipq8074, + .hal_params =3D &ath11k_hw_hal_params_ipq5018, .single_pdev_only =3D false, .coldboot_cal_mm =3D true, .coldboot_cal_ftm =3D true, @@ -789,7 +781,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D true, .fix_l1ss =3D false, .credit_flow =3D true, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX_QCA6390, .hal_params =3D &ath11k_hw_hal_params_qca6390, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D false, @@ -876,7 +867,6 @@ static const struct ath11k_hw_params ath11k_hw_params[]= =3D { .supports_regdb =3D true, .fix_l1ss =3D false, .credit_flow =3D true, - .max_tx_ring =3D DP_TCL_NUM_RING_MAX_QCA6390, .hal_params =3D &ath11k_hw_hal_params_qca6390, .supports_dynamic_smps_6ghz =3D false, .alloc_cacheable_memory =3D false, diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c b/drivers/net/wirele= ss/ath/ath11k/debugfs.c index 977f945b6e669..50f344803e8fd 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs.c +++ b/drivers/net/wireless/ath/ath11k/debugfs.c @@ -707,7 +707,7 @@ static ssize_t ath11k_debugfs_dump_soc_dp_stats(struct = file *file, len +=3D scnprintf(buf + len, size - len, "\nSOC TX STATS:\n"); len +=3D scnprintf(buf + len, size - len, "\nTCL Ring Full Failures:\n"); =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) len +=3D scnprintf(buf + len, size - len, "ring%d: %u\n", i, soc_stats->tx_err.desc_na[i]); =20 diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/at= h/ath11k/dp.c index 56b1a657e0b0f..c940de285276d 100644 --- a/drivers/net/wireless/ath/ath11k/dp.c +++ b/drivers/net/wireless/ath/ath11k/dp.c @@ -344,7 +344,7 @@ void ath11k_dp_stop_shadow_timers(struct ath11k_base *a= b) if (!ab->hw_params.supports_shadow_regs) return; =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) ath11k_dp_shadow_stop_timer(ab, &ab->dp.tx_ring_timer[i]); =20 ath11k_dp_shadow_stop_timer(ab, &ab->dp.reo_cmd_timer); @@ -359,7 +359,7 @@ static void ath11k_dp_srng_common_cleanup(struct ath11k= _base *ab) ath11k_dp_srng_cleanup(ab, &dp->wbm_desc_rel_ring); ath11k_dp_srng_cleanup(ab, &dp->tcl_cmd_ring); ath11k_dp_srng_cleanup(ab, &dp->tcl_status_ring); - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) { + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) { ath11k_dp_srng_cleanup(ab, &dp->tx_ring[i].tcl_data_ring); ath11k_dp_srng_cleanup(ab, &dp->tx_ring[i].tcl_comp_ring); } @@ -400,7 +400,7 @@ static int ath11k_dp_srng_common_setup(struct ath11k_ba= se *ab) goto err; } =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) { + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) { tcl_num =3D ab->hw_params.hal_params->tcl2wbm_rbm_map[i].tcl_ring_num; wbm_num =3D ab->hw_params.hal_params->tcl2wbm_rbm_map[i].wbm_ring_num; =20 @@ -782,7 +782,7 @@ int ath11k_dp_service_srng(struct ath11k_base *ab, int i, j; int tot_work_done =3D 0; =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) { + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) { if (BIT(ab->hw_params.hal_params->tcl2wbm_rbm_map[i].wbm_ring_num) & ab->hw_params.ring_mask->tx[grp_id]) ath11k_dp_tx_completion_handler(ab, i); @@ -1035,7 +1035,7 @@ void ath11k_dp_free(struct ath11k_base *ab) =20 ath11k_dp_reo_cmd_list_cleanup(ab); =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) { + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) { spin_lock_bh(&dp->tx_ring[i].tx_idr_lock); idr_for_each(&dp->tx_ring[i].txbuf_idr, ath11k_dp_tx_pending_cleanup, ab); @@ -1086,7 +1086,7 @@ int ath11k_dp_alloc(struct ath11k_base *ab) =20 size =3D sizeof(struct hal_wbm_release_ring) * DP_TX_COMP_RING_SIZE; =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) { + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) { idr_init(&dp->tx_ring[i].txbuf_idr); spin_lock_init(&dp->tx_ring[i].tx_idr_lock); dp->tx_ring[i].tcl_data_ring_id =3D i; diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless= /ath/ath11k/dp_tx.c index 562aba66582f3..86e1e6c27b36c 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -91,6 +91,7 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *ar= vif, struct hal_srng *tcl_ring; struct ieee80211_hdr *hdr =3D (void *)skb->data; struct dp_tx_ring *tx_ring; + size_t num_tx_rings =3D ab->hw_params.hal_params->num_tx_rings; void *hal_tcl_desc; u8 pool_id; u8 hal_ring_id; @@ -113,7 +114,7 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *= arvif, tcl_ring_sel: tcl_ring_retry =3D false; =20 - ti.ring_id =3D ring_selector % ab->hw_params.max_tx_ring; + ti.ring_id =3D ring_selector % num_tx_rings; ti.rbm_id =3D ab->hw_params.hal_params->tcl2wbm_rbm_map[ti.ring_id].rbm_i= d; =20 ring_map |=3D BIT(ti.ring_id); @@ -126,7 +127,7 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *= arvif, spin_unlock_bh(&tx_ring->tx_idr_lock); =20 if (unlikely(ret < 0)) { - if (ring_map =3D=3D (BIT(ab->hw_params.max_tx_ring) - 1) || + if (ring_map =3D=3D (BIT(num_tx_rings) - 1) || !ab->hw_params.tcl_ring_retry) { atomic_inc(&ab->soc_stats.tx_err.misc_fail); return -ENOSPC; @@ -244,8 +245,8 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *= arvif, * checking this ring earlier for each pkt tx. * Restart ring selection if some rings are not checked yet. */ - if (unlikely(ring_map !=3D (BIT(ab->hw_params.max_tx_ring)) - 1) && - ab->hw_params.tcl_ring_retry && ab->hw_params.max_tx_ring > 1) { + if (unlikely(ring_map !=3D (BIT(num_tx_rings)) - 1) && + ab->hw_params.tcl_ring_retry && num_tx_rings > 1) { tcl_ring_retry =3D true; ring_selector++; } diff --git a/drivers/net/wireless/ath/ath11k/hw.c b/drivers/net/wireless/at= h/ath11k/hw.c index caa6dc12a790b..bbaacdf76af0a 100644 --- a/drivers/net/wireless/ath/ath11k/hw.c +++ b/drivers/net/wireless/ath/ath11k/hw.c @@ -2707,6 +2707,14 @@ const struct ath11k_hw_regs wcn6750_regs =3D { .hal_reo1_misc_ctl =3D 0x000005d8, }; =20 +static const struct ath11k_hw_tcl2wbm_rbm_map ath11k_hw_tcl2wbm_rbm_map_ip= q5018[] =3D { + { + .tcl_ring_num =3D 0, + .wbm_ring_num =3D 0, + .rbm_id =3D HAL_RX_BUF_RBM_SW0_BM, + }, +}; + static const struct ath11k_hw_tcl2wbm_rbm_map ath11k_hw_tcl2wbm_rbm_map_ip= q8074[] =3D { { .tcl_ring_num =3D 0, @@ -2822,19 +2830,30 @@ const struct ath11k_hw_regs ipq5018_regs =3D { .hal_wbm1_release_ring_base_lsb =3D 0x0000097c, }; =20 +const struct ath11k_hw_hal_params ath11k_hw_hal_params_ipq5018 =3D { + .rx_buf_rbm =3D HAL_RX_BUF_RBM_SW3_BM, + .tcl2wbm_rbm_map =3D ath11k_hw_tcl2wbm_rbm_map_ipq5018, + .num_tx_rings =3D ARRAY_SIZE(ath11k_hw_tcl2wbm_rbm_map_ipq5018), +}; + const struct ath11k_hw_hal_params ath11k_hw_hal_params_ipq8074 =3D { .rx_buf_rbm =3D HAL_RX_BUF_RBM_SW3_BM, .tcl2wbm_rbm_map =3D ath11k_hw_tcl2wbm_rbm_map_ipq8074, + .num_tx_rings =3D ARRAY_SIZE(ath11k_hw_tcl2wbm_rbm_map_ipq8074), }; =20 const struct ath11k_hw_hal_params ath11k_hw_hal_params_qca6390 =3D { .rx_buf_rbm =3D HAL_RX_BUF_RBM_SW1_BM, .tcl2wbm_rbm_map =3D ath11k_hw_tcl2wbm_rbm_map_ipq8074, + .num_tx_rings =3D DP_TCL_NUM_RING_MAX_QCA6390, }; =20 +static_assert(ARRAY_SIZE(ath11k_hw_tcl2wbm_rbm_map_ipq8074) >=3D DP_TCL_NU= M_RING_MAX_QCA6390); + const struct ath11k_hw_hal_params ath11k_hw_hal_params_wcn6750 =3D { .rx_buf_rbm =3D HAL_RX_BUF_RBM_SW1_BM, .tcl2wbm_rbm_map =3D ath11k_hw_tcl2wbm_rbm_map_wcn6750, + .num_tx_rings =3D ARRAY_SIZE(ath11k_hw_tcl2wbm_rbm_map_wcn6750), }; =20 static const struct cfg80211_sar_freq_ranges ath11k_hw_sar_freq_ranges_wcn= 6855[] =3D { diff --git a/drivers/net/wireless/ath/ath11k/hw.h b/drivers/net/wireless/at= h/ath11k/hw.h index 52d9f4c13b136..9db984ac4321c 100644 --- a/drivers/net/wireless/ath/ath11k/hw.h +++ b/drivers/net/wireless/ath/ath11k/hw.h @@ -134,6 +134,7 @@ struct ath11k_hw_tcl2wbm_rbm_map { struct ath11k_hw_hal_params { enum hal_rx_buf_return_buf_manager rx_buf_rbm; const struct ath11k_hw_tcl2wbm_rbm_map *tcl2wbm_rbm_map; + size_t num_tx_rings; }; =20 struct ath11k_hw_params { @@ -198,7 +199,6 @@ struct ath11k_hw_params { bool supports_regdb; bool fix_l1ss; bool credit_flow; - u8 max_tx_ring; const struct ath11k_hw_hal_params *hal_params; bool supports_dynamic_smps_6ghz; bool alloc_cacheable_memory; @@ -291,6 +291,7 @@ extern const struct ce_ie_addr ath11k_ce_ie_addr_ipq501= 8; =20 extern const struct ce_remap ath11k_ce_remap_ipq5018; =20 +extern const struct ath11k_hw_hal_params ath11k_hw_hal_params_ipq5018; extern const struct ath11k_hw_hal_params ath11k_hw_hal_params_ipq8074; extern const struct ath11k_hw_hal_params ath11k_hw_hal_params_qca6390; extern const struct ath11k_hw_hal_params ath11k_hw_hal_params_wcn6750; diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/a= th/ath11k/mac.c index 3276fe443502f..33ebe03380114 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -7392,7 +7392,7 @@ static void ath11k_mac_op_remove_interface(struct iee= e80211_hw *hw, idr_for_each(&ar->txmgmt_idr, ath11k_mac_vif_txmgmt_idr_remove, vif); =20 - for (i =3D 0; i < ab->hw_params.max_tx_ring; i++) { + for (i =3D 0; i < ab->hw_params.hal_params->num_tx_rings; i++) { spin_lock_bh(&ab->dp.tx_ring[i].tx_idr_lock); idr_for_each(&ab->dp.tx_ring[i].txbuf_idr, ath11k_mac_vif_unref, vif); --=20 2.45.1